xenadmin/XenAdmin/SettingsPanels/CPUMemoryEditPage.cs
Carmen Agimof 4da67c0590 CA-147944: Use GB for VM Memory if large values
- Memory Tab uses GB units for values greater or equal to 1 GB, otherwise show in MB;
- Search Tab displays values in GB or MB in the same as the Memory Tab (e.g. 512 MB of 1 GB, 256 MB of 512 MB, 2.5 GB of 16 GB).
- The shiny bar present in the Memory Tab and in Memory Settings dialog shows the scaling in the following way: If smaller than 1 GB, then show as before, else show only labels with values multiples of half a GB.
- The units used in Memory Setting Dialog are set depending on the static_max. If it is greater or equal to 1 GB, then the units are GB, else MB. The user does not have the possibility of changing them.
2015-08-20 12:41:39 +01:00

445 lines
17 KiB
C#

/* Copyright (c) Citrix Systems Inc.
* All rights reserved.
*
* Redistribution and use in source and binary forms,
* with or without modification, are permitted provided
* that the following conditions are met:
*
* * Redistributions of source code must retain the above
* copyright notice, this list of conditions and the
* following disclaimer.
* * Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the
* following disclaimer in the documentation and/or other
* materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
using System;
using System.Collections.Generic;
using System.Drawing;
using System.Windows.Forms;
using XenAdmin.Actions;
using XenAdmin.Core;
using XenAPI;
using XenAdmin.Dialogs;
namespace XenAdmin.SettingsPanels
{
public partial class CPUMemoryEditPage : UserControl, IEditPage
{
private VM vm;
bool ShowMemory = false; // If this VM has DMC, we don't show the memory controls on this page.
bool MROrGreater = true; // If Midnight Ride or greater, we only show the VCPU controls when the VM is halted.
private bool _ValidToSave = true;
private decimal _OrigMemory;
private decimal _OrigVCPUs;
private decimal _OrigVCPUWeight;
private decimal _CurrentVCPUWeight;
private ChangeMemorySettingsAction memoryAction;
public bool ValidToSave
{
get
{
if (!_ValidToSave)
return false;
// Also confirm whether the user wants to save memory changes.
// If not, don't close the properties dialog.
if (MROrGreater && HasMemoryChanged)
{
long mem = Convert.ToInt64(this.nudMemory.Value * Util.BINARY_MEGA);
memoryAction = BallooningDialogBase.ConfirmAndReturnAction(Program.MainWindow, vm, mem, mem, mem, (long)vm.memory_static_max, false);
if (memoryAction == null)
return false;
}
return true;
}
}
public CPUMemoryEditPage()
{
InitializeComponent();
Text = Messages.CPU_AND_MEMORY;
transparentTrackBar1.Scroll += new EventHandler(tbPriority_Scroll);
this.nudMemory.TextChanged += new EventHandler(nudMemory_TextChanged);
this.nudVCPUs.TextChanged += new EventHandler(nudVCPUs_TextChanged);
this.nudMemory.LostFocus += new EventHandler(nudMemory_LostFocus);
this.nudVCPUs.LostFocus += new EventHandler(nudVCPUs_LostFocus);
}
public Image Image
{
get
{
return Properties.Resources._000_CPU_h32bit_16;
}
}
void nudVCPUs_LostFocus(object sender, EventArgs e)
{
ValidateNud(nudVCPUs, Convert.ToDecimal(vm.VCPUs_at_startup));
}
void nudMemory_LostFocus(object sender, EventArgs e)
{
ValidateNud(nudMemory, (decimal)vm.memory_static_max / Util.BINARY_MEGA);
}
private void ValidateNud(NumericUpDown nud, Decimal defaultValue)
{
if (!String.IsNullOrEmpty(nud.Text.Trim()))
return;
nud.Value = defaultValue >= nud.Minimum && defaultValue <= nud.Maximum ?
defaultValue : nud.Maximum;
nud.Text = nud.Value.ToString();
}
void nudVCPUs_TextChanged(object sender, EventArgs e)
{
decimal val;
if (decimal.TryParse(nudVCPUs.Text, out val))
{
if (val >= nudVCPUs.Minimum && val <= nudVCPUs.Maximum)
nudVCPUs_ValueChanged(null, null);
else if (val > nudVCPUs.Maximum)
ShowVcpuError(true, false);
else
ShowVcpuError(false, false);
}
if (this.nudVCPUs.Text == "")
{
_ValidToSave = false;
}
else
{
_ValidToSave = true;
}
}
void nudMemory_TextChanged(object sender, EventArgs e)
{
decimal val;
if (decimal.TryParse(nudMemory.Text, out val))
{
if (val >= nudMemory.Minimum && val <= nudMemory.Maximum)
nudMemory_ValueChanged(null, null);
else if (val > nudMemory.Maximum)
ShowMemError(true, false);
else
ShowMemError(false, false);
}
if (this.nudMemory.Text == "")
{
_ValidToSave = false;
}
else
{
_ValidToSave = true;
}
}
private void tbPriority_Scroll(object sender, EventArgs e)
{
_CurrentVCPUWeight = Convert.ToDecimal(Math.Pow(4.0d, Convert.ToDouble(transparentTrackBar1.Value)));
if (transparentTrackBar1.Value == transparentTrackBar1.Max)
_CurrentVCPUWeight--;
}
/// <summary>
/// Must be a VM.
/// </summary>
public void SetXenObjects(IXenObject orig, IXenObject clone)
{
vm = (VM)clone;
MROrGreater = Helpers.MidnightRideOrGreater(vm.Connection);
ShowMemory = !MROrGreater || Helpers.FeatureForbidden(vm, Host.RestrictDMC);
Repopulate();
}
public void Repopulate()
{
VM vm = this.vm;
Text = ShowMemory ? Messages.CPU_AND_MEMORY : Messages.CPU;
if (!ShowMemory)
lblMemory.Visible = panel2.Visible = MemWarningLabel.Visible = false;
else if (MROrGreater && vm.power_state != vm_power_state.Halted && vm.power_state != vm_power_state.Running)
{
panel2.Enabled = false;
MemWarningLabel.Text = Messages.MEM_NOT_WHEN_SUSPENDED;
MemWarningLabel.ForeColor = SystemColors.ControlText;
MemWarningLabel.Visible = true;
}
if (MROrGreater && vm.power_state != vm_power_state.Halted)
{
nudVCPUs.Enabled = false;
comboBoxTopology.Enabled = false;
VCPUWarningLabel.Text = Messages.VCPU_ONLY_WHEN_HALTED;
VCPUWarningLabel.ForeColor = SystemColors.ControlText;
VCPUWarningLabel.Visible = true;
}
// Since updates come in dribs and drabs, avoid error if new max and min arrive
// out of sync and maximum < minimum.
if (vm.memory_dynamic_max >= vm.memory_dynamic_min &&
vm.memory_static_max >= vm.memory_static_min)
{
decimal min = Convert.ToDecimal(vm.memory_static_min / Util.BINARY_MEGA);
decimal max = Convert.ToDecimal(vm.MaxMemAllowed / Util.BINARY_MEGA);
decimal value = Convert.ToDecimal(vm.memory_static_max / Util.BINARY_MEGA);
// Avoid setting the range to exclude the current value: CA-40041
if (value > max)
max = value;
if (value < min)
min = value;
this.nudMemory.Minimum = min;
this.nudMemory.Maximum = max;
this.nudMemory.Text = (this.nudMemory.Value = value).ToString();
}
// CA-12941
// We set a sensible maximum of about 8, but if the user sets something higher
// from the CLI then use that as the maximum.
this.nudVCPUs.Maximum = Convert.ToDecimal(vm.MaxVCPUsAllowed < vm.VCPUs_at_startup ? vm.VCPUs_at_startup : vm.MaxVCPUsAllowed);
this.nudVCPUs.Text = (this.nudVCPUs.Value = Convert.ToDecimal(vm.VCPUs_at_startup > 0 ? vm.VCPUs_at_startup : 1)).ToString();
_CurrentVCPUWeight = Convert.ToDecimal(vm.VCPUWeight);
this.transparentTrackBar1.Value = Convert.ToInt32(Math.Log(Convert.ToDouble(vm.VCPUWeight)) / Math.Log(4.0d));
Host currentHost = Helpers.GetMaster(this.vm.Connection);
if (currentHost != null)
{
bool QosRestricted = currentHost.RestrictQoS;
transparentTrackBar1.Enabled = !QosRestricted;
licenseRestrictionTip.Active = QosRestricted;
lblSliderLowest.Enabled = !QosRestricted;
lblSliderNormal.Enabled = !QosRestricted;
lblSliderHighest.Enabled = !QosRestricted;
lblPriority.Enabled = !QosRestricted;
panel1.Enabled = !QosRestricted;
// Show the performance warning about vCPUs > pCPUs.
// Don't show if the VM isn't running, since we don't know which server it will
// run on (and so can't count the number of pCPUs).
if ( vm.power_state == vm_power_state.Running
&& vm.VCPUs_at_startup > currentHost.host_CPUs.Count
&& !vm.IgnoreExcessiveVcpus)
{
lblVcpuWarning.Visible = true;
this.tableLayoutPanel1.RowStyles[1].SizeType = SizeType.Absolute;
this.tableLayoutPanel1.RowStyles[1].Height = 30;
}
else
{
lblVcpuWarning.Visible = false;
}
}
else
{
lblVcpuWarning.Visible = false;
}
_OrigMemory = nudMemory.Value;
_OrigVCPUs = nudVCPUs.Value;
_OrigVCPUWeight = _CurrentVCPUWeight;
comboBoxTopology.Populate(vm.VCPUs_at_startup, vm.VCPUs_max, vm.CoresPerSocket, vm.MaxCoresPerSocket);
_ValidToSave = true;
}
public bool HasChanged
{
get { return HasVCPUChanged || HasMemoryChanged || HasTopologyChanged; }
}
private bool HasMemoryChanged
{
get
{
return _OrigMemory != nudMemory.Value;
}
}
private bool HasVCPUChanged
{
get
{
return _OrigVCPUs != nudVCPUs.Value || _OrigVCPUWeight != _CurrentVCPUWeight;
}
}
private bool HasTopologyChanged
{
get
{
return vm.CoresPerSocket != comboBoxTopology.CoresPerSocket;
}
}
public AsyncAction SaveSettings()
{
List<AsyncAction> actions = new List<AsyncAction>();
if (HasVCPUChanged)
{
vm.VCPUWeight = Convert.ToInt32(_CurrentVCPUWeight);
if (_OrigVCPUs != nudVCPUs.Value)
actions.Add(new ChangeVCPUSettingsAction(vm, Convert.ToInt64(nudVCPUs.Value)));
}
if (HasTopologyChanged)
{
vm.CoresPerSocket = comboBoxTopology.CoresPerSocket;
}
if (HasMemoryChanged)
{
if (MROrGreater)
actions.Add(memoryAction); // Calculated in ValidToSave
else
vm.Memory = Convert.ToInt64(this.nudMemory.Value * Util.BINARY_MEGA);
}
if (!Program.RunInAutomatedTestMode && vm.power_state != vm_power_state.Halted)
{
if (!HasMemoryChanged)
new ThreeButtonDialog(new ThreeButtonDialog.Details(SystemIcons.Information, Messages.VM_VCPU_CHANGES_NOT_SUPPORTED_MESSAGE, Messages.VM_LIVE_CHANGES_NOT_SUPPORTED_TITLE)).ShowDialog();
else if (!MROrGreater)
new ThreeButtonDialog(new ThreeButtonDialog.Details(SystemIcons.Information, Messages.VM_VCPU_CHANGES_NOT_SUPPORTED_MESSAGE, Messages.VM_LIVE_CHANGES_NOT_SUPPORTED_TITLE)).ShowDialog();
// If it is >= Midnight Ride, and memory has changed (which can only happen in the free version),
// we have already given a message in ValidToSave that the VM will be forcibly rebooted, so no
// further message is needed here.
}
if (actions.Count == 0)
return null;
else if (actions.Count == 1)
return actions[0];
else
{
MultipleAction multipleAction = new MultipleAction(vm.Connection, "", "", "", actions, true);
return multipleAction;
}
}
/** Show local validation balloon tooltips */
public void ShowLocalValidationMessages() { }
/** Unregister listeners, dispose balloon tooltips, etc. */
public void Cleanup() { }
/// <summary>
/// Shows the warning dialog about vCPUs > pCPUs.
/// </summary>
private void lblVcpuWarning_LinkClicked(object sender, LinkLabelLinkClickedEventArgs e)
{
if (vm == null)
{
System.Diagnostics.Trace.Assert(false, "Selected object should be a vm");
}
else
{
new Dialogs.VcpuWarningDialog(vm).ShowDialog();
this.Refresh();
}
}
private void nudMemory_ValueChanged(object sender, EventArgs e)
{
ShowMemError(false, true);
}
private void ShowMemError(bool showAlways, bool testValue)
{
if (vm == null || !ShowMemory)
return;
Host selectedAffinity = vm.Connection.Resolve<Host>(vm.power_state == vm_power_state.Running ? vm.resident_on : vm.affinity);
if (selectedAffinity != null)
{
Host_metrics host_metrics = vm.Connection.Resolve<Host_metrics>(selectedAffinity.metrics);
if ((showAlways || (testValue && (host_metrics != null && (double)host_metrics.memory_total < (double)nudMemory.Value * (double)Util.BINARY_MEGA))))
{
MemWarningLabel.Visible = true;
}
else
{
MemWarningLabel.Visible = false;
}
}
}
private void nudVCPUs_ValueChanged(object sender, EventArgs e)
{
ShowVcpuError(false, true);
comboBoxTopology.Update((long)(nudVCPUs.Value));
ValidateVCPUSettings();
}
private void ShowVcpuError(bool showAlways, bool testValue)
{
if (vm == null || !nudVCPUs.Enabled)
return;
Host selectedAffinity = vm.Home();
if (selectedAffinity == null && vm.Connection.Cache.Hosts.Length == 1)
selectedAffinity = vm.Connection.Cache.Hosts[0];
if (showAlways || (testValue && (selectedAffinity != null && selectedAffinity.host_CPUs.Count < nudVCPUs.Value)))
{
VCPUWarningLabel.Visible = true;
}
else
{
VCPUWarningLabel.Visible = false;
}
}
public String SubText
{
get
{
return ShowMemory ?
String.Format(Messages.CPU_AND_MEMORY_SUB, nudVCPUs.Value, nudMemory.Value) :
String.Format(Messages.CPU_SUB, nudVCPUs.Value);
}
}
private void comboBoxTopology_SelectedIndexChanged(object sender, EventArgs e)
{
ValidateVCPUSettings();
}
private void ValidateVCPUSettings()
{
labelInvalidVCPUWarning.Visible = !VM.ValidVCPUConfiguration((long)(nudVCPUs.Value), comboBoxTopology.CoresPerSocket);
}
}
}