xenadmin/XenAdmin/Wizards/PatchingWizard/PatchingWizardModeGuidanceBuilder.cs
Mihaela Stoica 12a025a253 CA-220040: Patching wizard shows reboot required where it is not expected
- When building the list of servers that require post-install actions, ignore the ones where the patch has already been installed.
- Also fixing the infinite recursion in Build() method (causing StackOverflowException when installing a supplemental pack).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 17:36:11 +01:00

124 lines
5.5 KiB
C#

/* Copyright (c) Citrix Systems Inc.
* All rights reserved.
*
* Redistribution and use in source and binary forms,
* with or without modification, are permitted provided
* that the following conditions are met:
*
* * Redistributions of source code must retain the above
* copyright notice, this list of conditions and the
* following disclaimer.
* * Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the
* following disclaimer in the documentation and/or other
* materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
using System;
using System.Collections.Generic;
using System.Text;
using XenAdmin.Core;
using XenAPI;
using System.Linq;
namespace XenAdmin.Wizards.PatchingWizard
{
public class PatchingWizardModeGuidanceBuilder
{
public static string ModeRetailPatch(List<Host> servers, Pool_patch patch, Dictionary<string, LivePatchCode> LivePatchCodesByHost)
{
return Build(servers.Where(h => patch != null && patch.AppliedOn(h) == DateTime.MaxValue).ToList(), patch != null ? patch.after_apply_guidance : new List<after_apply_guidance>(), LivePatchCodesByHost);
}
public static string ModeSuppPack(List<Host> servers)
{
List<after_apply_guidance> guidance = new List<after_apply_guidance> { after_apply_guidance.restartHost };
return Build(servers, guidance, new Dictionary<string, LivePatchCode>());
}
private static string Build(List<Host> servers, List<after_apply_guidance> guidance, Dictionary<string, LivePatchCode> LivePatchCodesByHost)
{
StringBuilder sbLog = new StringBuilder();
foreach (after_apply_guidance guide in guidance)
{
if (guide == after_apply_guidance.restartHost
&& (LivePatchCodesByHost != null && servers.TrueForAll(h => LivePatchCodesByHost.ContainsKey(h.uuid) && LivePatchCodesByHost[h.uuid] == LivePatchCode.PATCH_PRECHECK_LIVEPATCH_COMPLETE)))
continue;
sbLog.AppendLine(GetGuideMessage(guide));
switch (guide)
{
case after_apply_guidance.restartHost:
case after_apply_guidance.restartXAPI:
foreach (Host host in servers)
{
if (guide == after_apply_guidance.restartHost && LivePatchCodesByHost != null && LivePatchCodesByHost.ContainsKey(host.uuid) && LivePatchCodesByHost[host.uuid] == LivePatchCode.PATCH_PRECHECK_LIVEPATCH_COMPLETE)
continue;
if (host.IsMaster())
sbLog.AppendFormat("\t{0} ({1})\r\n", host.Name, Messages.MASTER);
else
sbLog.AppendFormat("\t{0}\r\n", host.Name);
}
break;
case after_apply_guidance.restartPV:
foreach (VM vm in Helpers.VMsRunningOn(servers))
{
if (vm.IsHVM || !vm.is_a_real_vm)
continue;
sbLog.AppendFormat("\t{0}\r\n", vm.Name);
}
break;
case after_apply_guidance.restartHVM:
foreach (VM vm in Helpers.VMsRunningOn(servers))
{
if (!vm.IsHVM || !vm.is_a_real_vm)
continue;
sbLog.AppendFormat("\t{0}\r\n", vm.Name);
}
break;
}
}
if (sbLog.Length == 0)
sbLog.Append(Messages.PATCHINGWIZARD_MODEPAGE_NOACTION);
return sbLog.ToString();
}
private static string GetGuideMessage(after_apply_guidance guidance)
{
switch (guidance)
{
case after_apply_guidance.restartXAPI:
return Messages.PATCHINGWIZARD_MODEPAGE_RESTARTXAPI;
case after_apply_guidance.restartHost:
return Messages.PATCHINGWIZARD_MODEPAGE_RESTARTSERVERS;
case after_apply_guidance.restartHVM:
case after_apply_guidance.restartPV:
return Messages.PATCHINGWIZARD_MODEPAGE_RESTARTVMS;
default:
return Messages.PATCHINGWIZARD_MODEPAGE_UNKNOWNACTION;
}
}
}
}