xenadmin/XenAdmin/Dialogs/PvsSiteDialog.cs
Mihaela Stoica aebffe9b13 CP-19086: Improvements to the PVS cache UI
PVS Tab:
- Move the "View PVS sites" button inside the "Configure PVS Cache" dialog (next to Remove button) and make it per-site (showing only the PVS servers from that site)
- Remove "Currently attached" column from the VMs section
- Rename "Status" column to "Read caching status"

Configure PVS Cache" dialog:
- Make sure there is a scrollbar to accommodate all hosts in a pool
- Add a confirmation dialog when a site is removed. The action is executed when the Remove button is pressed.
- When Memory SR is selected, set the maximum value to the dom0-extra-memory..
- Allow empty configuration (but see next point): The OK button should only be disabled if the PVS site name is empty
- Add an extra option in the "Cache storage" combobox, with text "Not configured", selected by default on a new site. When this is selected, we will remove the existing entry in pvs_cache_storage and will not create a new one.
- When a PVS site is deleted (forgotten), we first delete all the associated PVS_servers, otherwise the site cannot be deleted.
2016-10-01 00:23:28 +01:00

128 lines
4.4 KiB
C#

/* Copyright (c) Citrix Systems Inc.
* All rights reserved.
*
* Redistribution and use in source and binary forms,
* with or without modification, are permitted provided
* that the following conditions are met:
*
* * Redistributions of source code must retain the above
* copyright notice, this list of conditions and the
* following disclaimer.
* * Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the
* following disclaimer in the documentation and/or other
* materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
using System;
using System.ComponentModel;
using System.Windows.Forms;
using XenAPI;
namespace XenAdmin.Dialogs
{
public partial class PvsSiteDialog : XenDialogBase
{
private readonly PVS_site pvsSite;
/// <summary>
/// Creates a dialog for viewing the PVS servers on a particular site.
/// </summary>
/// <param name="site">May not be null.</param>
public PvsSiteDialog(PVS_site site)
{
System.Diagnostics.Trace.Assert(site != null);
connection = site.Connection;
pvsSite = site;
InitializeComponent();
Text = string.Format(Messages.PVS_SITE_DIALOG_TITLE, pvsSite.Name.Ellipsise(50));
System.Diagnostics.Trace.Assert(gridView.Columns.Count > 0);
gridView.Columns[0].DefaultCellStyle.NullValue = null;
RegisterEventHandlers();
Rebuild();
}
private void RegisterEventHandlers()
{
UnregisterEventHandlers();
connection.Cache.RegisterBatchCollectionChanged<PVS_server>(PvsServerBatchCollectionChanged);
}
private void UnregisterEventHandlers()
{
connection.Cache.DeregisterBatchCollectionChanged<PVS_server>(PvsServerBatchCollectionChanged);
}
private void PvsServerBatchCollectionChanged(object sender, EventArgs e)
{
Program.Invoke(this, Rebuild);
}
protected override void OnClosing(CancelEventArgs e)
{
UnregisterEventHandlers();
base.OnClosing(e);
}
private void Rebuild()
{
Program.AssertOnEventThread();
try
{
gridView.SuspendLayout();
gridView.Rows.Clear();
foreach (var pvsServer in connection.ResolveAll(pvsSite.servers))
{
var serverRow = NewPvsServerRow(pvsServer);
gridView.Rows.Add(serverRow);
}
}
finally
{
gridView.ResumeLayout();
}
}
private DataGridViewRow NewPvsServerRow(PVS_server pvsServer)
{
var ipAddressesCell = new DataGridViewTextBoxCell();
var firstPortCell = new DataGridViewTextBoxCell();
var lastPortCell = new DataGridViewTextBoxCell();
ipAddressesCell.Value = string.Join(Messages.LIST_SEPARATOR, pvsServer.addresses);
firstPortCell.Value = pvsServer.first_port;
lastPortCell.Value = pvsServer.last_port;
var newRow = new DataGridViewRow { Tag = pvsSite };
newRow.Cells.AddRange(ipAddressesCell, firstPortCell, lastPortCell);
return newRow;
}
private void closeButton_Click(object sender, EventArgs e)
{
Close();
}
}
}