mirror of
https://github.com/xcp-ng/xenadmin.git
synced 2024-12-21 07:56:03 +01:00
90589a30c9
This PR is aimimg to (1) fix a regression introduced by #2223 whereby the toolbar items did not have the correct state on first launch; (2) improve performance by removing some updates which I believe are not needed. * Removed some duplicate calls to RefershTreeView and UpdateToolbars because they are called within the action's Complete event handler. Also, normalise the way the treeview refresh is requested by the various actions the commands are launching. Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com> * Removed some explicit calls to refresh the treeview since this is done by the connection result handlers. Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com> * The toolbars and tabs should be updated every time the treeview is refreshed. This should happen when the refresh event is handled rather than calling UpdateToolbars explicitly after a treeview refresh is requested; also, it is the treeview refreshes that should be throttled and not the toolbar and tab updates (the throttling mechanism may need correction). Also, removed unnecessary Invoke as we are already on the UI thread. Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com> * Simplified UpdateManager.Update event declaration. Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
101 lines
3.7 KiB
C#
101 lines
3.7 KiB
C#
/* Copyright (c) Citrix Systems, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms,
|
|
* with or without modification, are permitted provided
|
|
* that the following conditions are met:
|
|
*
|
|
* * Redistributions of source code must retain the above
|
|
* copyright notice, this list of conditions and the
|
|
* following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above
|
|
* copyright notice, this list of conditions and the
|
|
* following disclaimer in the documentation and/or other
|
|
* materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
|
|
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
|
|
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
|
|
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
|
|
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
|
|
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
|
|
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
using System.Collections.Generic;
|
|
using XenAPI;
|
|
using XenAdmin.Actions;
|
|
|
|
|
|
namespace XenAdmin.Commands
|
|
{
|
|
/// <summary>
|
|
/// Removes the selected hosts.
|
|
/// </summary>
|
|
internal class RemoveHostCommand : Command
|
|
{
|
|
private static readonly log4net.ILog log = log4net.LogManager.GetLogger(System.Reflection.MethodBase.GetCurrentMethod().DeclaringType);
|
|
|
|
/// <summary>
|
|
/// Initializes a new instance of this Command. The parameter-less constructor is required if
|
|
/// this Command is to be attached to a ToolStrip menu item or button. It should not be used in any other scenario.
|
|
/// </summary>
|
|
public RemoveHostCommand()
|
|
{
|
|
}
|
|
|
|
public RemoveHostCommand(IMainWindow mainWindow, IEnumerable<SelectedItem> selection)
|
|
: base(mainWindow, selection)
|
|
{
|
|
}
|
|
|
|
public RemoveHostCommand(IMainWindow mainWindow, Host host)
|
|
: base(mainWindow, host)
|
|
{
|
|
}
|
|
|
|
protected override void ExecuteCore(SelectedItemCollection selection)
|
|
{
|
|
MainWindowCommandInterface.SelectObjectInTree(null);
|
|
|
|
foreach (Host host in selection.AsXenObjects<Host>())
|
|
{
|
|
string msg = string.Format(Messages.MAINWINDOW_LOG_REMOVECONNECTION, host.Connection.Hostname);
|
|
log.Info(msg);
|
|
new ActionBase(msg, msg, false, true);
|
|
MainWindowCommandInterface.CloseActiveWizards(host.Connection);
|
|
host.Connection.EndConnect();
|
|
MainWindowCommandInterface.RemoveConnection(host.Connection);
|
|
}
|
|
|
|
MainWindowCommandInterface.SaveServerList();
|
|
}
|
|
|
|
private static bool CanExecute(Host host)
|
|
{
|
|
bool disconnected = host.Connection != null && !host.Connection.IsConnected;
|
|
return disconnected || host.IsMaster();
|
|
}
|
|
|
|
protected override bool CanExecuteCore(SelectedItemCollection selection)
|
|
{
|
|
return selection.AllItemsAre<Host>(CanExecute);
|
|
}
|
|
|
|
public override string MenuText
|
|
{
|
|
get
|
|
{
|
|
return Messages.MAINWINDOW_REMOVE_HOST;
|
|
}
|
|
}
|
|
}
|
|
}
|