mirror of
https://github.com/xcp-ng/xenadmin.git
synced 2024-12-30 07:40:13 +01:00
bc4a364f23
Changes to the DeleteAllAlertsAction: - when the dismiss operation fails with INVALID_HANDLE we need to remove the alert from our alert list (XenCenterAlerts) and trigger the CollectionChanged event so that the alert count gets updated. - the action title now says "Removing <n> alerts" when dismissing all/selected alerts and "Removing alert" when dismissing single alert (instead of "Removing all alerts" in all cases) - move the initialization of Dismissing flag outside the action (see below) This fix also includes changes so that the Dismissing flag works as intended: to be able to hide the dismissing alerts in the Alerts view immediately, rather than one by one when they were actually deleted, causing a large number of refreshes. On dismissing alerts we do: 1. set dismissing to true for all alerts 2. rebuild alert list (this will filter out the dismissing alerts) 3. dismiss alerts - run the DismissAllAlerts action Also, the action buttons on each row should only apply to the clicked row (not multiselect). Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
117 lines
4.7 KiB
C#
117 lines
4.7 KiB
C#
/* Copyright (c) Citrix Systems Inc.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms,
|
|
* with or without modification, are permitted provided
|
|
* that the following conditions are met:
|
|
*
|
|
* * Redistributions of source code must retain the above
|
|
* copyright notice, this list of conditions and the
|
|
* following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above
|
|
* copyright notice, this list of conditions and the
|
|
* following disclaimer in the documentation and/or other
|
|
* materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
|
|
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
|
|
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
|
|
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
|
|
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
|
|
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
|
|
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Text;
|
|
using XenAdmin.Alerts;
|
|
using XenAdmin.Network;
|
|
using XenAdmin.Core;
|
|
using XenAPI;
|
|
|
|
|
|
namespace XenAdmin.Actions
|
|
{
|
|
public class DeleteAllAlertsAction : AsyncAction
|
|
{
|
|
private readonly IEnumerable<Alert> Alerts;
|
|
private static readonly log4net.ILog log = log4net.LogManager.GetLogger(System.Reflection.MethodBase.GetCurrentMethod().DeclaringType);
|
|
|
|
/// <param name="connection">May be null, in which case this is expected to be for client-side alerts.</param>
|
|
public DeleteAllAlertsAction(IXenConnection connection, IEnumerable<Alert> alerts)
|
|
: base(connection,
|
|
GetActionTitle(connection, alerts.Count()),
|
|
Messages.ACTION_REMOVE_ALERTS_DESCRIPTION)
|
|
{
|
|
this.Alerts = alerts;
|
|
|
|
if (connection != null)
|
|
{
|
|
Pool = Helpers.GetPoolOfOne(connection);
|
|
Host = Helpers.GetMaster(connection);
|
|
}
|
|
}
|
|
|
|
private static string GetActionTitle(IXenConnection connection, int alertCount)
|
|
{
|
|
return connection == null
|
|
? alertCount == 1
|
|
? Messages.ACTION_REMOVE_ALERTS_ON_CLIENT_TITLE_ONE
|
|
: string.Format(Messages.ACTION_REMOVE_ALERTS_ON_CLIENT_TITLE, alertCount)
|
|
: alertCount == 1
|
|
? string.Format(Messages.ACTION_REMOVE_ALERTS_ON_CONNECTION_TITLE_ONE, Helpers.GetName(connection))
|
|
: string.Format(Messages.ACTION_REMOVE_ALERTS_ON_CONNECTION_TITLE, alertCount, Helpers.GetName(connection));
|
|
}
|
|
|
|
protected override void Run()
|
|
{
|
|
int i = 0;
|
|
int max = Alerts.Count();
|
|
Exception e = null;
|
|
LogDescriptionChanges = false;
|
|
|
|
try
|
|
{
|
|
foreach (Alert a in Alerts)
|
|
{
|
|
PercentComplete = (i * 100) / max;
|
|
i++;
|
|
Description = string.Format(Messages.ACTION_REMOVE_ALERTS_PROGRESS_DESCRIPTION, i, max);
|
|
|
|
Alert a1 = a;
|
|
BestEffort(ref e, delegate
|
|
{
|
|
try
|
|
{
|
|
a1.DismissSingle(Session);
|
|
}
|
|
catch (Failure exn)
|
|
{
|
|
if (exn.ErrorDescription[0] != Failure.HANDLE_INVALID)
|
|
throw;
|
|
//remove alert from XenCenterAlerts; this will trigger the CollectionChanged event, on which we update the alert count
|
|
if (Alert.FindAlert(a1) != null)
|
|
Alert.RemoveAlert(a1);
|
|
}
|
|
});
|
|
}
|
|
}
|
|
finally
|
|
{
|
|
LogDescriptionChanges = true;
|
|
}
|
|
|
|
Description = max == 1 ? Messages.ACTION_REMOVE_ALERTS_DONE_ONE : string.Format(Messages.ACTION_REMOVE_ALERTS_DONE, max);
|
|
}
|
|
}
|
|
}
|