xenadmin/XenAdmin/Commands/VMLifeCycleCommand.cs
Danilo Del Busso afb419af04
CP-44767, CP-44766 & CP-44765: Refactor usage of VM restrictions and add reference_label to OVFs (#3211)
* Tidy up `VM` extension: use `var`
* Tidy up `VM` extension: remove redundant initialisers
* Tidy up `VM` extension: use type keywords when possible
* Tidy up `VM` extension: merge conditional expressions
* Tidy up `VM` extension: remove redundant qualifiers
* Tidy up `VM` extension: remove redundant type arguments
* Tidy up `VM` extension: remove redundant `else`s and parentheses
* Tidy up `VM` extension: fix naming
* Tidy up `VM` extension: misc changes
* Tidy up `VM` extension: use `null` propagation
* Tidy up `VM` extension: fix whitespace
* Tidy up `VM` extension: apply ReSharper Code Cleanup utility
* Tidy up `VM` extension: Fix naming of private string array
* CP-44767: Ignore VM restriction when fetching `MaxVCPUsAllowed`
Instead, fetch the highest available value in all templates for the host.
This means that VMs imported from vhd won't automatically default to `DEFAULT_NUM_VCPUS_ALLOWED`, and that VMs that have been kept across XenServer upgrades won't be limited to the number of vCPUs in their own (possibly outdated) restrictions
* CP-44766: Use value in template with a matching `reference_label` when checking VM restrictions
* Move restriction getters to own region
* CP-44766: Use matching templates to fetch VM restrictions
- Rewrite `GetRestrictions...` methods to perform simpler operations
- Add `GetIntRestrictionValue` and `GetBoolRestrictionValue` wrappers to `GetRestrictionValueFromMatchingTemplate`
- Now all calls to a restrictions first check the template value, with a fall-back to defaults
* CP-44765: Export `reference-label` when generating OVFs
---------

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-09-29 03:45:17 +01:00

185 lines
6.7 KiB
C#

/* Copyright (c) Cloud Software Group, Inc.
*
* Redistribution and use in source and binary forms,
* with or without modification, are permitted provided
* that the following conditions are met:
*
* * Redistributions of source code must retain the above
* copyright notice, this list of conditions and the
* following disclaimer.
* * Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the
* following disclaimer in the documentation and/or other
* materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
using System.Collections.Generic;
using XenAPI;
using XenAdmin.Actions;
using System.Windows.Forms;
namespace XenAdmin.Commands
{
internal abstract class VMLifeCycleCommand : Command
{
/// <summary>
/// Initializes a new instance of this Command. The parameter-less constructor is required if
/// this Command is to be attached to a ToolStrip menu item or button. It should not be used in any other scenario.
/// </summary>
protected VMLifeCycleCommand()
{
}
protected VMLifeCycleCommand(IMainWindow mainWindow, IEnumerable<SelectedItem> selection)
: base(mainWindow, selection)
{
}
protected VMLifeCycleCommand(IMainWindow mainWindow, VM vm)
: this(mainWindow, vm, null)
{
}
protected VMLifeCycleCommand(IMainWindow mainWindow, VM vm, Control parent)
: base(mainWindow, new SelectedItem(vm))
{
Parent = parent;
}
protected abstract bool CanRun(VM vm);
protected abstract void Run(List<VM> vms);
protected void CancelAllTasks(IEnumerable<VM> vms)
{
foreach (VM vm in vms)
{
foreach (ActionBase action in ConnectionsManager.History)
{
if (vm.Equals(action.VM) && !action.IsCompleted && action.CanCancel)
{
action.Cancel();
}
}
}
}
protected void RunAction(IEnumerable<VM> vms, string title, string startDescription, string endDescription,
Dictionary<VM, List<VBD>> vbdsToEjectDict)
{
var actions = GetActions(vms, title, startDescription, endDescription, vbdsToEjectDict);
RunMultipleActions(actions, title, startDescription, endDescription, true);
}
private List<AsyncAction> GetActions(IEnumerable<VM> vms, string title, string startDescription,
string endDescription, Dictionary<VM, List<VBD>> vbdsToEjectDict)
{
List<AsyncAction> actions = new List<AsyncAction>();
foreach (VM vm in vms)
{
if (vm.Connection != null && vm.Connection.IsConnected)
{
if (vbdsToEjectDict != null && vbdsToEjectDict.ContainsKey(vm))
{
List<AsyncAction> subActions = GetVBDsToEjectActions(vm, vbdsToEjectDict[vm]);
subActions.Add(BuildAction(vm));
actions.Add(new MultipleAction(vm.Connection, title, startDescription, endDescription,
subActions));
}
else
{
actions.Add(BuildAction(vm));
}
}
}
return actions;
}
private List<AsyncAction> GetVBDsToEjectActions(VM vm, List<VBD> vbdsToEject)
{
List<AsyncAction> actions = new List<AsyncAction>();
if (vbdsToEject != null)
{
foreach (var vbd in vbdsToEject)
{
actions.Add(new ChangeVMISOAction(vbd.Connection, vm, null, vbd));
}
}
return actions;
}
protected abstract AsyncAction BuildAction(VM vm);
protected sealed override void RunCore(SelectedItemCollection selection)
{
List<VM> vms = selection.AsXenObjects<VM>(CanRun);
// sort so actions run in correct order.
vms.Sort();
Run(vms);
}
protected sealed override bool CanRunCore(SelectedItemCollection selection)
{
bool atLeastOneCanRun = false;
foreach (SelectedItem item in selection)
{
VM vm = item.XenObject as VM;
if (vm == null || vm.is_a_template || vm.is_a_snapshot)
{
return false;
}
else if (CanRun(vm))
{
atLeastOneCanRun = true;
}
}
return atLeastOneCanRun;
}
protected string GetCantRunNoToolsOrDriversReasonCore(IXenObject item)
{
VM vm = item as VM;
if (vm == null)
return null;
var status = vm.GetVirtualizationStatus(out _);
//trying to guess the reason
if (vm.HasNewVirtualizationStates())
{
if (!status.HasFlag(VM.VirtualizationStatus.IoDriversInstalled)) //note: this will also be true when the enum is in Unknown state
return Messages.VM_MISSING_IO_DRIVERS;
}
else
{
if (status == VM.VirtualizationStatus.NotInstalled || status.HasFlag(VM.VirtualizationStatus.Unknown))
return FriendlyErrorNames.VM_MISSING_PV_DRIVERS;
if (status.HasFlag(VM.VirtualizationStatus.PvDriversOutOfDate))
return FriendlyErrorNames.VM_OLD_PV_DRIVERS;
}
return null;
}
}
}