xenadmin/XenAdmin/Controls
Konstantina Chremmou 4ce9878b45 Refactored the VIFDialog to fix various problems: (#2398)
* Refactored the VIFDialog to fix various problems:
- Launch the dialog in using blocks.
- Event GotFocus is not meant to be handled directly in the code.
- Populate the dialog in the OnLoad override instead of the constructor
  as this causes problems at design time.
- Popping up an error message for duplicate MAC on combobox item
  selection or textbox text change is not optimal UX. Perform this
  check once when closing the form. Additionally the parent form of the
  pop up should be the dialog, not the main window.
- The validation messages are not obvious to the user because they are
  hidden in the tooltip of a disabled button. Show them inline instead.
- There is no need to create commands for VIF creation/change; use
  the relevant actions instead.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Corrections as per code review plus some more code tidy and refactoring.

- Added option to suppress Create/DeleteVIFActions
- Use property RebootRequired to indicate hot-plugging is unavailable
  (assigning various objects of different types to the Result of the action
  during its run may cause confusion).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-25 08:23:09 +01:00
..
AD Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
Ballooning Fix the wrong layout 2018-12-11 14:52:20 +00:00
CheckableDataGridView Removed code applicable to servers earlier than dundee since connection to them is now blocked. 2019-02-06 09:25:38 +00:00
ComboBoxes Fixed issue whereby VS kept toggling between SubType Component and User Control 2018-11-09 16:23:29 +00:00
Common Cleared some level 4 warnings. 2018-03-22 15:07:32 +00:00
ConsoleTab L10N: Translation and resx resync 2018-10-29 12:01:08 +00:00
CustomDataGraph CA-288560: Convert CPU average frequency to GHz, when needed 2018-05-02 12:57:10 +01:00
CustomGridView Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib. 2017-11-30 13:56:32 +00:00
CustomListPanel CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DataGridViewEx Added readonly restrictions to DataGridViewRow cells. 2018-12-19 11:30:15 +00:00
Folders CA-302791: Rewrote the ChangeFolder dialog to fix usability issues. 2018-11-26 10:29:39 +00:00
GPU Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
MainWindowControls Prevent VisualStudio's designer from crashing when opening the MainWindow. 2019-04-24 15:03:20 +01:00
NetworkingTab Refactored the VIFDialog to fix various problems: (#2398) 2019-04-25 08:23:09 +01:00
SummaryPanel CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
Tags CA-287643: Replaced list view with data grid view to resolve column sizing issue and for consistency with the rest of the product. (#2226) 2018-10-02 10:18:34 +01:00
TreeViews CA-302791: Rewrote the ChangeFolder dialog to fix usability issues. 2018-11-26 10:29:39 +00:00
Wlb Reduced accessibility of controls to private. Minor refactoring. Typo. Removed 2019-01-08 12:01:46 +00:00
XenSearch Reduced accessibility of controls to private. 2019-01-08 12:01:46 +00:00
AffinityPicker.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
AffinityPicker.Designer.cs CA-213728: Going to Home Server tab can change home server 2016-07-25 14:31:55 +01:00
AffinityPicker.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
AffinityPicker.resx CA-107915: Fixed radiobutton text truncation on the AffinityPicker by providing 2013-09-27 13:33:57 +01:00
AffinityPicker.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
BlueBorderPanel.cs Cleared some level 4 warnings. 2018-03-22 15:07:32 +00:00
BondDetails.cs Reduced accessibility of controls to private. Moved some of the wizard cancelling 2019-01-08 12:01:46 +00:00
BondDetails.Designer.cs Reduced accessibility of controls to private. Moved some of the wizard cancelling 2019-01-08 12:01:46 +00:00
BondDetails.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
BondDetails.resx CA-188553: [PAR-80] Creating a VLAN with MTU 9000 should be disabled 2015-12-21 18:09:48 +00:00
BondDetails.zh-CN.resx L10N : Translation updates and bug fixes 2017-07-19 15:09:10 +05:30
BootOrderListBox.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ChevronButton.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ChevronButton.Designer.cs CA-136768: Fixed bad layout of buttons at the top of the snapshots tab page. Also fixed text alignment on the chevron button. 2016-07-20 00:04:06 +01:00
ChevronButton.ja.resx L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
ChevronButton.resx CA-136768: Fixed bad layout of buttons at the top of the snapshots tab page. Also fixed text alignment on the chevron button. 2016-07-20 00:04:06 +01:00
ChevronButton.zh-CN.resx L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
ChevronToggleButton.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ColorsHelper.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ColorsHelper.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
ColorsHelper.ja.resx L10N:Translations check-ins 2017-01-12 13:22:48 +00:00
ColorsHelper.resx CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
ColorsHelper.zh-CN.resx L10N:Translations check-ins 2017-01-06 12:46:19 +00:00
ConnectionWrapperWithMoreStuff.cs Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib. 2017-11-30 13:56:32 +00:00
ConsolePanel.cs CA-311146: Copy the results of a linq query to a list to prevent 2019-02-26 11:18:53 +00:00
ConsolePanel.Designer.cs Fixed issue where the error message was not displayed if connection to the host console was not possible. 2016-07-03 17:45:49 +01:00
ConsolePanel.ja.resx L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
ConsolePanel.resx Fixed issue where the error message was not displayed if connection to the host console was not possible. 2016-07-03 17:45:49 +01:00
ConsolePanel.zh-CN.resx L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
CustomTreeNode.cs CA-270440: Copy VM full copy SR list isn't sorted naturally. Resolving not just for SrPickerItem but for the CustomTreeNode as used for other related classes. 2018-11-16 15:11:34 +00:00
CustomTreeView.cs Removed the label from the SrPicker because in half of the occasions it was 2018-10-24 12:49:31 +01:00
CustomTreeView.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
CustomTreeView.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
CustomTreeView.resx CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
CustomTreeView.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
DataGridViewDropDownSplitButtonCell.cs CA-271967: Dismiss button is flat after dismissing first of a list of events. 2018-11-16 11:14:21 +00:00
DataGridViewEnableableComboBoxCell.cs Fixed issue whereby VS kept toggling between SubType Component and User Control 2018-11-09 16:23:29 +00:00
DataGridViewTextAndImageCell.cs CA-242134: Rename some of the classes and files, following the removal of the VMPP support 2017-05-25 16:29:27 +01:00
DateTimeMinutes15.cs CA-301907: Improvements to the VMSS dialog, the VMSS frequency properties/wizard page and the VMSS finish wizard page (#2358) 2019-03-15 14:10:42 +00:00
DecentGroupBox.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DeprecationBanner.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DeprecationBanner.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
DeprecationBanner.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
DeprecationBanner.resx CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
DeprecationBanner.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
DoubleBufferedListView.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DoubleBufferedPanel.cs Fixed issue whereby VS kept toggling between SubType Component and User Control 2018-11-09 16:23:29 +00:00
DoubleBufferedPanel.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
DropDownButton.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DropDownButton.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
DropDownButton.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
DropDownButton.resx CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
DropDownButton.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
EmptyPanel.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
EmptyPanel.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
FilterDatesToolStripDropDownButton.cs CP-23450: Add "View" btn in Updates page toolbar 2017-09-18 14:58:04 +01:00
FilterLocationToolStripDropDownButton.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
FilterSeveritiesToolStripDropDownButton.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
FilterStatusToolStripDropDownButton.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
FlickerFreeListBox.cs Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib. 2017-11-30 13:56:32 +00:00
FlickerFreePanel.cs Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib. 2017-11-30 13:56:32 +00:00
FlickerFreePanel.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
GradientPanel.cs Removed redundant code from GradientPanel and made it more object oriented; 2018-11-09 16:20:52 +00:00
HaNtolControl.cs CA-271850: Increase the timeout of session for querying MaximumTolerableHostFailures. 2018-03-20 07:09:34 +00:00
HaNtolIndicator.cs CA-294292: Layout modifications to fix error message truncation issues. 2018-09-27 12:43:04 +01:00
HaNtolIndicator.Designer.cs CA-294292: Layout modifications to fix error message truncation issues. 2018-09-27 12:43:04 +01:00
HaNtolIndicator.ja.resx L10N: Translation updates along with Interface resync 2018-09-28 14:00:14 +01:00
HaNtolIndicator.resx CA-294292: Layout modifications to fix error message truncation issues. 2018-09-27 12:43:04 +01:00
HaNtolIndicator.zh-CN.resx L10N: Translation updates along with Interface resync 2018-09-28 14:00:14 +01:00
HaNtolIndicatorSimple.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
HaNtolIndicatorSimple.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
HaNtolIndicatorSimple.ja.resx L10N:Translations check-ins 2017-01-06 12:46:19 +00:00
HaNtolIndicatorSimple.resx CP-16012: Rename branding variables 2016-02-10 11:52:30 +00:00
HaNtolIndicatorSimple.zh-CN.resx L10N:Translations check-ins 2017-01-06 12:46:19 +00:00
HelpButton.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
HelpButton.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
HelpButton.ja.resx L10N:Translations check-ins 2017-01-06 12:46:19 +00:00
HelpButton.resx CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
HelpButton.zh-CN.resx L10N:Translations check-ins 2017-01-06 12:46:19 +00:00
ListViewColumnSorter.cs Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib. 2017-11-30 13:56:32 +00:00
ListViewEx.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
LunPerVdiPicker.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
LunPerVdiPicker.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
LunPerVdiPicker.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
LunPerVdiPicker.resx CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
LunPerVdiPicker.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
MenuStripEx.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
MultipleDvdIsoList.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
MultipleDvdIsoList.Designer.cs Fixed regression introduced in previous commit. Also, the MultipleDvdIsoList on the 2016-07-06 08:55:28 +01:00
MultipleDvdIsoList.ja.resx L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
MultipleDvdIsoList.resx Fixed regression introduced in previous commit. Also, the MultipleDvdIsoList on the 2016-07-06 08:55:28 +01:00
MultipleDvdIsoList.zh-CN.resx L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
NativeConstants.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
NonReopeningContextMenuStrip.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
PanelNoFocusScroll.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
PanelWithBorder.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
PDSection.cs fix typos and rename a function 2018-06-21 14:54:47 +01:00
PDSection.Designer.cs The event handler meant to toggle the section's expanded state on mouse double 2018-12-18 09:28:47 +00:00
PDSection.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
PDSection.resx CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
PDSection.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
PoolHostPicker.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
PoolHostPicker.Designer.cs CP-19607: More event handlers that needed to be deregistered 2017-01-31 14:35:59 +00:00
PoolHostPicker.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
PoolHostPicker.resx CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
PoolHostPicker.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
PvsCacheStorageRow.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
PvsCacheStorageRow.Designer.cs CA-235381: XenCenter should not allow users to edit the PVS cache storage if it is in use 2016-12-13 11:09:23 +00:00
PvsCacheStorageRow.ja.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
PvsCacheStorageRow.resx CA-235381: XenCenter should not allow users to edit the PVS cache storage if it is in use 2016-12-13 11:09:23 +00:00
PvsCacheStorageRow.zh-CN.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
SectionHeaderLabel.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
SectionHeaderLabel.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
ShadowPanel.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ShadowPanel.ja.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
ShadowPanel.resx CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
ShadowPanel.zh-CN.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
SimpleProgressBar.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
SimpleProgressBar.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
SnapshotTreeView.cs Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib. 2017-11-30 13:56:32 +00:00
SnapshotTreeView.designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
SnapshotTreeView.ja.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
SnapshotTreeView.resx CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
SnapshotTreeView.zh-CN.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
SpinnerIcon.cs CA-301907: Improvements to the VMSS dialog, the VMSS frequency properties/wizard page and the VMSS finish wizard page (#2358) 2019-03-15 14:10:42 +00:00
SRListBox.cs Cleared some level 4 warnings. 2018-03-22 15:07:32 +00:00
SrPicker.cs Removed the label from the SrPicker because in half of the occasions it was 2018-10-24 12:49:31 +01:00
SrPickerItem.cs CP-28926: Add additional error message for >2TB VDIs 2018-08-15 10:02:15 +01:00
ToolStripEx.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ToolTipContainer.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ToolTipContainer.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
ToolTipContainer.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
ToolTipContainer.resx CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
ToolTipContainer.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
TransparentPanel.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
TransparentTrackBar.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
TransparentTrackBar.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
TransparentTrackBar.ja.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
TransparentTrackBar.resx CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
TransparentTrackBar.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
UpsellPage.cs Compliance with C# conventions: normally interface names start with an I. 2018-04-03 13:00:27 +01:00
UpsellPage.Designer.cs CP-15401: Move hidden check out of designer 2016-01-22 17:02:59 +08:00
UpsellPage.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
UpsellPage.resx CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
UpsellPage.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
VerticalTabs.cs Compliance with C# conventions: normally interface names start with an I. 2018-04-03 13:00:27 +01:00
VisualMenuItem.cs CA-284226: Optimize performance of menu Start-on-Server and Migrate-to-Server (#1985) 2018-03-20 07:07:19 +00:00
XenTabControl.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
XenTabControl.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
XenTabControl.ja.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
XenTabControl.resx CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
XenTabControl.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
XenTabPage.cs CA-303195: Provide the user the option to reconsider wizard cancellation 2019-01-15 17:12:09 +00:00
XenTabPage.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
XenTabPage.ja.resx L10N:Translations check-ins 2016-12-21 16:20:30 +00:00
XenTabPage.resx CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
XenTabPage.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30