xenadmin/XenAdminTests/UnitTests/WlbTests/WlbPoolConfigurationTests.cs
Gabor Apati-Nagy 597762b884 CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
Removed code that is no longer needed. Also removed an obsolete unit test.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-12 16:49:37 +01:00

229 lines
12 KiB
C#

/* Copyright (c) Citrix Systems, Inc.
* All rights reserved.
*
* Redistribution and use in source and binary forms,
* with or without modification, are permitted provided
* that the following conditions are met:
*
* * Redistributions of source code must retain the above
* copyright notice, this list of conditions and the
* following disclaimer.
* * Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the
* following disclaimer in the documentation and/or other
* materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
using System;
using System.Collections.Generic;
using System.Reflection;
using NUnit.Framework;
using XenAdmin.Wlb;
using XenAdminTests.UnitTests.UnitTestHelper;
namespace XenAdminTests.UnitTests.WlbTests
{
[TestFixture, Category(TestCategories.Unit)]
public class WlbPoolConfigurationTests
{
private IUnitTestVerifier validator;
private WlbPoolConfiguration wlbPool;
private const int NUMBER_OF_PROPERTIES = 33;
[Test, ExpectedException(typeof(Exception))]
public void NullCtorThrows()
{
wlbPool = new WlbPoolConfiguration(null);
}
[Test]
public void ConstructedWithEmptyDictionaryVerifyGettersReturnValues()
{
wlbPool = new WlbPoolConfiguration(new Dictionary<string, string>());
PropertyInfo[] pi = wlbPool.GetType().GetProperties();
Assert.AreEqual(NUMBER_OF_PROPERTIES, pi.Length, "Number of properties");
List<string> fieldsToSkip = new List<string>()
{
"AutoBalanceAggressiveness", //Enum
"AutoBalanceSeverity", //Enum
"ReportingSMTPServer", //Not set
"PoolAuditGranularity" //Enum
};
foreach (PropertyInfo propertyInfo in pi)
{
if( !fieldsToSkip.Contains( propertyInfo.Name ))
{
string extractedValue = propertyInfo.GetValue(wlbPool, null).ToString();
Assert.IsFalse(String.IsNullOrEmpty(extractedValue), "PB:" + propertyInfo.Name);
}
}
Assert.IsNullOrEmpty(wlbPool.ReportingSMTPServer);
}
[Test]
public void SettersTest()
{
Dictionary<string, string> inputData = new Dictionary<string, string>()
{
{"WlbVersion", "6.0"},
{"AutoBalanceEnabled", "false"},
{"AutoBalancePollIntervals", "0.333333"},
{"AutoBalanceSeverity", "High"},
{"AutoBalanceAggressiveness", "High"},
{"PowerManagementEnabled", "false"},
{"PowerManagementPollIntervals", "5.321264"},
{"EnableOptimizationModeSchedules", "false"} //Equal to AutomateOptimizationMode
};
validator = new VerifyGettersAndSetters(new WlbPoolConfiguration(inputData));
MRSensitiveData expectedData = new MRSensitiveData()
{
AutoBalanceEnabled = true,
AutoBalancePollIntervals = 2.0,
AutoBalanceSeverity = WlbPoolAutoBalanceSeverity.Low,
AutoBalanceAggressiveness = WlbPoolAutoBalanceAggressiveness.Medium,
PowerManagementEnabled = true,
PowerManagementPollIntervals = 7.0,
AutomateOptimizationMode = true
};
validator.Verify( expectedData);
}
[Test]
public void SettersThatSetVerbatim()
{
Dictionary<string, string> inputData = new Dictionary<string, string>()
{
//Simple setters.....
{"OptimizationMode", "MaximizeDensity"}, //PerformanceMode
{"MetricGroomingPeriod", "2.0"},
{"RecentMoveMinutes", "2.0"},
//{"ReportingUseRSServer", "false"},
{"ReportingSMTPServer", "some string"},
//These set ranges of values.....
{"HostCpuThresholdCritical", "3"},
{"HostMemoryThresholdCritical", "3.0"},
{"HostPifReadThresholdCritical", "4.0"}, //HostNetworkReadThresholdCritical
{"HostPifWriteThresholdCritical", "5.0"}, //HostNetworkWriteThresholdCritical
{"HostPbdReadThresholdCritical", "6.0"}, //HostDiskReadThresholdCritical
{"HostPbdWriteThresholdCritical", "7.0"}, //HostDiskWriteThresholdCritical
{"VmCpuUtilizationWeightHigh", "8"},
{"VmMemoryWeightHigh", "9"},
{"VmDiskReadWeightHigh", "10"},
{"VmDiskWriteWeightHigh", "11"},
{"VmNetworkReadWeightHigh", "12"},
{"VmNetworkWriteWeightHigh", "13"}
};
validator = new VerifyGettersAndSetters(new WlbPoolConfiguration(inputData));
MRInSensitiveData data = new MRInSensitiveData()
{
PerformanceMode = WlbPoolPerformanceMode.MaximizePerformance,
MetricGroomingPeriod = 5.0,
RecentMoveMinutes = 6.0,
//ReportingUseRSServer = true,
ReportingSMTPServer = "who knows what?!",
HostCpuThresholdCritical = 1,
HostMemoryThresholdCritical = 2,
HostNetworkReadThresholdCritical = 1.0,
HostNetworkWriteThresholdCritical = 2.0,
HostDiskReadThresholdCritical = 3.0,
HostDiskWriteThresholdCritical = 4.0,
VmCpuUtilizationWeightHigh = 5,
VmMemoryWeightHigh = 6,
VmDiskReadWeightHigh = 7,
VmDiskWriteWeightHigh = 8,
VmNetworkReadWeightHigh = 9,
VmNetworkWriteWeightHigh = 10
};
validator.Verify(data);
}
[Test]
public void OvercommitCPUsGetTheCorrectValueForDifferentModes()
{
Dictionary<string, string> inputData = new Dictionary<string, string>()
{
{"OverCommitCpuInDensityMode", "false"},
{"OverCommitCpuInPerfMode", "true"}
};
wlbPool = new WlbPoolConfiguration(inputData);
//Setter drops through if the key has not been added to the dictionary so won't set the values
wlbPool.PerformanceMode = WlbPoolPerformanceMode.MaximizeDensity;
//This should be false if the key were there
Assert.IsTrue(wlbPool.OvercommitCPUs, "OvercommitCPUs in MaximizeDensity mode without key");
//Add the key and set the data - this is now the default behaviour
wlbPool.AddParameter("OptimizationMode", "MaximizeDensity");
wlbPool.PerformanceMode = WlbPoolPerformanceMode.MaximizeDensity;
Assert.IsFalse(wlbPool.OvercommitCPUs, "OvercommitCPUs in MaximizeDensity mode");
wlbPool.PerformanceMode = WlbPoolPerformanceMode.MaximizePerformance;
Assert.IsTrue(wlbPool.OvercommitCPUs, "OvercommitCPUs in MaximizePerformance");
}
#region Helper functions
private struct MRSensitiveData
{
public bool AutoBalanceEnabled;
public double AutoBalancePollIntervals;
public WlbPoolAutoBalanceSeverity AutoBalanceSeverity;
public WlbPoolAutoBalanceAggressiveness AutoBalanceAggressiveness;
public bool PowerManagementEnabled;
public double PowerManagementPollIntervals;
public bool AutomateOptimizationMode;
}
private struct MRInSensitiveData
{
public WlbPoolPerformanceMode PerformanceMode;
public double MetricGroomingPeriod;
public double RecentMoveMinutes;
//public bool ReportingUseRSServer;
public string ReportingSMTPServer;
public int HostCpuThresholdCritical;
public double HostMemoryThresholdCritical;
public double HostNetworkReadThresholdCritical;
public double HostNetworkWriteThresholdCritical;
public double HostDiskReadThresholdCritical;
public double HostDiskWriteThresholdCritical;
public int VmCpuUtilizationWeightHigh;
public int VmMemoryWeightHigh;
public int VmDiskReadWeightHigh;
public int VmDiskWriteWeightHigh;
public int VmNetworkReadWeightHigh;
public int VmNetworkWriteWeightHigh;
}
#endregion
}
}