xenadmin/XenAdmin/Wizards/GenericPages/VMMappingSummary.cs
Danilo Del Busso 6c584bb351
CA-375532, CA-336510, and CP-41825: Add warnings when user selects too many vCPUs (#3119)
* Tidy up `SelectMultipleVMDestinationPage.cs`
* CA-375532 & CA-336510: Add warning when importing VMs with too many vCPUs
* CA-375532 & CA-336510: Prevent users from starting appliance if a VM has too many vCPUs
* Tidy up `Page_CpuMem`: use expression-bodied properties
* Tidy up `Page_CpuMem`: use conventional naming scheme
* Tidy up `Page_CpuMem`: use explicit modifiers
* Tidy up `Page_CpuMem`: use `en-US` locale for names
* Tidy up `Page_CpuMem`: use `var` when possible
* Tidy up `Page_CpuMem`: rename `Vcpus` to `VCpus`
* Tidy up `Page_CpuMem`: reorder elements
* Tidy up `Page_CpuMem`: revert class renaming and fix `vCpus` typos
* CA-375532: Prevent users from starting VM if they select too many vCPUs
* Tidy up `Page_Finish`: use expression-bodied properties
* Tidy up `Page_Finish`: fix typo
* Tidy up `Page_CpuMem`: rename `CanStartVM` to `CanStartVm`
* Remove unnecessary using directives
* Anchor warning icon to the top-left corner of its parent
* CA-375532 & CA-336510: Warn users when selecting more vCPUs than pCPUs in the Properties page
* CP-41825: Add warning for imported VMs with > 32 vCPUs
* CP-41825: Add warning for new VMs with > 32 vCPUs
* CP-41825: Add warning for existing VMs when selecting > 32 vCPUs
* CP-41825: Update wording used to alert users running VMs with > 32vCPUs
* Remove unused local variable in `VappStartCommand.cs`
* Reword some vCPUs messages
* Simplify assignment of `CanStartImmediately` in `Page_Finish.cs`
* Simplify assignment of `CanStartVmsAutomatically` in `ImportFinishPage.cs`
* Remove useless `Count` check in `VappStartCommand`
* Rename `pictureBox1` to `warningPictureBox` and change its `SizeMode`
* Separate CPU and memory warnings in `Page_CpuMem`
* Shorten warning messages shown in `Page_CpuMem`
* Disable option to start VM when memory configuration isn't valid
* Report number of vCPUs and pCPUs when showing warning in New VM wizard
* Tidy up `CpuMemoryEditPage`: rename elements
* Tidy up `CpuMemoryEditPage`: use explicity modifiers
* Tidy up `CpuMemoryEditPage`: Rename `CPUMemoryEditPage` to `CpuMemoryEditPage`
* Tidy up `CpuMemoryEditPage`: Miscellaneous renames and improvements
* Tidy up `CpuMemoryEditPage`: Fix whitespace
* Tidy up `CpuMemoryEditPage`: Use ReSharper code formatter
* Tidy up `CpuMemoryEditPage`: Move events to own region
* Tidy up `CpuMemoryEditPage`: Move `IEditPage` members to own region
* Tidy up `CpuMemoryEditPage`: Order members outside of regions
* Replace topology and vCPU warning labels with structured warnings
* Ensure warnings ends with a dot
* Allow multiple CPU warnings to show at the same time
* Remove warning link for vCPUS > pCPUS Option is not achievable
* Enable option to force unit used in `MemorySpinner`
* Replace `NumericUpDown` with `MemorySpinner` and show warnings at bottom of control
* Check destination pCPUs count when destination is not a pool
* Do not disable option to start VMs after import if user selects a shared SR
* Add memory warning when importing appliance with too much memory
* Sort vCPUs and memory warning strings
* Remove target from `ImportWizard`'s summary
Target is not useful and can cause confusion as appliance VMs could start on non-target hosts
* The home server is needed in the summary when importing XVA. The target server is not needed in the summary when migrating a VM.
* Update warnings when the server selection changes. Corrected memory calculation.
* Show all warnings for vCPUs. Moved topology warning to the bottom. Separated methods for showing memory and vCPU warnings.
* Removed the memory setting from the VM Properties dialog. Split running VM info to a separate panel.
* Corrections to the logic for starting the VM automatically. Also, Fixed a bit the layout of the Finish page to make better use of the available space.
* Corrections as per code review.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Co-authored-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-08 11:24:39 +01:00

321 lines
10 KiB
C#

/* Copyright (c) Cloud Software Group, Inc.
*
* Redistribution and use in source and binary forms,
* with or without modification, are permitted provided
* that the following conditions are met:
*
* * Redistributions of source code must retain the above
* copyright notice, this list of conditions and the
* following disclaimer.
* * Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the
* following disclaimer in the documentation and/or other
* materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
using System;
using System.Collections.Generic;
using XenAdmin.Core;
using XenAdmin.Mappings;
using XenAdmin.Network;
using XenAPI;
namespace XenAdmin.Wizards.GenericPages
{
public class SummaryDetails
{
public SummaryDetails(string key, string value, bool errors)
{
Key = key;
Value = value;
Errors = errors;
}
public SummaryDetails(string key, string value)
: this(key, value, false)
{
}
public string Key { get; private set; }
public string Value { get; private set; }
public bool Errors { get; private set; }
}
/// <summary>
/// Concrete component class for decorators
/// </summary>
public class VMMappingSummary : MappingSummary
{
public override List<SummaryDetails> Details
{
get { return new List<SummaryDetails>(); }
}
}
#region Decorator classes to convert VM Mappings to a summary
public abstract class TitleSummary : MappingSummaryDecorator
{
private readonly VmMapping mapping;
public TitleSummary(MappingSummary summary, VmMapping mapping)
: base(summary)
{
this.mapping = mapping;
}
public override List<SummaryDetails> Details
{
get
{
List<SummaryDetails> decoratedSummary = summary.Details;
decoratedSummary.Add(new SummaryDetails(SummaryKeyText, mapping.VmNameLabel));
return decoratedSummary;
}
}
protected abstract string SummaryKeyText
{
get;
}
}
public class VmTitleSummary : TitleSummary
{
public VmTitleSummary(MappingSummary summary, VmMapping mapping)
: base(summary, mapping)
{
}
protected override string SummaryKeyText
{
get { return Messages.CPM_SUMMARY_KEY_MIGRATE_VM; }
}
}
public class TemplateTitleSummary : TitleSummary
{
public TemplateTitleSummary(MappingSummary summary, VmMapping mapping)
: base(summary, mapping)
{
}
protected override string SummaryKeyText
{
get { return Messages.CPM_SUMMARY_KEY_MIGRATE_TEMPLATE; }
}
}
public class DestinationPoolSummary : MappingSummaryDecorator
{
private readonly VmMapping mapping;
private readonly IXenConnection connection;
public DestinationPoolSummary(MappingSummary summary, VmMapping mapping, IXenConnection connection)
: base(summary)
{
this.mapping = mapping;
this.connection = connection;
}
public override List<SummaryDetails> Details
{
get
{
List<SummaryDetails> decoratedSummary = summary.Details;
decoratedSummary.Add(new SummaryDetails(Messages.CPM_SUMMARY_KEY_DESTINATION, ResolveLabel()));
return decoratedSummary;
}
}
private string ResolveLabel()
{
if (mapping.XenRef is XenRef<Host>)
{
Host targetHost = connection.Resolve(mapping.XenRef as XenRef<Host>);
if(targetHost == null)
{
return Messages.UNKNOWN;
}
Pool targetPool = Helpers.GetPool(targetHost.Connection);
if (targetPool != null)
{
return targetPool.Name();
}
return mapping.TargetName;
}
return mapping.TargetName;
}
}
public class StorageSummary : MappingSummaryDecorator
{
private readonly VmMapping mapping;
private readonly IXenConnection connection;
private const string separatorText = " -> ";
public StorageSummary(MappingSummary summary, VmMapping mapping, IXenConnection connection)
: base(summary)
{
this.mapping = mapping;
this.connection = connection;
}
public override List<SummaryDetails> Details
{
get
{
List<SummaryDetails> decoratedSummary = summary.Details;
AddStorageMappings(ref decoratedSummary);
return decoratedSummary;
}
}
private void AddStorageMappings(ref List<SummaryDetails> decoratedSummary)
{
bool firstItem = true;
foreach (var pair in mapping.Storage)
{
VDI vdi = connection.Resolve(new XenRef<VDI>(pair.Key));
if (vdi == null || vdi.is_a_snapshot) // don't display the storage mappings for the shapshots
continue;
string valueToAdd = vdi.Name() + separatorText + pair.Value.Name();
if (firstItem)
{
decoratedSummary.Add(new SummaryDetails(Messages.CPM_SUMMARY_KEY_STORAGE, valueToAdd));
firstItem = false;
}
else
{
decoratedSummary.Add(new SummaryDetails(String.Empty, valueToAdd));
}
}
}
}
public class NetworkSummary : MappingSummaryDecorator
{
private readonly VmMapping mapping;
private readonly IXenConnection connection;
private const string separatorText = " -> ";
public NetworkSummary(MappingSummary summary, VmMapping mapping, IXenConnection connection)
: base(summary)
{
this.mapping = mapping;
this.connection = connection;
}
public override List<SummaryDetails> Details
{
get
{
List<SummaryDetails> decoratedSummary = summary.Details;
AddStorageMappings(ref decoratedSummary);
return decoratedSummary;
}
}
private void AddStorageMappings(ref List<SummaryDetails> decoratedSummary)
{
bool addSummaryKey = true;
foreach (var pair in mapping.Networks)
{
XenAPI.Network net = connection.Resolve(new XenRef<XenAPI.Network>(pair.Key));
bool networkNotFound = net == null;
string valueToAdd = networkNotFound ? Messages.CPM_SUMMARY_NETWORK_NOT_FOUND : net.Name();
valueToAdd += separatorText + pair.Value.Name();
decoratedSummary.Add(addSummaryKey
? new SummaryDetails(Messages.CPM_SUMMARY_KEY_NETWORK, valueToAdd, networkNotFound)
: new SummaryDetails(String.Empty, valueToAdd, networkNotFound));
addSummaryKey = false;
}
}
}
/// <summary>
/// Decorator class adding a splitter to the formatting
/// </summary>
public class SummarySplitter : MappingSummaryDecorator
{
public SummarySplitter(MappingSummary summary) : base(summary) { }
public override List<SummaryDetails> Details
{
get
{
List<SummaryDetails> decoratedSummary = summary.Details;
decoratedSummary.Add(new SummaryDetails(String.Empty, String.Empty));
return decoratedSummary;
}
}
}
/// <summary>
/// Decorator class adding a splitter to the formatting
/// </summary>
public class TransferNetworkSummary : MappingSummaryDecorator
{
private readonly string networkName;
public TransferNetworkSummary(MappingSummary summary, string networkName)
: base(summary)
{
this.networkName = networkName;
}
public override List<SummaryDetails> Details
{
get
{
List<SummaryDetails> decoratedSummary = summary.Details;
if (!string.IsNullOrEmpty(networkName))
decoratedSummary.Add(new SummaryDetails(Messages.CPM_SUMMARY_KEY_TRANSFER_NETWORK, networkName));
return decoratedSummary;
}
}
}
#endregion
/// <summary>
/// Base class for decorator and component classes
/// </summary>
public abstract class MappingSummary
{
public abstract List<SummaryDetails> Details { get; }
}
/// <summary>
/// Base decorator class
/// </summary>
public abstract class MappingSummaryDecorator : MappingSummary
{
protected MappingSummary summary;
protected MappingSummaryDecorator(MappingSummary summary)
{
this.summary = summary;
}
public override List<SummaryDetails> Details => summary != null ? summary.Details : new List<SummaryDetails>();
}
}