mirror of
https://github.com/xcp-ng/xenadmin.git
synced 2025-01-22 16:20:42 +01:00
16d7f74158
* CP-36392: Add several `null` checks All were flagged by SonarQube Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-36392: Specify `namespace` for `SettingsUpdate` Added to `XenAdmin` Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-36392: Collapse useless condition check Also use pattern matching for type cast Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-36392: Specify `namespace` for `ProduceConsumerQueue` Add to `XenAdmin.Actions` Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-36392: Rename field in `BugToolPageSelectCapabilties` to avoid name clash Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-36392: Add explicit `null` check While the `null` check in `GraphDetailsDialog.cs` is not strictly necessary, it has been added to fix a SonarQube issue Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-36392: Remove unused field in `WlbPoolConfiguration.cs` Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-36392: Replace useless self-assignment with ad-hoc method Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-36392: Simplify dictionary key assignment in `WlbScheduledTask.cs` Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-36392: Fix minor formatting issues Add newline at end of file, and reformat content of if statement Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-36392: Tidy up latest flagged bugs changes - Fix whitespace/braces in a few affected files - Add missing null check in `ValueMaps.cs` - Check for args length in `RbacCollectorProxy.cs` - Fix logic in `MainWindow.cs` to revert to previous behaviour Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-36392: Tidy up setter in `ChangeableList.cs` Also update whitespace inconsitencies in `PerfmonAlertEditPage.cs` and `VMHAEditPage.cs` Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
113 lines
4.7 KiB
C#
113 lines
4.7 KiB
C#
/* Copyright (c) Citrix Systems, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms,
|
|
* with or without modification, are permitted provided
|
|
* that the following conditions are met:
|
|
*
|
|
* * Redistributions of source code must retain the above
|
|
* copyright notice, this list of conditions and the
|
|
* following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above
|
|
* copyright notice, this list of conditions and the
|
|
* following disclaimer in the documentation and/or other
|
|
* materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
|
|
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
|
|
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
|
|
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
|
|
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
|
|
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
|
|
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
using System.Collections.Generic;
|
|
using XenAdmin.Core;
|
|
using XenAPI;
|
|
using System.Linq;
|
|
using System;
|
|
|
|
|
|
namespace XenAdmin.Wizards.PatchingWizard.PlanActions
|
|
{
|
|
class RemoveUpdateFileFromCoordinatorPlanAction : PlanActionWithSession
|
|
{
|
|
private readonly List<HostUpdateMapping> patchMappings = new List<HostUpdateMapping>();
|
|
private readonly XenServerPatch xenServerPatch;
|
|
private readonly Host coordinator;
|
|
|
|
public RemoveUpdateFileFromCoordinatorPlanAction(Host coordinator, List<HostUpdateMapping> patchMappings, XenServerPatch xenServerPatch)
|
|
: base(coordinator.Connection)
|
|
{
|
|
this.patchMappings = patchMappings;
|
|
this.xenServerPatch = xenServerPatch;
|
|
this.coordinator = coordinator;
|
|
}
|
|
|
|
protected override void RunWithSession(ref Session session)
|
|
{
|
|
try
|
|
{
|
|
var existing = (from HostUpdateMapping hum in patchMappings
|
|
let xpm = hum as XenServerPatchMapping
|
|
where xpm != null && xpm.Matches(coordinator, xenServerPatch)
|
|
select xpm).FirstOrDefault();
|
|
|
|
if (!Helpers.ElyOrGreater(session.Connection))
|
|
{
|
|
Pool_patch poolPatch = null;
|
|
var mapping = existing as PoolPatchMapping;
|
|
|
|
if (mapping != null && mapping.IsValid)
|
|
{
|
|
poolPatch = mapping.Pool_patch;
|
|
}
|
|
else
|
|
{
|
|
poolPatch = session.Connection.Cache.Pool_patches.FirstOrDefault(pp => string.Equals(pp.uuid, xenServerPatch.Uuid, StringComparison.InvariantCultureIgnoreCase));
|
|
}
|
|
|
|
if (mapping != null && poolPatch != null && poolPatch.opaque_ref != null)
|
|
{
|
|
AddProgressStep(string.Format(Messages.UPDATES_WIZARD_REMOVING_UPDATES_FROM_POOL, poolPatch.Name()));
|
|
var task = Pool_patch.async_pool_clean(session, mapping.Pool_patch.opaque_ref);
|
|
PollTaskForResultAndDestroy(Connection, ref session, task);
|
|
|
|
patchMappings.Remove(mapping);
|
|
}
|
|
}
|
|
else
|
|
{
|
|
var mapping = existing as PoolUpdateMapping;
|
|
|
|
if (mapping != null && mapping.IsValid)
|
|
{
|
|
var poolUpdate = mapping.Pool_update;
|
|
AddProgressStep(string.Format(Messages.UPDATES_WIZARD_REMOVING_UPDATES_FROM_POOL, poolUpdate.Name()));
|
|
|
|
Pool_update.pool_clean(session, poolUpdate.opaque_ref);
|
|
|
|
if (!poolUpdate.AppliedOnHosts().Any())
|
|
Pool_update.destroy(session, poolUpdate.opaque_ref);
|
|
|
|
patchMappings.Remove(mapping);
|
|
}
|
|
}
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
//best effort
|
|
log.Error("Failed to remove update from the server.", ex);
|
|
}
|
|
}
|
|
}
|
|
}
|