mirror of
https://github.com/xcp-ng/xenadmin.git
synced 2024-11-25 06:16:37 +01:00
bba9f43c31
* Tidy up `ArchiveMaintainer`: use naming conventions * Tidy up `ArchiveMaintainer`: use `var` when possible * Tidy up `ArchiveMaintainer`: fix typos * Tidy up `ArchiveMaintainer`: move action methods in own region * Tidy up `ArchiveMaintainer`: apply code formatting * Tidy up `ArchiveMaintainer`: remove unused constant/using * Tidy up `ArchiveMaintainer`: group methods into regions * Tidy up `ArchiveMaintainer`: remove xmldocs * Tidy up `ArchiveMaintainer`: miscellaneous changes * Tidy up `ArchiveMaintainer`: move `NextArchiveDown` to correct `region` * CA-376887: Use multiple threads to load performance tab data This commit removes the ad-hoc use of `Thread` and instead relies on `ThreadPool` and `CancellationToken`s to handle multi-threading. To achieve this, `ArchiveMaintainer` instances are now tied to only one `XenObject`. If a user navigates to another Performance tab, a new instance of `ArchiveMaintainer` is used. This enables XenCenter to quietly cancel ongoing data fetching operations, and start a new one without affecting the UI. UI elements are simply updated to point to the new `ArchiveMaintainer` while the old one is being closed. Please note that follow up commits to clean up `ArchiveMaintiner` and this implementation are coming. They have been separated to make reviews easier * CA-376887: Move initial load logic to separate method in `ArchiveMaintainer` * CA-376887: Rename `Update` to `StartUpdateLoop` in `ArchiveMaintainer` * CA-376887: Fix use of `Dispose` in `PerformancePage` and collapse `Stop`/`Pause` into one method * CA-376887: Remove unused `FirstTime` variable * Tidy up `ArchiveMaintainer`: use `switch` when possible and improve logging * Tidy up `ArchiveMaintainer`: Move variables inline * Tidy up `ArchiveMaintainer`: Standardize fields/properties * Tidy up `ArchiveMaintainer`: Normalize whitespace * CA-376887: Ensure only one thread is spawned for each `ArchiveMaintainer` - Ensures resources are disposed of - Fixes issues whereby quickly starting and stopping threads for the same `XenObject` `ArchiveMantainer` would cause threads from not exiting * Improve formatting and whitespace in `ArchiveMaintainer` * Improve logging of exceptions in `ArchiveMaintainer:Get` * Fix `ServerNow` calls in `ArchiveMaintainer` * Deregister `ArchiveMaintainer` events when a new one is reassigned. Also rename methods * Apply code review suggestions Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com> |
||
|---|---|---|
| .. | ||
| ArchiveMaintainer.cs | ||
| DataArchive.cs | ||
| DataAxis.cs | ||
| DataEvent.cs | ||
| DataEventList.cs | ||
| DataEventList.designer.cs | ||
| DataEventList.ja.resx | ||
| DataEventList.resx | ||
| DataEventList.zh-CN.resx | ||
| DataGrid.cs | ||
| DataKey.cs | ||
| DataKey.Designer.cs | ||
| DataKey.ja.resx | ||
| DataKey.resx | ||
| DataKey.zh-CN.resx | ||
| DataPlot.cs | ||
| DataPlot.designer.cs | ||
| DataPlot.ja.resx | ||
| DataPlot.resx | ||
| DataPlot.zh-CN.resx | ||
| DataPlotNav.cs | ||
| DataPlotNav.designer.cs | ||
| DataPlotNav.ja.resx | ||
| DataPlotNav.resx | ||
| DataPlotNav.zh-CN.resx | ||
| DataPoint.cs | ||
| DataRange.cs | ||
| DataSet.cs | ||
| DataTimeRange.cs | ||
| DrawSetArgs.cs | ||
| GraphHelpers.cs | ||
| GraphList.cs | ||
| GraphList.Designer.cs | ||
| GraphList.ja.resx | ||
| GraphList.resx | ||
| GraphList.zh-CN.resx | ||
| LineRenderer.cs | ||
| LongPoint.cs | ||
| LongRectangle.cs | ||
| Palette.cs | ||
| Polygon.cs | ||