xenadmin/XenAdmin/Wizards/ImportWizard/GlobalSelectHost.cs
Mihaela Stoica deb953a6ff CA-280287: Fix the null reference exception on the Import wizard (#1918)
* CA-280287: Fix the null reference exception on the Import wizard

- Added a check so that we don't attempting to show the license warning if the wizard is open without a preselected host/pool.
- The license warning is now updated whenever the host selection changes; plus, we are not attempting to show it if the wizard is open without a preselected host/pool.

- Also a minor refactoring in the GlobalSelectHost page to fix this issue: when the wizard is open with a pre-selected host, we pass this to the page by assigning SelectedHost property, which in turn sets the m_selectedHost. The getter for SelectedHost  resets m_selectedHost to the selected item in the host list. If the getter is used before the host list selection is updated, then the desired pre-selection is lost, because m_selectedHost is reset to null.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-280287: Corrections following code review

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-01-19 14:05:20 +00:00

137 lines
4.1 KiB
C#

/* Copyright (c) Citrix Systems, Inc.
* All rights reserved.
*
* Redistribution and use in source and binary forms,
* with or without modification, are permitted provided
* that the following conditions are met:
*
* * Redistributions of source code must retain the above
* copyright notice, this list of conditions and the
* following disclaimer.
* * Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the
* following disclaimer in the documentation and/or other
* materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
using System;
using XenAdmin.Controls;
using XenAdmin.Commands;
using XenAdmin.Network;
using XenAPI;
namespace XenAdmin.Wizards.ImportWizard
{
internal partial class GlobalSelectHost : XenTabPage
{
private IXenObject m_selectedObject;
private bool m_buttonNextEnabled;
public event Action<IXenConnection> ConnectionSelectionChanged;
public GlobalSelectHost()
{
InitializeComponent();
m_poolHostPicker.AllowPoolSelect = true;
m_poolHostPicker.SelectedItemChanged += SelectedItemChanged;
}
#region Base class (XenTabPage) overrides
/// <summary>
/// Gets the page's title (headline)
/// </summary>
public override string PageTitle { get { return Messages.IMPORT_SELECT_HOST_PAGE_TITLE; } }
/// <summary>
/// Gets the page's label in the (left hand side) wizard progress panel
/// </summary>
public override string Text { get { return Messages.HOME_SERVER; } }
/// <summary>
/// Gets the value by which the help files section for this page is identified
/// </summary>
public override string HelpID { get { return "GlobalSelectHost"; } }
protected override bool ImplementsIsDirty()
{
return true;
}
public override void PopulatePage()
{
m_poolHostPicker.buildList();
var selectedHost = m_selectedObject as Host;
if (selectedHost != null)
m_poolHostPicker.SelectHost(selectedHost);
else if (m_selectedObject != null && m_selectedObject.Connection != null)
m_poolHostPicker.SelectConnection(m_selectedObject.Connection);
IsDirty = true;
}
public override bool EnableNext()
{
return m_buttonNextEnabled;
}
#endregion
#region Control event handlers
private void SelectedItemChanged(object sender, SelectedItemEventArgs e)
{
m_buttonNextEnabled = e.SomethingSelected;
OnPageUpdated();
IsDirty = true;
if (ConnectionSelectionChanged != null)
ConnectionSelectionChanged(SelectedHost != null ? SelectedHost.Connection : SelectedConnection);
}
private void m_buttonAddNewServer_Click(object sender, EventArgs e)
{
new AddHostCommand(Program.MainWindow, this).Execute();
}
#endregion
public Host SelectedHost
{
get
{
return m_poolHostPicker.ChosenHost;
}
}
public IXenConnection SelectedConnection
{
get
{
return m_poolHostPicker.ChosenConnection;
}
}
public void SetDefaultTarget(IXenObject xenObject)
{
m_selectedObject = xenObject;
}
}
}