mirror of
https://github.com/xcp-ng/xenadmin.git
synced 2024-11-25 06:16:37 +01:00
4ce9878b45
* Refactored the VIFDialog to fix various problems: - Launch the dialog in using blocks. - Event GotFocus is not meant to be handled directly in the code. - Populate the dialog in the OnLoad override instead of the constructor as this causes problems at design time. - Popping up an error message for duplicate MAC on combobox item selection or textbox text change is not optimal UX. Perform this check once when closing the form. Additionally the parent form of the pop up should be the dialog, not the main window. - The validation messages are not obvious to the user because they are hidden in the tooltip of a disabled button. Show them inline instead. - There is no need to create commands for VIF creation/change; use the relevant actions instead. Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com> * Corrections as per code review plus some more code tidy and refactoring. - Added option to suppress Create/DeleteVIFActions - Use property RebootRequired to indicate hot-plugging is unavailable (assigning various objects of different types to the Result of the action during its run may cause confusion). Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com> |
||
---|---|---|
.. | ||
NetworkList.cs | ||
NetworkList.Designer.cs | ||
NetworkList.ja.resx | ||
NetworkList.resx | ||
NetworkList.zh-CN.resx |