mirror of
https://github.com/xcp-ng/xenadmin.git
synced 2024-12-22 16:36:03 +01:00
c061b0f57d
* CA-257574: Manage vApps dialog is unusable with a vApp containing a large number of VMs - In the VMAppliancesDialog, change event handlers to reduce the number of refreshes when something changes: only reload the appliances when the VM_appliance collection change; if a relevant property is changed (in VM_appliance or VM), then update only the affected rows. - Improve the way we assign VMs to a group (AssignVMsToVMApplianceAction and AssignVMsToPolicyAction): only update the VMs that really changed. - Also improve the way we update the VM startup options and HA restart priorities on a set of VMs Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com> * CA-257574: Manage vApps dialog is unusable with a vApp containing a large number of VMs: changes following code review - reverted the changes to the AssignVMsToGroup actions that added the additional constructor - changed the AssignVMsToGroup actions to calculate the set difference between two lists more efficiently - added code to deregister PropertyChanged events on VM_appliances - removed getCurrentSettings() method as it is not needed, GetChangedSettings can be used in all cases Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
168 lines
6.6 KiB
C#
168 lines
6.6 KiB
C#
/* Copyright (c) Citrix Systems, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms,
|
|
* with or without modification, are permitted provided
|
|
* that the following conditions are met:
|
|
*
|
|
* * Redistributions of source code must retain the above
|
|
* copyright notice, this list of conditions and the
|
|
* following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above
|
|
* copyright notice, this list of conditions and the
|
|
* following disclaimer in the documentation and/or other
|
|
* materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
|
|
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
|
|
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
|
|
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
|
|
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
|
|
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
|
|
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using XenAdmin.Actions;
|
|
using XenAdmin.Controls;
|
|
using XenAdmin.Dialogs;
|
|
using XenAdmin.Wizards.HAWizard_Pages;
|
|
using XenAPI;
|
|
using System.Drawing;
|
|
|
|
|
|
namespace XenAdmin.Wizards
|
|
{
|
|
public partial class HAWizard : XenWizardBase
|
|
{
|
|
private readonly Intro xenTabPageIntro;
|
|
private readonly AssignPriorities xenTabPageAssignPriorities;
|
|
private readonly ChooseSR xenTabPageChooseSR;
|
|
private readonly HAFinishPage xenTabPageHaFinish;
|
|
|
|
private readonly Pool pool;
|
|
|
|
public HAWizard(Pool pool)
|
|
: base(pool.Connection)
|
|
{
|
|
InitializeComponent();
|
|
|
|
xenTabPageIntro = new Intro();
|
|
xenTabPageAssignPriorities = new AssignPriorities();
|
|
xenTabPageChooseSR = new ChooseSR();
|
|
xenTabPageHaFinish = new HAFinishPage();
|
|
|
|
this.pool = pool;
|
|
|
|
AddPage(xenTabPageIntro);
|
|
AddPage(xenTabPageChooseSR);
|
|
xenTabPageChooseSR.Pool = pool;
|
|
AddPage(xenTabPageAssignPriorities);
|
|
xenTabPageAssignPriorities.ProtectVmsByDefault = true;
|
|
xenTabPageAssignPriorities.Connection = pool.Connection;//set the connection again after the pafe has been added
|
|
AddPage(xenTabPageHaFinish);
|
|
}
|
|
|
|
protected override void OnShown(EventArgs e)
|
|
{
|
|
// Check for broken SRs
|
|
List<string> brokenSRs = new List<string>();
|
|
foreach (SR sr in xenConnection.Cache.SRs)
|
|
{
|
|
if (sr.HasPBDs && sr.IsBroken() && !sr.IsToolsSR && sr.shared)
|
|
{
|
|
brokenSRs.Add(sr.NameWithoutHost);
|
|
}
|
|
}
|
|
|
|
if (brokenSRs.Count > 0)
|
|
{
|
|
using (var dlg = new ThreeButtonDialog(
|
|
new ThreeButtonDialog.Details(
|
|
SystemIcons.Warning,
|
|
String.Format(Messages.HA_SRS_BROKEN_WARNING, String.Join("\n", brokenSRs.ToArray())),
|
|
Messages.HIGH_AVAILABILITY)))
|
|
{
|
|
dlg.ShowDialog(this);
|
|
}
|
|
}
|
|
|
|
base.OnShown(e);
|
|
}
|
|
|
|
protected override void UpdateWizardContent(XenTabPage senderPage)
|
|
{
|
|
if (senderPage.GetType() == typeof(AssignPriorities))
|
|
{
|
|
xenTabPageHaFinish.HeartbeatSrName = xenTabPageChooseSR.SelectedHeartbeatSR.Name;
|
|
xenTabPageHaFinish.Ntol = xenTabPageAssignPriorities.Ntol;
|
|
|
|
int alwaysRestartHighPriority = 0, alwaysRestart = 0, bestEffort = 0, doNotRestart = 0;
|
|
foreach (VM.HA_Restart_Priority priority in xenTabPageAssignPriorities.CurrentSettings.Values)
|
|
{
|
|
switch (priority)
|
|
{
|
|
case VM.HA_Restart_Priority.AlwaysRestartHighPriority:
|
|
alwaysRestartHighPriority++;
|
|
break;
|
|
case VM.HA_Restart_Priority.AlwaysRestart:
|
|
case VM.HA_Restart_Priority.Restart:
|
|
alwaysRestart++;
|
|
break;
|
|
case VM.HA_Restart_Priority.BestEffort:
|
|
bestEffort++;
|
|
break;
|
|
case VM.HA_Restart_Priority.DoNotRestart:
|
|
doNotRestart++;
|
|
break;
|
|
}
|
|
}
|
|
|
|
xenTabPageHaFinish.AlwaysRestartHighPriority = alwaysRestartHighPriority;
|
|
xenTabPageHaFinish.AlwaysRestart = alwaysRestart;
|
|
xenTabPageHaFinish.BestEffort = bestEffort;
|
|
xenTabPageHaFinish.DoNotRestart = doNotRestart;
|
|
}
|
|
}
|
|
|
|
protected override bool RunNextPagePrecheck(XenTabPage senderPage)
|
|
{
|
|
if (senderPage.GetType() == typeof(Intro))
|
|
{
|
|
// Start HB SR scan
|
|
// If scan finds no suitable SRs ChooseSR will show sensible text and disallow progress.
|
|
// If scan returns false user has cancelled and we should stay on intro.
|
|
return xenTabPageChooseSR.ScanForHeartbeatSRs();
|
|
}
|
|
return true;
|
|
}
|
|
|
|
protected override void FinishWizard()
|
|
{
|
|
long ntol = xenTabPageAssignPriorities.Ntol;
|
|
|
|
// Save configured restart priorities and enable HA.
|
|
EnableHAAction action = new EnableHAAction(pool, xenTabPageAssignPriorities.GetChangedStartupOptions(), new List<SR> { xenTabPageChooseSR.SelectedHeartbeatSR } , ntol);
|
|
// We will need to re-enable buttons when the action completes
|
|
action.Completed += Program.MainWindow.action_Completed;
|
|
action.RunAsync();
|
|
|
|
Program.MainWindow.UpdateToolbars();
|
|
base.FinishWizard();
|
|
}
|
|
|
|
protected override string WizardPaneHelpID()
|
|
{
|
|
return "HAWizard";
|
|
}
|
|
}
|
|
}
|