Commit Graph

1937 Commits

Author SHA1 Message Date
Ben Kochie
93a7f70c84
Merge pull request #2318 from alexjx/topic/pick-up-new-procfs
fix cpustat when some cpus are offline
2023-01-20 10:12:55 +01:00
Jia Xin
39b4556b5b fix cpustat when some cpus are offline
Signed-off-by: Jia Xin <alexjx@gmail.com>
2023-01-20 01:24:06 +00:00
Ben Kochie
a3bd2e1305
Merge pull request #2559 from bsiegert/netbsd-uname
Enable uname collector on NetBSD too
2022-12-31 13:03:41 +01:00
Benny Siegert
701912b5e7 Enable uname collector on NetBSD too
This collector works just fine without any further changes.

Signed-off-by: Benny Siegert <bsiegert@gmail.com>
2022-12-31 12:02:00 +01:00
Ben Kochie
b9eef570d5
Merge pull request #2554 from prometheus/superq/fix_thermal_missing
Fix thermal_zone collector noise
2022-12-29 14:27:13 +01:00
prombot
d647e2a01b Update common Prometheus files
Signed-off-by: prombot <prometheus-team@googlegroups.com>
2022-12-29 11:20:41 +01:00
Ben Kochie
efa7f24698
Fix thermal_zone collector noise
Add a check for missing/unreadable thermal zone stats and ignore if not
availlable.

Fixes: https://github.com/prometheus/node_exporter/issues/2552

Signed-off-by: Ben Kochie <superq@gmail.com>
2022-12-22 12:30:20 +01:00
Ben Kochie
4484f18566
Merge pull request #2542 from mchtech/add-perf-profiler-options
Add profiler options for perf collector
2022-12-22 10:29:03 +01:00
Ben Kochie
edc33af8ed
Merge pull request #2553 from hodgesds/perf-bump
Bump perf-utils version to 0.6.0
2022-12-22 10:23:08 +01:00
Daniel Hodges
b5259fe16f
Bump perf-utils version to 0.6.0
This change updates the perf-utils library to 0.6.0 which has some fixes
for automatically detecting the correct tracefs mountpoint if available.

Signed-off-by: Daniel Hodges <hodges.daniel.scott@gmail.com>
2022-12-21 20:57:17 -05:00
jalev
22e5dd2f0d Fix lint issues
Signed-off-by: jalev <qweet.ing@gmail.com>
2022-12-18 14:49:53 +01:00
James Bach
a177412d06 Change var name to match previous
Signed-off-by: James Bach <james.bach@wise.com>
Signed-off-by: jalev <qweet.ing@gmail.com>
2022-12-18 14:49:53 +01:00
James Bach
5538773089 Migrate arp_linux.go to procfs
Signed-off-by: James Bach <qweet.ing@gmail.com>
Signed-off-by: James Bach <james.bach@wise.com>
Signed-off-by: jalev <qweet.ing@gmail.com>
2022-12-18 14:49:53 +01:00
prombot
da08a2959f Update common Prometheus files
Signed-off-by: prombot <prometheus-team@googlegroups.com>
2022-12-13 13:46:20 +01:00
Ben Kochie
1e82c57931 Update v1.5.0 release notes
Add note about the change to the experimental web flag.

Fixes: https://github.com/prometheus/node_exporter/issues/2535

Signed-off-by: Ben Kochie <superq@gmail.com>
2022-12-13 13:36:44 +01:00
Ryan J. Geyer
5e552bac02 Replace mistaken ) with }, resulting in parsable promql
Signed-off-by: Ryan J. Geyer <me@ryangeyer.com>
2022-12-13 13:30:42 +01:00
Ben Kochie
8cbe5cda8b
Merge pull request #2543 from adeptg/master
fix the docker link in the ISSUE_TEMPLATE
2022-12-08 08:26:18 +01:00
Yury Vidineev
56554f3a8a fix the docker link in the ISSUE_TEMPLATE
Signed-off-by: Yury Vidineev <adeptg@gmail.com>
2022-12-07 16:11:28 -08:00
mchtech
f934f9cb0f add options for perf profilers
Signed-off-by: mchtech <michu_an@126.com>
2022-12-07 12:52:46 +08:00
Ben Kochie
9869d34a24
Merge pull request #2537 from simonpasquier/log-current-gomaxprocs
Log current value of GOMAXPROCS
2022-11-30 09:53:39 -08:00
Simon Pasquier
2d05f2e0c3 Log current value of GOMAXPROCS
With `--runtime.gomaxprocs=0`, the GOMAXPROXS value will default to the
number of logical CPUs. In this case, it is more useful to log the
actual value than the value set by the user via the command-line.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
2022-11-30 17:16:49 +01:00
Ben Kochie
219744f97d
Merge pull request #2534 from frebib/frebib/web.config.file
Correct documentation for --web.config.file flag
2022-11-29 12:37:06 -08:00
Joe Groocock
a5df170905
Correct documentation for --web.config.file flag
The --web.config flag changed to --web.config.file in
440a132c38 and was realised in the recent
v1.5.0 release.

Signed-off-by: Joe Groocock <me@frebib.net>
2022-11-29 19:37:41 +00:00
Ben Kochie
1b48970ffc
Merge pull request #2532 from prometheus/superq/1.5.0
Release v1.5.0
2022-11-29 10:57:50 -08:00
Ben Kochie
3db05cfb3d
Release v1.5.0
NOTE: This changes the Go runtime "GOMAXPROCS" to 1. This is done to limit the
  concurrency of the exporter to 1 CPU thread at a time in order to avoid a
  race condition problem in the Linux kernel (#2500) and parallel IO issues
  on nodes with high numbers of CPUs/CPU threads (#1880).

* [CHANGE] Default GOMAXPROCS to 1 #2530
* [FEATURE] Add multiple listeners and systemd socket listener activation #2393
* [ENHANCEMENT] Add RTNL version of netclass collector #2492, #2528
* [BUGFIX] Fix diskstats exclude flags #2487
* [BUGFIX] Bump go/x/crypt and go/x/net #2488
* [BUGFIX] Fix hwmon label sanitizer #2504
* [BUGFIX] Use native endianness when encoding InetDiagMsg #2508
* [BUGFIX] Fix btrfs device stats always being zero #2516
* [BUGFIX] Security: Update exporter-toolkit (CVE-2022-46146) #2531

Signed-off-by: Ben Kochie <superq@gmail.com>
2022-11-29 19:44:19 +01:00
Ben Kochie
8ece6336d9
Bump Go modules (#2531)
* Update all Go modules to latest.
* Update Go minimum version to 1.18.
Signed-off-by: Ben Kochie <superq@gmail.com>
2022-11-29 12:02:48 +01:00
Ben Kochie
fb26b9fc72
Default GOMAXPROCS to 1 (#2530)
Avoid running on all CPUs by limiting the Go runtime to one CPU by
default. Avoids having Go routines schedule on every CPU, driving up the
visible run queue length on high CPU count systems.

This also helps workaround a kernel deadlock issue with reading from
sysfs concurrently.

See:
* https://github.com/prometheus/node_exporter/issues/1880
* https://github.com/prometheus/node_exporter/issues/2500

Signed-off-by: Ben Kochie <superq@gmail.com>
2022-11-29 12:01:58 +01:00
Ben Kochie
13a5cc1f74
Refactor netclass_rtnl collector (#2528)
* Refactor netclass_rtnl collector

Merge the netclass_rtnl collector into the netclass collector.
* Disabled by default
* Followup to #2492

Signed-off-by: Ben Kochie <superq@gmail.com>
2022-11-29 11:22:25 +01:00
manu
956a3f8d47
update to golang.org/x/sys v0.1.0 (#2524)
Signed-off-by: Manuel Stausberg <stausberg@denic.de>
2022-11-21 17:25:58 +01:00
SUN Haoyu
bba0e2e557
add RTNL version of netclass collector (#2492)
* update rtnetlink package to v1.2.3
* add RTNL version of netclass collector that have all the metrics that netdev collector provides, too.

Signed-off-by: Haoyu Sun <hasun@redhat.com>
2022-11-21 16:38:04 +01:00
Sabart Otto
26e82af8a2
readme: remove RHEL/CentOS/Fedora installation info (#2525)
Copr community prometheus-exporters repository is obsoleted.

Signed-off-by: Otto Sabart <seberm@seberm.com>

Signed-off-by: Otto Sabart <seberm@seberm.com>
2022-11-14 17:57:01 +01:00
Marcus Cobden
936368d217
Fix btrfs device stats always being zero (#2516)
* Respect rootfs path config option in btrfs ioctl
* Fix btrfs device stats always being zero

Signed-off-by: Marcus Cobden <leth@users.noreply.github.com>
2022-11-08 16:09:39 +01:00
dependabot[bot]
fd14fb04c7 build(deps): bump github.com/jsimonetti/rtnetlink from 1.2.2 to 1.2.3
Bumps [github.com/jsimonetti/rtnetlink](https://github.com/jsimonetti/rtnetlink) from 1.2.2 to 1.2.3.
- [Release notes](https://github.com/jsimonetti/rtnetlink/releases)
- [Commits](https://github.com/jsimonetti/rtnetlink/compare/v1.2.2...v1.2.3)

---
updated-dependencies:
- dependency-name: github.com/jsimonetti/rtnetlink
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-11-03 13:22:46 +01:00
dependabot[bot]
fb5229e3b1 build(deps): bump github.com/prometheus/client_model from 0.2.0 to 0.3.0
Bumps [github.com/prometheus/client_model](https://github.com/prometheus/client_model) from 0.2.0 to 0.3.0.
- [Release notes](https://github.com/prometheus/client_model/releases)
- [Commits](https://github.com/prometheus/client_model/compare/v0.2.0...v0.3.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_model
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-11-03 13:22:36 +01:00
Ben Kochie
ba8c043079
Add procfs fallback to netdev collector (#2509)
Some systems have broken netlink messages due to patched kernels. Since
these messages can not be parsed, add a flag to fall back to parsing
from `/proc/net/dev`.

Fixes: https://github.com/prometheus/node_exporter/issues/2502

Signed-off-by: Ben Kochie <superq@gmail.com>

Signed-off-by: Ben Kochie <superq@gmail.com>
2022-10-24 10:30:32 +02:00
Perry Naseck
440a132c38
Add multiple listeners and systemd socket listener activation (#2393)
Update exporter-toolkit to v0.8.1 to enable new listener support.

Signed-off-by: Perry Naseck <git@perrynaseck.com>
2022-10-23 12:45:29 +02:00
Daniel Swarbrick
34a498e132
Use native endianness when encoding InetDiagMsg (#2508)
Note however that the InetDiagMsg struct contains a InetDiagSockID
member, which itself contains some members which are explicitly
specified as big-endian in Linux kernel source:

struct inet_diag_sockid {
	__be16	idiag_sport;
	__be16	idiag_dport;
	__be32	idiag_src[4];
	__be32	idiag_dst[4];
	__u32	idiag_if;
	__u32	idiag_cookie[2];
};

node_exporter currently does not use these members for anything, so this
is acceptable (for now).

Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com>
2022-10-22 11:05:47 +02:00
Jan Fajerski
87b8e3790d
docs/node-mixin: add fsMointpointSelector to alerts and dashboards (#2446)
* docs/node-mixin: add fsMountpointSelector

This adds the option to add a `mountpoint` selector to filesystem
related alerts. The default is `mountpoint!=""`.

* docs/node-mixins: add fsMountpointSelector to dashboards

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
2022-10-20 13:06:31 +02:00
dependabot[bot]
385cb1922c
build(deps): bump github.com/coreos/go-systemd/v22 from 22.3.2 to 22.4.0 (#2493)
Bumps [github.com/coreos/go-systemd/v22](https://github.com/coreos/go-systemd) from 22.3.2 to 22.4.0.
- [Release notes](https://github.com/coreos/go-systemd/releases)
- [Commits](https://github.com/coreos/go-systemd/compare/v22.3.2...v22.4.0)

---
updated-dependencies:
- dependency-name: github.com/coreos/go-systemd/v22
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-20 12:09:22 +02:00
dependabot[bot]
bb63f4f616 build(deps): bump github.com/mdlayher/netlink from 1.6.0 to 1.6.2
Bumps [github.com/mdlayher/netlink](https://github.com/mdlayher/netlink) from 1.6.0 to 1.6.2.
- [Release notes](https://github.com/mdlayher/netlink/releases)
- [Changelog](https://github.com/mdlayher/netlink/blob/main/CHANGELOG.md)
- [Commits](https://github.com/mdlayher/netlink/compare/v1.6.0...v1.6.2)

---
updated-dependencies:
- dependency-name: github.com/mdlayher/netlink
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-18 12:55:33 +02:00
dependabot[bot]
ebb8a667ec build(deps): bump github.com/opencontainers/selinux
Bumps [github.com/opencontainers/selinux](https://github.com/opencontainers/selinux) from 1.10.1 to 1.10.2.
- [Release notes](https://github.com/opencontainers/selinux/releases)
- [Commits](https://github.com/opencontainers/selinux/compare/v1.10.1...v1.10.2)

---
updated-dependencies:
- dependency-name: github.com/opencontainers/selinux
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-18 12:55:23 +02:00
Ben Kochie
98a40bd712
Fix hwmon label sanitizer (#2504)
We don't need to fully sanitize the hwmon label values to metric/label
name strings.
* Just make sure they're valid UTF-8.
* Always included the label metric to avoid group_left failures.

Signed-off-by: Ben Kochie <superq@gmail.com>

Signed-off-by: Ben Kochie <superq@gmail.com>
2022-10-11 14:40:28 +02:00
Jason Culligan
e1d9172fb6
Bump crypto and net CVE-2022-27191 CVE-2022-27664 (#2488)
* Bump crypto and net CVE-2022-27191 CVE-2022-27664

Signed-off-by: Jason Culligan <jason.culligan@intel.com>
2022-10-10 22:20:18 +02:00
Johannes 'fish' Ziemke
b7dd00ff8b Update ISSUE_TEMPLATE.md
Signed-off-by: Johannes 'fish' Ziemke <github@5pi.de>
2022-10-06 12:54:09 +02:00
Ben Kochie
d9b2634324
Fix diskstats exclude flags (#2487)
Correctly handle the new `collector.diskstats.device-exclude` flag to
avoid errors when using the old `collector.diskstats.ignored-devices`
flag.

Fixes: https://github.com/prometheus/node_exporter/issues/2486

Signed-off-by: Ben Kochie <superq@gmail.com>
2022-09-28 15:00:37 +02:00
Darshil Chanpura
daba360c93
Archived fixtures/udev similar to fixtures/sys to avoid go-get errors, fixes #2482 (#2485)
Signed-off-by: Darshil Chanpura <darshil@thatwebsite.xyz>
2022-09-27 23:07:57 +02:00
Ben Kochie
7da1321761
Release 1.4.0 (#2478)
* [CHANGE] Merge metrics descriptions in textfile collector #2475
* [FEATURE] [node-mixin] Add darwin dashboard to mixin #2351
* [FEATURE] Add "isolated" metric on cpu collector on linux #2251
* [FEATURE] Add cgroup summary collector #2408
* [FEATURE] Add selinux collector #2205
* [FEATURE] Add slab info collector #2376
* [FEATURE] Add sysctl collector #2425
* [FEATURE] Also track the CPU Spin time for OpenBSD systems #1971
* [FEATURE] Add support for MacOS version #2471
* [ENHANCEMENT] [node-mixin] Add missing selectors #2426
* [ENHANCEMENT] [node-mixin] Change current datasource to grafana's default #2281
* [ENHANCEMENT] [node-mixin] Change disk graph to disk table #2364
* [ENHANCEMENT] [node-mixin] Change io time units to %util #2375
* [ENHANCEMENT] Ad user_wired_bytes and laundry_bytes on *bsd #2266
* [ENHANCEMENT] Add additional vm_stat memory metrics for darwin #2240
* [ENHANCEMENT] Add device filter flags to arp collector #2254
* [ENHANCEMENT] Add diskstats include and exclude device flags #2417
* [ENHANCEMENT] Add node_softirqs_total metric #2221
* [ENHANCEMENT] Add rapl zone name label option #2401
* [ENHANCEMENT] Add slabinfo collector #1799
* [ENHANCEMENT] Allow user to select port on NTP server to query #2270
* [ENHANCEMENT] collector/diskstats: Add labels and metrics from udev #2404
* [ENHANCEMENT] Enable builds against older macOS SDK #2327
* [ENHANCEMENT] qdisk-linux: Add exclude and include flags for interface name #2432
* [ENHANCEMENT] systemd: Expose systemd minor version #2282
* [ENHANCEMENT] Use netlink for tcpstat collector #2322
* [ENHANCEMENT] Use netlink to get netdev stats #2074
* [ENHANCEMENT] Add additional perf counters for stalled frontend/backend cycles #2191
* [ENHANCEMENT] Add btrfs device error stats #2193
* [BUGFIX] [node-mixin] Fix fsSpaceAvailableCriticalThreshold and fsSpaceAvailableWarning #2352
* [BUGFIX] Fix concurrency issue in ethtool collector #2289
* [BUGFIX] Fix concurrency issue in netdev collector #2267
* [BUGFIX] Fix diskstat reads and write metrics for disks with different sector sizes #2311
* [BUGFIX] Fix iostat on macos broken by deprecation warning #2292
* [BUGFIX] Fix NodeFileDescriptorLimit alerts #2340
* [BUGFIX] Sanitize rapl zone names #2299
* [BUGFIX] Add file descriptor close safely in test #2447
* [BUGFIX] Fix race condition in os_release.go #2454
* [BUGFIX] Skip ZFS IO metrics if their paths are missing #2451

Signed-off-by: Ben Kochie <superq@gmail.com>

Signed-off-by: Ben Kochie <superq@gmail.com>
2022-09-26 14:30:51 +02:00
PrometheusBot
e0845a81fd
Update common Prometheus files (#2473)
Signed-off-by: prombot <prometheus-team@googlegroups.com>

Signed-off-by: prombot <prometheus-team@googlegroups.com>
2022-09-24 09:16:43 +02:00
Marcus Cobden
135710d8b5
Add btrfs device error stats (#2193)
* Improve metrics filesystem scanning logic
* Makes ioctl syscalls to load the device error stats.
* Adds filesystem mountpoint labels to existing metrics for ease of use.

Signed-off-by: Marcus Cobden <leth@users.noreply.github.com>
2022-09-24 08:25:15 +02:00
tnextday
d7e89e769d
Skip zfs iostats (#2451)
skip over the zfs IO metrics if their paths are missing

Signed-off-by: tnextday <fw2k4@163.com>

Signed-off-by: tnextday <fw2k4@163.com>
2022-09-22 19:32:31 +02:00