Kiu/VictoriaMetrics
Kiu/VictoriaMetrics
1
0
Fork 0
mirror of https://github.com/VictoriaMetrics/VictoriaMetrics.git synced 2024-12-13 13:11:37 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

app/vmselect/netstorage: remove spammy error message when certain vmstorage nodes are unavailable during query execution

Browse Source 
The amount of partial responses may be tracked by `vm_partial_search_results_total` metric.
This commit is contained in:
Aliaksandr Valialkin 2019-06-03 17:09:43 +03:00
parent 1d87abc8eb
commit a06b7f7f84
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/vmselect/netstorage/netstorage.go
View File

@ -653,12 +653,12 @@ func ProcessSearchQuery(at *auth.Token, sq *storage.SearchQuery, deadline Deadli
return nil, true, fmt.Errorf("error occured during search: %s", errors[0])
}
// Just log errors and return partial results.
// Just return partial results.
// This allows gracefully degrade vmselect in the case
// if certain storageNodes are temporarily unavailable.
// Do not log the error, since it may spam logs on busy vmselect
// serving high amount of requests.
partialSearchResults.Inc()
// Log only the first error, since it has no sense in returning all errors.
logger.Errorf("certain storageNodes are unhealthy during search: %s", errors[0])
isPartialResult = true
}
if err := tbf.Finalize(); err != nil {