7494 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
hagen1778	8040bdc1d6	docs/troubleshooting: mention query latency in unexpected query results ... See https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5555 Signed-off-by: hagen1778 <roman@victoriametrics.com>	2024-01-17 11:59:47 +01:00
Roman Khavronenko	3a1ef3184d	app/victoriametrics: update the test suite (#5627) ... app/victoriametrics: update the test suite * simplify /query and /query_range test cases configuration and tests * support instant queries with lookbehind window like `query=foo[5m]` * support instant queries selecting scalar value like `query=42` * add query_range test for prometheus Signed-off-by: hagen1778 <roman@victoriametrics.com>	2024-01-17 09:51:10 +01:00
Aliaksandr Valialkin	f3c5687a04	LICENSE: update the current year from 2023 to 2024	2024-01-17 01:48:04 +02:00
Aliaksandr Valialkin	1683df11f0	docs/CHANGELOG.md: document v1.93.10 LTS release ... See https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.93.10	2024-01-17 01:45:06 +02:00
Aliaksandr Valialkin	f2f0468ae7	docs/keyConcepts.md: clarify which values can be stored in VictoriaMetrics without precision loss ... This is a follow-up for 43d7de4afe Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5485 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5503	2024-01-17 01:09:16 +02:00
Aliaksandr Valialkin	ecce2d6db1	docs/CHANGELOG.md: document v1.87.13 LTS release ... See https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.87.13	2024-01-17 01:04:05 +02:00
Aliaksandr Valialkin	0f39c0e897	snap/local/Makefile: update Go builder from Go1.21.5 to Go1.21.6	2024-01-17 00:07:05 +02:00
Aliaksandr Valialkin	41932db848	lib/promscrape: cosmetic changes after 3ac44baebe ... - Rename mustLoadScrapeConfigFiles() to loadScrapeConfigFiles(), since now it may return error. - Split too long line with the error message into two lines in order to improve readability a bit. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5508 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5560	2024-01-16 22:29:09 +02:00
Aliaksandr Valialkin	c830064c2f	docs/{vmbackup,vmbackupmanager}.md: clarify why storing backups to S3 Glacier can be time-consuming and expensive ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5614 This is a follow-up for e14e3d9c8c	2024-01-16 21:50:43 +02:00
hagen1778	b0287867fe	deployment/dashboards: change title VictoriaMetrics to VictoriaMetrics - single-node ... The new title should provide better understanding of this dashboard purpose. Signed-off-by: hagen1778 <roman@victoriametrics.com>	2024-01-16 20:39:52 +01:00
Aliaksandr Valialkin	a9fd130980	app/vmselect/graphite: properly handle -N index for the array of N items ... This is a follow-up for 70cd09e736 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5581	2024-01-16 21:05:01 +02:00
Aliaksandr Valialkin	30d77393a5	docs/CHANGELOG.md: fix a link in the description of 70cd09e736 ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5581	2024-01-16 20:54:44 +02:00
Aliaksandr Valialkin	4e4d7f4cbe	app/vmctl: disallow insecure https connections to vm-native-dst-addr and vm-native-src-addr by default ... It is better from security PoV to disallow insecure https connections to vm-native-dst-addr and vm-native-src-addr . This also maintains backwards compatibility with vmctl before the commit 828aca82e9 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5595 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5606	2024-01-16 20:20:33 +02:00
Aliaksandr Valialkin	19c04549a5	docs/Single-server-VictoriaMetrics.md: explain why staleness markers are treated as an ordinary values during de-duplication ... This is a follow-up for d374595e31 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5587	2024-01-16 20:10:12 +02:00
Aliaksandr Valialkin	db6495560c	docs/vmagent.md: mention the minumum value for -remoteWrite.vmProtoCompressLevel ... Recommend using the default value for -remoteWrite.vmProtoCompressLevel This is a follow-up for 095d982976 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5575	2024-01-16 19:46:13 +02:00
Aliaksandr Valialkin	4073bb3303	lib/httputils: handle step=undefined query arg as an empty value ... This is needed for Grafana, which may send step=undefined when working with alerting rules and instant queries.	2024-01-16 18:59:26 +02:00
Yury Molodov	d365157381	vmui/vmanomaly: add support models that produce only anomaly_score (#5594) ... * vmui/vmanomaly: add support models that produce only `anomaly_score` * vmui/vmanomaly: fix display legend * vmui/vmanomaly: update comment on anomaly threshold	2024-01-16 18:50:19 +02:00
Artem Navoiev	846d5a3ab8	docs: vmanomaly fix font matter ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-16 16:58:48 +01:00
Artem Navoiev	481471b872	docs: vmanomaly remove commented text ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-16 16:43:59 +01:00
Aliaksandr Valialkin	a74f6d63e0	deployment/docker: update Go builder from Go1.21.5 to Go1.21.6	2024-01-16 17:00:16 +02:00
Aliaksandr Valialkin	6eae3f6c8a	vendor: run make vendor-update	2024-01-16 16:57:30 +02:00
Aliaksandr Valialkin	9d886a2eb0	lib/storage: follow-up for 4b8088e377 ... - Clarify the bugfix description at docs/CHANGELOG.md - Simplify the code by accessing prefetchedMetricIDs struct under the lock instead of using lockless access to immutable struct. This shouldn't worsen code scalability too much on busy systems with many CPU cores, since the code executed under the lock is quite small and fast. This allows removing cloning of prefetchedMetricIDs struct every time new metric names are pre-fetched. This should reduce load on Go GC, since the cloning of uin64set.Set struct allocates many new objects.	2024-01-16 15:29:57 +02:00
Aliaksandr Valialkin	b49b8fed3c	app/vmselect/promql: simplify the code after 388d020b7c ... Add a test, which verifies the correct sorting of float64 slices with NaNs. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5506 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5509	2024-01-16 15:06:33 +02:00
Hui Wang	3ac44baebe	exit vmagent if there is config syntax error in scrape_config_files when -promscrape.config.strictParse=true (#5560)	2024-01-16 17:30:02 +08:00
hagen1778	d0e4190969	deployment/alerts: add job label to DiskRunsOutOfSpace alerting rule ... So it is easier to understand to which installation the triggered instance belongs. Signed-off-by: hagen1778 <roman@victoriametrics.com>	2024-01-16 09:49:39 +01:00
Aliaksandr Valialkin	388d020b7c	app/vmselect/promql: follow-up for ce4f26db02 ... - Document the bugfix at docs/CHANGELOG.md - Filter out NaN values before sorting as suggested at https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5509#discussion_r1447369218 - Revert unrelated changes in lib/filestream and lib/fs - Use simpler test at app/vmselect/promql/exec_test.go Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5509 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5506	2024-01-16 02:55:08 +02:00
Zongyang	ce4f26db02	FIX bottomk doesn't return any data when there are no time range overlap between timeseries (#5509) ... * FIX sort order in bottomk * Add lessWithNaNsReversed for bottomk * Add ut for TopK * Move lt from loop * FIX lint * FIX lint * FIX lint * Mod log format --------- Co-authored-by: xiaozongyang <xiaozngyang@kanyun.com> Co-authored-by: Aliaksandr Valialkin <valyala@victoriametrics.com>	2024-01-16 02:19:36 +02:00
Aliaksandr Valialkin	190a6565ae	app/vmselect/promql: consistently sort results of a or b query ... Previously the order of results returned from `a or b` query could change with each request because the sorting for such query has been disabled in order to satisfy https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4763 . This commit executes `a or b` query as `sortByMetricName(a) or sortByMetricName(b)`. This makes the order of returned time series consistent across requests, while maintaining the requirement from https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4763 , e.g. `b` results are consistently put after `a` results. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5393	2024-01-16 01:30:10 +02:00
Aliaksandr Valialkin	7fc2bd0412	app/vmstorage: expose proper types for storage metrics when -metrics.exposeMetadata command-line flag is set ... This is a follow-up for 326a77c697	2024-01-16 00:20:37 +02:00
Aliaksandr Valialkin	bfa73ebdf3	lib/prompbmarshal: move WriteRequest proto definition to the correct place	2024-01-16 00:20:37 +02:00
Artem Navoiev	51cdf3676b	docs: vmanomaly fix image size ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-15 23:10:52 +01:00
Artem Navoiev	74219a1727	vmanomly: guide add diagramm ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-15 23:07:49 +01:00
Artem Navoiev	041a1966c5	docs: vmanomaly fix formatting and remove unnecessary elements ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-15 22:45:02 +01:00
Artem Navoiev	191e322879	vmanomaly - models a bit pretify docs (#5618) ... * vmanomaly - models a bit pretify docs Signed-off-by: Artem Navoiev <tenmozes@gmail.com> * typi Signed-off-by: Artem Navoiev <tenmozes@gmail.com> * fix formatting Signed-off-by: Artem Navoiev <tenmozes@gmail.com> --------- Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-15 13:26:38 -08:00
Artem Navoiev	544da241e8	vmanomaly guides - fix formating, add missing piece, clarify statement, use common languagefor VM ecosystem (#5620) ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-15 13:26:26 -08:00
Artem Navoiev	0c78b891b0	clarify cluster multitenacy in vmanomaly docs (#5619) ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-15 12:36:28 -08:00
Artem Navoiev	f51b7fda8e	docs: fix markdown in how-to-monitor-k8s ... Signed-off-by: Artem Navoiev <tenmozes@gmail.com>	2024-01-15 18:16:26 +01:00
Aliaksandr Valialkin	4b42c8abbb	lib/promscrape/discovery/hetzner: fix golangci-lint warnings after 03a97dc678 ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5550	2024-01-15 17:12:40 +02:00
Roman Khavronenko	e14e3d9c8c	docs: mention requirements for latest backups (#5614) ... Add docs to explain that `latest` backup folder can be accessed more frequently than others. Hence, it is recommended to keep it on storages with low access price. Signed-off-by: hagen1778 <roman@victoriametrics.com>	2024-01-15 15:30:55 +01:00
Aliaksandr Valialkin	5106045048	app/vmstorage: deregister storage metrics before stopping the storage ... This prevents from possible nil pointer dereference issues when the storage metrics are read after the storage is stopped. Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5548	2024-01-15 16:11:45 +02:00
Aliaksandr Valialkin	be509b3995	lib/pushmetrics: wait until the background goroutines, which push metrics, are stopped at pushmetrics.Stop() ... Previously the was a race condition when the background goroutine still could try collecting metrics from already stopped resources after returning from pushmetrics.Stop(). Now the pushmetrics.Stop() waits until the background goroutine is stopped before returning. This is a follow-up for https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5549 and the commit fe2d9f6646 . Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5548	2024-01-15 13:50:36 +02:00
Aliaksandr Valialkin	9fd20202e1	vendor/github.com/VictoriaMetrics/easyproto: update from v0.1.3 to v0.1.4 ... This fixes vet error for 32-bit architectures: https://github.com/VictoriaMetrics/VictoriaMetrics/actions/runs/7521709384/job/20472882877	2024-01-15 11:31:30 +02:00
Aleksandr Stepanov	03a97dc678	vmagent: added hetzner sd config (#5550) ... * added hetzner robot and hetzner cloud sd configs * remove gettoken fun and update docs * Updated CHANGELOG and vmagent docs * Updated CHANGELOG and vmagent docs --------- Co-authored-by: Nikolay <nik@victoriametrics.com>	2024-01-15 10:13:22 +01:00
Roman Khavronenko	4b8088e377	lib/storage: properly check for storage/prefetchedMetricIDs cache expiration deadline (#5607) ... Before, this cache was limited only by size. Cache invalidation by time happens with jitter to prevent thundering herd problem. Signed-off-by: hagen1778 <roman@victoriametrics.com>	2024-01-15 10:03:06 +01:00
rbizos	70cd09e736	Handling negative index in Graphite groupByNode/aliasByNode (#5581) ... Handeling the error case with -1 Signed-off-by: Raphael Bizos <r.bizos@criteo.com> Co-authored-by: Nikolay <nik@victoriametrics.com>	2024-01-15 09:57:15 +01:00
Aliaksandr Valialkin	d2c94a0663	lib/prompbmarshal: switch to github.com/VictoriaMetrics/easyproto	2024-01-14 23:04:45 +02:00
Aliaksandr Valialkin	a47127c1a6	app/vmalert/remotewrite: properly calculate vmalert_remotewrite_dropped_rows_total ... It was calculating the number of dropped time series instead of the number of dropped samples. While at it, drop vmalert_remotewrite_dropped_bytes_total metric, since it was inconsistently calculated - at one place it was calculating raw protobuf-encoded sample sizes, while at another place it was calculating the size of snappy-compressed prompbmarshal.WriteRequest protobuf message. Additionally, this metric has zero practical sense, so just drop it in order to reduce the level of confusion.	2024-01-14 22:55:11 +02:00
Aliaksandr Valialkin	c005245741	lib/prompb: switch to github.com/VictoriaMetrics/easyproto	2024-01-14 22:46:06 +02:00
Aliaksandr Valialkin	f2229c2e42	lib/prompb: change type of Label.Name and Label.Value from []byte to string ... This makes it more consistent with lib/prompbmarshal.Label	2024-01-14 22:33:21 +02:00
Aliaksandr Valialkin	f405384c8c	lib/protoparser/datadogv2: simplify code for parsing protobuf messages after 0597718435 ... Updates https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5094 Updates https://github.com/VictoriaMetrics/VictoriaMetrics/issues/4451	2024-01-14 21:43:01 +02:00