Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-25 06:16:37 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

CA-189084: Control domain memory alerts not getting generated in Xencenter.

Browse Source 
Added logging to catch {}
This commit is contained in:
Gabor Apati-Nagy 2015-12-08 11:38:10 +00:00
parent 4baa36efab
commit 9a9f117dd8
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
XenAdmin/SettingsPanels/PerfmonAlertEditPage.cs
View File

@ -267,7 +267,10 @@ namespace XenAdmin.SettingsPanels
physicalUtilisationAlert.Populate(perfmonDefinition);
}
}
catch { }
catch (Exception ex)
{
log.Error("Unexpected error during populating controls for Alerts. Exception swallowed.", ex); //Adding this to pre-existing empty catch block to log it at least
}
// Dom0 memory usage is stored in the other_config of the Dom0 vm not on the host (or any other XenObject)
try
@ -295,7 +298,7 @@ namespace XenAdmin.SettingsPanels
}
catch (Exception ex)
{
log.Error("Unexpected error during populating controls for Dom0 Memory Usage alert. Leaving it as is.", ex);
log.Error("Unexpected error during populating controls for Dom0 Memory Usage alert. Exception swallowed.", ex); //Any error here will cause the controls not being populated, but they will be still usable.
}
}