Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2025-01-20 23:39:51 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,268 Commits 12 Branches 48 Tags 186 MiB
1580a89594
Commit Graph

6268 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Konstantina Chremmou
1580a89594
Merge pull request #2931 from kc284/settings 
Minor refactoring; null check; tidy up
 2022-01-27 13:34:20 +00:00
Konstantina Chremmou
bae03aff8b Fixed issue where the settings from previous installations were not imported. Added more documentation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-24 19:55:38 +00:00
Danilo Del Busso
2bc25d72d5 CP-38814: Add friendly names to new xapi alerts 
vm_migrated
vm_snapshotted
vm_snapshot_reverted
vm_checkpointed
vm_paused
vm_unpaused

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-24 15:46:37 +00:00
Danilo Del Busso
d7f1853562 Bump C# SDK to modified version of xapi 21.3.0/1.xs8 
SDK update does not contain the removal of `evacuate` overloads

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-24 15:46:37 +00:00
Danilo Del Busso
7f38f71a6e CP-38832: Bump xencenter-pipeline to v4.3 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-24 15:23:40 +00:00
Konstantina Chremmou
8f9afafb7a Use Tick() when setting both the PercentComplete and the Description to avoid firing OnChanged() twice. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-24 15:23:02 +00:00
Konstantina Chremmou
1225e98225 Improved logging and reporting percentage when importing an XVA. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-24 15:23:02 +00:00
Konstantina Chremmou
b4afd3ce4c CA-261979: Use utf-8 encoding for logging (or on localised systems the log files may contain illegible characters). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-24 15:22:28 +00:00
Danilo Del Busso
f07b3d4e05 CP-37850: Update RPU005 to version 4.0 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-24 15:22:07 +00:00
Konstantina Chremmou
ba8cf7f782
Merge pull request #2934 from xenserver/feature/CP-38483 
CP-38483: Unbundle putty from  Citrix Hypervisor Center
 2022-01-24 15:21:32 +00:00
Konstantina Chremmou
f29e267670 Some corrections and refactoring on the external console feature. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
c9bb9c1f0c CA-362353: Add file existence check when launching SSH console 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
66d1c6624b CA-362355: Remove SSH console location check if paths haven't changed 
Avoids users not being able to save other options if the selected SSH console location isn't valid

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
322edd3536 CA-362352: Save SSH Console settings changes on startup 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
34876461fc CA-362354: Account for non-exe files when saving SSH client path 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Konstantina Chremmou
2c18b7c7ed Tidy up: moved method to Settings and renamed it. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-13 11:04:13 +00:00
Konstantina Chremmou
8086359d2d Minor refactoring. Show more logging. Null check. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-13 11:01:59 +00:00
Konstantina Chremmou
1e1bb8ddcd Retry sorting .resx strings. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-10 14:39:38 +00:00
Darren Matthews
95667d3c80 L10N : Translations 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2022-01-10 10:13:24 +00:00
Konstantina Chremmou
e129b0b321 Revert "Sort .resx strings" 
This reverts commit 0536fdc05a.
 2022-01-10 10:12:30 +00:00
Danilo Del Busso
0536fdc05a Sort .resx strings 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-10 09:53:58 +00:00
Danilo Del Busso
8da9db629d Normalise line endings with CR/LF when using sort_strings.ps1 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-10 09:53:58 +00:00
Danilo Del Busso
dc282732d3 CP-38530: Bump dotnet-pacakges version 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-07 10:04:43 +00:00
Danilo Del Busso
9ebcdaabd7 CP-38530: Remove reference to PuTTY in LegalNoticesDialog 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-07 10:04:43 +00:00
Danilo Del Busso
6a52322035 CP-38530: Remove PuTTY from build scripts and wix installer 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-07 10:04:43 +00:00
Konstantina Chremmou
7ca120eb76 Fixed DialogResult and ButtonType for buttons (dialog was not closing on Esc or from control box). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-06 10:50:13 +00:00
Konstantina Chremmou
489069b36b Control behaviour corrections: 
- When radio buttons share the same container, only one needs to be checked.
- Do not set the owning control to null, or the balloon does not hide when asked to.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-06 10:50:13 +00:00
Konstantina Chremmou
57b07a9c7b Set roaming to true. Corrected setting type. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-06 10:50:13 +00:00
Konstantina Chremmou
879191424c Added hotkeys. Corrected tab indices. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
b66685a927 CP-38529: Remove method calling PuTTY in GeneralTabPage 
Method is not useful anymore. This commit only removes the PuTTY-related code.

Other docker-related unused code is ignored as it should be removed separately.

Whitespace diffs are tabs -> spaces and automatic VS2019 reformatting

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
c58d066389 CP-38529: Order strings in Messages.resx alphabetically 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
d27eaa3bbd CP-38529: Use pre-installed SSH clients to launch VM console 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
8801b6bdf9 CP-38529: Check SSH client settings on launch 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
495dcd66d4 CP-38529: Make PluginManager public in MainWindow.cs 
To allow to open the Options page from other forms

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
3956502063 CP-38529: Add External Tools options page 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
c6eedbc9f3 CP-38529: Add ssh client strings to Messages.resx 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
971ae0d064 CP-38529: Add SSH client settings 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
41be442413 CP-38529: Add SshConsole enum 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00
Darren Matthews
702ce7ce0f L10N : Resx resync and Translation Updates 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2022-01-05 11:38:40 +00:00
Danilo Del Busso
596f76ddcb
CA-361926: Ensure Messages.resx in XenCenter stays alphabetically sorted (#2915) 
* CA-361926: Add script to check sorting of Messages.resx

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361926: Add string sorting to PR/push checks

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361926: Add script to sort strings in Messages.resx

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361926: Allow multi-path input for string sorting scripts

Also improved output to help with errors

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361926: Add localization option to string sorting scripts

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361926: Specify encoding in string sorting scripts

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361926: Update `main.yml` to reflect changes to string checking scripts

Also add other `.resx` files

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361926: Remove case sensitive equality for boolean operation

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361926: Rename `Get-Path` into `Get-ResolvedPath`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361926: Remove unused variable

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361926: Add exit code check before executing string sorting check for `Branding.resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361926: Improve readability of string sorting scripts

Changed spacing using automatic formatter

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361926: Fix exit message in string sorting scripts

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-05 11:14:21 +00:00
Danilo Del Busso
48dd60486a
Merge pull request #2889 from danilo-delbusso/CA-359124 
CA-359124 & CA-360426: Add snapshot VIFs to mapping during cross pool migration & fix VIF mapping in cross pool migration
 2022-01-05 12:13:40 +01:00
Danilo Del Busso
d33f90aaf3
CA-361078: vCPUs count isn't exported/imported within OVFs (#2913) 
* CA-361078: Export max vCPUs when generating OVF

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361078: Populate max vCPUs when importing OVFs

Also keeps backwards compatibility with old import

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-361078: Tidy up `SetCPUs` method in `OVF.cs`

Also fixes whitespace using automatic formatter in VS2019

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-04 10:56:16 +00:00
Konstantina Chremmou
b50ba18b38 Show the snapshot's name for the extra VIFs belonging to snapshots. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-12-23 16:40:05 +01:00
Konstantina Chremmou
f6db9820a1 Retrieve VM snapshots from the cache instead of making an API call to the server. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-12-23 16:40:05 +01:00
Danilo Del Busso
18595759f7 CA-362018: Improve update notification dismissal message 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-22 12:15:08 +01:00
Danilo Del Busso
91f4a76f22 CP-36392: Amend WLB tests to account for deleted property 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-22 10:16:53 +00:00
Danilo Del Busso
16d7f74158
CP-36392: Misc fixes to flagged Bugs (#2907) 
* CP-36392: Add several `null` checks

All were flagged by SonarQube

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Specify `namespace` for `SettingsUpdate`

Added to `XenAdmin`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Collapse useless condition check

Also use pattern matching for type cast

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Specify `namespace` for `ProduceConsumerQueue`

Add to `XenAdmin.Actions`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Rename field in `BugToolPageSelectCapabilties` to avoid name clash

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Add explicit `null` check

While the `null` check in `GraphDetailsDialog.cs` is not strictly necessary, it has been added to fix a SonarQube issue

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Remove unused field in `WlbPoolConfiguration.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Replace useless self-assignment with ad-hoc method

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Simplify dictionary key assignment in `WlbScheduledTask.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Fix minor formatting issues

Add newline at end of file, and reformat content of if statement

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Tidy up latest flagged bugs changes

- Fix whitespace/braces in a few affected files
- Add missing null check in `ValueMaps.cs`
- Check for args length in `RbacCollectorProxy.cs`
- Fix logic in `MainWindow.cs` to revert to previous behaviour

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Tidy up setter in `ChangeableList.cs`

Also update whitespace inconsitencies in `PerfmonAlertEditPage.cs` and `VMHAEditPage.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-21 15:53:46 +00:00
Konstantina Chremmou
3121885aac
Merge pull request #2905 from danilo-delbusso/ad-logout_CA-343229 
CA-343229: Changing roles when logged in as an AD user only takes effect after logging out/in
 2021-12-17 11:25:26 +00:00
Konstantina Chremmou
4a6b2b1e1b
CA-343229: Some modifications: 
- Fixed issue whereby logging out the current user did not log out other
  sessions of the currentUser opened from outside the application.
- Improved prompts shown to the user when changing roles.
- Corrected percentage reporting.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-12-17 11:08:31 +00:00
Danilo Del Busso
53bf485a14
Replace negative term with log(ging) out user 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-12-17 11:06:56 +00:00