Commit Graph

5143 Commits

Author SHA1 Message Date
Mihaela Stoica
20dfd74375 CA-271864: Add the host name to the precheck problem description for more Problem classes.
Also changed two classes to inherit from the VMProblem class.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-16 11:38:34 +01:00
Mihaela Stoica
8b2ab5f79d Removed some unused classes and messages
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-16 11:38:34 +01:00
Mihaela Stoica
5879b5ae60 CA-271864: Add the host name to the precheck failure when the VM cannot be evacuated.
The other part of this ticket (add OTHER_OPERATION_IN_PROGRESS to the known errors) has already been done in commit 97a60c91.
Minor refactoring to the VMProblem class.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-16 11:38:34 +01:00
Konstantina Chremmou
c8c2ea448a CA-156828: Do not uncompress imported appliance on a modal dialog, but rather
asynchronously on the SelectImportSourcePage, so that the rest of XenCenter
is usable while the unzip is taking place; for this purpose a progress bar
was added on the page and the DecompressApplianceDialog was removed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-16 10:59:35 +01:00
Konstantina Chremmou
a918a0b0c8 The method UpdateToolbarsCore should be private. Do not call it explicitly; it is
called by the PluginsChanged event handler.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
c270882737 Improved previous commit to avoid setting the TabPageFeature Urls when switching
from this an object with selected TabPageFeature to a different object with a
deselected TabPageFeature.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
abec5c4aba CA-284090: Added a dedicated status bar on the TabPageFeature to resemble real
life browsers and allow the user to see the status even if other actions are taking
place. Removed webClient use from the browser; instead try sequentially to navigate
to all Uris until one succeeds; this avoids sending duplicate requests and allows
the user to see all endpoints tried out. Reworked the WebBrowser event handlers
to ensure the UI reflects correctly the browser state.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
07f298096f CA-284090: Refactored the code setting the object in the TabePageFeatures to avoid
multiple iterations as well as updating the feature when it's not needed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
d67dd1c815 Do not create a Uri if there are no IPs as it throws exception unnecessarily; Return
about:blank instead. Removed parameter null check as it is done by PlaceholderRegex.Replace.
Minor tidy up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
3de03f32d3 Simplified retrieval of credentials from authentication prompt.
Placed TabPageCredentialsDialog controls on a TableLayout panel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
518951d868 Deregister events and dispose of web clients when removing them from the list.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
23975c5ee6 Updated event signature to use Action<T1,T2> instead of custom delegates.
Moved NavigateError- and AuthenticatinPromptEventArgs classes inside WebBrowser2
as they are only relevant to the latter class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
7494a712fb Re-arranged the class members to make the file easier to navigate and minimise scrolling up/down when developing.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Mihaela Stoica
034f472163 CA-286882: Check for page visibilty before calling HidePage
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-13 17:18:53 +01:00
Mihaela Stoica
56a3725b36 Corrected the title and description of VM lifecycle operations when run as Mulltiple/Parallel actions
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-13 17:18:53 +01:00
Mihaela Stoica
8230315f76 CA-286882: Shutting down large number of VMs causes XenCenter to hang
Created a new base class for the Notifications pages (Alerts, Updates, Events). This can be used in the future to host more of the common code between these pages. For now, it implements a common mechanism for showing/hiding the page and ensures that the event handlers are deregistered when the page is hidden (i.e. when the user switches to a different view) and registered again when the page becomes visible

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-13 17:18:53 +01:00
Konstantina Chremmou
f4d92da5ee CA-202377: Removed last instance of the QueuedBackgroundWorker and deleted the class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-13 17:04:27 +01:00
Konstantina Chremmou
78ecef617d Fixed issue where the agility calculation was run even for VMs that were not
actually added (because they can't be protected, e.g. the control domains).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-13 17:04:27 +01:00
Konstantina Chremmou
649e5a3483 Do not start updating the agility before reaching the corresponding page on the HAWizard.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-13 17:04:27 +01:00
Konstantina Chremmou
a68ca3beb2 Added tooltip on the Agility cell so the user can see the reason why the VM
is not agile simply by hovering over the cell. Previously the user could see
this only if they selected the VM, expanded the restart priority dropdown
and hovered over the Restart item.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-13 17:04:27 +01:00
Kat Shann
72562ba059 Lima Help Files (#2178)
* L10n: Inverness: build_chm #24
* Revert "L10n: Inverness": This reverts commit 8b41bb8c79cd4d73ed6021a5533cf7624a5421c4.
* L10n: Inverness: CHMs from build_chm master-l10n #24 Second attempt at checkin with a merge conflict resolve. (I hope)
* L10n: Localized files with fix: Remove artifacts introduced by XTM
* Update Kolkata Help files
* Update fro broken links fix
* CP-28648: Check -in the Lima versions of the CHM files

Signed-off-by: Katherine Shann <katherine.shann@citrix.com>
2018-08-13 11:42:06 +01:00
Konstantina Chremmou
b19d2fdeec CA-104539: Don't allow the user to make a pool into a standalone server if HA is enabled
or being enabled. Although the CLI allows it, it makes sense to disallow deleting the pool
when HA is on because XenCenter does not offer enabling HA if there is no pool there.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-10 09:50:31 +01:00
Konstantina Chremmou
0827d686ba Added hotkeys to ToolStriMenuItems and ellipsis (in reality only the iscsiToolStripMenuItem
launches a dialog requiring user input, but added it to fcToolStripMenuItem
too because it looks symmetric and in any case the user does have to close
an error pop-up if the scan fails). Also, do not show "no SRs found pop-up"
if the user cancels the IscsiDeviceConfigDialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-10 09:50:31 +01:00
Ji Jiang
d0fc3be56e CA-294091: Fix two Update wizards co-exist bug
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-08-07 12:02:57 +01:00
Mihaela Stoica
61ee71dac1 CA-290536: Fix XenCenter uncaught exception in VM console when losing host connection
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-06 15:14:24 +01:00
Mihaela Stoica
b8168eed28 CA-292626: Consider the contains-livepatch flag of all the applicable… (#2165)
* CA-292626: Consider the contains-livepatch flag of all the applicable updates when doing the prechecks in the automated updates mode.

Instead of looking at the minimal patches, we look at all applicable patches for that host (i.e. all the updates on the host's version that are not already installed) and we say that the host won't need a reboot only if all these are marked as contains-livepatch.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-03 16:11:06 +01:00
timliu55
51ba3a82ce CA-293854: Patching wizard updates list loses selection and resizes c… (#2164)
* CA-293854: Patching wizard updates list loses selection and resizes columns when resorted
Remove the redundant code
Change the AutoSize mode from DisplayedCells to AllCells.
Fix the date column sorting
Disable column header AutoSizing

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-03 11:32:51 +01:00
liulinC
7be8bd0530 CA-204242: save the server status report blocks xencenter (#2158)
* CA-204242: save the server status report blocks xencenter

Signed-off-by: Lin Liu <lin.liu@citrix.com>
2018-08-03 09:08:47 +01:00
Darren Matthews
a6991596a5 L10N Bug Fixes (CA-294292 & CA-294333) (#2163)
* L10N: CA-294292 Fixed truncation issue in language files.
* L10N: CA-294333 Fixed overlapping issue in Japanese file.
* L10N: CA-294333 Fixed overlapping issue in Japanese file.

Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-02 10:13:54 +01:00
Konstantina Chremmou
3ade18250a Some layout improvements (margins, control anchoring, removal of unnecessary controls).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 13:42:48 +01:00
Konstantina Chremmou
fc88e5c5be Removed null value image from datagridview columns as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
65f67f2455 Ensure AdEnableAction is always shown in History. FindActiveAdAction can be private.
Show ellipsis on the join/leave button since it launches a dialog requirng user input.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
12fe9e9620 Store the domain and username rather than the whole AdPasswordPrompt.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
02eaac832a CA-294365: Replaced all references to pool or master except the necessary
with references to the connection; pool or master can be resolved from the
latter. This among others prevents the AD page from crashing when the master
and the pool change after master's entering maintenance mode.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
d604fc16ab Ensure subject events are deregistered every time the rows are cleared.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
d65dbeaf2e Launch action dialogs in a using block. Prevent button flickering when the gridview is repopulated.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
1d5d06c15d No need to repopulate the whole list if a subject's property has changed, refresh just this subject's row.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
21072e13fc Removed redundant code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
41c2eb71f6 Smarter icon/text selection and minor layout improvements, in particular icon alignment.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
3bd8a03699 CA-272127: Aesthetic and usability improvements in the AD users list: fixed
cell alignment; removed grid; expand/collapse on row double click and on expander
cell single click. Refactored class AdSubjectRow.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
18be622889 Made the Events page rows to expand/collapse on double click like the Alerts and Updates pages.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
timliu55
d6b18e969a CA-287610: EN: Error message "Unable to connect to iSCSI storage" is truncated
Just enable the AutoSize property like the other labels.

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-07-31 11:42:47 +01:00
Mihaela Stoica
9dc0d77ef6 CA-292626: Consider the contains-livepatch flag when doing prechecks in the automated updates mode.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-30 14:33:22 +01:00
Jisheng Xing
6cf48a9125 CA-293680: Tasks to be performed after upgrade in XC don't quite fit within the box
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-07-30 12:21:58 +01:00
timliu55
38391c943e CA-293628 Some RPU prechecks do not mention the host the precheck has… (#2156)
* CA-293628: Some RPU prechecks do not mention the host the precheck has run on
Signed-off-by: Tim Liu <tim.liu@citrix.com>

* CA-293628: Some RPU prechecks do not mention the host the precheck has run on
Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-07-30 11:06:26 +01:00
jishengx
260ec2d013 CA-284914: Prechecks are re-run every time the 'Hide successful prech… (#2088)
* CA-284914: Prechecks are re-run every time the 'Hide successful prechecks' is ticked/unticked

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix some comments
2018-07-26 16:11:53 +01:00
Mihaela Stoica
f663ababd5 CA-293857: When uploading and introducing an update, delete the VDI if the update introduce fails (regardless of the error).
Also add a sleep to try and avoid getting a VDI_IN_USE exception when deleting the VDI after the upload failed or has been cancelled by the user

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-25 13:08:04 +01:00
Mihaela Stoica
2266e89cd9 CA-294285: Make WlbRetrieveVmRecommendationsAction an AsyncAction and specify the method for the RBAC checks
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-25 10:46:23 +01:00
Konstantina Chremmou
1bcbb3d454 CA-289960: If a VM does not acknowledge the need to shut down on host reboot,
include the VM's name in the message to help the user identify it.
Also, we have more instances of "shut down" than "shutdown".

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-25 09:39:04 +01:00
Konstantina Chremmou
85b326497d CA-293664: Corrected text colour for selected item.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-25 09:39:04 +01:00