Commit Graph

6438 Commits

Author SHA1 Message Date
Konstantina Chremmou
26328477a5
Merge pull request #3018 from danilo-delbusso/task/auto-launch_CP-39818
CP-39818: Auto-launch app after installation is finalized
2022-06-14 14:24:18 +01:00
CitrixChris
ffa7f28c12
Merge pull request #3019 from xenserver/feature/REQ-622
REQ-622: Citrix Hypervisor Center quick-update mechanism
2022-06-13 14:57:15 +01:00
Danilo Del Busso
f8482e7502
CP-39818: Fix whitespace in installer localization files
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-06-09 16:04:25 +01:00
Danilo Del Busso
e4deda22b3
CP-39818: Show auto-launch option when repairing/changing the installation
New logic only hides the option when uninstalling the app

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-06-09 15:56:28 +01:00
Danilo Del Busso
a6113b26d8
CP-39818: Apply code review suggestions
- Use `BrandConsole` for the name of the app
- Use a localised value for the word `Launch`
- Use `asyncNoWait` when launching the CHC executable

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-06-09 15:55:07 +01:00
Konstantina Chremmou
cfcb45a4c5 Bumped branding and pipeline versions to 4.3 and 4.4 respectively.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-09 15:14:10 +01:00
Konstantina Chremmou
c66a23f314 CP-39952: Do not ask the user to uninstall the container management supp-pack.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-08 14:01:04 +01:00
Konstantina Chremmou
fd627e687f CP-39933: Show the names of the PV guests preventing upgrade if any are detected.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-08 14:01:04 +01:00
Danilo Del Busso
37c374155f
CP-39818: Auto-launch app after installation is finalized
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-06-06 13:00:12 +01:00
Konstantina Chremmou
1b259814bf
Merge pull request #3012 from kc284/destroyMany
CP-38687 + issue with version checking
2022-05-25 11:40:54 +01:00
Konstantina Chremmou
bca04c1b00 Improved documentation for xe.exe. Add the deprecated alongside the new check ID.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-25 11:40:36 +01:00
Konstantina Chremmou
2889b1678d Corrections as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-25 11:36:08 +01:00
Konstantina Chremmou
cc4d3d9ee7 Extended product version checker to cope with RPM versions. Use xapi_build instead of xapi for version comparisons.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-25 11:36:02 +01:00
Konstantina Chremmou
df35684586 Moved version checking methods to a separate file. Use C# naming conventions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Commands/DragDropCrossPoolMoveHaltedVMCommand.cs
#	XenAdmin/Commands/DragDropMigrateVMCommand.cs
#	XenAdmin/Wizards/CrossPoolMigrateWizard/Filters/CrossPoolMigrateCanMigrateFilter.cs
2022-05-25 11:35:47 +01:00
Konstantina Chremmou
2f30ef1e19 CP-38687: Improved the speed of deleting multiple alerts.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-25 11:29:25 +01:00
Konstantina Chremmou
afa21f16a9
Merge pull request #3011 from kc284/CA-366140
CA-366140: Reverted original solution. Handled error thrown when retrieving datasources.
2022-05-25 11:04:51 +01:00
Konstantina Chremmou
76738ad91f
Merge pull request #3003 from kc284/drag-drop-3
CA-294370: Rewrote logic calculating if migration is allowed + some other fixes.
2022-05-25 11:04:26 +01:00
Konstantina Chremmou
755cec2bc1
Merge pull request #2998 from danilo-delbusso/bug/scrollbar_CA-293683
CA-293683: Prevent automatic scrolling in RPU wizard if user has scrolled manually
2022-05-25 11:04:03 +01:00
Konstantina Chremmou
dcbbbe84e9 CA-366140: Handle and log exceptions thrown when retrieving data sources.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-19 12:12:46 +01:00
Konstantina Chremmou
20cf55c19f Revert "CA-366140: Run data source operations on VMs only if they are allowed."
This reverts commit dd56f744e8.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Actions/GUIActions/SaveDataSourceStateAction.cs
2022-05-19 11:18:52 +01:00
Konstantina Chremmou
7a930070af
Merge pull request #3006 from kc284/cli-protocol
Certificate validation for xe.exe (CP-36392) + a lot of refactoring
2022-05-19 11:10:18 +01:00
Konstantina Chremmou
74bf6f3ba5 CP-36392: Fixes to sonarqube score.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-19 11:09:46 +01:00
Konstantina Chremmou
4f7ad4f0f0 Fixed broken build and made some additional L10n corrections to the layout.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-19 11:09:39 +01:00
Konstantina Chremmou
eb0dc04381 Fixed indentation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-18 20:32:36 +01:00
Konstantina Chremmou
02f59946b9 Fixed further code smells as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-18 20:28:08 +01:00
Konstantina Chremmou
c4617240aa Corrections as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-18 20:28:08 +01:00
Konstantina Chremmou
5c632a5592 Moved Logger class to its own file. Improved the format of the logged messages.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-18 11:43:57 +01:00
Konstantina Chremmou
0cfe9c0a07 Corrections as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-18 10:54:44 +01:00
kishore Mengani
6b69496a39 L10n: Resx resync and trnslations updates
Signed-off-by: kishore Mengani <kishore.mengani@citrix.com>
2022-05-17 10:51:10 +01:00
Danilo Del Busso
4f09efe475
CA-293683: Prevent automatic scrolling when setting text in SmartScrollTextBox
Also fix issue whereby `IsVerticalScrollBarAtBottom` would also return `True`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-05-16 15:33:52 +01:00
Konstantina Chremmou
0e3e81d118 Fixed broken tests.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-16 15:13:20 +01:00
Konstantina Chremmou
8af0184030 Replaced dismiss button with release notes button. Show the application name in the update button.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-16 14:08:02 +01:00
Danilo Del Busso
6b200bef8b
Reorder fields in AutomatedUpdatesBasePage.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-05-12 13:36:13 +01:00
Danilo Del Busso
f2a67243a7
Apply code cleanup to AutomatedUpdatesBasePage.cs
Use `var` where possible
Rename fields and methods following conventions
Use pattern matching when casting
Rename variables using more meaningful names

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-05-12 13:34:58 +01:00
Danilo Del Busso
27382f308b
CA-293683: Prevent automatic scrolling in RPU wizard if user has scrolled manually
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-05-12 13:06:04 +01:00
Konstantina Chremmou
dd0c5d4891 CP-36392: Implemented server certificate validation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-10 21:44:29 +01:00
Konstantina Chremmou
a02dfbb07e Reworked error handling. Prevent from showing duplicate output of commands in debug mode.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-10 20:47:27 +01:00
Konstantina Chremmou
90097ece49 Use C# naming conventions for properties. Also, do not provide default username.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-10 19:32:44 +01:00
Konstantina Chremmou
76e0b098b2 Removed undocumented argument "server". Added explicit help switch.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-10 19:24:21 +01:00
Danilo Del Busso
140bb501af Point URL in CHCUpdates.xml to MSI location
Previously, the URL would point to the XML itself, causing checksum check errors

Also fixes issue whereby building non-branded builds would fail

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-05-10 12:24:00 +01:00
CitrixChris
1d003da4c7
CP-39720: Enable auth tokens (#3002)
* CP-39720 adds a auth token to updates.xml download and chc.msi download if it exists in the registry keys

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 adds definition of GetInternalStageAuthToken() to XenServerHealthCheckConfigProvider.cs

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 updates token name to be more consistent

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 updates token name in missed request

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 reads token name from registry

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-05-10 12:22:28 +01:00
Konstantina Chremmou
48f7ffe0d6 Removed unimplemented switch --nossl.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 15:21:54 +01:00
Konstantina Chremmou
d23c7f2de6 Removed class ThinCliProtocol. Class Config suffices.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 15:21:54 +01:00
Konstantina Chremmou
fc13c1e060 Turned magic string into a constant in the Messages class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 15:21:54 +01:00
Konstantina Chremmou
2bc75656cf Show the executable's version when using -version. Updated version check during handshake.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 15:21:54 +01:00
Konstantina Chremmou
d662af4f8e Removed field thinCliProtocol.dropOut as it was always false.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 15:21:54 +01:00
Konstantina Chremmou
aff3d2ad97 Removed code redundancies. Use C# naming conventions for method, classes and enums.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 15:21:54 +01:00
Konstantina Chremmou
a1a577fa22 Removed field thinCliProtocol.dProgress because it was not implemented.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 15:21:54 +01:00
Konstantina Chremmou
c226316632 Replaced field thinCliProtocol.dExit with direct call to Environment.Exit().
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 15:21:54 +01:00
Konstantina Chremmou
b343a97b72 Replaced field thinCliProtocol.dConsoleReadLine with direct call to Console.ReadLine().
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 15:21:54 +01:00