Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-12-23 08:56:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
5,010 Commits 12 Branches 48 Tags 186 MiB
2c07869599
Commit Graph

5010 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Konstantina Chremmou
2c07869599 CA-292363: Do not show the DownloadAndUnzipXenServerPatchAction in action history. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-26 22:15:11 +01:00
Konstantina Chremmou
d3f761b070 Reworked the logging for the plan actions. (#2109) 
* Deprecate set but unused Status property in favour of ProgressDescription.
* Deprecate set but unused TitlePlan property.
* Deprecated property Title in favour of ProgressDescription.
* Removed unused plan RebootHostPlanAction.
* Updated event declaration.
* Removed property Visible. The plan is to have the actions log their history as soon as some is available.
* Reworked the logging for the plan actions. The main change is the replacement of
the ProgressDescription with a stack where all the steps of an action are stored,
i.e. the action is responsible for its history, not the worker running it.
* Lock the progress history before accessing it.
* Better handling of error logging and user cancellation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-26 14:04:51 +01:00
Ji Jiang
41e358a8fa CP-28583: Remove host-level selection in Update wizard 
1) Always pool level selection of hosts, except uploading sup pack file
from disk.
2) Revert homogeneity precheck change recently. It won't happen in new version
update any more.
3) User can never update slaves to a higher version than master, so delete
master_version_not_compatible_problem.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-26 12:45:59 +01:00
Mihaela Stoica
1bd439a2af CP-28279: Corrections to the plan actions 
- In the RPU case, re-enable the host after the upgrade is done, as the host will be put back into maintenance mode when needed during the update process.
- The VMs should not be repatriated during the RPU
- When a host is rebooted, it needs to be disabled first (even if an evacuation is not needed), otherwise the reboot won't happen

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 17:12:39 +01:00
Mihaela Stoica
2023f93199 CP-28279:When installing the updates in the RPU wizard, we need to get the minimal patches for the first upgraded host (usualy the master), not for the whole pool, because the pool is of mixed versions at this stage. 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
03b5e9a0c4 Moved logic for calculating the progress increment into the UpdateProgressBackgroundWorker. 
Renamed HostPlanActions class to HostPlan to avoid confusion with the HostPlanAction class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
37d9bc4b3b Moved all the code for the manual upgrade into the UpgradeManualHostPlanAction and removed the IsManual property. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
09de5fbcd6 Code repetition. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
73fd7df880 Use existing extension method to retrieve the host's running VMs. Removed field 
Dialogs needed only by test code; use existing wrappers of Windows APIs instead.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
50b78ddd83 Moved NonModalThreeButtonDialog out of the RpuUpgradePage because it is pretty generic and can be reused. 
Removed unnecessary null check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-25 11:31:18 +01:00
Mihaela Stoica
0d3c475439 CP-28279: Fix the AutoScaleMode 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Mihaela Stoica
e8d2b9e493 CP-28279: Use different messages for RPU (for reporting success or failure) 
- Also corrected the function that creates the update plan action in RPU: when running a retry, these actions shouldn't be regenerated.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Mihaela Stoica
7ed8a2ba44 CP-28279: Add updates installations to the RPU wizard 
- Some methods have been moved/added to the base class to facilitate the calculation of the plan actions in the RPU case.
- Also fixed the calculation of the progress bar value.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Mihaela Stoica
a99ae50f57 CP-28279: Change the upgrade page of the RPU wizard to inherit from the class AutomatedUpdatesBasePage 
- Methods have been added to the base class to deal with the manual upgrade mode

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Mihaela Stoica
3201ed3329 CP-28279: Fix the layout of the AutomatedUpdatesBasePage 
(by putting everything on a TableLayoutPanel)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-25 11:31:18 +01:00
Konstantina Chremmou
97a60c91da Since the reason why a VM already involved in an operation in progress cannot be migrated is known, display it, otherwise the user may wonder unnecessarily what the problem is. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-22 17:40:53 +01:00
Konstantina Chremmou
e7683fcf0b CP-28492: Evacuate the VMs before the first reboot and repatriate them after the last one. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-22 17:40:53 +01:00
Konstantina Chremmou
cfb1c0f4d7 CA-291402: Do not display a plan action before it is actually running; this prevents skipped actions from being displayed. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-22 17:40:53 +01:00
Konstantina Chremmou
907e991745 Renamed file to match class name. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-22 17:40:53 +01:00
Ji Jiang
6d070d3cfc CP-28425: Add automated updates license precheck in RPU wizard 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-22 17:20:11 +01:00
Ji Jiang
ccf6f97732 CP-28280: Add CFU availability precheck to RPU wizard comments fix 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-22 12:02:19 +01:00
Ji Jiang
9ae8340913 CP-28280: Add CFU availability precheck to RPU wizard 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-22 12:02:19 +01:00
Mihaela Stoica
3c300accce CP-28279: Make the base AutomatedUpdatesBasePage class abstract 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-20 11:15:35 +01:00
Mihaela Stoica
73f6ebdf5c CP-28279: Add a base class for Automated Updates (this will be later used for the RPU as well) 
The base class contains all the code for creating and starting the background workers, displaying the progress of the actions, handling failures and retries.
The derived classes override the property for label at the top of the page and the method that generates the plan actions.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-20 11:15:35 +01:00
Joey
507bf01083
Merge pull request #2101 from kc284/REQ-672 
The check for hosts that are unlicensed for automated updates should …
 2018-06-20 10:21:55 +01:00
Konstantina Chremmou
6513abc09e The check for hosts that are unlicensed for automated updates should be on all pool hosts as there maybe individual restrictions (for example via a feature flag). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-19 17:20:08 +01:00
Mihaela Stoica
da9e5a5cab CP-28284: Implement IEquatable in PlanAction 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Mihaela Stoica
59b9b695db CP-28284: Changes following code review 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Mihaela Stoica
631d7656a2 CP-28284: Corrections 
- ensure that an action is only added once to the DoneActions and InProgressActions
- reset the wizard buttons (Cancel, Finish) when a retry is started

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Mihaela Stoica
920da093e0 CP-28284: Only show the error icon and text when all the workers have finished 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Mihaela Stoica
eca6081f48 CP-28284: Show the plan actions indented under the pool name 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Mihaela Stoica
7fa9d0b94f CP-28284: Updates wizard: Add a "pause and resume" mechanism to handle failures 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-19 13:34:37 +01:00
Mihaela Stoica
da2c96ad1c CP-28426: RPU wizard: add user option for automatically applying updates - changes following code review 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-18 16:28:28 +01:00
Mihaela Stoica
dd19f3a0b7 CP-28426: RPU wizard: add user option for automatically applying updates 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-18 16:28:28 +01:00
Joey
abe97def1e CP-28286: Support resume from a partially upgraded pool via Update wi… (#2095) 
* CP-28286: Support resume from a partially upgraded pool via Update wizard

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>

* CP-28286: Fix comments of the previous commit

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-18 10:46:41 +01:00
Joey
cf9e05059c
Merge pull request #2096 from MihaelaStoica/CP-28282 
CP-28282: Update the disk space precheck to calculate the required space according to the new workflow
 2018-06-15 16:24:53 +01:00
Mihaela Stoica
93a154e04f CP-28282: Unit tests fix + improved message 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-15 16:05:37 +01:00
Mihaela Stoica
121bce92af CP-28282: Correction to the required disk space calculation 
- also renamed a variable and updated the problem description to include the server name

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-15 14:24:29 +01:00
Mihaela Stoica
e8ab24820d CP-28282: Fix the bug where the action fails with InvalidOperationException if there is no available SR for upload 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-14 16:39:43 +01:00
Mihaela Stoica
c702399d95 CP-28282: Update the disk space precheck to calculate the required space according to the new workflow (apply all hotfixes to a host before moving to the next one) 
- this commit covers the post-Ely case, where updates are uploaded to storage repositories

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-13 17:24:33 +01:00
Mihaela Stoica
2efc1b8685 CP-28282: Update the disk space precheck to calculate the required space according to the new workflow (apply all hotfixes to a host before moving to the next one) 
- this commit covers the pre-Ely case, where patches are uploaded to the server

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-13 17:23:17 +01:00
Mihaela Stoica
318f20f65f CP-28282: Preliminary work: move the disk space calculation inside the precheck 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2018-06-13 17:22:52 +01:00
Mihaela Stoica
8fff0b2b10
Merge pull request #2093 from kc284/REQ-672 
Separate displayed update information per pool. Minor layout corrections and removal of unused LinkLabel.
 2018-06-08 16:54:11 +01:00
Konstantina Chremmou
49823f9dd9 Do not show the successful completion message before the update is actually completed. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-08 16:41:06 +01:00
Konstantina Chremmou
73e7b66fa4 Do not change the page top blurb depending on the process outcome. Improved error messages. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-08 16:15:55 +01:00
Konstantina Chremmou
2e2ae7c196 Separate displayed update information per pool. Minor layout corrections and removal of unused LinkLabel. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-08 13:42:06 +01:00
Mihaela Stoica
15edb13997
Merge pull request #2089 from kc284/REQ-672 
First batch of changes for CP-28281
 2018-06-08 11:32:26 +01:00
Ji Jiang
88224df214 CA-290316: Skip hotfix homogeneity precheck in mixed pool 
Because we couldn't control user's selected combination from
a mixed pool, and the version compatibility precheck exists already,
here just simply skip the precheck and issue a warning.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2018-06-08 11:17:41 +01:00
Konstantina Chremmou
11a9785dba Log the patch clean-up actions on the screen in case of a failure. Order the shown actions per pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 16:34:13 +01:00
Konstantina Chremmou
1b4a862fd0 Further corrections to the load/leave page workflow and object selection ensuring correct enablement of the Next button. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2018-06-07 12:27:57 +01:00