Commit Graph

5864 Commits

Author SHA1 Message Date
Konstantina Chremmou
2e66ec9133 Merge remote-tracking branch 'upstream/master' into feature/REQ-819
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/OptionsPages/SecurityOptionsPage.cs
2020-08-11 13:35:39 +01:00
Konstantina Chremmou
c244d8d4db CA-339584: Include CD VDI in the storage mapping for intra-pool migration
Also: removed unused method; some property modernisation; removed class
LiveMigrateOptionsVmMapping which was rather complicating things.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-08-11 08:46:42 +01:00
Konstantina Chremmou
e0864cd99c CA-342526: Ensure the update list has been populated and the specified update has been selected before stepping into the next page.
Also, reduced visibility of the methods moving between wizard pages to avoid
creating complex situations.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-31 10:54:49 +01:00
Konstantina Chremmou
a076cc59a2
Dialog deletion (#2701)
* Replaced LicenseWarningDialog with a simple WarningDialog.
* Replaced VcpuWarningDialog with a simple WarningDialog.
* Replaced RemoveCrashdumpsWarningDialog with a simple WarningDialog.
* Replaced UsbUsageDialog with a simple WarningDialog.
* Replaced WlbDeleteReportSubscriptionDialog with a simple WarningDialog. Added null checks to event invocation.
* Replaced DisableWlbDialog with a simple Warning dialog.
* Replaced ConnectionRefusedDialog with a simple Error dialog.
* Replaced UserDeviceDialog with a simple Warning dialog.
* Replaced RevertDialog with a simple Warning dialog.
* Removed unused dialogs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 11:29:01 +01:00
Konstantina Chremmou
a66a82878e The ConnectionOptionsPage should not access private controls of its parent but rather communicate its valid state via an event.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 11:27:29 +01:00
Konstantina Chremmou
ca3e9c0219 Removed unused SaveSessionCommand and consequently refactored SaveAndRestoreDialog constructor.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 11:27:29 +01:00
Konstantina Chremmou
65ea154b9d Moved the code that logs settings to the Settings static class.
Although it may look tidy to log the settings in the OptionsDialogPages that
expose them to the user, in reality it makes for unnecessarily complicated code
design as it places business logic in UI code and mixes the class dependencies.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 11:27:29 +01:00
Konstantina Chremmou
82bb06dba3 Unit tests for filtering VMs by virtualisation state.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 10:42:20 +01:00
Konstantina Chremmou
8fb44a55cb Added flag VM.VirtualisationStatus.NOT_INSTALLED to replace value 0 for clarity.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 10:42:20 +01:00
Konstantina Chremmou
2755f71dcf CA-341423: Added a new filter value for VMs with only the management agent installed so they can be easier to find.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 10:42:20 +01:00
Konstantina Chremmou
e30ea433c7 Refactoring to simplify the code and make calculations more efficient:
Removed unnecessary abstractions. Replaced named delegates with anonymous ones.
Use pattern matching and avoid multiple casts. Be consistent in the properties
we check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 10:42:20 +01:00
Konstantina Chremmou
5526a3f7d1 CP-34045: Removed max resolution and max displays columns.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-28 10:01:09 +01:00
Aaron Robson
ec6ef00d39 ignore 'vim.exe.stackdump' 2020-07-27 22:45:32 +01:00
Aaron Robson
05c8809539 CP-34000: decimal network and disk access rate unit calculations
Though this was shown in units like kB/s and MB/s (decimal units) it was calculated in
binary terms i.e. 1MB/s was treated as 1024kB/s instead of the expected 1000kB/s.

Updated translations for the units to be of the form 'MB/s' instead of 'MBps'.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2020-07-18 07:55:34 +01:00
Konstantina Chremmou
5f7d3e1518 Homogeneous icon usage across the application.
- Replaced remaining instances of SystemIcons. SystemIcons.Information of size
  32x32 were excepted as we don't have the right size icon yet.
- The question mark icon is used for help, not for asking questions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-18 07:49:27 +01:00
Konstantina Chremmou
8a6a579402 CP-20425: Use static images everywhere an image is assigned programmatically.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-18 07:49:27 +01:00
Konstantina Chremmou
d08f02cce2 CP-20425: Added test to ensure all Resource images have a static counterpart.
Also, stop boxing Bitmap into Image so as to avoid casting wherever it is called.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-18 07:49:27 +01:00
Konstantina Chremmou
ea4175e75c CP-20425: Use the SpinnerIcon instead of a new spinner implementation which does not use the static images.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-18 07:49:27 +01:00
Konstantina Chremmou
e27a0a7333 Minor refactoring on UpsellPage:
- Modernised properties.
- Removed unnecessary public method; it was rather obfuscating setting properties.
- Made Image property non-browsable.
- Missing null check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-18 07:49:27 +01:00
Konstantina Chremmou
9d7cf72c78 CP-33781: Added admin exit procedure warnings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-17 16:04:10 +01:00
Konstantina Chremmou
5c1a982659 CP-33771: Added an item to the pool menu for triggering a secret rotation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-17 16:04:10 +01:00
Konstantina Chremmou
ce033019e1 CP-34109: Move non-open source build tasks to an internal pipeline.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-14 11:39:25 +01:00
Konstantina Chremmou
a2596ec201
Merge pull request #2711 from xenserver/dotnet48
Merge branch dotnet48 into master
2020-07-07 12:10:46 +01:00
Konstantina Chremmou
e42bc54be4 CA-187276: Re-enable "Open SSH Console" button after VM restart
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-07 09:25:54 +01:00
Konstantina Chremmou
6b168f0e6e CA-341778: Missing entries from distros treated as Linux.
Also, moved the list to the VM class so it can be kept up to date when new guests are added.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-07 09:24:55 +01:00
Konstantina Chremmou
6bf1f7c23c Fixed broken tests and corrected assertion handling in the Jenkinsfile.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-02 09:27:26 +01:00
Konstantina Chremmou
0199e1e73e Latest SDK.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-29 12:41:24 +01:00
Konstantina Chremmou
f3c5e74dae CP-33892: Audited the use of First() and replaced with FirstOrDefault() where appropriate.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-25 11:17:11 +01:00
Konstantina Chremmou
c14184919d Extended disk latency regex and added unit tests.
Also made a small addition to a past test as per code review.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-23 08:51:41 +01:00
Konstantina Chremmou
50f4b3dd9d Last bit of CA-239885: Upgrade the Moq.dll version.
Note this is not the latest as post-4.5.3 versions introduce other package
dependencies. So far 4.5.3 covers our needs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-23 08:51:41 +01:00
Konstantina Chremmou
d2ded59b7a CA-341576: Corrected title and button text.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-22 11:46:02 +01:00
Konstantina Chremmou
db041099ef CA-339271: Improved action description. Also:
Added cancelling ability to MoveVM action; made some simplifications.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-19 14:04:59 +01:00
Talons Lee
b09d3cb8e7 CP-33715: add gooroom os icon
Signed-off-by: Talons Lee <xin.li@citrix.com>
2020-06-15 22:37:50 +01:00
Konstantina Chremmou
d045d180a0
Merge pull request #2696 from xenserver/master
Bring branch dotnet48 up to date with master
2020-06-15 15:43:52 +01:00
Konstantina Chremmou
7a90d4e4f1 Sign localised resource dlls.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-12 09:11:46 +01:00
Darren Matthews
cef05ab005 L10N : Resx Resync and translation update. Fixed Confirmation Options page with the Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-06-11 13:57:12 +01:00
Darren Matthews
00b6fdc8e3 L10N: Translation and Resx Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-06-11 13:57:12 +01:00
Konstantina Chremmou
acd3094b48 CA-314005: Proceed to setting the memory if the issued shutdown has been interrupted by a different shutdown task.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-10 23:48:54 +01:00
Konstantina Chremmou
ebe0257af1 CA-339648: Refresh user row when the other_config changes so as to show up to date account details.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-05 16:58:19 +01:00
Konstantina Chremmou
c9449b9914 CP-33153: Added friendly title and description for GFS2_CAPACITY alert. Corrected scan action description.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-05 11:50:49 +01:00
Konstantina Chremmou
d54df5efe2 CA-338784: Limit XE client to GET the same file with the initial command line.
CA-338766: Get the fullpath from the input params values.

Signed-off-by: Min Li <min.li1@citrix.com>
2020-06-05 11:50:27 +01:00
Konstantina Chremmou
89487fcf60 CA-337270: Perform authentication on a background thread.
- Added controls to display the error in case authentication fails.
- Use the same control(LinkLabel) to show the rubric either when new
  authentication is needed or an existing one can be used.
- Moved privacy policy statement next to the checkbox because it looked crammed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-05 11:48:54 +01:00
Konstantina Chremmou
ec7fc14c18 Typo.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-05 11:48:54 +01:00
Konstantina Chremmou
9ec3dc3127 CA-339374: Changed order of control disposal. Also, fixed wrong title of the undocked console.
Disposing the vncTabView disconnects the RdpClient and should not be called after
base.Dispose() is called on VNCView, because the latter has released the COM objects
and causes an InvalidComObjectException to be thrown.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-01 11:10:54 +01:00
Konstantina Chremmou
797605d2e7 CA-339526: Updated API bindings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-29 14:53:54 +01:00
Konstantina Chremmou
cae3796887 CA-339526: Ignore classes that are present in the database but not exposed in the SDK.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-29 14:53:54 +01:00
Konstantina Chremmou
ffcc069aa1 CA-339526: New API bindings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-28 18:02:42 +01:00
Konstantina Chremmou
9087755277 Test corrections.
- Exclude VNC key map from l10n tests.
- Added parameterless constructors to the archive classes for use by the tests.
- Scalability tests were removed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-26 23:31:06 +01:00
Konstantina Chremmou
e4e25f30fc CP-32921: Use the full path for the MSBuild executable. Temporary new location for the third party libraries.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-25 23:03:02 +01:00
Konstantina Chremmou
4f4217a2b1 CA-339685: Corrected calculation of completion percentage and added checks for division by zero.
Also, some simplifications and removal of unused variables and fields.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-22 00:25:56 +01:00