Also: removed unused method; some property modernisation; removed class
LiveMigrateOptionsVmMapping which was rather complicating things.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, reduced visibility of the methods moving between wizard pages to avoid
creating complex situations.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Replaced LicenseWarningDialog with a simple WarningDialog.
* Replaced VcpuWarningDialog with a simple WarningDialog.
* Replaced RemoveCrashdumpsWarningDialog with a simple WarningDialog.
* Replaced UsbUsageDialog with a simple WarningDialog.
* Replaced WlbDeleteReportSubscriptionDialog with a simple WarningDialog. Added null checks to event invocation.
* Replaced DisableWlbDialog with a simple Warning dialog.
* Replaced ConnectionRefusedDialog with a simple Error dialog.
* Replaced UserDeviceDialog with a simple Warning dialog.
* Replaced RevertDialog with a simple Warning dialog.
* Removed unused dialogs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Although it may look tidy to log the settings in the OptionsDialogPages that
expose them to the user, in reality it makes for unnecessarily complicated code
design as it places business logic in UI code and mixes the class dependencies.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Removed unnecessary abstractions. Replaced named delegates with anonymous ones.
Use pattern matching and avoid multiple casts. Be consistent in the properties
we check.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Though this was shown in units like kB/s and MB/s (decimal units) it was calculated in
binary terms i.e. 1MB/s was treated as 1024kB/s instead of the expected 1000kB/s.
Updated translations for the units to be of the form 'MB/s' instead of 'MBps'.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
- Replaced remaining instances of SystemIcons. SystemIcons.Information of size
32x32 were excepted as we don't have the right size icon yet.
- The question mark icon is used for help, not for asking questions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, stop boxing Bitmap into Image so as to avoid casting wherever it is called.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, moved the list to the VM class so it can be kept up to date when new guests are added.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Note this is not the latest as post-4.5.3 versions introduce other package
dependencies. So far 4.5.3 covers our needs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Added controls to display the error in case authentication fails.
- Use the same control(LinkLabel) to show the rubric either when new
authentication is needed or an existing one can be used.
- Moved privacy policy statement next to the checkbox because it looked crammed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Disposing the vncTabView disconnects the RdpClient and should not be called after
base.Dispose() is called on VNCView, because the latter has released the COM objects
and causes an InvalidComObjectException to be thrown.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Exclude VNC key map from l10n tests.
- Added parameterless constructors to the archive classes for use by the tests.
- Scalability tests were removed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>