Commit Graph

6325 Commits

Author SHA1 Message Date
Konstantina Chremmou
3858320cc4
CA-366115 & CA-366116: Quick Update Feature - FQP Bug fixes (#2988)
* CA-366115: Release the installer when cancelling the installation because of pending tasks.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* CA-366116: Use always the same filename for the temporary downloaded installer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Allow to cancel while retrying to download the installer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-12 12:09:44 +01:00
CitrixChris
5b0b27eca1
CP-39382: Lock msi file while verifying and launching install process (#2973)
* CP-39382 adds lock around msi file while being verified and launched. Improves naming of variables in line with conventions.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-39382 removes unnessessary usings, fixes background tasks running check. Tidies up structure.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* Further modifications.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* CP-39382 adds back in messages lost in merge conflict resolution

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-11 10:11:33 +01:00
Konstantina Chremmou
4656114963
Merge pull request #2981 from kc284/feature/REQ-622
Merged master into feature/REQ-622
2022-04-01 16:01:10 +01:00
Konstantina Chremmou
5920691ea4 Merge branch 'master' into feature/REQ-622
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	Jenkinsfile
#	XenAdmin/Commands/DisconnectCommand.cs
#	XenAdmin/MainWindow.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
2022-03-30 15:17:13 +01:00
Konstantina Chremmou
f5075e8eac Sorted string prior to merging from master (where there are sorted).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-30 15:00:27 +01:00
Danilo Del Busso
893f42d831 CP-39114: Add CHCUpdates.xml and dev-CHCUpdates.xml generation to build script
dev-CHCUpdates.xml contains a placeholder value for the destination URL
- Add existence check for `pdb` files in build script
 This prevents script from stopping if MSBuild didn't generate any `pdb` files in `packages`
- Insert placeholders for pipeline and branding in Jenkinsfile
- Remove existence check for package `pdb`s in build script
 Also simplify MSI checksum extraction from `sha356sum` call

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-03-30 13:59:17 +01:00
Danilo Del Busso
ccf7fbe01a CP-39128: Make UPDATES_URL a branded string
- Add VS Enterprise as option for building project
 Also add to `re-branding.sh` replacement list
- Bump branding version to v4.3
- Add default `UPDATES_URL` to `branding.sh`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-03-30 13:59:17 +01:00
CitrixChris
e951aa5268
Changes the confimation dialog to one that actually shows background … (#2959)
* Changes the confimation dialog to one that actually shows background tasks

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Removes unused messages

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Seperates Download and Install Logic so background task checker only happens after msi is downloaded

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Allows download to be canceled

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Some corrections.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-28 15:25:32 +01:00
Konstantina Chremmou
f5672a8645 CP-39323: Check for DMC in use prior to cross-pool migration to pools where DMC is unavailable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:10:51 +00:00
Konstantina Chremmou
dd978914cf CA-365297: Fixed error shown when attempting live migration of DMC VM to non-DMC host.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:10:51 +00:00
Konstantina Chremmou
2110607cc1 CA-365143: Correction when changing a VM's memory settings:
- Corrected the logic deducing whether shutting down and restart is needed.
- Fixed crash when starting a VM without a home host.
- Also, renamed some fields for better compliance with C# naming conventions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:10:40 +00:00
Konstantina Chremmou
220ab25302 CA-365317: Updated warnings after disallowing connection to pre-yangtze servers.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:10:25 +00:00
Konstantina Chremmou
3453e84a0f CA-365223: PVS accelerator is now part of the main install.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:33:03 +00:00
Konstantina Chremmou
ab676786b1 CP-39366: Disallow connection to servers earlier than yangtze.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:32:48 +00:00
Konstantina Chremmou
713bec52ce CA-365082: Do not run the PrepareToUpgradeCheck before the necessary RPU hotfix has been applied.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:32:29 +00:00
Konstantina Chremmou
25760b2bc6 CP-38814: Minor message improvement.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:32:11 +00:00
Konstantina Chremmou
eb58973497 Fixed crash when retrieving pool info from DR metadata.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:31:48 +00:00
Konstantina Chremmou
545d85d433 CA-364273: Do not log out the current user if they cancel the operation from the elevated session dialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:31:31 +00:00
CitrixChris
f0f0de0076
CA-364330 wraps cyptoexception in try catch to show appropriate message (#2968)
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-03-10 14:16:13 +00:00
Konstantina Chremmou
00c5285411 CP-39142: Add RPU pre-check in CHCenter to warn of DMC removal.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:36:06 +00:00
Konstantina Chremmou
dec2eead15 Renamed methods so they describe better what they do.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:36:06 +00:00
Konstantina Chremmou
b2dc968ab1 CP-38895: Check version annotations when using API fields or methods.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:35:45 +00:00
Darren Matthews
151841ce5e L10N : Translation Updates & Resx sync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2022-03-03 14:35:30 +00:00
Danilo Del Busso
101d6f0a00 CP-36392: Use value in empty setters
Mostly to remove warning from SonarQube, so exception is only thrown in DEBUG mode

Address code surrounding previously emptied setters
Avoids throwing exceptions when not needed
Move default `VerticalTabs` fields outside of constructor

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-24 11:53:44 +00:00
Danilo Del Busso
2c5373323c CP-36392: Inherit IDisposable to avoid confusion
Classes didn't extend IDisposable
Also used null propagation to tidy up method body

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-24 11:53:44 +00:00
Danilo Del Busso
a310fa60cf CP-36392: Remove all unnecessary using s
Ignores XenAPI

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-24 11:53:44 +00:00
Darren Matthews
c7c60849b3 L10N : Resx Sync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2022-02-24 11:53:31 +00:00
Konstantina Chremmou
d0944cf19c A new row should be added only when it is not found.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-23 12:38:02 +00:00
Konstantina Chremmou
a342adc859 CA-364152: Do not calculate completed percentage if there are no actions to run.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-23 12:38:02 +00:00
Konstantina Chremmou
ff76729940 Hide the client update button by default. Added null check.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-21 15:56:06 +00:00
Danilo Del Busso
a578b6924c CA-361078: Parse OVFs without a Limit element in the vCPUs section
VMWare OVFs don't export the value

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-18 10:28:38 +00:00
CitrixChris
59e45f40c6
Update alert test fixes (#2953)
* CP-31587 made checksum comparison case insensitive as well as culture insensative

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Fixes not null assertion

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* Merges internal classes to be in same file

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
2022-02-18 10:24:33 +00:00
Konstantina Chremmou
8493ee5e90 CA-363819: Fixed issue where VM network usage data were not shown on the Search TabPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:57 +00:00
Konstantina Chremmou
29189873a3 CA-363610: OVF import: fixed upload of OS fixup ISO.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:57 +00:00
Konstantina Chremmou
493ed4cabe CP-38526/XSI-1055: Improved import performance for OVF/OVA packages with .vhd disks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:57 +00:00
Konstantina Chremmou
df6f1ba65b CP-38832: Bumped branding library version to v4.2.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 13:17:49 +00:00
Konstantina Chremmou
99452959c3 Further tweaks as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 12:52:30 +00:00
Konstantina Chremmou
b050adaeaa Some corrections and tidy up.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
0d9a204661 CP-31587 moves validate msi exception messages to messages.resx. Sets update client button to hidden on launch.
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
5845bab13f CP-31587 Implements reviewer's comments.
Moves dialog strings to messages.resx. Corrects button colours, hides update client option to avoid highlighting when disabled. Revmoves unessessary comments.

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
d8b1d5737d CP-31587 added comfirmation dialog to manageupdates page
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
755411a970 CP-31587 implements confirmation check before updating client
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
75f9b402ec CP-31587 added a checksum check to download and install client action
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
c1c8c3d1c3 Adds updates check started/completed event handlers
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
0a0533a59f CP-31587 improved DownloadAnUpdateClientAction
Made variables more accurate, removed unnessessary code

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Christophe25
aa59e8f475 CP-31587 Created new download and install action that downloads the file from updates.xml url and stores in in temp folder with progress dialog
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
2022-02-17 12:52:30 +00:00
Konstantina Chremmou
edfcf036d2 CP-38832: Try again bumping xencenter-pipeline to v4.3.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-14 14:35:59 +00:00
Konstantina Chremmou
7771471522 Use Write-Host when we just want to log output on the console.
Write-Output passes data further down the pipeline.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-14 14:35:59 +00:00
Konstantina Chremmou
ca37331c8d CA-362709, CA-362711: Reworked the logic for allowing full disk copy when creating a VM from a snapshot or custom template.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-14 14:35:51 +00:00
Konstantina Chremmou
9af52bdcbf CP-39053: Bumped branding library version to v4.1.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-09 11:25:50 +00:00