Commit Graph

5584 Commits

Author SHA1 Message Date
Ji Jiang
6a421173cc CP-29276: Implement update/supp pack application in RPU wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-10-08 12:32:01 +01:00
Ji Jiang
539d1850d0 CA-298913 + CA-297215: Fix KeyNotFoundException
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-10-08 11:12:50 +01:00
Konstantina Chremmou
2c328c086d Homogenised error handling in Invoke functions.
Renamed method IsExiting to IsInvokable to better describe its contents.
Added null check in it (previously only one of the four Invoke methods was
checking for null).
Added null check when we set the TestExceptionString in automated test mode.
Added logging to exception handling.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
e2d828a33b Removed some redundant code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
9236bbc0e3 CA-298592: Check the licenseStatus is not null when accessing its properties.
There can be cases when we have logged in a session, events are fired
causing the tab pages to be refreshed, however we may abort the connection,
for example, due to brand mismatch. In this case the licenseStatus has not
been initialized, however the refreshing general tab tries to access its
properties resulting to a crash.
Also some method tidy up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
365889a018 Compacted overload of method EndConnect.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
c3fcffa236 When we end the connection call OnConnectionClosed instead of OnConnectionStateChanged.
This avoids firing the ConnectionClosed event explicitly after EndConnect;
it also avoids refreshing explicitly the tree as the main Window handles the
ConnectionClosed event which requests a refresh.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
be0176afe0 When the connection is refused, create the failed action before showing the
pop-up, otherwise the UX is slightly strange if the failure appears on the
status bar only after the user has closed the pop-up.
Also, improved failure message shown on the History page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
7e6f0bb10c Removed explicit call of UpdateToolbars immediately after the first RequestRefreshTreeView.
Due to the delay interval between refreshes, this UpdateTolbars was called
before any root nodes were added to the tree, hence the only new tab to
add was Search, which got selected  (previously this did not happen,
because it was taken for granted that the root node was added by the constructor).
Immediately afterwards the treeview was refreshed, the root node was selected and the
home page was added, but the selected Search tab was erroneously preserved.
Also removed extra RequestRefreshTreeView because the tree will be refreshed,
if required, by the handlers of the connection events.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
968701cf8e Removed property MenuShortcuts in favour of MenuShortcutsEnabled.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
edea57ebf3 Simplified the logic updating the TabPages.
- The new logic of adding/removing tabs in the ChangeToNewTabs method also fixes
  tab-title flickering when we move from the Home node to a disconnected host.
- Renamed enum members Tab.Overview to Tab.Search and Tab.Settings to Tab.General
  since the pages mapped to them are TabPageSearch and TabPageGeneral respectively.
- Do not call directly UpdateToolbarsCore but rather UpdateToolbars since the
  latter takes account of the queued requested updates.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
b267007bdc Unused code removal; designer tidy up.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
194cd18ea3 Do not construct certain members if we are in Visual Studio's designer mode
because they crash the designer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
fb40cb7a5a Hide properties which should not be serialised by the Visual Studio designer.
Minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
fa1cf41d5b No need to add nodes to the treeview in the constructor (which also means at design time);
PersistExpandNodes should not take for granted that the treeview always has nodes.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Ji Jiang
c31778c3fe CA-298913 CA-297215: Fix restartHost and restartXapi bugs after patching
With this change, following are working:
1) After applying XS75E003-5 only restart host, no restart toolstack
2) After applying vGPU driver on 7.4, restart host happens

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-10-05 15:45:05 +01:00
Konstantina Chremmou
a7c628b9ae Fixed issues with showing the correct licence for a host/pool on the main window and general tab.
- When the host/pool was disconnected or when changing selection from connected to disconnected pool
the header was not updated with the new licence status.
- If the pool hosts' edition is none of the known editions, show unknown, not free.
- Tidy up: moved the Pool.LicenseString method to Helpers.GetFriendlyLicenseName.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-05 15:16:12 +01:00
Mihaela Stoica
02075486ba
Merge pull request #2237 from xenserver/feature/REQ-488
Merge branch feature/REQ-488 into master
2018-10-05 09:41:21 +01:00
Aaron Robson
a6d1ad9bfa CA-297666: Wait for host to become enabled before resuming a VM in the patching wizard. (#2233)
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-04 13:55:50 +01:00
Konstantina Chremmou
cf49ee9063 CA-299064: Fixed wrong image size and tooltip typo.
Also, removed unnecessary comments from index.html because they were making
the file illegible. Included new logo in the project file.
Added localised html files so we can generate the mht files from them
(localisation should not happen in the mht files, but rather in the source html).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-04 10:17:37 +01:00
Michael Z
8cd3fad5ba CA-298952: Update web links with new branding.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-10-02 10:52:58 +01:00
Aaron Robson
ca1113fbcc CA-287643: Replaced list view with data grid view to resolve column sizing issue and for consistency with the rest of the product. (#2226)
CA-287643: Replaced list view with data grid view to resolve column sizing issue and for consistency with the rest of the product.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-02 10:18:34 +01:00
Darren Matthews
2ce509efb3 L10N: Translation updates along with Interface resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-28 14:00:14 +01:00
Michael Z
5584433997 CA-298952: Update product web site link.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-28 11:50:34 +01:00
Aaron Robson
4a62f3ee90 CP-29474: Working through deleting or updating the last of the HelpIDs into sensible help links. (#2231)
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-09-28 10:01:33 +01:00
Konstantina Chremmou
3f2ddb854a Since the ConfigureHA button is used both enablement and editing HA, we don't
need an EnableHA button which additionally appears greyed out while HA is being
enabled. While an HA action is in progress we should only change the enabled
status of the already visible buttons.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-27 12:43:04 +01:00
Darren Matthews
47be1b0ecf L10N: CA-294292 resync Japanese and Chinese files. Truncation issues fixed.
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-27 12:43:04 +01:00
Konstantina Chremmou
2b83de433d CA-294292: Layout modifications to fix error message truncation issues.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-27 12:43:04 +01:00
Aaron Robson
2f497e1053 CA-294286: New VM memory limitations shown
Added labels showing the VM memory limits posed by the template.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-09-26 11:06:24 +01:00
Konstantina Chremmou
95cd300e61 CA-210190 Memory spinner: removed the label so it's easier to align
the spinner with the surrounding controls on a parent control/form.
Also, removed the icon from the spinner because in the
majority of implementations it was invisible and the extra space was just
complicating the alignment of the surrounding controls.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-26 11:06:24 +01:00
Aaron Robson
e29db55d9d CP-29474: Installer changes(#2230)
* Installer script changes for US and International versions to not include the .chm help files that have been removed.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-09-26 09:13:39 +01:00
Aaron Robson
a36d16ebcd CP-29474: Use online help (#2229)
* Using web help instead of local Proof of Concept working.
Please note that some of the HelpIDs in the HelpManager had a mapping to the web page name.
Some are not used anymore, but they should be checked.

* Removing the help files (.chm) from the project, will require changes to the installer scripts.

* Setting the locale in the HELP_URL.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-09-25 16:31:31 +01:00
Michael
ffa8efdba7
Merge pull request #2228 from kc284/rebranding
Minor language corrections and removal of duplicate message.
2018-09-20 23:14:19 -04:00
Konstantina Chremmou
eedba61938 Minor language corrections and removal of duplicate message.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-21 02:08:54 +01:00
Konstantina Chremmou
1d7008beab
Merge pull request #2227 from xenserver/feature/REQ-680
REQ-680: Rebranding XenServer to Citrix Hypervisor
2018-09-21 00:28:44 +01:00
Konstantina Chremmou
1b962268bc
Merge pull request #2225 from michael2012z/feature/REQ-680-merge
Merge master into REQ-680
2018-09-20 15:47:36 +01:00
Michael Z
40197ae2d0 REQ-680: Fix auto-merge errors.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-20 22:41:11 +08:00
Darren Matthews
2ae91f85e2 L10N: Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-19 10:52:23 +01:00
Mihaela Stoica
8998e88255 CA-297216: Remove the unused class and control
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-09-18 15:33:53 +01:00
Mihaela Stoica
592b110f06 CA-297216: Remove the upsell message from the memory tab and disable the DMC settings for VMs in the "Memory Setting" dialog if the server is not licensed.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-09-18 15:33:53 +01:00
Michael Z
9034c5a57a REQ-680: Merge master to feature branch.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-17 20:00:30 +10:00
Konstantina Chremmou
04b37092a6 CA-297020: Do not download imported appliance on a modal dialog (#2200)
* CA-297020: Do not download imported appliance on a modal dialog, but rather
asynchronously on the ImportSourcePage, so that the rest of XenCenter is usable
while the download is taking place; used the page's progress bar for this purpose
and removed the DownloadApplianceDialog.

* Corrections to the validation of the import source.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-14 15:55:05 +01:00
Michael Z
5e37264185 CA-297617: Change Citrix Hypervisor Tools to Citrix VM Tools.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-14 15:54:04 +01:00
Michael Z
9f4e8f8447 CP-29230: Fix build error in spell check.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-14 11:25:38 +01:00
Darren Matthews
fa5dd85c52 L10N: Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-13 11:40:50 +01:00
Michael Z
816bd0601a CP-29230: Switch between new and legacy license names according to server version.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-13 10:39:14 +01:00
Michael Z
31b38796db CP-29230: Replace Enterprise with Premium, Free with Express.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-13 10:39:14 +01:00
Ji Jiang
e26040de9e CA-289189: Fix copyright build failure
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-09-13 10:01:30 +01:00
Darren Matthews
99d0c6ed88 L10N : CA-294333 fixed with resx resync. Translation updates. (#2215)
* L10N: Translation and resx resync
* L10N: CA-294333 Overlap Issue fixed in redesign.

Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-12 23:44:16 +01:00
Ji Jiang
4896b89bb6 CA-289189: Add sole PIF name changing action
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-09-12 23:42:11 +01:00