Commit Graph

3424 Commits

Author SHA1 Message Date
Konstantina Chremmou
4844bac1e8 CP-30451: Unit test restructuring and modifications for better use of the Nunit3 framework.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 16:34:59 +01:00
Konstantina Chremmou
866eae0edc Minor improvements on ImportWizard pages.
- Made storage selector blurb for XVA import a bit more informative.
- A simple checkbox for starting the new VMS on the finish page is adequate.
- Typos. Property modernisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 11:25:37 +01:00
Konstantina Chremmou
db02d206cb Duplicate hotkey. Layout simplification trying to leverage CA-209149.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 11:11:47 +01:00
Lin Liu
52a9bbe257 CA-322735: Keep XenCenter showing the real device number used in the VM
Signed-off-by: Lin Liu <lin.liu@citrix.com>
2019-07-09 08:31:04 +01:00
Darren Matthews
a0aeeccee7 L10N : Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-07-03 12:16:09 +01:00
Mihaela Stoica
891d4d9223 CP-31529: Update RPU003 to the version 8
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-06-21 12:22:01 +01:00
Mihaela Stoica
71333fcf90 CA-304656: Stop users from applying automated updates that will bring the server to a verson incompatible with the current XenCenter version.
When running the XenCenter version precheck, calculate the higher server version that will be installed (by looking at the update sequence) and use this for checking the XenCenter version compatibility.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-06-11 09:34:25 +01:00
Mihaela Stoica
23b0517cb7 CA-314346: Fix Next button enablement on the Destination page of the VM migrate and VM import wizards.
- if there is only one host in the selected pool, then preselect it.
- make sure that  the Next button is enabled when a target host is selected.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-06-11 09:07:07 +01:00
Michael Z
a0e3649ba8 CA-320182: Error in adding vGPU in New VM wizard.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Michael Z
9a26478a16 CP-31400: Collection of improvements.
1. Update AddVGPUDialog title;
2. Add label above the combobox;
3. In the combobox, add text to the entry saying if multiple vGPU is supported;
4. When the dialog is open, focus on the combobox;
5. Preselect the vGPU type if there is only one option available;
6. Setup the Help ID for dialog;
7. Optimize vGPU adding and deleting in GpuAssignAction.

Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Michael Z
7f4ddc87e7 Change AutoScaleMode to Dpi.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Michael Z
b0e6e6216b Simplify more.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Michael Z
9c94e4ffd0 CP-30423: Update binding; Remove hardcode for device; Simplify combobox building calculation.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Mihaela Stoica
1145f20fe8 CP-31063: Add info regarding multiple vGPU support.
Also, update the text referring to vGPUs and hide the PCI slot number column on older hosts

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-06-10 14:49:31 +08:00
Michael
99af56ac94 REQ-720: Initial implementation of GPUEditPage and AddVgpuDialog. (#2422)
* CP-31063: Add support for multiple vGPU
(incomplete)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CP-31063: Add support for multiple vGPU
(part 2)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* AddVGPUDialog

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Update bindings.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* REQ-720: Initial implementation of AddVgpuDialog.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Improve the handling of buttons and combobox. Fix comments.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Fix comments.

Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Darren Matthews
1f2a729573 L10N : Translation Updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-06-09 17:04:28 +01:00
Konstantina Chremmou
c7b531ed80 CP-31105: Moved the Homepage to the Branding folder and added it to the project as a link.
Also, no need to include the homepage sources to the project.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-06-04 16:38:18 +01:00
Mihaela Stoica
aee265b85d CA-311255: Fix duplicated entries of latest CR
- the issue was that in one usage of PatchCanBeInstalledOnHost the wrong version was passed to the applicableVersion parameter (in CreateAlertForXenServerVersion)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-29 08:48:37 +01:00
Darren Matthews
0a6d66ce6d L10N : translation update and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-05-28 21:53:56 +01:00
Mihaela Stoica
cdd57df54d CA-316236 Rename the "save a a template" option from the Snapshot page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-23 15:09:59 +01:00
Mihaela Stoica
ae5d8331e0 CA-316236 Rename the export option from Snapshot page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-23 15:09:59 +01:00
Konstantina Chremmou
8b1e799c7b General TabPage layout modifications (includes CA-164372). (#2439)
- CA-164372: Added line breaks in the pool updates list for readability and to match the corresponding host list.
- Moved the updates, version and licence sections closer together.
- Removed unnecessary panels and placed top buttons on a TableLayoutPanel.
- Moved size hardcoded values from the code to the resource files.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-05-21 11:58:26 +01:00
Mihaela Stoica
aaa573dd21
Merge pull request #2438 from xenserver/feature/REQ-745
Merge feature/REQ-745 branch into master
2019-05-20 10:48:48 +01:00
Mihaela Stoica
36b1e44030 CA-310177: Use a new tooltip message when the selected iso is neither corrupted nor an update
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-17 12:37:02 +01:00
Mihaela Stoica
6075f5185d CA-310177: Check if the selected iso file contains a valid ISO file system.
Also removed unnecessary call to OnPageUpdated.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-17 12:37:02 +01:00
Mihaela Stoica
32a41236a8 CA-317856: Ensure that VMs are repatriated after all hotfixes are appl… (#2436)
* CA-317856: Ensure that VMs are repatriated after all hotfixes are applied and the host has been rebooted.
- there is no need to remove the "reboot host" plan actions from the delayed actions list, because the action itself has code to check if a reboot is actually needed.
* CA-317856: Only add the "Exit maintenance mode" progress step if the host is in maintenance mode at that point.
- moved the AddProgressStep() call inside the function that checks if anything needs to be done (i.e. is host needs to be enables)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-17 12:32:25 +01:00
Mihaela Stoica
c96bf94f8c CA-318280: Add a null check for the VM.appliance property, as it could be null when read from the DR metadata
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-15 13:16:21 +01:00
Mihaela Stoica
8e5db5ce58 Merge branch 'master' into feature/REQ-745
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/PatchingWizard/AutomatedUpdatesBasePage.cs
#	XenAdmin/Wizards/PatchingWizard/PlanActions/RestartHostPlanAction.cs
2019-05-14 16:46:02 +01:00
Mihaela Stoica
f3064173e3 CA-304786: Fix the error where the Patching wizard cannot display available hosts when patch ISO is used by another process
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-04-26 12:14:38 +01:00
Andrew Kisliakov
d8341d5162 Correct spelling in Resolving Subjects Dialog
Signed-off-by: andrew.kisliakov@citrix.com
2019-04-26 12:13:06 +01:00
Darren Matthews
1100fb5199 L10N : Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-04-25 16:29:56 +01:00
Konstantina Chremmou
4ce9878b45 Refactored the VIFDialog to fix various problems: (#2398)
* Refactored the VIFDialog to fix various problems:
- Launch the dialog in using blocks.
- Event GotFocus is not meant to be handled directly in the code.
- Populate the dialog in the OnLoad override instead of the constructor
  as this causes problems at design time.
- Popping up an error message for duplicate MAC on combobox item
  selection or textbox text change is not optimal UX. Perform this
  check once when closing the form. Additionally the parent form of the
  pop up should be the dialog, not the main window.
- The validation messages are not obvious to the user because they are
  hidden in the tooltip of a disabled button. Show them inline instead.
- There is no need to create commands for VIF creation/change; use
  the relevant actions instead.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Corrections as per code review plus some more code tidy and refactoring.

- Added option to suppress Create/DeleteVIFActions
- Use property RebootRequired to indicate hot-plugging is unavailable
  (assigning various objects of different types to the Result of the action
  during its run may cause confusion).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-25 08:23:09 +01:00
Konstantina Chremmou
8492d2713a No need to set ShowProgress to its default value. Removed unused constructor. Compacted Properties.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-24 15:03:20 +01:00
Konstantina Chremmou
7c2c970423 Fixed typo.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-24 15:03:20 +01:00
Konstantina Chremmou
c3f77a7113 Increased slightly the size of the dialog to avoid message truncation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-24 15:03:20 +01:00
Konstantina Chremmou
6273856761 Prevent VisualStudio's designer from crashing when opening the MainWindow.
Made command parameterless constructors public; made browsable events public;
replaced manually written with auto-generated code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-24 15:03:20 +01:00
Konstantina Chremmou
c444d21719 Removed duplicate resource.
Also, renamed message to match naming convention for same category messages.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-24 15:03:20 +01:00
Mihaela Stoica
273c9f3394 CA-314346: Fix Next button enablement on the Destination page of the VM migrate and VM import wizards
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-04-16 23:01:11 +01:00
Darren Matthews
bc009bda2c L10N : Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-04-04 09:05:50 +01:00
Mihaela Stoica
9e100f4fb9 CP-31022: Update the "XenCenter out-of-date" message
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-04-01 17:43:01 +01:00
RoryBG
80333d5aa4 CP-29310 & CP-30765: added support for the new xxHash-based VM imports and exports (#2411)
* added support for the new xxHash-based VM imports and exports
* added xxHash to the legal notices
* added Citrix copyright notice
* removed redundant code and made use of unused variable

Signed-off-by: Rory Bertuzzi-Glover <rory.bertuzzi-glover@citrix.com>
2019-03-26 16:06:25 +00:00
Darren Matthews
3e4108cef8 L10N : translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-03-26 12:08:55 +00:00
Konstantina Chremmou
b33e08b73e CP-30918: Show warnings if GFS2 SRs are not used with multipath.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-25 06:48:41 +00:00
Konstantina Chremmou
8bdc8816c3 CA-309152: Remote logging is offered in addition to local and not instead of it (#2405)
* The radiobuttons local-remote gave the impression the two types of logging
were mutually exclusive. Use a checkbox instead to make it obvious that
the logs are directed to a remote server in addition to being stored locally.

* Updated log destination display on the General TabPage.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-21 13:35:26 +00:00
Konstantina Chremmou
dd6dd86f5d Use the 32x32 warning icon on the certificate warning dialogs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-20 16:58:02 +00:00
Konstantina Chremmou
cad6239c3d Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors
and removed static method creating the dialog from XenObject; the constructor
can be used for this purpose if the command's CantExecuteReasons are keyed
on IXenObjet instead of SelectedItem.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-20 16:58:02 +00:00
Konstantina Chremmou
24664dbd75 Enforce icon size 32x32 on ThreeButtonDialog. Compacted constructors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-20 16:58:02 +00:00
Konstantina Chremmou
66829d7a91 Refactoring to the MeddlingActionManager.
Removed unnecessary ITaskSpecification interface and its inefficient
implementations; compacted methods to make following the logic easier
and avoid duplicate dictionary lookups.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-18 13:26:48 +00:00
Aaron Robson
cdc8de930f CA-301907: Improvements to the VMSS dialog, the VMSS frequency properties/wizard page and the VMSS finish wizard page (#2358)
- On the dialog show the next run time in both the client's and the server's local time zone.
- On the VMSS frequency page allow the user to pick the schedule in the client's
  local time zone and show then next run time in both the client's and the server's local time zone.
- Refactoring to fix workflow and class design, reduce amount of code and simplify logic.
- Various layout improvements.

Signed-off-by: Aaron Robson aaron.robson@citrix.com
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-15 14:10:42 +00:00
Mihaela Stoica
97101ca2e8 CA-309844: Fix meddling actions
- Refactored MeddlingAction and Task classes: moved the logic for building a MeddlingAction outside the Task class and switched to using the vm_operations enum to identify which tasks are suitable for MeddlingAction

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-03-15 09:42:04 +00:00