Commit Graph

3424 Commits

Author SHA1 Message Date
Konstantina Chremmou
788421f3f8 Removed specific version example as it is outdated.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-13 15:59:04 +00:00
Konstantina Chremmou
70b8002c0b Correction to tab indices and label alignment.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-13 15:59:04 +00:00
Konstantina Chremmou
799157a20b Changed small info icon to match the one used on other pages. Minor text and margin correction.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-13 15:59:04 +00:00
Konstantina Chremmou
3c730a0c01 CA-310980: Show successful completed status on the patching page when no action is to be taken.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-13 15:58:24 +00:00
Mihaela Stoica
94ecd4f21c Fix RestartHostPlanAction
- if we decided to skip the host restart, then we should really skip it

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-03-12 11:22:04 +00:00
Mihaela Stoica
dc333963b6
Merge pull request #2406 from xenserver/master
Merge master into REQ-745
2019-03-12 09:41:39 +00:00
Mihaela Stoica
d9ea36b33d CP-30785: Replace xenserver.org links in XenCenter
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-03-08 10:22:41 +00:00
Mihaela Stoica
2d1d1fe5a7 CA-309758: Change the order of filters
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-03-04 11:06:59 +00:00
Mihaela Stoica
4abe4ddb30 CA-309758: Optimisations to the way we assert if Vms can be migrated to a destination pool in the Cross Pool Migrate wizard
- When asserting if a VM can be migrated to a pool we don't have to check all the hosts in the pool at this point, we can enable the pool when we find the first host where migration is possible; we will check the rest of the hosts only if that pool is selected.
- If the destination pool is older than the source, then we don't need to do any server calls because we know that migration to an older host is not allowed.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-03-04 11:06:59 +00:00
Mihaela Stoica
0df39a9d83 CA-310766: Use a dictionary instead of multiple lists
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-26 17:38:37 +00:00
Ji Jiang
ea1cd77306 CA-310766: Fix format SR type bug in Hardware HBA new SR wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2019-02-26 17:38:37 +00:00
Darren Matthews
597813723d L10N : Translation Updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-02-26 11:54:11 +00:00
Konstantina Chremmou
2c884ea47f CA-311146: Copy the results of a linq query to a list to prevent
enumeration on modified collection (it also improves efficiency).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-02-26 11:18:53 +00:00
Konstantina Chremmou
977d2aa503 CP-30597: Remove RPU005. Use a repackaged RPU004 instead.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-02-22 17:23:33 +00:00
Mihaela Stoica
130dfe7b55 CA-310250: Improvements to the guest UEFI UI
-  hide the boot mode control if there is only one option (BIOS boot);
- add text "(experimental)" to the experimental options (in the radio button text);
- if an option is disabled, then hide the experimantal warning, as there is already a note saying why it is disabled;
- more detailed experimental warning.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-21 12:40:22 +00:00
Darren Matthews
2f1838956c L10N : CA-311136 Fixed truncation issue
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-02-20 08:18:56 +00:00
Ji Jiang
ba649634e5 CP-30602: Add boot mode info to Naples XC
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2019-02-15 12:02:11 +00:00
Mihaela Stoica
adbc768851 CA-309037: If live patching fails, do not attempt to reboot the host, but show a warning in the wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-15 11:18:28 +00:00
Mihaela Stoica
788f0cd9df CA-309037: Do the host evacuation before applying the updates
If a host needs to be rebooted after the update application, and the update is not a live patch, then do the host evacuation before applying the update.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-15 11:18:28 +00:00
Mihaela Stoica
0fd9897529 Fix RestartHostPlanAction
- if we decided to skip the host restart, then we should really skip it

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-15 11:18:28 +00:00
Mihaela Stoica
5da6edaf7e CA-310765: Reset the lostConnection flag, so that a retry of this action runs correctly.
Thsi fixes the bug where XenCenter shows connection failure in the RPU when retrying an upgrade

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-14 08:32:05 +00:00
Darren Matthews
3445cb7ff2 L10N : Translation and Resx Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-02-12 21:54:10 +00:00
Mihaela Stoica
f49ee32d3e CP-30597: Update the RPU hotfixes
- Removed RPU001 and RPU002, as 6.x versions are not supported in XenCenter anymore
- Replaced RPU003 and RPU004 with new versions
- Added RPU005 for Lima

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-12 18:03:51 +00:00
Mihaela Stoica
d2f62111f7 CA-309753: If the user decides not to proceed with cancelling the wizard, then the wizard shouln't do the cleanup actions
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-06 15:13:32 +00:00
Konstantina Chremmou
3cd74cc61f CP-30504: Blocked connection to mixed version pools with slaves earlier than dundee.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-02-06 09:25:38 +00:00
Konstantina Chremmou
0ed05e4c6c Removed option to enable RDP polling as it only applies to pre-6.5 hosts which are not longer supported.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-02-06 09:25:38 +00:00
Konstantina Chremmou
eef3320eca Removed code applicable to servers earlier than dundee since connection to them is now blocked.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-02-06 09:25:38 +00:00
Darren Matthews
e5e82b5496 L10N: Translation and Resx Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-02-06 09:24:50 +00:00
Konstantina Chremmou
fc69887281 CA-168861: Corrected margins for labels and comboboxes.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-31 15:24:28 +00:00
Konstantina Chremmou
7836717a56 CA-308212: The prepare_host_upgrade plugin should be called on each
of the hosts to be upgraded and not only on the first one in the list.
For this purpose, the test has been moved to the prechecks, and the
failures are now shown as a non-fixable problem.
Further, specification of the network location of the installer files
has moved closer to the upgrade mode selection.
Also, moved the hotfix and upgrade related checks immediately after the
host liveness check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-31 15:04:03 +00:00
Mihaela Stoica
df534e3f70 CP-30335: Make all warnings in prechecks non-fixable, to avoid opening a modal dialog (for more info) or an URL when Resolve all is pressed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-01-28 17:44:12 +00:00
Konstantina Chremmou
544bcb4978 CP-29923: Provide user friendly descriptions for errors thrown by the host upgrade plugin.
Moved these errors to the FriendlyNames, which is reserved for resources with
keys coming verbatim from the server.
Some code efficiency corrections to the page's workflow.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-28 14:49:48 +00:00
Konstantina Chremmou
7a4d5719c7 Renamed class and file PropertyManager to FriendlyNameManager to avoid confusion,
because it only manages friendly names; moved it closer to the relevant resource files.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-28 14:49:48 +00:00
Mihaela Stoica
6d44fd0350 CP-30335 - Part 2: Add a new precheck + Part 3: Enhance the error message displayed in case of migration failure during the RPU (#2371)
* CP-30335: Fix RPU wizard tests

* CP-30335: Add abstract class WarningWithMoreInfo and use it for two of the existing Warnings

* CP-30335: Add a new precheck which produces a warning if the Dom0 memory after the upgrade will be increased.

- if the Dom0 memory after the upgrade is known, then a warning is shown if this is higher than the current memory, regardless of the version of the upgrade
- if the Dom0 memory after the upgrade is not known (e.g. because the rpu plugin does not have the function that returns this), then a warning is shown if upgrading from a pre-Naples version

* CP-30335: Add a more detailed error message if the host evacuation fails due to not enough memory in the RPU and Patching wizards

* CP-30335: Add branding variable for version 8.0

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-01-28 14:44:58 +00:00
Mihaela Stoica
b1dba44197
Merge pull request #2373 from xenserver/master
Merge master into REQ-602
2019-01-25 15:17:48 +00:00
Mihaela Stoica
e67e5eb644 CP-30335: Rearrange the RPU wizard pages
- Moved Install Location (RollingUpgradeWizard_SelectInstallMethod) page immediatelly after the Upgrade Mode page (and before the Prechecks page)
- Added a new page, called Extras, which contains the updates and supp pack installation options. These options have been moved here from the "Upgrade Mode" and "Ready To Upgrade" pages. This page is also inserted before the Prechecks
- There is no "Ready To Upgrade" page anymore. So the wizard pages are:
   - when automatic mode is selected: Before You Start, Select Pools, Upgrade Mode, Installer Location, Extras, Prechecks, Apply Upgrade.
   - when manual mode is selected: Before You Start, Select Pools, Upgrade Mode, Extras, Prechecks, Apply Upgrade.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-01-21 17:13:54 +00:00
Mihaela Stoica
60e2b61bb7 CP-30335: Rename class
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-01-21 17:13:54 +00:00
Darren Matthews
7271a59ad9 L10N : Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-01-21 10:27:48 +00:00
Konstantina Chremmou
db6b00265b CA-292363: Provide the user the option to reconsider cancellation of the update
or upgrade process (either when cancelling the wizard itself or when exiting
the application). Rephrased confirmation message for clarity.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-15 17:12:09 +00:00
Konstantina Chremmou
749518e94c CA-303195: Provide the user the option to reconsider wizard cancellation
(either when cancelling the wizard itself or exiting the application).
Implemented in the first instance for compiling the server status report.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-15 17:12:09 +00:00
Konstantina Chremmou
b66f11a1e8 CA-303195: Rewrote the logic for compiling and retrieving server status data. The changes include:
- removal of the SystemStatusAction launching the individual SingleHostStatusActions,
because the connection was set incorrectly to the last one of the selected
connections and, if an error occurred to that connection, the data collection
for all of them failed.
- proper handling of HTTP.CancelledExceptions.
- replacement of the FlickerFreeListBox by the more versatile DataGridViewEx.
- corrections to reporting progress for individual hosts as well as page totals.
- made collection of client side data more obvious.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-15 17:12:09 +00:00
Konstantina Chremmou
b94274949e Removed unnecessary call to the base class method.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-15 17:12:09 +00:00
Konstantina Chremmou
67a0980318 Brought the Select/Clear All buttons closer to the bottom of the server list
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-15 17:12:09 +00:00
Konstantina Chremmou
0567d838df Do not set the owner form within the NewDiskDialog constructor; it should be
set by the caller. Test corrections so they don't time out due to blocking
open dialogs. Some tidying up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-14 09:45:13 +00:00
Konstantina Chremmou
58b65f8a8a Enforce failure if MWWaitFor times out without a message, ortherwise failures
are swallowed. Use optional parameters instead of method overloads. Some other
modernisations.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-14 09:45:13 +00:00
Darren Matthews
1bf47e47df L10N : Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-01-13 01:06:04 +00:00
Darren Matthews
0f6f7c0ec4 L10N: Translation updates and resx resync (#2363)
L10N: Translation updates and resx resync

Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-01-10 14:03:27 +00:00
minli1
dba6fe1c9e CA-30405: Change/remove message to generic for VM.suspend with VGPU
Signed-off-by: Min Li <min.li1@citrix.com>
2019-01-10 13:34:23 +00:00
minli1
25d99ed98e CP-30405: Change/remove message to generic for VM.checkpoint with VGPU
Signed-off-by: Min Li <min.li1@citrix.com>
2019-01-10 13:34:23 +00:00
minli1
3f4cf82a13 CP-30405: Refine conditions when creating VM scheduled snapshots.
Since we support checkpoint of Nvidia VGPU dedicated VMs, the conditions
text when new a VMSS needs to be refined.Note that Intel and AMD dedicated
GPUs VMs still be blocked for checkpoint.

Signed-off-by: Min Li <min.li1@citrix.com>
2019-01-10 13:34:23 +00:00
Konstantina Chremmou
ada6f7dac7 CA-296490: Upload single update to multiple pools in parallel. (#2338)
* Simplification: use auto-properties.

* Removed unnecessary null check. Converted private methods to linq method chain.

* Removed unused file. Added null check.

* Corrected property names as it was difficult to distinguish between the alert,
the patch and the filepath.

* Removed duplicate lock.

* CA-296490: Rewrote the logic uploading single updates so as to facilitate uploading to multiple pools in parallel.

* Corrections as per code review.

* Account for the case of uploading from disk legacy updates that do not correspond to an update alert.
Removed unfriendly error messages (the failure is written out in the logs anyway).

* Wizard test corrections and some modernising:
- Only call cancel on the last page if the test allows us to.
- Do finish the UpdatesWizard test.
- Finish the RunWizardKeyboardTests using key strokes instead of button clicks.
- Ensure the Cancel/Previous buttons do not have focus when sending an Enter stroke.
- Use optional parameters in the WizardTest constructor and string interpolation.

* Renamed badly named property.

* Improved code cloning VMs by assigning new opaque_refs to cloned VBDs.
Compacted test object provider: use optional parameters instead of method overloads.

* Modifications to prevent multiple update of enabled state and ensure the wizard
buttons are updated last.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-10 13:24:42 +00:00
Konstantina Chremmou
7a0658c908 Reduced accessibility of controls to private. Moved some of the wizard cancelling
logic to the last wizard page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Konstantina Chremmou
1789abb901 Reduced accessibility of controls to private. Minor refactoring. Typo. Removed
unnecessary event handler. Removed event that was fired but never subscribed to.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Konstantina Chremmou
cd2c2f6ea7 Reduced accessibility of controls to private. Minor refactoring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Konstantina Chremmou
033b7579ef Reduced accessibility of controls to private.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Mihaela Stoica
42054964cd
Merge pull request #2361 from xenserver/feature/REQ-396
Merge feature/REQ-396 to master
2019-01-08 10:48:36 +00:00
Konstantina Chremmou
e59019858c Ensure we never attempt getting the file size if file is null
Fixes https://github.com/xenserver/xenadmin/issues/2356
Also, some code modernising.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-07 14:19:02 +00:00
Konstantina Chremmou
01369b4af1 Merge remote-tracking branch 'upstream/master' into feature/REQ-715
# Conflicts:
#	XenAdmin/MainWindow.cs
#	XenModel/InvisibleMessages.Designer.cs
2019-01-04 18:21:55 +00:00
Konstantina Chremmou
e32e67cd02 Added missing copyright notice.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-02 12:54:08 +00:00
Aaron Robson
dc25f9f53a CP-29875: Remove HelpHelper putting ProduceUrl into HelpManager.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com> (+1 squashed commits)

Squashed commits:

[170a204c] CP-29875: Campaign/Version number should have underscores as separators not points.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com> (+1 squashed commits)

Squashed commits:

[ead4af87] CP-29857: Ensure that the help URL is fully lower case.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com> (+2 squashed commit)

Squashed commit:

[0350c0a6] CP-29875: Include campaign, medium and source in the help URLs.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>

[1e1c1c1c] CP-29875: Refactor and unit test current help URL behavior.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-12-27 12:57:20 +00:00
Darren Matthews
6733649868 L10N : Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-12-20 11:06:41 +00:00
Konstantina Chremmou
361de2dc22 Added missing Roaming attribute to ShowUpdatesByServer.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 13:05:18 +00:00
Konstantina Chremmou
44d70e6867 Suggested UX enhancement: store the user's preferred updates view; note that
option to change this on the Options dialog has not been provided as deemed
unnecessary.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 11:30:15 +00:00
Konstantina Chremmou
5f800f9816 CA-304787: Fixed issue where the Updates-by-server view did not show the required
updates until Refresh was clicked. Also, some UX improvements:

- The Install Updates button should always be enabled in case the user wants
to install supp packs.
- If a type of update is disabled, show always the message at the top of the
grid view, for both views, and even if the list is not completely empty,
otherwise the user may easily forget the update is disabled and be misled.
In this case, the centred warning does not need to show the reason why no
updates were found.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 11:30:15 +00:00
Konstantina Chremmou
981bc3094c Fixed controls spacing, top toolstrip borders and made the top toolstrip on the History page click through.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 11:30:15 +00:00
Konstantina Chremmou
e762dd04c7 Added readonly restrictions to DataGridViewRow cells.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 11:30:15 +00:00
Mihaela Stoica
138e5884b6 CP-30251: Show a warning if the feature is experimental
Use two separate feature flags, `guefi` and `guefi-secureboot`, with the following rules:
- If the feature is disabled, then the option is hidden in XenCenter.
- If the feature is enabled and experimental, then the option is visible and a warning is displayed in XenCenter (in the New Vm and Import wizards).

Also show the reason why a boot mode option is greyed out (when the uefi/uefi-secure boot mode is not supported in the selected template).

(On the Page_InstallationMedia control, I moved the BootModeContol and PvBootBox controls inside the TableLayoutPanel, to allow better alignment and for better visibility in the design mode)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-12-18 15:56:27 +00:00
Mihaela Stoica
d90340efbe CP-30251: Check version number to determine feature availability.
- In the New VM wizard, the boot mode control is only visible for Naples or greater hosts
- In the Import wizard, I had moved the boot mode options to a separate page, added after the target selection page, to allow the version check. The new "Boot options" page is only added for Naples or greater hosts.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-12-18 15:44:23 +00:00
Aaron Robson
b017f08225 Filtering out DEBUG XenAPI.Session logs by default to reduce noise when generally logging for diagnostic purposes at the DEBUG level.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-12-18 09:31:19 +00:00
Konstantina Chremmou
83732625ac The event handler meant to toggle the section's expanded state on mouse double
click was hooked to the wrong event.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-18 09:28:47 +00:00
Konstantina Chremmou
d08efd4a86 Expand the general section on the GeneralTabPage by default only the first
time a new object type is selected. If the user has chosen to collapse it,
respect their choice.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-18 09:28:47 +00:00
Konstantina Chremmou
7a3ba9c980 CA-287648: Do not show the user the licence status before its value has been retrieved.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-18 09:28:47 +00:00
Konstantina Chremmou
7918bc9480 Removed unused method and fixed some code inefficiencies.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-18 09:28:47 +00:00
Konstantina Chremmou
5a4ff2c8a9 Renamed event handler to be more relevant to the event handled.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-18 09:28:47 +00:00
Mihaela Stoica
703630ea36 Merge remote-tracking branch 'upstream/master' into feature/REQ-396
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenAdmin/Alerts/Types/MessageAlert.cs
#	XenModel/XenAPI/Message.cs
#	XenModel/XenAPI/VM.cs
2018-12-12 16:02:03 +00:00
Tim Liu
530257c1bb Fix the wrong layout
Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-12-11 14:52:20 +00:00
Mihaela Stoica
fdbcdcf0e1 CP-29856: Support minimum number of vCPUs in guest templates (#2332)
* CP-29856: Support minimum number of vCPUs in guest templates

- Show a warning if the user wants to set a smaller number of vCPUs than the minimum specified in the template
- Add a null check; Set the warning label text before making it visible to avoid flickering.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-12-11 14:34:35 +00:00
Mihaela Stoica
4a21157533 CP-30123: Update bindings and revert CP-29657 (message for HOST_LOW_MEMORY)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-12-07 16:14:50 +00:00
Darren Matthews
e6d2861b9b L10N : Translation updates and resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-12-03 14:48:42 +00:00
Konstantina Chremmou
930f7380d3 CA-303201: Added null check for the update on host corresponding to the selected update.
If, for example, the host was disconnected, poolUpdateFromHost was null,
which was causing a silent exception resulting to an empty precheck list
shown on the page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-03 10:44:35 +00:00
Mihaela Stoica
fe7b4b6297 CA-304025: XenCenter should not do an immediate toolstack restart if a host reboot is pending, but do the host reboot instead
If the update sequence for automated updates contains an update which requires a host reboot and a hotfix with an immediate toolstack restart (after-apply-guidance=restartXAPI and guidance-mandatory=true),
then XenCenter should do an immediate host reboot after applying the hotfix that required the immediate toolstack restart (as doing a toolstack restart when a host reboot is required is potentially risky)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-30 13:54:02 +00:00
Aaron Robson
7024c5b11f CA-300384: XC unable to create (GFS2) VDI of virtual-size larger than… (#2318)
* CA-300384: XC unable to create (GFS2) VDI of virtual-size larger than available storage when creating new VM.
Calling SR.VdiCreationCanProceed on the total space required of each SR as it takes into account that Thinly Provisioned SRs may overprovision in the same way that the NewDiskDialog does by effectively ignoring the free space limit.
IsSufficientFreeSpaceAvailableOnSrForVdi was not taking into account Thin Provisioning when checking if the virtual disk would fit on the SR and as a consequence would attempt to find another SR to place it on silently; either choosing "Local Storage" or "<no suitable storage>" depending on the size requested relative to the SR sizes.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>

* CA-300384: Hooking into the warning mechanism of the storage grid to ensure that the user is aware that over-provisioning is occurring, but not block them from continuing.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-28 16:32:40 +00:00
Aaron Robson
602edd47d8 XOP-953: Cannot change dom0 memory via XenCenter (XC 7.5 RTM on XS 7.… (#2330)
CA-303516: Cannot change dom0 memory via XenCenter.
Allowing the user to proceed (not set the value and min/max to 0.0GB) even if the memory static min and max is in the wrong order.
Adding further detail to the error message in case an out of bounds value is sent to the API which could potentially happen due to the range widening that occurs if the min/max would invalidate the existing value.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-27 15:40:38 +00:00
Mihaela Stoica
6cd2e28754 CA-300760: Only create the action that moves a halted VM if there are actually disks that need to be moved
- with this change the user won't see the misleading "Moving VM to new storage" in History if they tried to move the VM inside the pool, but actually didn't select different SRs for the VM's disks.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-26 16:34:46 +00:00
Mihaela Stoica
8ab3ea2837 CA-300760: Allow intra-pool move of halted VMs through the wizard, even if the storage migration is not allowed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-26 16:34:46 +00:00
Mihaela Stoica
88ec36ae5f CA-300760: Allow VM intra-pool migration through the wizard, even if the storage migration is not allowed
- if a VM can migrate inside a pool, then we will allow it in the wizard, even if storage migration is not allowed
- If it is a intra-pool migration (without moving the disks), then use the VM migrate action (which does a VM.pool_migrate), not the cross pool migrate action.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-26 16:34:46 +00:00
Konstantina Chremmou
ff708345fa Added functionality allowing renaming of folders. Fixed issue where the form
closed on double-clicking on the node expanded icon. Some improvement in the
use of the folder name prompt dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-26 10:29:39 +00:00
Konstantina Chremmou
16c88cc7b7 CA-302791: Rewrote the ChangeFolder dialog to fix usability issues.
- Corrected folder selection; reduced clicks required to select folders;
  improved text; added delete button.
- Moved FolderChangeDialogTreeView to the same folder as the other TreeViews;
- Added missing null checks to the MutliSelectTreeView and hid properties
  HScrollPos and VScrollPos from VS's designer (the former was initialised
  to zero every time the designer was updated, causing the treeview images
  to disappear).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-26 10:29:39 +00:00
Darren Matthews
97b847ffa6 L10N : Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-11-22 23:48:28 +00:00
Mihaela Stoica
306b0b043b CP-29779: Handle VM_SECURE_BOOT_FAILED alerts in XenCenter
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-22 23:44:07 +00:00
Konstantina Chremmou
243f3a209d CA-302807: Fixed issue where the server selection on the Patching wizard was
lost when leaving and returning back to the SelectServers page.
Also, the list of SelectedServers does not need to be re-evaluated every time
it is accessed but rather once when we move away from the page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-22 13:58:19 +00:00
Aaron Robson
c597b2f795 CP-290940: Dundee is the earliest version to support Automated Updates, show a Server up to date tooltip for Dundee and later, where there are no updates to perform.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-22 10:47:23 +00:00
Aaron Robson
6f847962ca CA-272847: Compilation time is way overestimated (when creating a ser… (#2316)
* CA-272847: Compilation time is way overestimated (when creating a server status report).

- As the times are made up of server timeouts they overestimate quite significantly, we are removing the time estimates from the screen.
- Do not mention being able to see the time that has been removed inside the explanatory label.
- Removing further unused Util functions LThanTime and GThanTime.
- Redone the layout with the privacy link on a separate row to avoid wrapping at smaller sizes and to even up the layout of the Select/Clear buttons with the Total Size label.
- Fixed the tab indexes and removed the invisible Split Container.
- Adjusted the blurb margins to our default and set the last row with the privacy link to be AutoSize rather than absolute in case of truncation in other languages.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-19 12:27:31 +00:00
Aaron Robson
4af1f68fd6 CA-270440: Copy VM full copy SR list isn't sorted naturally. Resolving not just for SrPickerItem but for the CustomTreeNode as used for other related classes.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-16 15:11:34 +00:00
Mihaela Stoica
660eab5d99 CA-300759: When there is a GFS2 SR in the pool, VMs on local storage should still be allowed to be migrated to the local storage of another host.
When XenCenter checks if a VM can be storage-migrated (including in the same pool), it only checks if migration is possible to one SR (the first SR from the SR list  that supports vdi creation), which could be a GFS2 SR, where migration is not supported. With this fix, we will only consider the SRs which support migration (instead of vdi creation).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-16 11:50:12 +00:00
Aaron Robson
7122615836 CA-271967: Dismiss button is flat after dismissing first of a list of events.
Handling OnMouseMove which fires more repeatedly than OnMouseEnter and OnMouseLeave with an early return to preserve CPU efficiency.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-16 11:14:21 +00:00
Tim Liu
0377db7be0 CA-301156: VM created from disk import for a UEFI VM has missing values (#2311)
* CA-301156: VM created from disk import for a UEFI VM has missing values

Set default params when importing VHD

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-11-16 10:03:18 +00:00
Konstantina Chremmou
3f64c26d87 Added .vs and .vscode to .gitignore. Reverted control subtype change introduced
inadvertently with commit c1256c7734 before the
issue was fixed in commit 2a575b01a5.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-13 11:08:10 +00:00
Konstantina Chremmou
f5174e5bfe Fixed issue where the patching wizard offered to re-apply an already applied
update if the user selected it from the disk.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-13 11:08:10 +00:00
Konstantina Chremmou
b7fd97af11 Removed obsolete UpdateType.Existing and associated properties and methods.
Also, simplified the logic selecting the single update when we leave the
SelectPatchPage so as to avoid ambiguities in which properties are to be set
and refactored the error handling methods to avoid duplicate checks and
provide the right error message (for example, the error message was misleading
for a non-existent path; or, the level of detail provided in the case of
invalid zip content was of lesser relevance to the user).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-13 11:08:10 +00:00