Commit Graph

2296 Commits

Author SHA1 Message Date
Konstantina Chremmou
40e395f2bd CA-338273: Accept more ISO 8086 formats.
Also, move time utility methods to one place (the Util class which contains unit conversions).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-24 14:30:32 +01:00
Konstantina Chremmou
d80bbfb151
Merge pull request #2656 from xenserver/feature/read-caching
Merge feature/read-caching branch to master
2020-04-24 11:47:26 +01:00
Konstantina Chremmou
dcc87f4710 CP-32713: Show an error message if the user attempts an update using the base installation ISO.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-22 10:33:22 +01:00
Konstantina Chremmou
cf0da96b87 CA-187943: Revised warning messages to take account the selected affinity.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-20 19:07:31 +01:00
Konstantina Chremmou
3c68e7e097 Improved parsing of SMAPIv3 errors. Deprecated Failure method that should not be used directly by the implementation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-20 18:56:13 +01:00
Mihaela Stoica
7f6877c330
Merge pull request #2652 from xenserver/feature/REQ-811
Merge feature/REQ-811 into master
2020-04-20 18:39:37 +01:00
Konstantina Chremmou
d198b693d1 Replaced InstallToolsWarningDialog with a ThreeButtonDialog. Removed methods duplicating command execution logic.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-17 16:23:06 +01:00
Konstantina Chremmou
dfb49c97a1 CP-32687, CP-32689: Remove "Install PV Tools" options from stockholm onwards.
Replace with help links where necessary or convenient. Also:
- Registered unused event.
- Minor refactoring to: make the InstallToolsCommand.CanExecute clearer; use
  local methods.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-17 16:23:06 +01:00
Mihaela Stoica
66d192b1d8 CP-32985: Changes following code review
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2020-04-16 10:26:17 +01:00
Mihaela Stoica
04dc8533e8 CP-32985: Use SM.features field
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2020-04-16 10:26:17 +01:00
Mihaela Stoica
71a09385c3 CP-32985: XenCenter control to turn read caching on / off per SR
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2020-04-16 10:26:17 +01:00
Konstantina Chremmou
c6c725c37d CA-338012: Corrected error messages for RBAC restrictions and intermediate certificate errors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-15 14:30:00 +01:00
Darren Matthews
bb560db1dc L10N : Resx resync and translation update
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-04-08 15:56:46 +01:00
Konstantina Chremmou
0188fdc69b Corrections as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-08 13:55:35 +01:00
Konstantina Chremmou
e9acde0b64 Try handling a connection interruption.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-08 13:55:35 +01:00
Konstantina Chremmou
79bebdb816 Parse the certificate alert body as xml. Accept more ISO 8086 formats.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-08 13:55:35 +01:00
Konstantina Chremmou
8fc258420d CP-32699: New dialog for certificate installation on a server.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-08 13:55:35 +01:00
Konstantina Chremmou
52369c9d0d Removed references to SSL certificates.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-08 13:55:35 +01:00
Konstantina Chremmou
a8fc37b22b Merge remote-tracking branch 'upstream/master' into feature/REQ-811
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Diagnostics/Checks/Check.cs
#	XenAdmin/Diagnostics/Problems/PoolProblem/PoolHasPVGuestWarningUrl.cs
#	XenAdmin/Diagnostics/Problems/Problem.cs
#	XenAdmin/Diagnostics/Problems/WarningWithMoreInfo.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenAdmin.csproj
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
2020-04-02 23:29:54 +01:00
Konstantina Chremmou
03dbf38f6f Merge branch 'master' into feature/REQ-814
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenModel/Messages.Designer.cs
2020-04-02 10:58:58 +01:00
Konstantina Chremmou
6c5edddda8 CP-32701: Show certificate expiry alerts.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-01 16:27:13 +01:00
Konstantina Chremmou
fc944784b4 CP-32697: Show certificate metadata on the host's General TabPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-01 16:27:13 +01:00
Konstantina Chremmou
8c4af40cf2 Added command and menu item for launching the certificate installation dialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-01 16:27:13 +01:00
Konstantina Chremmou
ec1b45cd56 New API class for certificates.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-01 16:27:13 +01:00
Konstantina Chremmou
974ece8878 CA-337287: Skip legacy protocol and power-on iLO checks with a warning if the RPU hotfix is missing.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-30 10:48:32 +01:00
Konstantina Chremmou
3a35a96530 CP-33294: Remove iLO power on option from XenCenter
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-30 10:48:32 +01:00
Konstantina Chremmou
5406b933fd CA-330308: Rewrote Power-On edit page to fix workflow issues:
- It was not possible to apply different settings to multiple hosts
at the same time.
- Server calls were made on the UI thread.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-30 10:48:32 +01:00
Konstantina Chremmou
888a0555ab CA-337287: Skip vSwitch controller and PV guest checks with a warning if the RPU hotfix is missing.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-27 16:47:25 +00:00
Konstantina Chremmou
9e458373b0 Missing copyright; typos found from spell check; added terms to ignore list.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-04 12:40:20 +00:00
Konstantina Chremmou
a07c68a345 CA-334756: Allow detaching and reattaching all types of SRs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-03 09:30:00 +00:00
Konstantina Chremmou
00cc547aaf Warning and error corrections.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-02 17:46:29 +00:00
Konstantina Chremmou
d3c5769a70 CP-32844: Check and warn if DVSC is configured when updating or upgrading a pool.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-02 17:46:29 +00:00
Konstantina Chremmou
4ff42f51f3 Modifications on the NewNetwork wizard (includes CA-192746).
- NetworkDetails page: reworked it to fix NumericUpdown validation and messages (CA-192746).
- SelectNetworkType page: moved warnings closer to the corresponding network types,
  fixed wrong label enabled state and made enablement logic more explicit.
- All pages: property modernisation and control layout tweaks (mostly margins).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-02 17:46:29 +00:00
Darren Matthews
57cbf560d5 L10N : Scientific Notation Updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-02-28 14:46:07 +00:00
Konstantina Chremmou
7aeb17272b CP-32844: Check and warn if legacy SSL mode is enabled when updating or upgrading a pool.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-02-27 09:29:40 +00:00
Konstantina Chremmou
a36b4062b8 Derive BrokenSR from HostProblem. Removed obsolete classes. Some code modernisation and consolidation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-02-27 09:29:40 +00:00
Konstantina Chremmou
bbc826264a Put controls on a TableLayoutPanel. Corrected warning text for standalone host.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-02-27 09:29:40 +00:00
Darren Matthews
7925bcae27 L10N : Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-02-26 08:24:06 +00:00
Konstantina Chremmou
1b35a6898f Spelling corrections, mostly for consistency with the docs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-02-14 14:43:22 +00:00
Konstantina Chremmou
3869d9654d New bindings (includes CP-29452, CA-75634, CA-280976).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-02-14 14:43:22 +00:00
Konstantina Chremmou
1bcec343f1 Merge remote-tracking branch 'upstream/feature/REQ-803' 2020-02-13 11:43:17 +00:00
Mihaela Stoica
2b0822f3d3 CP-32931: Stop sending licensing information to the licensing server
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2020-02-11 08:35:42 +00:00
Darren Matthews
07d475b6cd L10N : Translation update and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-02-03 13:51:15 +00:00
Konstantina Chremmou
24605a3459 Latest C# SDK (defines stockholm release).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-29 12:46:21 +00:00
Konstantina Chremmou
f7391e991b
CA-156873, CP-31105 (partial): Apply common branding and versioning to assemblies; branding refactoring
Added brand management files and refactored the following brand variables:
* BRANDING_XENSERVER_UPDATE_URL
* BRANDING_PERF_ALERT_MAIL_LANGUAGE_DEFAULT
* BRANDING_SEARCH
* BRANDING_UPDATE
* BRANDING_BACKUP
* BRANDING_LEGACY_PRODUCT_BRAND
* ISO
* BRANDING_VERSION_5_6
* BRANDING_VERSION_6_2
* BRANDING_VERSION_6_0
* BRANDING_VERSION_6_5
* BRANDING_VERSION_7_0
* BRANDING_VERSION_7_1_2
* BRANDING_VERSION_8_0
* BRANDING_VERSION_8_1
* BRANDIND_COPYRIGHT
* BRANDING_COPYRIGHT_2

Also: Try passing the timestamp server as parameter
2020-01-22 14:47:39 +00:00
Mihaela Stoica
37a3d17667 Add StockholmOrGreater functions
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2020-01-17 10:56:38 +00:00
Konstantina Chremmou
bfc8141391 CA-318468, CA-271455: Reworked OVF validation and OVA package extraction during import.
- Handle validation for OVF files with a name different from the containing
  OVA package. Other corrections to wrong validation logic.
- Show validation warnings on a dialog that can be turned off.
- Clean up extracted files after an OVA package has been imported.
- Plus code refactoring and simplification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-16 16:26:30 +00:00
Konstantina Chremmou
45fe63ecde Corrections as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-08 16:09:36 +00:00
Konstantina Chremmou
efa0fc2fdc CA-187943: Show a warning when a new VM's disks cannot be accommodated on the template or default SR due to lack of space.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-08 16:09:36 +00:00
Konstantina Chremmou
99a3a30fc7 Removed methods that add unnecessary complexity.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-08 16:09:36 +00:00
Konstantina Chremmou
9e1ec4cf41 CA-333236: Calculate local time for HotfixEligibilityAlert properties on the UI thread.
The Title and Description of HotfixEligibilityAlert  involve calculation of local
time which should be done on the UI thread, otherwise the time is not localised
correctly, and additionally the application crashes when dismissing or sorting
these alerts.
Also, stop spamming the logs with each alert removal; code efficiency correction.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-02 13:15:18 +00:00
Darren Matthews
ce217adc60 L10N : Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-12-13 12:49:56 +00:00
Konstantina Chremmou
f459ef5956 CA-331420: Do not refresh the license status on the general tab if the selected object is not a pool/host.
- Removed AsyncServerTime class as it adds complexity and the risk of
  getting an outdated time.
- Simplified event signatures and compacted nested method calls.
- Fixed typo and removed unused code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-09 14:39:09 +00:00
Xueqing Zhang
224acb6706 CA-330890: update storage select wazard in XCM
Signed-off-by: Xueqing Zhang <xueqing.zhang@citrix.com>
2019-12-09 11:06:25 +00:00
Konstantina Chremmou
fc1cbf636e Simplified signature of connection events.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-06 11:17:46 +00:00
Konstantina Chremmou
1bf5add051 Typo in property name.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-06 11:17:46 +00:00
Konstantina Chremmou
423e619101 Updated 3rd party libraries; includes upgrade to PuTTY 0.73 (CP-32362)
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-14 12:14:26 +00:00
Mihaela Stoica
c1dc88a203 Update API bindings
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-11-13 13:39:27 +00:00
Konstantina Chremmou
072397ac2a Refactoring and deletion of dead code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
5614dafbe6 CA-329742, CA-330301: Logging simplification.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
99572da0fb Corrections to the logging of Win32 exceptions. Minor refactoring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
667e9e8caf Log the stack trace when an exception is encountered and don't use the *Format() counterpart of the logging method for it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fad80c778b Avoid duplicate logging; compact multiple logging calls.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
f4265732ca Do not localise log entries or ellipsise names. Log exception stack traces where applicable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fb2edf99b8 Do not initialise a logger if a class does not use it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Darren Matthews
e56a6e5d66 L10N : Translation Update and Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-11-11 15:23:40 +00:00
Mihaela Stoica
01b011c982 CA-329399: Improve the error message displayed if the update wizard if a host cannot be evacuated.
If a host cannot be evacuated because other hosts in the pool are maintenance mode and pending a reboot following an update installation, then include instructions to reboot those hosts and then press Retry.
Also updated the text for the Manual mode, removing the reference to installing other updates and doing a reboot manually at the end, because that won't be always possible, due to the fact that now we put the hosts in maintenance mode before installing the update.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-11-08 10:27:49 +00:00
Mihaela Stoica
16eb52eba3 Sort Messages.resx
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-11-01 15:14:24 +00:00
Mihaela Stoica
326e4d8fe8 CA-329695: Restrict switching the boot mode in the New VM wizard (when created from template or snapshot)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-11-01 15:14:24 +00:00
Konstantina Chremmou
5d8b0f685f Corrected spelling to match the docs. Use en-us spelling.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-30 11:41:44 +00:00
Konstantina Chremmou
dcaf527757 CA-293784: Path and message updates.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-30 11:41:44 +00:00
Darren Matthews
01764e8972 L10N: Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-10-21 13:53:59 +01:00
Mihaela Stoica
32981d24f1 CP-32254: Add DMC deprecation banner
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-10-18 10:04:51 +01:00
Xueqing Zhang
4dacede64b CP-32033 Add PV guests precheck in Xencenter
Signed-off-by: Xueqing Zhang <Xueqing.Zhang@citrix.com>
2019-10-18 09:56:21 +01:00
Konstantina Chremmou
ce958e5999 Corrected message and tab indices.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
d013c21f27 Further corrections to the DiskSpinner's rounding behaviour.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
f39a715816 CP-29522, CA-302477: Added TB option to the NumericUpdown of the NewDiskDialog and fixed validation on the VDISizeLocationPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
ec79720057 Do not pass the delegates showing messages as parameters to the actions, but rather have them handle action events.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
6f0a9cae6a CA-293784: updated plugins to use the XenServerPSModule as the snap-in has been retired.
- Check for the module existence when the process is created, not when
loading the plugin.
- Removed snapin max and min version as the specification documents them
as not implemented (CA-40580).
- Refactored Registry class to avoid code repetition and ensure that all
opened keys are closed.
- Added null checks and compacted the code parsing the plugin xml.
- Modernized properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-09 13:32:07 +01:00
Konstantina Chremmou
e9d2da082d Prevent XenCenter from crashing if starting it by double-clicking a license file.
Also, fixed hotkeys and info message on the PasswordRequest dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-07 18:00:32 +01:00
Mihaela Stoica
8b41a214b2
Merge pull request #2521 from xenserver/feature/REQ-756
Merge feature/REQ-756 into master
2019-09-27 13:18:21 +01:00
Darren Matthews
4a3fd35b51 L10N: Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-09-25 15:17:19 +01:00
Konstantina Chremmou
91e2ec3bbe CP-32101: Allow the application to seek help relevant to its release instead of always pointing to help for the latest CR.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 15:02:05 +01:00
Konstantina Chremmou
5244c91658 Help refactoring.
- Removed DebugHelp. The user settings are normally not meant for debugging code.
- Moved HelpId logic from the main window to the tab pages.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 15:02:05 +01:00
Konstantina Chremmou
441734be82 CP-32140: Allow the user to select which XCM VPX to use when there are multiple XCM VPXs in the pool.
Also, corrected the RBAC permission check after stopping using the conversion plugin.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 13:25:26 +01:00
Konstantina Chremmou
3d92246607 The GpuConfiguration list should not be editable. Resize GpuShinyBar Edit button when the text changes.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-23 13:39:54 +01:00
Konstantina Chremmou
ceccfcbe79 CA-325439: Pre-populate download locations. Validation corrections on the server status report wizard.
- Moved path validation checks from the wizard to its last page (planning
to remove XenWizardBase.FinishCancelled in future).
- If the directory did not exist, the user saw a message about inability
to write a file which was misleading. Check directory existence explicitly.
- Populate the last wizard page on load rather than on construction to
avoid unnecessary validations.
- Save in the settings the report output directory, not the filename.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-19 14:06:28 +01:00
Mihaela Stoica
0e47725ceb CP-32137: Updated alert message + sorted Messages.resx
Also rewrote the IsAlertNeeded() function, for better readability

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-16 10:46:06 +01:00
Mihaela Stoica
43dd9d4b4d CP-32137: Add alert for versions approaching EOL
The Approaching EOL alert will be shown when the EOL date is known, but the hotfix-eligibility flag is not yet set to "none".

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-16 10:46:06 +01:00
Mihaela Stoica
4832c7f5e6 CP-32139: Add text regarding the supportability for versions that have reached EOL
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-16 10:46:06 +01:00
Mihaela Stoica
b7738d1d81
Merge pull request #2511 from kc284/CA-272770
CA-272770: Check whether the selected ISO SR supports VDI creation before copying the Fixup ISO on it.
2019-09-13 13:50:08 +01:00
Konstantina Chremmou
ca72f25ebe Merge remote-tracking branch 'upstream/master' into feature/REQ-756
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.Designer.cs
#	XenAdmin/MainWindow.resx
#	XenAdmin/Properties/Resources.resx
2019-09-13 13:17:32 +01:00
Konstantina Chremmou
bf1cdb67ec Change case to match the help files.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-13 12:48:48 +01:00
Konstantina Chremmou
2c59ca255e CP-30364: Facilitate overriding the help files location for testing purposes
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-13 12:00:56 +01:00
Konstantina Chremmou
d52008aaf9 CA-272770: Check whether the selected ISO SR supports VDI creation before copying the Fixup ISO on it.
Also, minor layout correction, and usability enhancement: do not disable
the controls under the radio button when the latter is deselected.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-12 23:05:15 +01:00
Konstantina Chremmou
d2db181872 CA-314721: Fixed parsing of nvidia gpu metrics names.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-11 14:23:48 +01:00
Konstantina Chremmou
d5d32baa88 CA-326611: Improved connecting to the conversion VM.
- Poll for the appliance version because the service may take a while to
  start after an IP address is obtained.
- More flexible IP address look up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-11 13:27:29 +01:00
Konstantina Chremmou
8701641e47 CA-326609: Ensure the conversion wizard offers only SRs that can be seen from all hosts in the pool.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-11 13:27:29 +01:00
Konstantina Chremmou
61f6f89c25
Merge pull request #2510 from xenserver/feature/REQ-775
Merge REQ-775 into master
2019-09-06 12:08:23 +01:00
Mihaela Stoica
b7c64bddb2 CA-326341: Refresh the hotfix eligibility alerts after a check for updates is completed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-04 14:40:03 +01:00
Konstantina Chremmou
57689f7498 Some spelling corrections.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-04 13:37:33 +01:00
Konstantina Chremmou
830b979813 Obsolete class (possible CP-4813 leftover).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-04 13:37:33 +01:00
Mihaela Stoica
fca17a7ef5 Fix menu and dialog title inconsistencies for Snapshot schedules.
Also, use an info (instead of warning) icon on the message for Disk and memory snapshot

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-03 09:44:59 +01:00
Mihaela Stoica
3f5125b293 CA-325846: Do not display invalid data in the hotfix eligibility warnings and alerts
- if a hotfix eligibility date field is invalid, then the hotfix eligibility warning does not include any reference to this date.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-03 08:52:40 +01:00
Mihaela Stoica
e4305ecb15 CA-325822: Refresh existing hotfix eligibility alerts when the license status changes
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-03 08:52:40 +01:00
Konstantina Chremmou
1a88c3713d Activate the conversion VPX and get the service IP address without employing the conversion plug-in.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-02 10:34:58 +01:00
Konstantina Chremmou
f46c9ea8d6 CP-30890/XSI-284: Support import of gzipped XVAs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-28 15:30:01 +01:00
Konstantina Chremmou
6066de3ae2 Corrections and enhancements. (#2496)
* Corrections and enhancements.

Fixed version compatibility check. Added context menu to the conversion list.

* Exclude templates and snapshots when looking for the conversion VM.

* Further corrections.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-28 14:57:36 +01:00
Konstantina Chremmou
aab9df208a Further improvements.
- Added textual description of the conversion status in the Details panel.
- Merged status detail and error message.
- Added initial sort order.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-27 07:52:38 +01:00
Konstantina Chremmou
d22b212afa Renamed property as there are clashes with a child class (will have to be refactored in future). Treat warnings as errors in all projects.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-22 14:03:30 +01:00
Konstantina Chremmou
65fa1b3033 Removed copyright from resx files. Text corrections.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-22 12:49:03 +01:00
Konstantina Chremmou
9157735803 CP-30958: Initial implementation of the Conversion Manager in XenCenter. (#2481)
* CP-30958: Initial implementation of the Conversion Manager in XenCenter.
* Corrections following review and improvements.
* Further corrections and improvements.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-22 10:47:43 +01:00
Mihaela Stoica
482c86a731 CP-31527: Add notifications in XenCenter for versions that are no lon… (#2486)
CP-31527: Add notifications in XenCenter for versions that are no longer eligible for hotfixes

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-08-21 11:43:11 +01:00
Konstantina Chremmou
374078fbec Fixed a bunch of small issues on the password handling dialogs.
- CA-92787: Added tip on how to reset a forgotten password on the LoadSessionDialog.
- The LoadSessionDialog was launching help twice.
- The error message on the SetPasswordDialog was truncated after the first time
it appeared.
- The checks on the ChangeMasterPasswordDialog were out of order.
- Minor layout corrections and code compacting on all dialogs.
- Moved LoadSessionDialog to the same folder as the other RestoreSession dialogs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-19 09:30:13 +01:00
Konstantina Chremmou
adab54a9c5 CA-293375: Fixed inconsistencies in the items related to removing servers from a pool
- Add item "Remove From Pool" to the main Server menu; it should be enabled
if the selected servers are removable and disabled at all other times.
The item should be present in the server's right click menu only if it is enabled.
- Replaced the above item in the Pool menu with the dropdown "Remove Server"
where the user can select the server to remove from the list of removable
servers.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-15 11:33:01 +01:00
Konstantina Chremmou
8fedb2d6e0 Removed unnecessary constructors. The ones with the 'params' param cover for them.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-15 11:33:01 +01:00
Konstantina Chremmou
57b8d8f5cb Do not expose the Ovf project's settings to the other projects in the solution.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-14 11:07:16 +01:00
Konstantina Chremmou
e6da7045b6 Ensure we always dispose of the ArchiveIterator and ArchiveWriter after use.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-13 10:18:15 +01:00
Konstantina Chremmou
38fcc83874 Fixed labels; removed unnecessary control disablement.
The blurbs should be user-centric rather than developer-centric.
No need to disable the page controls in the absence of signature/manifest
since the whole page becomes disabled in that case.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-13 10:18:15 +01:00
Darren Matthews
4162b19cfc L10N : Translation and resx updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-08-09 12:14:59 +01:00
Konstantina Chremmou
9cfc7ff8d3 Added friendly name and description for the bug tool capability nvidia-logs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-06 10:43:01 +01:00
Konstantina Chremmou
dd94ebaf3f Duplicate key. Use "Delete" instead of "Delete VM" to match menus for other objects.
Made Debug Assertion more detailed to aid us pick unique hotkeys.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-25 13:09:22 +01:00
Konstantina Chremmou
30226c590d CA-116060: Stop saving the expanded state of the New Search panel with the other Search metadata.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-23 14:00:38 +01:00
Darren Matthews
8b698c0bfc L10N : Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-07-23 11:27:21 +01:00
Konstantina Chremmou
8f2794b89d Prevent crash and improve behaviour when the user tries to configure/disable HA in a pool that has lost the HA statefile.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-23 10:28:01 +01:00
Konstantina Chremmou
dd81a5d14c CA-280117: Show the user the VDI uuid instead of the VDI opaque_ref when enabling HA throws VDI_NOT_AVAILABLE error.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-23 10:28:01 +01:00
Mihaela Stoica
c137b4a6ea CA-317752: Take live-patching qualification into consideration in the Install Update pre-checks
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-22 17:49:18 +01:00
Konstantina Chremmou
0e57e871b9 Removed unnecessary instance class SrPickerItemFactory.
Removed comments that did not provide further info than the class name
they were documenting. Removed unused code. Launch progress dialog within
a using block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 16:19:25 +01:00
Konstantina Chremmou
6e9ac153ca CA-323248: Allow VDI move to a local SR if the latter can be seen from the home hosts of the VMs the VDI is attached to.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 16:19:25 +01:00
Konstantina Chremmou
1c22696d70 Message normalisation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 13:15:59 +01:00
Konstantina Chremmou
85654a4f36 CA-314720: Replaced "Still waiting" dialog popping up during RPU with a message displayed in the upgrade output.
Also, fixed issue where uploading a supp-pack resulted in a perpetually
pending action if the file had disappeared from the disk.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 13:15:59 +01:00
Mihaela Stoica
3d3a96fbe6 CA-323766: Show the upgrade version in the RPU wizard, if available
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-22 12:24:07 +01:00
Darren Matthews
60b4282aba L10N : Resx resync and translation update
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-07-18 14:49:51 +01:00
Konstantina Chremmou
b533585a79 Renamed release. Updated bindings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-18 09:38:26 +01:00
Konstantina Chremmou
866eae0edc Minor improvements on ImportWizard pages.
- Made storage selector blurb for XVA import a bit more informative.
- A simple checkbox for starting the new VMS on the finish page is adequate.
- Typos. Property modernisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 11:25:37 +01:00
Konstantina Chremmou
db02d206cb Duplicate hotkey. Layout simplification trying to leverage CA-209149.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 11:11:47 +01:00
Konstantina Chremmou
979f88a90c CA-322699: Do not use an intermediate MemoryStream when sanitising the files of a tar archive.
If the tar contains huge files, this causes memory spikes, even OutOfMemoryException.
Instead, copy the file from the input to the output stream in chunks.
For this purpose the sanitisation code was moved to XenCenterLib to avoid
exposing the tar internals to the UI project.
Also, made some minor improvements in error handling, clean up, and logging.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 09:19:47 +01:00
Konstantina Chremmou
197b95cb73 Compacted methods marking action as completed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 09:19:47 +01:00
Konstantina Chremmou
46b5efd15e Simplified event declaration.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 09:19:47 +01:00
Lin Liu
52a9bbe257 CA-322735: Keep XenCenter showing the real device number used in the VM
Signed-off-by: Lin Liu <lin.liu@citrix.com>
2019-07-09 08:31:04 +01:00
Darren Matthews
a0aeeccee7 L10N : Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-07-03 12:16:09 +01:00
Mihaela Stoica
dbfcce83c9 Update XenAPI bindings (includes CA-258385)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-06-19 09:20:21 +01:00
Michael Z
372088cf43 CA-320459: Mistake in handling vGPUs when creating a VM from template.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Michael Z
b2b39df313 Improve the resource and code for vGPU combobox entry text.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Michael Z
771abb9699 XenCenterBindings update.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Michael Z
9a26478a16 CP-31400: Collection of improvements.
1. Update AddVGPUDialog title;
2. Add label above the combobox;
3. In the combobox, add text to the entry saying if multiple vGPU is supported;
4. When the dialog is open, focus on the combobox;
5. Preselect the vGPU type if there is only one option available;
6. Setup the Help ID for dialog;
7. Optimize vGPU adding and deleting in GpuAssignAction.

Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Michael Z
9c94e4ffd0 CP-30423: Update binding; Remove hardcode for device; Simplify combobox building calculation.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Mihaela Stoica
1145f20fe8 CP-31063: Add info regarding multiple vGPU support.
Also, update the text referring to vGPUs and hide the PCI slot number column on older hosts

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-06-10 14:49:31 +08:00
Michael
99af56ac94 REQ-720: Initial implementation of GPUEditPage and AddVgpuDialog. (#2422)
* CP-31063: Add support for multiple vGPU
(incomplete)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CP-31063: Add support for multiple vGPU
(part 2)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* AddVGPUDialog

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Update bindings.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* REQ-720: Initial implementation of AddVgpuDialog.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Improve the handling of buttons and combobox. Fix comments.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Fix comments.

Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Darren Matthews
1f2a729573 L10N : Translation Updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-06-09 17:04:28 +01:00