Commit Graph

3471 Commits

Author SHA1 Message Date
Konstantina Chremmou
cd2c2f6ea7 Reduced accessibility of controls to private. Minor refactoring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Konstantina Chremmou
033b7579ef Reduced accessibility of controls to private.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Mihaela Stoica
42054964cd
Merge pull request #2361 from xenserver/feature/REQ-396
Merge feature/REQ-396 to master
2019-01-08 10:48:36 +00:00
Konstantina Chremmou
e59019858c Ensure we never attempt getting the file size if file is null
Fixes https://github.com/xenserver/xenadmin/issues/2356
Also, some code modernising.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-07 14:19:02 +00:00
Konstantina Chremmou
01369b4af1 Merge remote-tracking branch 'upstream/master' into feature/REQ-715
# Conflicts:
#	XenAdmin/MainWindow.cs
#	XenModel/InvisibleMessages.Designer.cs
2019-01-04 18:21:55 +00:00
Konstantina Chremmou
e32e67cd02 Added missing copyright notice.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-02 12:54:08 +00:00
Aaron Robson
dc25f9f53a CP-29875: Remove HelpHelper putting ProduceUrl into HelpManager.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com> (+1 squashed commits)

Squashed commits:

[170a204c] CP-29875: Campaign/Version number should have underscores as separators not points.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com> (+1 squashed commits)

Squashed commits:

[ead4af87] CP-29857: Ensure that the help URL is fully lower case.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com> (+2 squashed commit)

Squashed commit:

[0350c0a6] CP-29875: Include campaign, medium and source in the help URLs.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>

[1e1c1c1c] CP-29875: Refactor and unit test current help URL behavior.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-12-27 12:57:20 +00:00
Darren Matthews
6733649868 L10N : Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-12-20 11:06:41 +00:00
Konstantina Chremmou
361de2dc22 Added missing Roaming attribute to ShowUpdatesByServer.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 13:05:18 +00:00
Konstantina Chremmou
44d70e6867 Suggested UX enhancement: store the user's preferred updates view; note that
option to change this on the Options dialog has not been provided as deemed
unnecessary.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 11:30:15 +00:00
Konstantina Chremmou
5f800f9816 CA-304787: Fixed issue where the Updates-by-server view did not show the required
updates until Refresh was clicked. Also, some UX improvements:

- The Install Updates button should always be enabled in case the user wants
to install supp packs.
- If a type of update is disabled, show always the message at the top of the
grid view, for both views, and even if the list is not completely empty,
otherwise the user may easily forget the update is disabled and be misled.
In this case, the centred warning does not need to show the reason why no
updates were found.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 11:30:15 +00:00
Konstantina Chremmou
981bc3094c Fixed controls spacing, top toolstrip borders and made the top toolstrip on the History page click through.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 11:30:15 +00:00
Konstantina Chremmou
e762dd04c7 Added readonly restrictions to DataGridViewRow cells.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 11:30:15 +00:00
Mihaela Stoica
138e5884b6 CP-30251: Show a warning if the feature is experimental
Use two separate feature flags, `guefi` and `guefi-secureboot`, with the following rules:
- If the feature is disabled, then the option is hidden in XenCenter.
- If the feature is enabled and experimental, then the option is visible and a warning is displayed in XenCenter (in the New Vm and Import wizards).

Also show the reason why a boot mode option is greyed out (when the uefi/uefi-secure boot mode is not supported in the selected template).

(On the Page_InstallationMedia control, I moved the BootModeContol and PvBootBox controls inside the TableLayoutPanel, to allow better alignment and for better visibility in the design mode)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-12-18 15:56:27 +00:00
Mihaela Stoica
d90340efbe CP-30251: Check version number to determine feature availability.
- In the New VM wizard, the boot mode control is only visible for Naples or greater hosts
- In the Import wizard, I had moved the boot mode options to a separate page, added after the target selection page, to allow the version check. The new "Boot options" page is only added for Naples or greater hosts.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-12-18 15:44:23 +00:00
Aaron Robson
b017f08225 Filtering out DEBUG XenAPI.Session logs by default to reduce noise when generally logging for diagnostic purposes at the DEBUG level.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-12-18 09:31:19 +00:00
Konstantina Chremmou
83732625ac The event handler meant to toggle the section's expanded state on mouse double
click was hooked to the wrong event.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-18 09:28:47 +00:00
Konstantina Chremmou
d08efd4a86 Expand the general section on the GeneralTabPage by default only the first
time a new object type is selected. If the user has chosen to collapse it,
respect their choice.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-18 09:28:47 +00:00
Konstantina Chremmou
7a3ba9c980 CA-287648: Do not show the user the licence status before its value has been retrieved.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-18 09:28:47 +00:00
Konstantina Chremmou
7918bc9480 Removed unused method and fixed some code inefficiencies.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-18 09:28:47 +00:00
Konstantina Chremmou
5a4ff2c8a9 Renamed event handler to be more relevant to the event handled.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-18 09:28:47 +00:00
Mihaela Stoica
703630ea36 Merge remote-tracking branch 'upstream/master' into feature/REQ-396
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenAdmin/Alerts/Types/MessageAlert.cs
#	XenModel/XenAPI/Message.cs
#	XenModel/XenAPI/VM.cs
2018-12-12 16:02:03 +00:00
Tim Liu
530257c1bb Fix the wrong layout
Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-12-11 14:52:20 +00:00
Mihaela Stoica
fdbcdcf0e1 CP-29856: Support minimum number of vCPUs in guest templates (#2332)
* CP-29856: Support minimum number of vCPUs in guest templates

- Show a warning if the user wants to set a smaller number of vCPUs than the minimum specified in the template
- Add a null check; Set the warning label text before making it visible to avoid flickering.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-12-11 14:34:35 +00:00
Mihaela Stoica
4a21157533 CP-30123: Update bindings and revert CP-29657 (message for HOST_LOW_MEMORY)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-12-07 16:14:50 +00:00
Darren Matthews
e6d2861b9b L10N : Translation updates and resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-12-03 14:48:42 +00:00
Konstantina Chremmou
930f7380d3 CA-303201: Added null check for the update on host corresponding to the selected update.
If, for example, the host was disconnected, poolUpdateFromHost was null,
which was causing a silent exception resulting to an empty precheck list
shown on the page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-03 10:44:35 +00:00
Mihaela Stoica
fe7b4b6297 CA-304025: XenCenter should not do an immediate toolstack restart if a host reboot is pending, but do the host reboot instead
If the update sequence for automated updates contains an update which requires a host reboot and a hotfix with an immediate toolstack restart (after-apply-guidance=restartXAPI and guidance-mandatory=true),
then XenCenter should do an immediate host reboot after applying the hotfix that required the immediate toolstack restart (as doing a toolstack restart when a host reboot is required is potentially risky)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-30 13:54:02 +00:00
Aaron Robson
7024c5b11f CA-300384: XC unable to create (GFS2) VDI of virtual-size larger than… (#2318)
* CA-300384: XC unable to create (GFS2) VDI of virtual-size larger than available storage when creating new VM.
Calling SR.VdiCreationCanProceed on the total space required of each SR as it takes into account that Thinly Provisioned SRs may overprovision in the same way that the NewDiskDialog does by effectively ignoring the free space limit.
IsSufficientFreeSpaceAvailableOnSrForVdi was not taking into account Thin Provisioning when checking if the virtual disk would fit on the SR and as a consequence would attempt to find another SR to place it on silently; either choosing "Local Storage" or "<no suitable storage>" depending on the size requested relative to the SR sizes.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>

* CA-300384: Hooking into the warning mechanism of the storage grid to ensure that the user is aware that over-provisioning is occurring, but not block them from continuing.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-28 16:32:40 +00:00
Aaron Robson
602edd47d8 XOP-953: Cannot change dom0 memory via XenCenter (XC 7.5 RTM on XS 7.… (#2330)
CA-303516: Cannot change dom0 memory via XenCenter.
Allowing the user to proceed (not set the value and min/max to 0.0GB) even if the memory static min and max is in the wrong order.
Adding further detail to the error message in case an out of bounds value is sent to the API which could potentially happen due to the range widening that occurs if the min/max would invalidate the existing value.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-27 15:40:38 +00:00
Mihaela Stoica
6cd2e28754 CA-300760: Only create the action that moves a halted VM if there are actually disks that need to be moved
- with this change the user won't see the misleading "Moving VM to new storage" in History if they tried to move the VM inside the pool, but actually didn't select different SRs for the VM's disks.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-26 16:34:46 +00:00
Mihaela Stoica
8ab3ea2837 CA-300760: Allow intra-pool move of halted VMs through the wizard, even if the storage migration is not allowed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-26 16:34:46 +00:00
Mihaela Stoica
88ec36ae5f CA-300760: Allow VM intra-pool migration through the wizard, even if the storage migration is not allowed
- if a VM can migrate inside a pool, then we will allow it in the wizard, even if storage migration is not allowed
- If it is a intra-pool migration (without moving the disks), then use the VM migrate action (which does a VM.pool_migrate), not the cross pool migrate action.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-26 16:34:46 +00:00
Konstantina Chremmou
ff708345fa Added functionality allowing renaming of folders. Fixed issue where the form
closed on double-clicking on the node expanded icon. Some improvement in the
use of the folder name prompt dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-26 10:29:39 +00:00
Konstantina Chremmou
16c88cc7b7 CA-302791: Rewrote the ChangeFolder dialog to fix usability issues.
- Corrected folder selection; reduced clicks required to select folders;
  improved text; added delete button.
- Moved FolderChangeDialogTreeView to the same folder as the other TreeViews;
- Added missing null checks to the MutliSelectTreeView and hid properties
  HScrollPos and VScrollPos from VS's designer (the former was initialised
  to zero every time the designer was updated, causing the treeview images
  to disappear).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-26 10:29:39 +00:00
Darren Matthews
97b847ffa6 L10N : Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-11-22 23:48:28 +00:00
Mihaela Stoica
306b0b043b CP-29779: Handle VM_SECURE_BOOT_FAILED alerts in XenCenter
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-22 23:44:07 +00:00
Konstantina Chremmou
243f3a209d CA-302807: Fixed issue where the server selection on the Patching wizard was
lost when leaving and returning back to the SelectServers page.
Also, the list of SelectedServers does not need to be re-evaluated every time
it is accessed but rather once when we move away from the page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-22 13:58:19 +00:00
Aaron Robson
c597b2f795 CP-290940: Dundee is the earliest version to support Automated Updates, show a Server up to date tooltip for Dundee and later, where there are no updates to perform.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-22 10:47:23 +00:00
Aaron Robson
6f847962ca CA-272847: Compilation time is way overestimated (when creating a ser… (#2316)
* CA-272847: Compilation time is way overestimated (when creating a server status report).

- As the times are made up of server timeouts they overestimate quite significantly, we are removing the time estimates from the screen.
- Do not mention being able to see the time that has been removed inside the explanatory label.
- Removing further unused Util functions LThanTime and GThanTime.
- Redone the layout with the privacy link on a separate row to avoid wrapping at smaller sizes and to even up the layout of the Select/Clear buttons with the Total Size label.
- Fixed the tab indexes and removed the invisible Split Container.
- Adjusted the blurb margins to our default and set the last row with the privacy link to be AutoSize rather than absolute in case of truncation in other languages.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-19 12:27:31 +00:00
Aaron Robson
4af1f68fd6 CA-270440: Copy VM full copy SR list isn't sorted naturally. Resolving not just for SrPickerItem but for the CustomTreeNode as used for other related classes.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-16 15:11:34 +00:00
Mihaela Stoica
660eab5d99 CA-300759: When there is a GFS2 SR in the pool, VMs on local storage should still be allowed to be migrated to the local storage of another host.
When XenCenter checks if a VM can be storage-migrated (including in the same pool), it only checks if migration is possible to one SR (the first SR from the SR list  that supports vdi creation), which could be a GFS2 SR, where migration is not supported. With this fix, we will only consider the SRs which support migration (instead of vdi creation).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-16 11:50:12 +00:00
Aaron Robson
7122615836 CA-271967: Dismiss button is flat after dismissing first of a list of events.
Handling OnMouseMove which fires more repeatedly than OnMouseEnter and OnMouseLeave with an early return to preserve CPU efficiency.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-16 11:14:21 +00:00
Tim Liu
0377db7be0 CA-301156: VM created from disk import for a UEFI VM has missing values (#2311)
* CA-301156: VM created from disk import for a UEFI VM has missing values

Set default params when importing VHD

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-11-16 10:03:18 +00:00
Konstantina Chremmou
3f64c26d87 Added .vs and .vscode to .gitignore. Reverted control subtype change introduced
inadvertently with commit c1256c7734 before the
issue was fixed in commit 2a575b01a5.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-13 11:08:10 +00:00
Konstantina Chremmou
f5174e5bfe Fixed issue where the patching wizard offered to re-apply an already applied
update if the user selected it from the disk.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-13 11:08:10 +00:00
Konstantina Chremmou
b7fd97af11 Removed obsolete UpdateType.Existing and associated properties and methods.
Also, simplified the logic selecting the single update when we leave the
SelectPatchPage so as to avoid ambiguities in which properties are to be set
and refactored the error handling methods to avoid duplicate checks and
provide the right error message (for example, the error message was misleading
for a non-existent path; or, the level of detail provided in the case of
invalid zip content was of lesser relevance to the user).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-13 11:08:10 +00:00
Konstantina Chremmou
67cc929f91 Fixed crash occurring on closing the PatchingWizard if the user uploaded a
legacy patch and then went back to select and install an update.

The code was removing all the uploaded legacy patches except the installed
ones. In this case the installed legacy patch is null hence all the already
uploaded patches need to be removed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-13 11:08:10 +00:00
Darren Matthews
599d4ea7df L10N: Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-11-12 10:29:10 +00:00
Konstantina Chremmou
2a575b01a5 Fixed issue whereby VS kept toggling between SubType Component and User Control
for some custom controls.

In the case of DoubleBufferedPanel I removed the Designer attributes from
the class definition.
In the case of the EnableableComboBoxEditingControl I moved it to a new
file because the other classes it was sharing the old file with did not
derive from Component.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-09 16:23:29 +00:00
Konstantina Chremmou
c1256c7734 Removed redundant code from GradientPanel and made it more object oriented;
also moved it out of the containing folder as it was its only resident.
Corrected the TitleBar fore colour as it was hard to read due to small contrast
with the bar's backround colour; normalised the code setting the other colours
so it's more unambiguous.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-09 16:20:52 +00:00
Aaron Robson
c4c216a1d1 CA-271945: Close active Wizards when unwinding the Host Maintenance Mode action regardless of if the server is unable to be resolved.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-09 13:53:39 +00:00
Aaron Robson
a78a754ddd CA-271945: Ensuring that the name of the VM is as up to date as possible when creating the name of AutoStart unwind action.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-09 13:53:39 +00:00
Aaron Robson
7accaadb26 CA-271945: Attempting to resolve the pool's connection and searching for it in all open connections for the EnableHAAction in case a host has been destroyed or the master changed.
Preventing an Object (host) has been deleted error when attempting to reenable Maintenance Mode on a Host that has been kicked out of the pool when exiting the RPU Wizard.
Returning null to prevent making orphened tasks that will be stuck at 0% completion if it is impossible to fulfill.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-09 13:53:39 +00:00
Aaron Robson
6353043b15 CP-27819: Switch to Visual Studio 2017 (into master) (#2305)
* CP-27819: Manually setting the ToolsVersion to 15.0 (VS2017) in all .csproj files for consistency and to attempt to enforce consistency of dev environments with the explicitness of the msbuild scripts as used in the build environments.
Auto updated as many of the .sln and .csproj files as VS2017 was willing to do https://docs.microsoft.com/en-us/visualstudio/ide/reference/upgrade-devenv-exe?view=vs-2017 and included changes to the gitignore to ensure that the update report and backup files are not included in the repo.

* CP-27819: Tidying up by removing FileUpgradeFlags, OldToolsVersion and UpgradeBackupLocation nodes from the .csproj files as they are produced as hints for how to revert project upgrades for which we can use version control.

* CP-27819: Removing redundant "ManifestCertificateThumbprint" and "ManifestTimestampUrl" nodes from project files "mk\sign.bat" has been used for this purpose for some time now.

* CP-27819: Updated readme to reflect that VS2017 is now in use.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-09 11:23:32 +00:00
Aaron Robson
f95f094e60 CA-172658: Descriptive error message when failing to suspend a VM fro… (#2275)
* CA-172658: Descriptive error message when failing to suspend a VM f om XenCenter.
Checking if a VM has a pass-through GPU or a vGPU assigned and showing the reason in dialog and tooltip.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-08 22:27:59 +00:00
Joey
6d2c3541f5 CP-29768: Add Skip functionality for RPU supp pack installation (#2283)
* CP-29768: Add Skip functionality for RPU supp pack installation

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>

* Minor corrections

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* Revert unnecessary layout changes

Also changed the title of the confirmation dialog to the wizard title, as it could be shown in either RPU or the Patching wizard

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-11-07 18:07:53 +02:00
Aaron Robson
4a70c32786 CA-301193: XenCenter UI looks ugly after installation of latest Win10 CU update (#2296)
* CA-301193: Avoiding calling ProfessionalColors before we have called Application.EnableVisualStyles as it causes visual styles to be prevented from being enabled and can prevent the program from displayed as expected as the value of Application.InitializeComCtlSupportsVisualStyles is found only one time when first needed and cached. If Application.useVisualStyles is not true as in this case it relies on calling "comctl32.dll" methods to determine if this is the case and after KB4462933 this is no longer the case.
* CA-301193: Setting the TitleBarStartColor and TitleBarEndColor to the ProfessionalColors values.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-04 00:14:59 +00:00
Alexander Schulz
fe924cddbf Use local timestamps for run history 2018-11-02 12:03:56 +00:00
Konstantina Chremmou
9751de6d5e Fixed crash occurring when the user selected a single legacy patch, moved to
the Prechecks page, then back to select a single iso update, and forwards again
to the Prechecks page. The cause was that the values of Patch and PoolUpdate
were not always propagated from the Upload page to the following pages, hence
on that occasion they were both non-null, while the logic of the following
pages expects only one of the two to be non-null.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-01 13:12:09 +02:00
Konstantina Chremmou
3e0a958783 Removed accessors that were set but never used. Removed unused constructors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-01 13:12:09 +02:00
Konstantina Chremmou
e63ca825e4 Fixed crash caused by code redundancy.
One of the PatchGridViewRow constructors was obsoleted, hence the _image and
_status cells and the row's PathPatch were always null. When a user selected a
patch, moved to the Prechecks page, back to the Select page, and the host got
disconnected, on moving to the SelectServers page and closing the warning pop-up,
XenCenter crashed because it was trying to update details of null cells. Also,
removed obsoleted toggling expanded state functionality.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-01 13:12:09 +02:00
Konstantina Chremmou
8b107c86e8 Renamed UpdateType NewRetail to Legacy.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-01 13:12:09 +02:00
Konstantina Chremmou
fc98eed16b CA-237915: When one attempts logging oneself out, warn them if there are outstanding actions.
For this purpose, call the DisconnectCommand instead of session.logout_subject_identifier.
Also:
- Add the new actions to the History synchronously on the main thread,
otherwise the warning dialog may not detect in time the new actions.
- Although the local root account is currently first in the list, checking whether
the first item is selected is a fragile way of establishing whether the local
root account is selected. Check the row's IsLocalRootRow property as in the
rest of the file.
- Added username detail to the logout action; fixed typo in message key.
- Some minor refactoring to make the code more efficient.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-01 12:52:07 +02:00
Konstantina Chremmou
80608f971c CP-27924: Require RPU004 when upgrading from kolkata servers (RPU004 is unchanged).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-01 12:08:56 +02:00
Darren Matthews
1a74fd440f L10N: Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-29 12:01:08 +00:00
Konstantina Chremmou
e9b598e3ba CA-209495: Layout correction on exit VM full screen tip.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-26 13:39:13 +03:00
Konstantina Chremmou
fdb9cb4743 CA-235084, CA-235085: Layout corrections on the host and VM memory panels.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-26 13:39:13 +03:00
Darren Matthews
c8ff108fef L10N: Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-25 09:32:42 +01:00
Aaron Robson
1e7b99c5c3 CA-299065: Duplicate host name in error message resolving in the Patching Wizard as well.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-24 14:25:24 +01:00
Aaron Robson
1a0a1f6359 CA-299065: Duplicate host name in error message in the RPU and Patching wizards. 2018-10-24 14:25:24 +01:00
Konstantina Chremmou
5b79b1dc94 Removed the label from the SrPicker because in half of the occasions it was
hidden and in all other cases it was set by the implementing control, i.e.
the label was not reusable, hence no reason to have it in the control and risk
layout issues. This means that the SrPicker does not need to be a control
encapsulating a CustomTreeVIew, but simply derive from the latter.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
f1d5abb7a5 Replaced duplicate events ItemSelectionNull and ItemSelectionNotNull with SrSelectionChanged.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
0fe584cdba Removed unnecessary method and replaced it with the field it returns.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
0eef02fc3b Removed redundant code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Aaron Robson
312ed10b80 CA-293814: If there are no VMs running, immediately start entering Ma… (#2253)
* CA-293814: If there are no VMs running, entering Maintenance Mode without showing Dialog.

* CA-293814: Refreshing the view after shortcutting entering the mainenance view (no running VMs so no window shown) in the same way as the rest of the updates are managed.
Please see: https://github.com/xenserver/xenadmin/pull/2264

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-24 11:42:13 +01:00
Aaron Robson
97cd8286b9 CA-203431: Host name is repeated twice in multipathing alert message in XC (#2272)
* CA-203431: Removed prefix comma and space from the start of the list of hosts in the multipathing alert message.

* CA-203431: Removed duplicate Host names from multipathing alert message.

* CA-203431: Unit tests for MessageAlert.FindHostUuids with tweaks to allow it to handle a null input as if it was an empty enumeration.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-23 14:50:28 +01:00
Aaron Robson
1ef23f393f CA-298921: End of error message in XenCenter is cut off when failed t… (#2273)
* CA-298921: End of error message in XenCenter is cut off when failed to start VM, word wrapping on the Reason column (and top aligning the other columns) for consistency.

* CA-298921: Adjusted the padding of the icon.

* CA-298921: Removed null Bitmap from .resx.

* CA-298921: Resolving text alignment issues with single line (i.e. short) Reasons.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-23 13:06:02 +01:00
Aaron Robson
525034d233 CP-14807: Delete OEM in ServerVersion (#2270)
* CP-14807: Delete OEM in ServerVersion

* CP-14807: Removing unused IgnorePatchAction and IgnoreServerAction classes (moving their constants to the Updates class).

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-22 14:34:31 +01:00
Konstantina Chremmou
e8ff04d671 Removed HostMaintenanceModeCheck; simplified logic by having the HostLivenessCheck
verify, if required, whether the host is enabled.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-22 14:23:29 +01:00
Konstantina Chremmou
0d0aa34f37 CA-299356: If there are any broken SRs, show all of them when running prechecks
instead of finishing the precheck after the first one is found.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-22 14:23:29 +01:00
Mihaela Stoica
8c5e08294c CA-299946: Resolve the VM before locking it
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-10-22 13:46:03 +01:00
Darren Matthews
176624e029 L10N: Translation updates and resx sync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-21 13:53:09 +01:00
Aaron Robson
fbb8864a51
Merge pull request #2276 from xenserver/master
Merge master into feature branch
2018-10-18 15:08:54 +01:00
Konstantina Chremmou
90589a30c9 Modified treeview and toolbar updates (#2264)
This PR is aimimg to (1) fix a regression introduced by #2223 whereby the toolbar items did not have the correct state on first launch; (2) improve performance by removing some updates which I believe are not needed.

* Removed some duplicate calls to RefershTreeView and UpdateToolbars because
they are called within the action's Complete event handler.
Also, normalise the way the treeview refresh is requested by the various actions the
commands are launching.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Removed some explicit calls to refresh the treeview since this is done by
the connection result handlers.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* The toolbars and tabs should be updated every time the treeview is refreshed.

This should happen when the refresh event is handled rather than calling
UpdateToolbars explicitly after a treeview refresh is requested; also, it is
the treeview refreshes that should be throttled and not the toolbar and
tab updates (the throttling mechanism may need correction).
Also, removed unnecessary Invoke as we are already on the UI thread.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Simplified UpdateManager.Update event declaration.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-16 16:24:54 +01:00
Mihaela Stoica
01e8e3feed
Merge pull request #2251 from kc284/disk
CA-289948: allow VDI of a stopped VM to be moved on unlicensed pools
2018-10-16 13:27:36 +01:00
Darren Matthews
5645cb9596 L10N: resx sync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-16 12:38:36 +01:00
Aaron Robson
d8a2c9b82e CP-29657: Create message for HOST_LOW_MEMORY in XenCenter. (#2263)
* CP-29657: Create message for HOST_LOW_MEMORY in XenCenter.
Includes an update to the latest XenModel API.

* CP-29657: Included rebuilt FriendlyErrorNames designer.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-15 09:51:58 +01:00
Konstantina Chremmou
2b9bc8e3b6 Renamed resource to fix Visual Studio warning. Stop copying stray images into
the build output folder and removed one of them as it's now unused. Included
some left out images into the project. Updated README.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-15 09:44:06 +01:00
Konstantina Chremmou
c0af621167 A couple of random corrrections on error handling (#2265)
* Correct out of range percentage and throw an assertion instead of silently
logging it so we can fix the causes of it. Compacted method logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Exception handling: prevent InvalidOperationException if the health check service
is not found on the computer (installation is optional).
Do not throw exception and handle if the task handle is invalid, but rather
throw it only for other cases of task.status being failure.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-12 13:36:44 +01:00
Darren Matthews
877f656d15 L10N: Translations updates (#2258)
* L10N: Translations updates
* L10N : Updated Ja homepage link

Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-11 10:41:58 +01:00
=
e62096da26 CP-29106: XenCenter should disable the automatic check of VDIs
integrity and scare the user if it is turned on.

Signed-off-by: Gerald Elder-Vass <gerald.elder-vass@citrix.com>
2018-10-11 08:13:56 +01:00
Darren Matthews
a8e03537a5 L10N : Translation updates and ReSync resx files
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-09 12:26:51 +01:00
Mihaela Stoica
4a9f2c1c11 Update credits
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-10-09 12:19:54 +01:00
Aaron Robson
6517403aa2 [aaf84eec] CA-298693: Using enum for memorymode to replace magic numbers.
Refactoring the memory spinner visibility logic for clarity in the New VM wizard.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-09 11:44:25 +01:00
Aaron Robson
3bd0a489f2 CA-298693: Going back to the Template tab of the NewVM wizard should not cause a different template to be selected, even if the template was selected outside of the form it should only initially set it.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-09 11:44:25 +01:00
Aaron Robson
edbf616ef8 CA-298693: Making the Static Maximum visible explicitly (with memory mode of 3) in the New VM wizard.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-09 11:44:25 +01:00
Darren Matthews
5fd030d873 L10N: Translation Updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-08 13:08:41 +01:00
Konstantina Chremmou
f2a45442f8 CA-208682: Some layout corrections to make localisation for the CertificateChangedDialog
easier. Also, launch dialogs within a using block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 13:06:40 +01:00
Konstantina Chremmou
ca0f4ce1d4 CA-238884: Some layout corrections to ease localisation for the PvsPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 13:06:40 +01:00
Aaron Robson
c1c368070a CA-299063: Prevent the Network Interfaces from disappearing when the VM is Locked due to a Storage Deveice being deleted.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-08 12:59:55 +01:00
Konstantina Chremmou
9bd27f8915 Minor layout corrections and button reordering on the storage tab for VMs,
Hosts, and SRs, so that all three tab pages look the same.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 12:33:05 +01:00
Konstantina Chremmou
988db0cbba Separated the MoveVirtualDiskDialog from the MigrateVirtualDiskDialog so it
is easier to understand which one is called from which command.
Removed superfluous TableLayoutPanel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 12:33:04 +01:00
Konstantina Chremmou
b6420b6c12 CA-289948: If migration of individual VDIs is not allowed due to licensing restrictions,
do not show the upsell dialog; the user should be able to move the VDIs without
having to detach them first.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 12:33:04 +01:00
Ji Jiang
6a421173cc CP-29276: Implement update/supp pack application in RPU wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-10-08 12:32:01 +01:00
Ji Jiang
539d1850d0 CA-298913 + CA-297215: Fix KeyNotFoundException
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-10-08 11:12:50 +01:00
Konstantina Chremmou
2c328c086d Homogenised error handling in Invoke functions.
Renamed method IsExiting to IsInvokable to better describe its contents.
Added null check in it (previously only one of the four Invoke methods was
checking for null).
Added null check when we set the TestExceptionString in automated test mode.
Added logging to exception handling.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
e2d828a33b Removed some redundant code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
9236bbc0e3 CA-298592: Check the licenseStatus is not null when accessing its properties.
There can be cases when we have logged in a session, events are fired
causing the tab pages to be refreshed, however we may abort the connection,
for example, due to brand mismatch. In this case the licenseStatus has not
been initialized, however the refreshing general tab tries to access its
properties resulting to a crash.
Also some method tidy up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
c3fcffa236 When we end the connection call OnConnectionClosed instead of OnConnectionStateChanged.
This avoids firing the ConnectionClosed event explicitly after EndConnect;
it also avoids refreshing explicitly the tree as the main Window handles the
ConnectionClosed event which requests a refresh.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
be0176afe0 When the connection is refused, create the failed action before showing the
pop-up, otherwise the UX is slightly strange if the failure appears on the
status bar only after the user has closed the pop-up.
Also, improved failure message shown on the History page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
7e6f0bb10c Removed explicit call of UpdateToolbars immediately after the first RequestRefreshTreeView.
Due to the delay interval between refreshes, this UpdateTolbars was called
before any root nodes were added to the tree, hence the only new tab to
add was Search, which got selected  (previously this did not happen,
because it was taken for granted that the root node was added by the constructor).
Immediately afterwards the treeview was refreshed, the root node was selected and the
home page was added, but the selected Search tab was erroneously preserved.
Also removed extra RequestRefreshTreeView because the tree will be refreshed,
if required, by the handlers of the connection events.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
968701cf8e Removed property MenuShortcuts in favour of MenuShortcutsEnabled.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
edea57ebf3 Simplified the logic updating the TabPages.
- The new logic of adding/removing tabs in the ChangeToNewTabs method also fixes
  tab-title flickering when we move from the Home node to a disconnected host.
- Renamed enum members Tab.Overview to Tab.Search and Tab.Settings to Tab.General
  since the pages mapped to them are TabPageSearch and TabPageGeneral respectively.
- Do not call directly UpdateToolbarsCore but rather UpdateToolbars since the
  latter takes account of the queued requested updates.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
b267007bdc Unused code removal; designer tidy up.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
194cd18ea3 Do not construct certain members if we are in Visual Studio's designer mode
because they crash the designer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
fb40cb7a5a Hide properties which should not be serialised by the Visual Studio designer.
Minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
fa1cf41d5b No need to add nodes to the treeview in the constructor (which also means at design time);
PersistExpandNodes should not take for granted that the treeview always has nodes.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Ji Jiang
c31778c3fe CA-298913 CA-297215: Fix restartHost and restartXapi bugs after patching
With this change, following are working:
1) After applying XS75E003-5 only restart host, no restart toolstack
2) After applying vGPU driver on 7.4, restart host happens

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-10-05 15:45:05 +01:00
Konstantina Chremmou
a7c628b9ae Fixed issues with showing the correct licence for a host/pool on the main window and general tab.
- When the host/pool was disconnected or when changing selection from connected to disconnected pool
the header was not updated with the new licence status.
- If the pool hosts' edition is none of the known editions, show unknown, not free.
- Tidy up: moved the Pool.LicenseString method to Helpers.GetFriendlyLicenseName.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-05 15:16:12 +01:00
Mihaela Stoica
02075486ba
Merge pull request #2237 from xenserver/feature/REQ-488
Merge branch feature/REQ-488 into master
2018-10-05 09:41:21 +01:00
Aaron Robson
a6d1ad9bfa CA-297666: Wait for host to become enabled before resuming a VM in the patching wizard. (#2233)
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-04 13:55:50 +01:00
Konstantina Chremmou
cf49ee9063 CA-299064: Fixed wrong image size and tooltip typo.
Also, removed unnecessary comments from index.html because they were making
the file illegible. Included new logo in the project file.
Added localised html files so we can generate the mht files from them
(localisation should not happen in the mht files, but rather in the source html).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-04 10:17:37 +01:00
Aaron Robson
ca1113fbcc CA-287643: Replaced list view with data grid view to resolve column sizing issue and for consistency with the rest of the product. (#2226)
CA-287643: Replaced list view with data grid view to resolve column sizing issue and for consistency with the rest of the product.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-02 10:18:34 +01:00
Darren Matthews
2ce509efb3 L10N: Translation updates along with Interface resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-28 14:00:14 +01:00
Aaron Robson
4a62f3ee90 CP-29474: Working through deleting or updating the last of the HelpIDs into sensible help links. (#2231)
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-09-28 10:01:33 +01:00
Konstantina Chremmou
3f2ddb854a Since the ConfigureHA button is used both enablement and editing HA, we don't
need an EnableHA button which additionally appears greyed out while HA is being
enabled. While an HA action is in progress we should only change the enabled
status of the already visible buttons.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-27 12:43:04 +01:00
Darren Matthews
47be1b0ecf L10N: CA-294292 resync Japanese and Chinese files. Truncation issues fixed.
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-27 12:43:04 +01:00
Konstantina Chremmou
2b83de433d CA-294292: Layout modifications to fix error message truncation issues.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-27 12:43:04 +01:00
Aaron Robson
2f497e1053 CA-294286: New VM memory limitations shown
Added labels showing the VM memory limits posed by the template.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-09-26 11:06:24 +01:00
Konstantina Chremmou
95cd300e61 CA-210190 Memory spinner: removed the label so it's easier to align
the spinner with the surrounding controls on a parent control/form.
Also, removed the icon from the spinner because in the
majority of implementations it was invisible and the extra space was just
complicating the alignment of the surrounding controls.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-26 11:06:24 +01:00
Aaron Robson
a36d16ebcd CP-29474: Use online help (#2229)
* Using web help instead of local Proof of Concept working.
Please note that some of the HelpIDs in the HelpManager had a mapping to the web page name.
Some are not used anymore, but they should be checked.

* Removing the help files (.chm) from the project, will require changes to the installer scripts.

* Setting the locale in the HELP_URL.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-09-25 16:31:31 +01:00
Konstantina Chremmou
1d7008beab
Merge pull request #2227 from xenserver/feature/REQ-680
REQ-680: Rebranding XenServer to Citrix Hypervisor
2018-09-21 00:28:44 +01:00
Michael Z
40197ae2d0 REQ-680: Fix auto-merge errors.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-20 22:41:11 +08:00
Darren Matthews
2ae91f85e2 L10N: Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-19 10:52:23 +01:00
Mihaela Stoica
8998e88255 CA-297216: Remove the unused class and control
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-09-18 15:33:53 +01:00
Mihaela Stoica
592b110f06 CA-297216: Remove the upsell message from the memory tab and disable the DMC settings for VMs in the "Memory Setting" dialog if the server is not licensed.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-09-18 15:33:53 +01:00
Michael Z
9034c5a57a REQ-680: Merge master to feature branch.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-17 20:00:30 +10:00
Konstantina Chremmou
04b37092a6 CA-297020: Do not download imported appliance on a modal dialog (#2200)
* CA-297020: Do not download imported appliance on a modal dialog, but rather
asynchronously on the ImportSourcePage, so that the rest of XenCenter is usable
while the download is taking place; used the page's progress bar for this purpose
and removed the DownloadApplianceDialog.

* Corrections to the validation of the import source.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-14 15:55:05 +01:00
Michael Z
5e37264185 CA-297617: Change Citrix Hypervisor Tools to Citrix VM Tools.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-14 15:54:04 +01:00
Darren Matthews
fa5dd85c52 L10N: Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-13 11:40:50 +01:00
Michael Z
816bd0601a CP-29230: Switch between new and legacy license names according to server version.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-13 10:39:14 +01:00
Michael Z
31b38796db CP-29230: Replace Enterprise with Premium, Free with Express.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-13 10:39:14 +01:00
Darren Matthews
99d0c6ed88 L10N : CA-294333 fixed with resx resync. Translation updates. (#2215)
* L10N: Translation and resx resync
* L10N: CA-294333 Overlap Issue fixed in redesign.

Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-12 23:44:16 +01:00
Ji Jiang
4896b89bb6 CA-289189: Add sole PIF name changing action
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-09-12 23:42:11 +01:00
Konstantina Chremmou
c35a8f739d CA-294333: NewPolicySnapshotPage corrections + small checkbox bug (#2199)
* CA-294333: NewPolicySnapshotPage corrections.
- Fixed layout and accessibility of controls.
- Changed clickable info icons to normal icon+text info panels because they
are used more widely across XenCenter and the user does not need extra clicks
to access the information.
- Fixed bug where two clicks were required to check the quiescing checkbox
if the Disk and Memory radio was selected.

* Minor layout correction.

* Removed some obsolete code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-12 09:22:03 +01:00
Darren Matthews
d17dedc3fd L10N: CA-286950 Fixed truncation issue in Japanese and Chinese languages. Provide additional fix to the Chinese resource file.
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-11 11:15:30 +01:00
Konstantina Chremmou
90183251d8 CA-297088: Fixed issue where XenCenter froze if a new server was added while
we were on the select host page of the Import and Migration Wizards.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-05 13:31:19 +01:00
Konstantina Chremmou
b634988c69 CA-297087: Fixed crash occurring when launching the Import Wizard without
having preselected a connection on the treeview. Also added a null check to
prevent crash if the connection is suddenly interrupted while moving away
from the select destination host page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-31 17:58:37 +01:00
Tim Liu
685a53bc22 CP-28679: XC: Allow choosing boot options during disk import (#2203)
* CP-28679: XC: Allow choosing boot options during disk import

Signed-off-by: Tim Liu <tim.liu@citrix.com>

* CP-28679: XC: Allow choosing boot options during disk import

1. Keep spaces instead of tabs
2. Update page header text to reflect the new control
3. Refine UI

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-31 02:02:33 +01:00
Konstantina Chremmou
a1033de3a4
Merge pull request #2206 from xenserver/master
Merging from master into feature/REQ-396 to fix broken tests
2018-08-29 15:17:44 +01:00
Konstantina Chremmou
ad773d8f75 Fixed null reference exception in tests.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-29 10:25:47 +01:00
Michael Z
4e60915f3c CP-29280: Replace XenServer logo.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-08-29 08:16:56 +01:00
Tim Liu
2cc5b1f0b6 CP-28676: XC: Allow choosing boot options during new VM wizard
1. Make controls auto sizable
2. Change hotkey
3. Rename variable

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-28 12:46:36 +01:00
Tim Liu
f0b1e6b3af CP-28676: XC: Allow choosing boot options during new VM wizard
1. Update the duplicated shortcuts on CPU&Mem Page
2. Default radio boxes invisible
3. Move hardcoded logic to VM.cs
4. BIOS boot should be always enabled
5. Move radio boxes to Installation Media page
6. Extract radio boxes as a user control
7. Update summary

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-28 12:46:36 +01:00
Tim Liu
98207906d7 CP-28676: XC: Allow choosing boot options during new VM wizard
Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-28 12:46:36 +01:00
Weiwei You
1ed70d2233 CP-28915: Add HavanaOrGreater method
Signed-off-by: Weiwei You <weiwei.you@citrix.com>
2018-08-24 12:12:28 +01:00
Darren Matthews
f7859a1596 L10N: Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-23 08:41:13 +01:00
Darren Matthews
0e7057d067 L10N: Translation updates and Re-Sync JA & CN resx files to match the new English resx
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-22 09:02:08 +01:00
Darren Matthews
fc7ec88fd4 L10N: CA-294333 fixed overlap issue in JA resource file
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-22 09:02:08 +01:00
Tim Liu
d432cf5477 CA-293776: The order in which a single update is applied on the slave… (#2180)
* CA-293776: The order in which a single update is applied on the slaves is not the same as the order in which they are displayed

Apply the same Hosts sorting rules for all the PatchingWizard Pages .

Signed-off-by: Tim Liu <tim.liu@citrix.com>

* CA-293776: The order in which a single update is applied on the slaves is not the same as the order in which they are displayed

Place orderby clause after where clause

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-20 15:46:58 +01:00
Konstantina Chremmou
b36534c157 CA-293813: Patch pools in parallel when installing a single update/patch or supplemental package. (#2183)
* CA-293813: Patch pools in parallel when installing a single update/patch or supplemental package.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Corrections as per code review.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 12:05:16 +01:00
Konstantina Chremmou
542da6487c Removed call to empty base method. Added erroneously removed comma.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 08:23:04 +01:00
Konstantina Chremmou
1c2845697c Fixed tab order; renamed the radio buttons because it was difficult to tell what each one referred to.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 08:23:04 +01:00
Konstantina Chremmou
6885c21b5e Removed unnecessary control VMMemoryControlsBase and moved the logic of the VMs
property to the derived classes (they don't share much of it anyway) and the method
CalcMemoryUsed to the VMShinyBar class where it is needed. Also made the latter's
property Increment non-browsable.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 08:23:04 +01:00
Konstantina Chremmou
c67f85ebaa CA-210190: Fixed various layout and truncation issues on the VM/template memory
setting controls. Also removed the various types of ballooning dialogs since
the only thing changing was the contained memory settings control.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 08:23:04 +01:00
Konstantina Chremmou
9b61298113 Added hotkeys; fixed tab order; fixed flickering of warning message on first load.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-16 14:09:36 +01:00
Mihaela Stoica
e21c26be67 CA-271864: Add the missing setter
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-16 11:38:34 +01:00
Mihaela Stoica
20dfd74375 CA-271864: Add the host name to the precheck problem description for more Problem classes.
Also changed two classes to inherit from the VMProblem class.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-16 11:38:34 +01:00
Mihaela Stoica
8b2ab5f79d Removed some unused classes and messages
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-16 11:38:34 +01:00
Mihaela Stoica
5879b5ae60 CA-271864: Add the host name to the precheck failure when the VM cannot be evacuated.
The other part of this ticket (add OTHER_OPERATION_IN_PROGRESS to the known errors) has already been done in commit 97a60c91.
Minor refactoring to the VMProblem class.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-16 11:38:34 +01:00
Konstantina Chremmou
c8c2ea448a CA-156828: Do not uncompress imported appliance on a modal dialog, but rather
asynchronously on the SelectImportSourcePage, so that the rest of XenCenter
is usable while the unzip is taking place; for this purpose a progress bar
was added on the page and the DecompressApplianceDialog was removed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-16 10:59:35 +01:00
serenc
1b0338d36b CP-28926: Add additional error message for >2TB VDIs
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-08-15 10:02:15 +01:00
Michael Z
96837cd425 Replace a wrong logo image.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-08-15 10:00:44 +01:00
Konstantina Chremmou
a918a0b0c8 The method UpdateToolbarsCore should be private. Do not call it explicitly; it is
called by the PluginsChanged event handler.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
c270882737 Improved previous commit to avoid setting the TabPageFeature Urls when switching
from this an object with selected TabPageFeature to a different object with a
deselected TabPageFeature.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
abec5c4aba CA-284090: Added a dedicated status bar on the TabPageFeature to resemble real
life browsers and allow the user to see the status even if other actions are taking
place. Removed webClient use from the browser; instead try sequentially to navigate
to all Uris until one succeeds; this avoids sending duplicate requests and allows
the user to see all endpoints tried out. Reworked the WebBrowser event handlers
to ensure the UI reflects correctly the browser state.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
07f298096f CA-284090: Refactored the code setting the object in the TabePageFeatures to avoid
multiple iterations as well as updating the feature when it's not needed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
d67dd1c815 Do not create a Uri if there are no IPs as it throws exception unnecessarily; Return
about:blank instead. Removed parameter null check as it is done by PlaceholderRegex.Replace.
Minor tidy up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
3de03f32d3 Simplified retrieval of credentials from authentication prompt.
Placed TabPageCredentialsDialog controls on a TableLayout panel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
518951d868 Deregister events and dispose of web clients when removing them from the list.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
23975c5ee6 Updated event signature to use Action<T1,T2> instead of custom delegates.
Moved NavigateError- and AuthenticatinPromptEventArgs classes inside WebBrowser2
as they are only relevant to the latter class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
7494a712fb Re-arranged the class members to make the file easier to navigate and minimise scrolling up/down when developing.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Mihaela Stoica
034f472163 CA-286882: Check for page visibilty before calling HidePage
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-13 17:18:53 +01:00
Mihaela Stoica
56a3725b36 Corrected the title and description of VM lifecycle operations when run as Mulltiple/Parallel actions
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-13 17:18:53 +01:00
Mihaela Stoica
8230315f76 CA-286882: Shutting down large number of VMs causes XenCenter to hang
Created a new base class for the Notifications pages (Alerts, Updates, Events). This can be used in the future to host more of the common code between these pages. For now, it implements a common mechanism for showing/hiding the page and ensures that the event handlers are deregistered when the page is hidden (i.e. when the user switches to a different view) and registered again when the page becomes visible

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-13 17:18:53 +01:00
Konstantina Chremmou
f4d92da5ee CA-202377: Removed last instance of the QueuedBackgroundWorker and deleted the class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-13 17:04:27 +01:00
Konstantina Chremmou
78ecef617d Fixed issue where the agility calculation was run even for VMs that were not
actually added (because they can't be protected, e.g. the control domains).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-13 17:04:27 +01:00
Konstantina Chremmou
649e5a3483 Do not start updating the agility before reaching the corresponding page on the HAWizard.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-13 17:04:27 +01:00
Konstantina Chremmou
a68ca3beb2 Added tooltip on the Agility cell so the user can see the reason why the VM
is not agile simply by hovering over the cell. Previously the user could see
this only if they selected the VM, expanded the restart priority dropdown
and hovered over the Restart item.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-13 17:04:27 +01:00
Kat Shann
72562ba059 Lima Help Files (#2178)
* L10n: Inverness: build_chm #24
* Revert "L10n: Inverness": This reverts commit 8b41bb8c79cd4d73ed6021a5533cf7624a5421c4.
* L10n: Inverness: CHMs from build_chm master-l10n #24 Second attempt at checkin with a merge conflict resolve. (I hope)
* L10n: Localized files with fix: Remove artifacts introduced by XTM
* Update Kolkata Help files
* Update fro broken links fix
* CP-28648: Check -in the Lima versions of the CHM files

Signed-off-by: Katherine Shann <katherine.shann@citrix.com>
2018-08-13 11:42:06 +01:00
Konstantina Chremmou
b19d2fdeec CA-104539: Don't allow the user to make a pool into a standalone server if HA is enabled
or being enabled. Although the CLI allows it, it makes sense to disallow deleting the pool
when HA is on because XenCenter does not offer enabling HA if there is no pool there.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-10 09:50:31 +01:00
Konstantina Chremmou
0827d686ba Added hotkeys to ToolStriMenuItems and ellipsis (in reality only the iscsiToolStripMenuItem
launches a dialog requiring user input, but added it to fcToolStripMenuItem
too because it looks symmetric and in any case the user does have to close
an error pop-up if the scan fails). Also, do not show "no SRs found pop-up"
if the user cancels the IscsiDeviceConfigDialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-10 09:50:31 +01:00
Ji Jiang
d0fc3be56e CA-294091: Fix two Update wizards co-exist bug
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-08-07 12:02:57 +01:00
serencorbett1
cb26b4a259 CP-28926: Block export of VMs with >2TB disks in ova/ovf format (#2162)
CP-28926: Block export of VMs with >2TiB disks in ova/ovf format

Signed-off-by: serenc <seren.corbett@citrix.com>
2018-08-07 09:43:36 +01:00
serencorbett1
bf088cb944 CP-27825: Remove restriction on creating >2TB disk (#2160)
* Remove restriction on creating >2TB disk
* Changed restrictions for resizing VDI
* Removed old method and replaced it with direct calls to new method

Signed-off-by: serenc <seren.corbett@citrix.com>
2018-08-06 15:28:32 +01:00
Mihaela Stoica
61ee71dac1 CA-290536: Fix XenCenter uncaught exception in VM console when losing host connection
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-06 15:14:24 +01:00
Mihaela Stoica
b8168eed28 CA-292626: Consider the contains-livepatch flag of all the applicable… (#2165)
* CA-292626: Consider the contains-livepatch flag of all the applicable updates when doing the prechecks in the automated updates mode.

Instead of looking at the minimal patches, we look at all applicable patches for that host (i.e. all the updates on the host's version that are not already installed) and we say that the host won't need a reboot only if all these are marked as contains-livepatch.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-03 16:11:06 +01:00
timliu55
51ba3a82ce CA-293854: Patching wizard updates list loses selection and resizes c… (#2164)
* CA-293854: Patching wizard updates list loses selection and resizes columns when resorted
Remove the redundant code
Change the AutoSize mode from DisplayedCells to AllCells.
Fix the date column sorting
Disable column header AutoSizing

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-03 11:32:51 +01:00
liulinC
7be8bd0530 CA-204242: save the server status report blocks xencenter (#2158)
* CA-204242: save the server status report blocks xencenter

Signed-off-by: Lin Liu <lin.liu@citrix.com>
2018-08-03 09:08:47 +01:00