Commit Graph

5630 Commits

Author SHA1 Message Date
Konstantina Chremmou
667848fef3 CA-329686: Do not fail the import if calling a hard shutdown on the fixed up VM fails; the VM may already be halted.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-11 11:46:21 +00:00
Mihaela Stoica
01b011c982 CA-329399: Improve the error message displayed if the update wizard if a host cannot be evacuated.
If a host cannot be evacuated because other hosts in the pool are maintenance mode and pending a reboot following an update installation, then include instructions to reboot those hosts and then press Retry.
Also updated the text for the Manual mode, removing the reference to installing other updates and doing a reboot manually at the end, because that won't be always possible, due to the fact that now we put the hosts in maintenance mode before installing the update.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-11-08 10:27:49 +00:00
Konstantina Chremmou
4a8507fd86 CA-330394: Fixed issue whereby queued conversions had a start time in future.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-08 09:24:06 +00:00
Lin Liu
eb309a1af2 CA-329435: Multiple vGPU settings are not preserved when importing OVA/OVF format file
Signed-off-by: Lin Liu <lin.liu@citrix.com>
2019-11-07 09:49:54 +00:00
Konstantina Chremmou
8d006affe7 CA-329687: Fixed verification code error.
Do not leave out bytes if the number read is odd, which can happen if the file is smaller than the buffer used.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-05 10:21:55 +00:00
Mihaela Stoica
16eb52eba3 Sort Messages.resx
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-11-01 15:14:24 +00:00
Mihaela Stoica
326e4d8fe8 CA-329695: Restrict switching the boot mode in the New VM wizard (when created from template or snapshot)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-11-01 15:14:24 +00:00
Konstantina Chremmou
56b3990875 CA-329838: Do not reload the last wizard page when hitting the finish button.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-01 11:00:46 +00:00
Konstantina Chremmou
5d8b0f685f Corrected spelling to match the docs. Use en-us spelling.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-30 11:41:44 +00:00
Konstantina Chremmou
dcaf527757 CA-293784: Path and message updates.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-30 11:41:44 +00:00
Konstantina Chremmou
7cc42fe2ee CA-329317: When migrating a VDI do not enable target SRs that do not allow mirroring.
- Compacted code deciding whether to show an SR on the picker.
- Removed code sorting the disabled SRs because it repeats partially the
SR checks without reflecting exactly the disabled reason and probably
causes confusion when compared with the main treeview.
- Renamed property.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-25 10:07:06 +01:00
Konstantina Chremmou
94beeb8f28 CA-329436: Prevent OVF import from crashing when the HardwareVirtualSection>System section lacks a VirtualSystemType tag.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-24 09:19:22 +01:00
Mihaela Stoica
7b28e9e8a4 CA-328060: Set a limit of 1 MB to the VNC clipboard buffer
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-10-21 13:55:20 +01:00
Darren Matthews
01764e8972 L10N: Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-10-21 13:53:59 +01:00
Mihaela Stoica
c0c491c7d0 CP-29522: Fix unit test
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-10-18 10:18:31 +01:00
Mihaela Stoica
32981d24f1 CP-32254: Add DMC deprecation banner
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-10-18 10:04:51 +01:00
Xueqing Zhang
4dacede64b CP-32033 Add PV guests precheck in Xencenter
Signed-off-by: Xueqing Zhang <Xueqing.Zhang@citrix.com>
2019-10-18 09:56:21 +01:00
Konstantina Chremmou
ce958e5999 Corrected message and tab indices.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
d013c21f27 Further corrections to the DiskSpinner's rounding behaviour.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
f39a715816 CP-29522, CA-302477: Added TB option to the NumericUpdown of the NewDiskDialog and fixed validation on the VDISizeLocationPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
73eaed6af8 Fixed some issues around the validation of SrPicker selections.
- Fixed button enablement on the IntraPoolCopy page.
- Regression on the NewDiskDialog were selection was considered valid
even if the SR was disabled.The SrSelectionChanged and SelectedIndexChanged
were fired in the wrong order. To fix this the event SrSelectionChanged
is removed (in reality after the refactoring in 5b79b1dc94
it became obsolete).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
ec79720057 Do not pass the delegates showing messages as parameters to the actions, but rather have them handle action events.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
6f0a9cae6a CA-293784: updated plugins to use the XenServerPSModule as the snap-in has been retired.
- Check for the module existence when the process is created, not when
loading the plugin.
- Removed snapin max and min version as the specification documents them
as not implemented (CA-40580).
- Refactored Registry class to avoid code repetition and ensure that all
opened keys are closed.
- Added null checks and compacted the code parsing the plugin xml.
- Modernized properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-09 13:32:07 +01:00
Konstantina Chremmou
6bae7380a2 Property modernisation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-09 13:32:07 +01:00
Konstantina Chremmou
e9d2da082d Prevent XenCenter from crashing if starting it by double-clicking a license file.
Also, fixed hotkeys and info message on the PasswordRequest dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-07 18:00:32 +01:00
Konstantina Chremmou
73d457ec16 CA-328086: Prevent XenCenter from crashing when started from the cli without enough parameters for connecting to a server.
Also, compacted the code parsing command line parameters; removed class
and cli option MessageBoxTest as it adds to code complexity, plus that
the application is not meant to be used as testing infrastructure.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-07 18:00:32 +01:00
Mihaela Stoica
8b41a214b2
Merge pull request #2521 from xenserver/feature/REQ-756
Merge feature/REQ-756 into master
2019-09-27 13:18:21 +01:00
Darren Matthews
4a3fd35b51 L10N: Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-09-25 15:17:19 +01:00
Konstantina Chremmou
91e2ec3bbe CP-32101: Allow the application to seek help relevant to its release instead of always pointing to help for the latest CR.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 15:02:05 +01:00
Konstantina Chremmou
5244c91658 Help refactoring.
- Removed DebugHelp. The user settings are normally not meant for debugging code.
- Moved HelpId logic from the main window to the tab pages.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 15:02:05 +01:00
Konstantina Chremmou
eed06a6b4a Fixed unlocalised message.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 15:02:05 +01:00
Konstantina Chremmou
b46d9fda92 Throw specific NotImplementedException instead of generic exception. Some property modernisation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 15:02:05 +01:00
Konstantina Chremmou
441734be82 CP-32140: Allow the user to select which XCM VPX to use when there are multiple XCM VPXs in the pool.
Also, corrected the RBAC permission check after stopping using the conversion plugin.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 13:25:26 +01:00
Konstantina Chremmou
3d92246607 The GpuConfiguration list should not be editable. Resize GpuShinyBar Edit button when the text changes.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-23 13:39:54 +01:00
Konstantina Chremmou
ceccfcbe79 CA-325439: Pre-populate download locations. Validation corrections on the server status report wizard.
- Moved path validation checks from the wizard to its last page (planning
to remove XenWizardBase.FinishCancelled in future).
- If the directory did not exist, the user saw a message about inability
to write a file which was misleading. Check directory existence explicitly.
- Populate the last wizard page on load rather than on construction to
avoid unnecessary validations.
- Save in the settings the report output directory, not the filename.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-19 14:06:28 +01:00
Mihaela Stoica
0e47725ceb CP-32137: Updated alert message + sorted Messages.resx
Also rewrote the IsAlertNeeded() function, for better readability

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-16 10:46:06 +01:00
Mihaela Stoica
43dd9d4b4d CP-32137: Add alert for versions approaching EOL
The Approaching EOL alert will be shown when the EOL date is known, but the hotfix-eligibility flag is not yet set to "none".

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-16 10:46:06 +01:00
Mihaela Stoica
4832c7f5e6 CP-32139: Add text regarding the supportability for versions that have reached EOL
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-16 10:46:06 +01:00
Mihaela Stoica
b7738d1d81
Merge pull request #2511 from kc284/CA-272770
CA-272770: Check whether the selected ISO SR supports VDI creation before copying the Fixup ISO on it.
2019-09-13 13:50:08 +01:00
Mihaela Stoica
3ea93a9bd4
Merge pull request #2517 from kc284/feature/REQ-756
Merge master into feature/REQ-756
2019-09-13 13:46:53 +01:00
Konstantina Chremmou
ca72f25ebe Merge remote-tracking branch 'upstream/master' into feature/REQ-756
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.Designer.cs
#	XenAdmin/MainWindow.resx
#	XenAdmin/Properties/Resources.resx
2019-09-13 13:17:32 +01:00
Konstantina Chremmou
a3a7b93b8d CP-32097: Added help ids for the conversion dialog and wizard.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-13 12:48:48 +01:00
Konstantina Chremmou
bf1cdb67ec Change case to match the help files.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-13 12:48:48 +01:00
Konstantina Chremmou
2c59ca255e CP-30364: Facilitate overriding the help files location for testing purposes
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-13 12:00:56 +01:00
Konstantina Chremmou
d52008aaf9 CA-272770: Check whether the selected ISO SR supports VDI creation before copying the Fixup ISO on it.
Also, minor layout correction, and usability enhancement: do not disable
the controls under the radio button when the latter is deselected.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-12 23:05:15 +01:00
Konstantina Chremmou
d2db181872 CA-314721: Fixed parsing of nvidia gpu metrics names.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-11 14:23:48 +01:00
Konstantina Chremmou
d5d32baa88 CA-326611: Improved connecting to the conversion VM.
- Poll for the appliance version because the service may take a while to
  start after an IP address is obtained.
- More flexible IP address look up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-11 13:27:29 +01:00
Konstantina Chremmou
8701641e47 CA-326609: Ensure the conversion wizard offers only SRs that can be seen from all hosts in the pool.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-11 13:27:29 +01:00
Mihaela Stoica
57741506b4 CP-32070: Fix icon visibility + some improvements
- make the info messages icon+text instead of clickable icons. Some rearrangements of the controls on the dialog to accommodate them.
- in the "Assign To Snapshot Schedule" dropdown item, do not add a separator if there are no suitable policies listed.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-07 01:35:46 +01:00
Konstantina Chremmou
61f6f89c25
Merge pull request #2510 from xenserver/feature/REQ-775
Merge REQ-775 into master
2019-09-06 12:08:23 +01:00