Commit Graph

1243 Commits

Author SHA1 Message Date
Mihaela Stoica
01b011c982 CA-329399: Improve the error message displayed if the update wizard if a host cannot be evacuated.
If a host cannot be evacuated because other hosts in the pool are maintenance mode and pending a reboot following an update installation, then include instructions to reboot those hosts and then press Retry.
Also updated the text for the Manual mode, removing the reference to installing other updates and doing a reboot manually at the end, because that won't be always possible, due to the fact that now we put the hosts in maintenance mode before installing the update.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-11-08 10:27:49 +00:00
Mihaela Stoica
326e4d8fe8 CA-329695: Restrict switching the boot mode in the New VM wizard (when created from template or snapshot)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-11-01 15:14:24 +00:00
Konstantina Chremmou
56b3990875 CA-329838: Do not reload the last wizard page when hitting the finish button.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-01 11:00:46 +00:00
Konstantina Chremmou
5d8b0f685f Corrected spelling to match the docs. Use en-us spelling.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-30 11:41:44 +00:00
Darren Matthews
01764e8972 L10N: Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-10-21 13:53:59 +01:00
Xueqing Zhang
4dacede64b CP-32033 Add PV guests precheck in Xencenter
Signed-off-by: Xueqing Zhang <Xueqing.Zhang@citrix.com>
2019-10-18 09:56:21 +01:00
Konstantina Chremmou
f39a715816 CP-29522, CA-302477: Added TB option to the NumericUpdown of the NewDiskDialog and fixed validation on the VDISizeLocationPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
73eaed6af8 Fixed some issues around the validation of SrPicker selections.
- Fixed button enablement on the IntraPoolCopy page.
- Regression on the NewDiskDialog were selection was considered valid
even if the SR was disabled.The SrSelectionChanged and SelectedIndexChanged
were fired in the wrong order. To fix this the event SrSelectionChanged
is removed (in reality after the refactoring in 5b79b1dc94
it became obsolete).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Mihaela Stoica
8b41a214b2
Merge pull request #2521 from xenserver/feature/REQ-756
Merge feature/REQ-756 into master
2019-09-27 13:18:21 +01:00
Darren Matthews
4a3fd35b51 L10N: Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-09-25 15:17:19 +01:00
Konstantina Chremmou
5244c91658 Help refactoring.
- Removed DebugHelp. The user settings are normally not meant for debugging code.
- Moved HelpId logic from the main window to the tab pages.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 15:02:05 +01:00
Konstantina Chremmou
eed06a6b4a Fixed unlocalised message.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 15:02:05 +01:00
Konstantina Chremmou
ceccfcbe79 CA-325439: Pre-populate download locations. Validation corrections on the server status report wizard.
- Moved path validation checks from the wizard to its last page (planning
to remove XenWizardBase.FinishCancelled in future).
- If the directory did not exist, the user saw a message about inability
to write a file which was misleading. Check directory existence explicitly.
- Populate the last wizard page on load rather than on construction to
avoid unnecessary validations.
- Save in the settings the report output directory, not the filename.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-19 14:06:28 +01:00
Konstantina Chremmou
ca72f25ebe Merge remote-tracking branch 'upstream/master' into feature/REQ-756
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.Designer.cs
#	XenAdmin/MainWindow.resx
#	XenAdmin/Properties/Resources.resx
2019-09-13 13:17:32 +01:00
Konstantina Chremmou
d52008aaf9 CA-272770: Check whether the selected ISO SR supports VDI creation before copying the Fixup ISO on it.
Also, minor layout correction, and usability enhancement: do not disable
the controls under the radio button when the latter is deselected.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-12 23:05:15 +01:00
Konstantina Chremmou
8701641e47 CA-326609: Ensure the conversion wizard offers only SRs that can be seen from all hosts in the pool.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-11 13:27:29 +01:00
Mihaela Stoica
fca17a7ef5 Fix menu and dialog title inconsistencies for Snapshot schedules.
Also, use an info (instead of warning) icon on the message for Disk and memory snapshot

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-03 09:44:59 +01:00
Mihaela Stoica
661eee069c CP-32070: Add a warning on the Scheduled snapshots properties page
The warning is visible for vss scheduled snapshots on Quebec or newer hosts (these would be snapshots created before the host has been upgraded).
Also corrected a typo in a function name.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-03 08:18:19 +01:00
Mihaela Stoica
224f398307 CP-32070: Hide the quiesce checkbox based on the version of the server
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-03 08:18:19 +01:00
Mihaela Stoica
2a15b62f86 CA-322529: Do not add nulls to the sub-actions list for a multiple action
- This fixes the issue where we create a multiple action to delete the update installation files, but the sub-actions list contains null values because the connection to the host has been lost

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-02 11:21:23 +01:00
Konstantina Chremmou
629e2f641a CA-326161: Check for null before accessing the ManualTextInstructions
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-02 08:05:48 +01:00
Konstantina Chremmou
f46c9ea8d6 CP-30890/XSI-284: Support import of gzipped XVAs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-28 15:30:01 +01:00
Konstantina Chremmou
65fa1b3033 Removed copyright from resx files. Text corrections.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-22 12:49:03 +01:00
Konstantina Chremmou
fc07e2344e Missing comma. Wrong AutoScaleMode.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-22 11:48:14 +01:00
Konstantina Chremmou
9157735803 CP-30958: Initial implementation of the Conversion Manager in XenCenter. (#2481)
* CP-30958: Initial implementation of the Conversion Manager in XenCenter.
* Corrections following review and improvements.
* Further corrections and improvements.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-22 10:47:43 +01:00
Konstantina Chremmou
57b8d8f5cb Do not expose the Ovf project's settings to the other projects in the solution.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-14 11:07:16 +01:00
Konstantina Chremmou
536cb18837 CA-322526: Made the ImportOptions page sensitive to PBD changes in the cache. Improved combobox selection functionality.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-14 11:07:16 +01:00
Konstantina Chremmou
e6da7045b6 Ensure we always dispose of the ArchiveIterator and ArchiveWriter after use.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-13 10:18:15 +01:00
Konstantina Chremmou
38fcc83874 Fixed labels; removed unnecessary control disablement.
The blurbs should be user-centric rather than developer-centric.
No need to disable the page controls in the absence of signature/manifest
since the whole page becomes disabled in that case.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-13 10:18:15 +01:00
Konstantina Chremmou
fd95530e4f CA-294511: Rewrote the OVA appliance abstraction class to include:
- Verification of appliance files in chunks to avoid StreamTooLong exception.
- Disposal of HashAlgorithms and X509Certificates after use.
- General code simplification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-13 10:18:15 +01:00
Mihaela Stoica
76c806c0b3 CA-322790: Fix unhandled exception when the host cannot be reached to execute an API call.
In the CrossPoolMigrateCanMigrateFilter a WebException can be raised if the host cannot be reached to execute the API call that asserts is the VM can be migrated there. With these changes, we catch any exception (not just Failure) and mark the VM as not migratable (because we couldn't assert if it can be migrated to that host).

Also fixed other places where the same error might occur.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-24 09:46:00 +01:00
Konstantina Chremmou
8f2794b89d Prevent crash and improve behaviour when the user tries to configure/disable HA in a pool that has lost the HA statefile.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-23 10:28:01 +01:00
Mihaela Stoica
c137b4a6ea CA-317752: Take live-patching qualification into consideration in the Install Update pre-checks
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-22 17:49:18 +01:00
Konstantina Chremmou
85654a4f36 CA-314720: Replaced "Still waiting" dialog popping up during RPU with a message displayed in the upgrade output.
Also, fixed issue where uploading a supp-pack resulted in a perpetually
pending action if the file had disappeared from the disk.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 13:15:59 +01:00
Mihaela Stoica
3d3a96fbe6 CA-323766: Show the upgrade version in the RPU wizard, if available
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-22 12:24:07 +01:00
Darren Matthews
60b4282aba L10N : Resx resync and translation update
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-07-18 14:49:51 +01:00
Mihaela Stoica
79c9a7ecbc CA-320203: Fixed the update wizard failure when installing two cumula… (#2466)
CA-320203: Fixed the update wizard failure when installing two cumulative updates

The issue was that when installing 2 new versions in one go (e.g. two cumulative updates), the installation succeeds on master but it cannot continue on slaves, because it cannot find the first CU update anymore.
The fix is to refresh the update record before applying the update, with the record found in the cache. Also, if there is no update in the cache, try to re-introduce the update.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-07-12 14:43:48 +01:00
Konstantina Chremmou
866eae0edc Minor improvements on ImportWizard pages.
- Made storage selector blurb for XVA import a bit more informative.
- A simple checkbox for starting the new VMS on the finish page is adequate.
- Typos. Property modernisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 11:25:37 +01:00
Konstantina Chremmou
db02d206cb Duplicate hotkey. Layout simplification trying to leverage CA-209149.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 11:11:47 +01:00
Mihaela Stoica
71333fcf90 CA-304656: Stop users from applying automated updates that will bring the server to a verson incompatible with the current XenCenter version.
When running the XenCenter version precheck, calculate the higher server version that will be installed (by looking at the update sequence) and use this for checking the XenCenter version compatibility.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-06-11 09:34:25 +01:00
Mihaela Stoica
23b0517cb7 CA-314346: Fix Next button enablement on the Destination page of the VM migrate and VM import wizards.
- if there is only one host in the selected pool, then preselect it.
- make sure that  the Next button is enabled when a target host is selected.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-06-11 09:07:07 +01:00
Michael
99af56ac94 REQ-720: Initial implementation of GPUEditPage and AddVgpuDialog. (#2422)
* CP-31063: Add support for multiple vGPU
(incomplete)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CP-31063: Add support for multiple vGPU
(part 2)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* AddVGPUDialog

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Update bindings.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* REQ-720: Initial implementation of AddVgpuDialog.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Improve the handling of buttons and combobox. Fix comments.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Fix comments.

Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Mihaela Stoica
aaa573dd21
Merge pull request #2438 from xenserver/feature/REQ-745
Merge feature/REQ-745 branch into master
2019-05-20 10:48:48 +01:00
Mihaela Stoica
36b1e44030 CA-310177: Use a new tooltip message when the selected iso is neither corrupted nor an update
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-17 12:37:02 +01:00
Mihaela Stoica
6075f5185d CA-310177: Check if the selected iso file contains a valid ISO file system.
Also removed unnecessary call to OnPageUpdated.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-17 12:37:02 +01:00
Mihaela Stoica
32a41236a8 CA-317856: Ensure that VMs are repatriated after all hotfixes are appl… (#2436)
* CA-317856: Ensure that VMs are repatriated after all hotfixes are applied and the host has been rebooted.
- there is no need to remove the "reboot host" plan actions from the delayed actions list, because the action itself has code to check if a reboot is actually needed.
* CA-317856: Only add the "Exit maintenance mode" progress step if the host is in maintenance mode at that point.
- moved the AddProgressStep() call inside the function that checks if anything needs to be done (i.e. is host needs to be enables)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-17 12:32:25 +01:00
Mihaela Stoica
c96bf94f8c CA-318280: Add a null check for the VM.appliance property, as it could be null when read from the DR metadata
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-15 13:16:21 +01:00
Mihaela Stoica
8e5db5ce58 Merge branch 'master' into feature/REQ-745
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/PatchingWizard/AutomatedUpdatesBasePage.cs
#	XenAdmin/Wizards/PatchingWizard/PlanActions/RestartHostPlanAction.cs
2019-05-14 16:46:02 +01:00
Mihaela Stoica
f3064173e3 CA-304786: Fix the error where the Patching wizard cannot display available hosts when patch ISO is used by another process
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-04-26 12:14:38 +01:00
Konstantina Chremmou
4ce9878b45 Refactored the VIFDialog to fix various problems: (#2398)
* Refactored the VIFDialog to fix various problems:
- Launch the dialog in using blocks.
- Event GotFocus is not meant to be handled directly in the code.
- Populate the dialog in the OnLoad override instead of the constructor
  as this causes problems at design time.
- Popping up an error message for duplicate MAC on combobox item
  selection or textbox text change is not optimal UX. Perform this
  check once when closing the form. Additionally the parent form of the
  pop up should be the dialog, not the main window.
- The validation messages are not obvious to the user because they are
  hidden in the tooltip of a disabled button. Show them inline instead.
- There is no need to create commands for VIF creation/change; use
  the relevant actions instead.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Corrections as per code review plus some more code tidy and refactoring.

- Added option to suppress Create/DeleteVIFActions
- Use property RebootRequired to indicate hot-plugging is unavailable
  (assigning various objects of different types to the Result of the action
  during its run may cause confusion).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-25 08:23:09 +01:00