Commit Graph

411 Commits

Author SHA1 Message Date
Rob Hoes
1de9f35566 CA-192640: Don't log exceptions when HealthCheck service is not installed (part 2)
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
2016-01-20 14:47:39 +00:00
Mihaela Stoica
9aee7a4f9b Merge pull request #773 from GaborApatiNagy/CA-187681
CA-187681: xs-tools ISO doesn't get mounted on dlvm xva(Centos 7 HVM)
2016-01-20 12:27:29 +00:00
Gabor Apati-Nagy
89a91bd247 CA-187681: Improvement for VM.IsWindows property
vm.guest_metrics.PV_drivers_up_to_date is obsolete (and can be wrong) for new type Windows VMs and this led to early escape from this action.
2016-01-20 12:13:35 +00:00
Cheng Zhang
15ef3410a3 CP-15398: Make file name and dir rebrandablei
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-19 18:40:55 +08:00
Mihaela Stoica
89694b98e3 Merge pull request #775 from GaborApatiNagy/CA-159790_2
CA-159790: [XSO-208] & CA-103752
2016-01-18 21:58:21 +00:00
Gabor Apati-Nagy
5d82d9e3ff CA-103752: XenCenter ‘Event Log’ window does not show any host/pool information for ‘Actions’ level logs while applying license to host
Setting Host or Pool on the ApplyLicenseEditionAction when there is one XenObject in the list

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-01-15 13:45:54 +00:00
Rob Hoes
f5a12452ca CA-192640: Don't log exceptions when HealthCheck service is not installed
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
2016-01-14 13:52:20 +00:00
Gabor Apati-Nagy
274c98d8d9 CP-14822: UI: New VM Creation: update code to apply recommendations
This changeset implements the followings:

On creation of a new VM,
* XenCenter will use licensed state of the host to determine whether it should obey/apply the template-recommendation regarding the vendor device.
* If the host is licensed, and the selected template's recommendations suggest that has_vendor_device can be set/should be set to true, as part of VM creation, XenCenter will set the vm's has_vendor_device based on the recommendation using set_has_vendor_device API call (after it has cloned the template and before calling vm.provision).
* XenCenter will not expose details whether 1G or 2G VM is going to be created.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-12-17 15:31:41 +00:00
Gabor Apati-Nagy
652c7225f8 CA-189084: Control domain memory alerts not getting generated in Xencenter.
Removed unnecessary code found in code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-12-10 13:43:54 +00:00
Gabor Apati-Nagy
4baa36efab CA-189084: Control domain memory alerts not getting generated in Xencenter.
Dom0 memory alerts have to be configured in the other_config of the control domain (dom0) and not of the the host. This changeset implements this exception.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-12-07 17:57:54 +00:00
Stephen Turner
ac71c2c454 CA-190904: Remove obsolete SR.upgrade and SR.share menu items 2015-11-30 11:53:54 +00:00
Gabor Apati-Nagy
34612db6f8 Merge pull request #746 from GaborApatiNagy/CA-178985
CA-178985: Removed ova.xml import from XenCenter
2015-11-25 13:48:44 +00:00
Gabor Apati-Nagy
f0ea3aa807 CA-178985: Removed ova.xml import from XenCenter
because it has been broken and we decided not to keep this feature

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-11-25 12:12:20 +00:00
Gabor Apati-Nagy
4586832d5f CA-178985: Removed ova.xml import from XenCenter
because it has been broken and we decided not to keep this feature

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-11-25 11:01:28 +00:00
Gabor Apati-Nagy
d79351a8f4 CA-187909: Special characters should be UrlEncoded on HTTP calls
A bit of refactoring

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-11-23 14:47:28 +00:00
Gabor Apati-Nagy
104d5554fb CA-187909: Special characters should be URLencoded on HTTP calls
UrlEncoded all the strings that are used to create URLs. (Such as untrusted user input: string fileName)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-11-16 17:50:43 +00:00
Mihaela Stoica
3c956f28ac CP-14780: Revert Windows Update changes (part2)
Revert "Merge pull request #708 from GaborApatiNagy/master_windows_update"

This reverts commit fe03f1382f, reversing
changes made to 423065a2c8.

Conflicts:
	XenAdminTests/TabsAndMenus/MainMenuGeorge.cs
2015-11-10 13:13:23 +00:00
Stephen Turner
f2f590e3e7 CP-14647: More changes after read-through, including getting rid of OEM edition 2015-11-08 16:31:48 +00:00
Stephen Turner
448ee7fa4e CP-14647: Intermediate check-in #6
Fix two warnings-as-errors, and update sample dbs to newer API
2015-11-08 11:28:03 +00:00
Stephen Turner
8ea7e73b55 CP-14647: Intermediate check-in #5
This should cover everything except updating the tests to use more recent
servers.
2015-11-08 11:28:02 +00:00
Stephen Turner
ce609e31ff CP-14647: Intermediate check-in #4 2015-11-08 11:28:01 +00:00
Stephen Turner
c667e51fd2 CP-14647: Intermediate check-in #3 2015-11-08 11:27:59 +00:00
Stephen Turner
cf6534275e CP-14647: Intermediate check-in #2 2015-11-08 11:27:57 +00:00
Stephen Turner
b587ab832e CP-14647: Intermediate check-in #1 2015-11-08 11:27:56 +00:00
Mihaela Stoica
0963f8ccd2 CA-186234: Group the issues found in a pool when retrieving CIS analysis results for a pool
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-11-06 15:01:31 +00:00
Mihaela Stoica
af7852c7a0 CA-180576: Provide a option to give case number when uploading a report from the Server Status Report wizard
- added Case Number edit box on the Destination page of the wizard
- valid case number needs to be 9 or less digits

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-11-03 15:48:14 +00:00
Mihaela Stoica
fe9f4cf555 CP-14085: Added Assert for CPU feature masking
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-10-28 14:02:29 +00:00
Mihaela Stoica
0a6955d157 CP-14085: Feature leveling not needed on pool-join
Feature leveling should "just work" for Dundee and higher hosts, without the need for us to level them explicitly

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-10-23 12:08:19 +01:00
Mihaela Stoica
2d154cf8f7 CA-180128: Ignoring XmlRpcIllFormedXmlException in DoWithSessionRetry (when disruption is expected)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-10-20 11:02:01 +01:00
Mihaela Stoica
fe03f1382f Merge pull request #708 from GaborApatiNagy/master_windows_update
Upgrade VMs
2015-10-19 16:29:52 +01:00
Gabor Apati-Nagy
7b7bcb0aa5 CP-14379, CP-14461, CP-14462, CP-14463, CP-14464, CP-14465, CP-14467:
Implementing Upgrading VMs to Windows Update

New screen features:
-Create skeleton of the Upgrade VM dialog
-Implement a Go To Console link (just a link that opens a vm console)
-Implement logic to show the right status for a VM (includes rules to
get the states). Includes updating the dialog whenever the status changes.
-Add status texts to Messages, proper text on the UI
-Add stub methods to VM class in XenAPI-Extensions to r/w states from
Guest Agent
-UI: Implement rules what vms to display, checkbox rules, read only vms,
and when to enable the Upgrade button
-Implement Upgrade button (writes state for GA, mounts ISO) + maximum
parallel executions/actions

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-10-16 12:47:00 +01:00
Mihaela Stoica
5c80fcc4ea CA-180120: Changed the progress description displayed on the Upload page in the Patching wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-10-15 14:15:10 +01:00
Hui Zhang
50c2f588d7 CA-185063: Health Check Service: Filename is missed in CIS report.
Add status report filename in the CIS Upload URL.

Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2015-10-09 15:55:59 +08:00
Mihaela Stoica
1405ec29f4 CA-180128: Make RelatedTask property setter aware of ExpectDisruption flag
When the pool's ssl_legacy settings are changed, we may temporarily lose connection. The action generally copes well, because PollToCompletion is aware of the ExpectDisruption flag.
But when the action's RelatedTask is assigned, we perform more api calls, which may fail with WebException. When disruption is expected, we need to ignore it and try again on a new session (CancellingAction.DoWithSessionRetry).
2015-10-06 16:25:32 +01:00
Carmen Agimof
e44c7b20e2 Merge pull request #679 from MihaelaStoica/CA-183321
CA-183321 and more thin-lvhd-related fixes
2015-09-23 14:19:12 +01:00
Gabor Apati-Nagy
0ac03285da Merge pull request #682 from MihaelaStoica/CP-13983
CP-13983: Fix the SR convert action
2015-09-23 12:36:05 +01:00
Gabor Apati-Nagy
ad80ced66d Merge pull request #673 from MihaelaStoica/CA-182884
Use the Enum functions for string-to-enum and enum-to-string conversions
2015-09-23 12:35:28 +01:00
Mihaela Stoica
0de5a2d310 CP-13983: Fix the SR convert action
- use SR.opaque_ref instead of uuid

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-09-22 11:05:39 +01:00
Mihaela Stoica
f507b65126 CA-183321: Fixed the bug where the disk initial and incremental allocations values were ignored while creating new VM's disk
When creating a new VM, we no longer use vm.provision to create VM's disks, but instead we create the disks ourselves using vdi.create; this way we can specify the initial and incremental allocations for the new disks.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-09-18 15:51:17 +01:00
Mihaela Stoica
2766a18987 Use the ToString() function directly for enum-to-string conversions
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-09-15 13:55:18 +01:00
Gabor Apati-Nagy
bf8e2cfc77 Merge pull request #669 from agimofcarmen/CA-179502
CA-179502: Reviewed all use of MemorySizeStringMB and came to the con…
2015-09-11 12:20:40 +01:00
Mihaela Stoica
23db625d15 Change the validity period of the diagnostic token to one year.
- This is temporary, until the API accepts max_age=0 (never expire)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-09-10 15:29:35 +01:00
Carmen Agimof
4fadf796ad CA-179502: Reviewed all use of MemorySizeStringMB and came to the conclusion that all its usages must be replaced with MemorySizeStringSuitableUnits. 2015-09-10 14:36:46 +01:00
Carmen Agimof
cd4281ffab Merge pull request #651 from MihaelaStoica/CP-13077
CP-13077: Changes to the Health Check feature to work properly with RBAC
2015-09-09 13:16:15 +01:00
Mihaela Stoica
fb8a6665a6 Merge pull request #664 from agimofcarmen/CP-13984
CP-13984: Changes the wording on Convert SR dialog (replace upgrade with convert).
2015-09-08 15:35:36 +01:00
Carmen Agimof
0dd8fa7f05 CP-13984: Changes the wording on Convert SR dialog (replace upgrade with convert). 2015-09-08 15:32:47 +01:00
Mihaela Stoica
b13e72c14f Merge pull request #662 from agimofcarmen/CA-181442
CA-181442: Removes unused variable.
2015-09-08 14:57:06 +01:00
Carmen Agimof
e04203a5a3 Removes unused variable. 2015-09-08 13:58:13 +01:00
Mihaela Stoica
d7fa39bb75 Merge pull request #655 from agimofcarmen/CA-181442
CA 181442: Cancelling the wizard while upload is in progress does not cause an unhandled exception anymore.
2015-09-08 12:05:30 +01:00
Mihaela Stoica
62bc632f02 CP-13074: Update the URLs used for retrieving the analysis results 2015-09-07 17:58:53 +01:00
Carmen Agimof
22b3450dcd CA-181442: Make the list that contained all NewUploadedPatches a Dictionary that matches the patch with its path. This is helpful when trying to upload to a server where the update it is already uploaded (and therefore we do not do the upload again and we cannot get the patch).
Adds a flag in the UploadPatchAction that is used when checking if the file should be deleted on cancel.
2015-09-07 12:18:01 +01:00
Carmen Agimof
05884ea9be CA-181442: Cancelling the wizard while upload is in progress does not cause an unhandled exception anymore. 2015-09-04 17:18:26 +01:00
Carmen Agimof
9b0f478952 CA-181390: Solved issue related to taking a file from disk that is not in the list of updates taken from the Citrix website. Created a dictionary that contains all the uploaded updates(the patch path) and on which hosts they were applied.
- Not applied updates do not appear anymore in the General Tab of a pool. (Related to CA-180577)
- If we apply a patch that was already applied (happens when we take a file from disk that is not in the updates list taken from the Citrix website -> no metadata), on cancel we are now removing the uploaded patch from the host.
2015-09-04 17:09:22 +01:00
Mihaela Stoica
53b01c425c CP-13077: Changes to the Health Check feature to work properly with RBAC
Changed all the health check actions to perform the necessary role checks
- HealthCheckAuthenticationAction: changed so it does not save the tokens, so no role checks required in this action (all the checks are performed in SaveHealthCheckSettingsAction)
- GetHealthCheckAnalysisActions: added role checks

On the Health Check Overview dialog, a pool is displayed as read-only if connected as a user with roles that don't permit changing the health check settings:
- the following actions are not available: enroll, edit settings, disable health check, request upload, get analysis result
2015-09-03 11:49:53 +01:00
Gabor Apati-Nagy
402994a7a1 Merge pull request #638 from MihaelaStoica/CP-12156_2
CP-12156: Obtain and display the result of the CIS analysis of the last uploaded report
2015-08-27 14:04:17 +01:00
Gabor Apati-Nagy
19d9d1589c CP-13100: XenCenter: Convert a thickly provisoned LVM-based SR to a thinly provisioned SR
Some checks following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-08-27 13:50:56 +01:00
Mihaela Stoica
e38c707ffb CP-12156: Removed unused variable
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-08-27 01:04:56 +01:00
Mihaela Stoica
2eba1c705f Merge remote-tracking branch 'upstream/master' into CP-12156_2
Conflicts:
	XenModel/XenAPI-Extensions/Pool.cs
	XenModel/XenModel.csproj
2015-08-27 01:03:58 +01:00
Mihaela Stoica
44e18df03d CP-12156: Obtain and display the result of the CIS analysis of the last uploaded report
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-08-27 00:30:02 +01:00
Gabor Apati-Nagy
77beffacf9 Merge remote-tracking branch 'github_xenadmin/master' into CP-13100
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/TabPages/GeneralTabPage.cs
2015-08-26 17:58:38 +01:00
Gabor Apati-Nagy
cb90872c6c CP-13100: XenCenter: Convert a thickly provisoned LVM-based SR to a thinly provisioned SR
Added new functionality (using percentages yet)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-08-26 17:54:03 +01:00
Hui Zhang
0761aa5be2 CP-13848: XenCenter transfers proxy settings to HealthCheckService.
Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2015-08-25 20:32:58 +08:00
Mihaela Stoica
ff64416407 Move HealthCheckSettings class to a separate file
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-08-21 15:19:24 +01:00
Mihaela Stoica
0a3deaf526 Merge pull request #624 from agimofcarmen/CA-147944_II
CA-147944: Use GB for VM Memory if large values
2015-08-20 17:17:12 +01:00
Mihaela Stoica
cb35725dd7 CP-13074: Finalize the CIS domain names and product key used for retrieving the authentication tokens and upload
- change the URLs to the production site
- for development and testing these settings should be changed to the staging site via registry keys

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-08-20 16:59:58 +01:00
Carmen Agimof
4da67c0590 CA-147944: Use GB for VM Memory if large values
- Memory Tab uses GB units for values greater or equal to 1 GB, otherwise show in MB;
- Search Tab displays values in GB or MB in the same as the Memory Tab (e.g. 512 MB of 1 GB, 256 MB of 512 MB, 2.5 GB of 16 GB).
- The shiny bar present in the Memory Tab and in Memory Settings dialog shows the scaling in the following way: If smaller than 1 GB, then show as before, else show only labels with values multiples of half a GB.
- The units used in Memory Setting Dialog are set depending on the static_max. If it is greater or equal to 1 GB, then the units are GB, else MB. The user does not have the possibility of changing them.
2015-08-20 12:41:39 +01:00
Gabor Apati-Nagy
b123bf8dda Merge pull request #619 from stephen-turner/CP-13374
CP-13374 XenCenter can now turn on and off ssl-legacy
2015-08-19 17:31:42 +01:00
Stephen Turner
59a432ff40 CP-13374: Remove unused variable 2015-08-19 09:21:47 +01:00
Stephen Turner
227ee84da7 CP-13374 XenCenter can now turn on and off ssl-legacy.
The main functionality is working, but the ExpectDisruption flag isn't fully working yet.
2015-08-18 09:35:55 +01:00
Hui Zhang
aef05ab064 CP-13072: HealthCheckService: Use proxy for bundle upload.
Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2015-08-17 15:54:19 +08:00
Cheng Zhang
3f2e8a51da CA-179369: Change CIS default setting
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2015-08-11 16:09:45 +08:00
Stephen Turner
cdfc665458 Merge pull request #596 from GaborApatiNagy/master_CA-177058
CA-177058: [SCTX-2146] VM Power Admin could not create VMs - RBAC issues with XS 6.5
2015-08-05 12:21:27 +01:00
Gabor Apati-Nagy
f6b632d0b6 Merge pull request #593 from agimofcarmen/CA-178243
CA-178243: When only Automatic check for XenServer updates was checke…
2015-08-04 17:30:22 +01:00
Carmen Agimof
c8e5138031 CA-178243: Refactors code, simplifying it. Now we only keep one list in DownloadUpdatesXmlAction for XenServerVersions and added a property that returns the list with the versions if Automatic check for XS version is checked and a new list which is empty when is not checked. 2015-08-04 17:28:29 +01:00
Gabor Apati-Nagy
191820abf4 CA-177058: [SCTX-2146] VM Power Admin could not create VMs - RBAC issues with XS 6.5 2015-08-04 11:25:59 +01:00
Carmen Agimof
9de57d38c2 CA-178243: When only Automatic check for XenServer updates was checked in Updates Options, when opening XC, the grid appeared empty in the Updates Tab. This was because to get the list of XS updates, we need the list of XS versions. Created a list of XenServer versions that is used only to get the XenServer updates. 2015-08-03 15:06:01 +01:00
Mihaela Stoica
f6c477eb67 Merge remote-tracking branch 'hui/CA-178338' into CP-13073 2015-07-30 10:31:38 +01:00
Hui Zhang
d6ff10654d CA-178338: XenServerHealthCheckService: bundle uploading update.
1. Add logs to track the uploading process.
2. Catch the potential exception.

Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2015-07-30 17:02:48 +08:00
Mihaela Stoica
61b5821e4f CP-13073: Rename files (Call Home to Health Check)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-07-29 09:12:46 +01:00
Mihaela Stoica
a9be9846ff CP-13073: Rename Call Home to Health Check in code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-07-29 08:44:41 +01:00
Gabor Apati-Nagy
ecb048b9ee Merge pull request #572 from MihaelaStoica/CP-13120
CP-13120: User-friendly errors when Health Check authorization fails
2015-07-28 16:14:28 +01:00
Mihaela Stoica
bfa5db8b40 Merge pull request #574 from GaborApatiNagy/master_CA-173497
CA-173497: Thin provisioning: Repair of SR of thin-provisioning on SR hang without return
2015-07-27 13:12:10 +01:00
Gabor Apati-Nagy
50797b5805 CA-173497: Thin provisioning: Repair of SR of thin-provisioning on SR hang without return
-When detaching an SR, we detach the slaves first
-When reattaching the SR, we attach the master first

This fix was required by thin provisioning, but it does worth to use the same logic regardless of the provisioning method.
2015-07-24 14:48:09 +01:00
Mihaela Stoica
b22331fb68 CP-13120: User-friendly errors when Health Check authorization fails 2015-07-24 09:01:04 +01:00
Mihaela Stoica
f727af1c51 CP-12679: Upload the report from the Server Status Report wizard
- added the upload action, called after the report is successfully saved on disk.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-07-20 15:15:51 +01:00
Mihaela Stoica
96f9b9c6ac CP-12679: Upload the report from the Server Status Report wizard
- make pre product key (used for authentication) configurable via registry entries

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-07-20 15:15:45 +01:00
Mihaela Stoica
df8ac2ce74 CP-12679: Upload the report from the Server Status Report wizard
- moved XenServerHealthCheckUpload.cs to XenModel

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-07-20 15:15:42 +01:00
Mihaela Stoica
f262692693 Rename Health Check service name to "XenServerHealthCheck" 2015-07-17 16:05:15 +01:00
Cheng Zhang
09d0245082 CP-12769: Send credential only when HealthCheckService is running.
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2015-07-15 13:49:23 +08:00
Mihaela Stoica
8679858177 Added copyright/license headers
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-07-10 13:36:26 +01:00
Mihaela Stoica
d366c57f55 CP-12890: Allow user to specify XenServer credentials to use for Health Check
- added new fields to the Health Check Settings dialog (XenServer credentials)
- these credentials are saved as xapi secrets, and on un-enroll they are being removed
- removed the Authenticate button; the authentication is now done on pressing the OK button
- the Health Check Settings dialog is displayed on "Enroll now" and "Edit Health Check settings"
- display the "Last Successful Upload" on the Health Check Overview dialog
- use uniform format when converting time to string and string to time

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-07-06 17:02:55 +01:00
Cheng Zhang
a0431e5cb9 CP-12770: rework comments
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2015-07-01 19:12:43 +08:00
Cheng Zhang
50817a5746 CP-12769: Add timeout for pipe client connecting
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2015-07-01 18:19:44 +08:00
Cheng Zhang
324c249285 CP-12769: Send server connection details to the Health Check Service
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2015-07-01 11:53:56 +08:00
Gabor Apati-Nagy
43fb63d522 Merge pull request #521 from MihaelaStoica/CP-12164
CA-12164: Server Status Report wizard: Add option to upload the serve…
2015-06-30 15:45:47 +01:00
Mihaela Stoica
9c13c7e4b9 CA-12164: Server Status Report wizard: Add option to upload the server status report to CIS
In the CallHomeAuthenticationAction.SetUploadTokenSecret() check if the tokenKey is null (public static, may be reused later).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-06-30 12:04:24 +01:00
Gabor Apati-Nagy
bebd1583ca Merge pull request #514 from MihaelaStoica/CP-12164
CA-12164: Server Status Report wizard: Add option to upload the serve…
2015-06-30 11:58:50 +01:00
Gabor Apati-Nagy
3402ca03d8 CP-12314: CAR-576 XC: New SR type for FCoE
Added 'path' for FCoE device config
2015-06-29 14:44:32 +01:00
Mihaela Stoica
551d7657ca CP-12314: Add New SR type for FCoE in the SR wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-06-29 14:44:29 +01:00
Mihaela Stoica
d4f41660b8 Merge pull request #505 from GaborApatiNagy/master_CP-12641
CP-12641 and CP-12475: XenCenter work for thin provisioning
2015-06-29 14:08:16 +01:00
Mihaela Stoica
f0e7f5328f CA-12164: Server Status Report wizard: Add option to upload the server status report to CIS
- add the option on the destination page of the wizard
- for authentication purposes, MyCitrix credentials are required.
- these credentials are only used to obtain an upload token that will be used for the upload.
- the upload token expires in 24 hours and is not saved in the xapi database.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-06-25 23:51:11 +01:00
Gabor Apati-Nagy
306a8b0acb CP-12641 and CP-12475: XenCenter work for thin provisioning
-New SR wizard: new page
-Add Virtual Disk dialog: new fields

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-06-17 09:59:21 +01:00
Mihaela Stoica
0cd0b5f0d7 CP-12626: Use health_check_config field for Call Home enrollment settings
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-06-16 14:47:33 +01:00
Mihaela Stoica
2dd4c52350 CP-12153: Call Home Authentication
- added getter and setter to the token property to prevent "Field never assigned" warning

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-06-03 15:14:39 +01:00
Mihaela Stoica
f8e47e82b5 CP-12153: Call Home Authentication
- changes following code review
- added some more logging of exceptions, also some null checks

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-06-02 16:47:19 +01:00
Mihaela Stoica
9c3982542e CP-12153: Call Home Authentication
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-06-02 14:48:59 +01:00
Mihaela Stoica
9783c6dc7e CP-12152: Call Home enrollment 2015-05-18 15:23:32 +01:00
Gabor Apati-Nagy
ffb620461f CA-147254: Adding DVD drive fails with obscure error message 2015-05-15 16:32:37 +01:00
Mihaela Stoica
830d8f6f60 CP-11292: Remove storage motion constraints: changes following code review
- added some null checks
- in the Cross pool migrate wizard, add Transfer network page for all cases except intra-pool move (which is performed via VMMoveAction)
- added comments to VMCrossPoolMigrateAction constructor to make it cleared what the copy parameter means

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-04-15 09:37:12 +01:00
Mihaela Stoica
e314a654f7 CP-11292: Remove storage motion constraints: Allow cross-pool copy for stopped VMs
- modified the VMCopyCommand to launch a cross pool copy if permitted
- added the CrossPoolCopyVMCommand which opens the Cross pool migration wizard in "copy" mode
- modified the cross pool migrate action with an extra "copy" parameter, which will add a copy option to the vm.migrate_send function call

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-03-31 14:27:04 +01:00
Gabor Apati-Nagy
eb61f8fe0c CA-165367: Reclaim freed space feature fails on Local storage on Slave host 2015-03-27 15:06:17 +00:00
Gabor Apati-Nagy
23319daeba Merge pull request #393 from MihaelaStoica/CP-11032
CP-11032: Remove storage motion constraints: Allow cross-pool move of stopped and suspended VMs
2015-03-24 18:11:48 +00:00
Stephen Turner
1eef9002c8 Hotfix download progress bar makes GUI unresponsive 2015-03-19 14:23:54 +00:00
Mihaela Stoica
d616009824 CP-11032: Remove storage motion constraints: Allow cross-pool move of stopped and suspended VMs
- With these changes, a stopped or suspended VM can be moved across pools; this is performed as a vm migrate operation.
- The intra pool move will continue to be a vdi.copy + destroy operation for stopped VMs, but for suspended VMs we need to do it a as vm migrate operation.
- We use the Cross Pool migrate wizard for both intra and cross pool move operations, but introduced a wizard mode parameter in order to adapt the wizard to the specific operation we want to perform (migrate, move or copy)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-03-17 16:35:12 +00:00
Gabor Apati-Nagy
35b3edd590 CA-163778: [CAR-1711] Cleanup not working
-When calling cleanup_disk_space, excluded patch is passed only when it is
not null

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-03-13 13:47:45 +00:00
Gabor Apati-Nagy
f6dad3c2a2 CA-163777: [CAR-1711] Incorrect message for cleanup
-Added missing parameter to get_required_space plugin call.
-The required space is not shown in the notification when we are unable to tell how much space is required .

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-03-11 14:49:07 +00:00
Gabor Apati-Nagy
be8cd99839 CP-11364: XC to use xapi.secret when creating CIFS SRs 2015-03-10 14:59:05 +00:00
Mihaela Stoica
18ee60104b CA-162966: Fix the bug where the GPU value could not be updated via VM Properties for Linux HVM
- The problem was that we didn't create a vgpu if the vgpu_type was null. But for Linux HVM, this is gpu passthrough case.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-03-04 16:50:49 +00:00
Mihaela Stoica
c7f3ea5b30 Merge pull request #358 from GaborApatiNagy/CP-10144
CP-10144: Support CIFS as an SR type in XenCenter
2015-03-03 17:07:37 +00:00
Gabor Apati-Nagy
2d98dd9d85 CP-10144: Support CIFS as an SR type in XenCenter
-Added support for CIFS (SR type, SR Wizard)
-Added some Debug.Asserts to the Create SR action to watch for clear text paswords

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-03-03 15:51:56 +00:00
Mihaela Stoica
6d4e68b308 CA-161620: Changes following code review
- log the error description as Error, not Warning
- slightly changed the action title

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-03-03 14:51:44 +00:00
Mihaela Stoica
de4ff847c5 CA-161620: If the supplemental pack installation fails, then XenCenter will display a message suggesting the user refers to the users guide for installing via the CLI.
- When the install fails, log the full error description
- Added a specific exception for the supp pack installation failure
- Better action title (depending on the number of servers it applies to)
- Added a "More Info" button on the "Update" page, which displays a message with more information on the supp pack installation failure

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-27 17:00:03 +00:00
Mihaela Stoica
9c0bdcf08c Merge branch 'master' of https://github.com/xenserver/xenadmin into CP-10625 2015-02-25 15:50:59 +00:00
Gabor Apati-Nagy
29b7342597 Merge pull request #339 from MihaelaStoica/CA-161097
CA-161097: Pause the automatic refresh on Container processes page when the page is not visible
2015-02-25 15:15:54 +00:00
Mihaela Stoica
bf2e9bcfb1 CP-10625: Provide Xencenter user interface to enable/disable integrated GPU passthrough
- Added a "Integrated GPU passthrough" section to the PoolGpuEdit page.
- This section is only visible for a host that has GPU capability and the enabling/disabling of integrated GPU passthrough is not restricted.
- With this addition, the GPU page can now be displayed for a pooled host as well (previously only pool or standalone host)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-25 13:01:03 +00:00
Mihaela Stoica
08d4b6e306 CA-161097: Changes following code review
- Disable the Refresh button while a refresh is in progress.
- Introduced ExecuteContainerPluginAction - an action that stores the container it was called for, so that on completion we can decide whether to update the view or not (if the container displayed has changed, then we shouldn't update the view with the results from a previously selected container).

These changes apply to container Processes and Details tabs.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-25 12:44:03 +00:00
Mihaela Stoica
8a9b2d8c70 Merge branch 'master' of https://github.com/xenserver/xenadmin into CP-10926
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/XenAPI-Extensions/VDI.cs
	XenModel/XenAPI-Extensions/VM.cs
2015-02-23 17:57:18 +00:00
Stephen Turner
8aae324f0a Merge 2015-02-23 14:34:35 +00:00
Stephen Turner
5adab0cfa6 CAR-1711: Download update from a pool name, not an IP address 2015-02-20 13:39:13 +00:00
Stephen Turner
a2883d8252 CA-161460: Present a helpful error message when a patch we are trying to download from another server has been deleted 2015-02-20 13:07:20 +00:00
Mihaela Stoica
eab66b9bf0 CA-161002: Internationalize strings on the Cloud Config Parameters page and CreateVMAction
- also added Help Id got the Cloud Config Parameters page

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-19 14:48:52 +00:00
Mihaela Stoica
1a484b99ff CP-11135: Expand patch precheck to account for OUT_OF_SPACE exception
- Pool_patch.precheck can fail with the xapi error OUT_OF_SPACE when is trying to copy the patch from master to the slaves. This happens before the patch-precheck checks if enough space is available for installation. Therefore is different from the error we are currently processing, PATCH_PRECHECK_FAILED_OUT_OF_SPACE
- If the precheck fails with OUT_OF_SPACE then we try and retrieve the disk space requirements and report a HostOutOfSpaceProblem.
- Changed the PatchPrecheckCheck to try and find problem from a xapi failure, as well as from the result of the precheck  call.
- Also removed ampersand from the the link labels (More Info and Clean up)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-16 11:11:30 +00:00
Mihaela Stoica
9c652cd687 CP-10926: Add dialog for customizing the config drive in XenCenter after VM creation
- The cloud config parameters page is only visible on a VM that already has a config drive.
- The cloud config parameters can only be changed when the VM is halted.
- In the New VM wizard, if a template is selected that already has a config drive, them the wizard will display the existing configuration, not the default one.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-13 14:43:13 +00:00
Gabor Apati-Nagy
878229e9a8 CP-10798: XenCenter work for CAR-1711: Pre-Checks for hotfix installation space
-Fixed code following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-02-12 14:00:51 +00:00
Gabor Apati-Nagy
91789256e8 CP-10798: XenCenter work for CAR-1711: Pre-Checks for hotfix installation space
-Added HostOutOfSpaceProblem to let the user to clean up disk space when getting PATCH_PRECHECK_FAILED_OUT_OF_SPACE error at precheck stage in the patch install wizard.
-A bit of refactoring of DiskSpaceRequirements class in order to be reused here

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-02-12 13:13:45 +00:00
Mihaela Stoica
fe8c876a83 CP-10927: Add container restart operation
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-11 11:08:37 +00:00
Gabor Apati-Nagy
69b957cc63 Merge pull request #319 from MihaelaStoica/CA-160904
CA-160904: Fix NullReferenceException on the New VM Wizard
2015-02-10 11:45:30 +00:00
Gabor Apati-Nagy
746db783ec Merge pull request #317 from MihaelaStoica/CAR-1736
CP-10900: Add functionality for enabling/disabling/querying the containe...
2015-02-10 11:44:49 +00:00
Mihaela Stoica
640aef8c1e CP-10900: Add functionality for enabling/disabling/querying the container monitoring on a per-VM-basis to XenCenter
- Changed 'Enlightenment' to 'Container Enlightenment'

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-10 11:42:29 +00:00
Mihaela Stoica
dbebab2563 CP-10927: Internationalize existing container commands and actions
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-09 16:53:29 +00:00
Mihaela Stoica
8b9d089687 CA-160904: Fix NullReferenceException on the New VM Wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-09 11:16:01 +00:00
Mihaela Stoica
c3b667ec7f CP-10900: Add functionality for enabling/disabling/querying the container monitoring on a per-VM-basis to XenCenter
New Page: Enlightenment on VM Properties Dialog, visible only for:
- VMs on Cream Or Greater hosts
- that can be enlightened, regardless of their power state

A VM can be enlightened if the key "xscontainer-monitor" exists in other_config.
A VM is enlightened if other_config:xscontainer-monitor if true.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-06 17:46:58 +00:00
Gabor Apati-Nagy
d1b6996809 Merge pull request #316 from MihaelaStoica/CP-10799
CP-10799: Ensuring sufficient disk space for service pack installation: ...
2015-02-06 15:04:55 +00:00
Gabor Apati-Nagy
2d89776d49 Merge pull request #315 from MihaelaStoica/CAR-1711
CP-10797: Ensuring sufficient disk space for service pack installation: ...
2015-02-06 13:51:36 +00:00
Mihaela Stoica
e6784d1837 CP-10799: Ensuring sufficient disk space for service pack installation: Display hotfix installation size on the Updates page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-06 12:32:29 +00:00
Mihaela Stoica
19f66414a7 CP-10797: Ensuring sufficient disk space for service pack installation: Changes following code review
- don't update the progress bar when checking disk space (only the description)
- the color used for "in progress" action description (above the progress bar) should be the system default font color, not black
- actions should throw ArgumentNullException, not NullReferenceException

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-06 10:34:18 +00:00
Mihaela Stoica
48636e12d6 CP-10797: Ensuring sufficient disk space for service pack installation: In the Install Update Wizard check if there is enough space to upload a hotfix
- Before starting the upload to the master hosts, check if there is enough disk space (check only performed for Cream or greater hosts)
- If enough space available the upload starts automatically; otherwise an error is displayed
- If we can free up enough disk space then we offer the option to Clean up. Otherwise we provide the user with the information on required and available space and the user will have to manually free up required space.

- Also Disable the Upload page for oem updates

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-05 17:01:14 +00:00
Gabor Apati-Nagy
fddb5a032b Merge remote-tracking branch 'creedence-docker/master' into docker
Conflicts:
	XenAdmin/Wizards/NewVMWizard/NewVMWizard.cs
	XenModel/Messages.resx
2015-02-04 16:23:20 +00:00
Mihaela Stoica
f617b4ca26 CP-10621, CP-10824: Supp Pack installation through XenCenter: Changes following code review
UploadSupplementalPackAction:
- use http-put with the default timeout
- throw current exception in RemoveVDI (instead of encapsulating it in a new one)
- add other_config key before uploading to make sure the vdi has this flag set from the beginning of its lifetime
- upload progress bar now shows the total progress per row

Also included a cosmetic rewrite of PatchingWizard_PatchingPage,GetUpdateName function

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-01-28 09:51:25 +00:00
Mihaela Stoica
a6b58acbd2 CP-10824: Supp Pack installation through XenCenter: Add other_config entry for the temporary VDI
- add an entry in the VDI's other_config to identify it as supp pack iso, so that we can easily find these vdis and remove if needed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-01-27 11:00:35 +00:00
Mihaela Stoica
5b33590df0 CP-10824: Supp Pack installation through XenCenter: Install supp pack from vdi
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-01-26 15:43:36 +00:00
Mihaela Stoica
11d86f1c90 CP-10621: Supp Pack installation through XenCenter: Select and upload a supp pack in the hotfix wizard
- Select a supp pack in the hotfix wizard
- Recognise that it's a supp pack not a hotfix
- Check if there's enough space on a SR to contain it: (1) default SR if shared or (2) any shared SR or (3) local SR on each host in pool
- Create a VDI to contain it
- Upload the supp pack to the VDI

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-01-23 12:31:44 +00:00
Mihaela Stoica
dbdd3cc02c CA-157501: Fixing inconsistent GPU dialogs in XS "Standard" when compared with "Enterprise"
New properties:
- Pool.HasGpu = Pool has at least one PGPU
- Pool.HasVGpu = Pool has at least one PGPU that HasVGpu
- PGPU.HasVGpu = PGPU has at least one supported_VGPU_type that is not pass-through

New or modified helper functions:
- Helpers.GpuCapability = GPU feature not restricted (by licensing) and Pool.HasGpu
- Helpers.VGpuCapability = vGPU feature not restricted (by licensing) and Pool.HasVGpu
- Helpers.ClearwaterSp1OrGreater = API version is 2.1 or greater

The GPU dialogs are displayed as follows:
- GPU page on VM properties dialog: Visible only if VM.CanHaveGpu and the GPU feature not restricted (by licensing)
- GPU page on New VM Wizard: Visible only if VM.CanHaveGpu and the pool has GPU capability (Helpers.GpuCapability)
- GPU page on Pool properties dialog: Visible only if the pool has vGPU capability (Helpers.VGpuCapability)
- GPU tab: Visible only if the pool has GPU capability (Helpers.GpuCapability) and is Clearwater SP1 or greater
- On the GPU tab, the "Placement policy" panel: Visible only if the pool has vGPU capability (Helpers.VGpuCapability)
- On the GPU tab, the "Edit" button on the "vGPU types" panel: Visible only if the PGPU.HasVGpu and vGPU feature not restricted (by licensing)

Also:
- VM.CanHaveVGpu function renamed to CanHaveGpu
- On the GPU tab, renamed "Allowed vGPU types" to "vGPU types
2015-01-19 16:49:47 +00:00
Gabor Apati-Nagy
d50f8a7d94 Merge branch 'master' into master_github
Conflicts:
	XenModel/Messages.resx
	XenModel/XenAPI-Extensions/Host.cs
	mk/xenadmin-build.sh
2015-01-19 15:22:59 +00:00
Mihaela Stoica
13c6d323c3 CA-147163: Non-modal hotfix upload progress dialog
- Added new page to the patching wizard, called "Upload" which displays the upload actions for each server and the progress of these actions
- MultipleAction: added the functionality to optionally stop the action on first failure
- Fixed the error where an existing patch downloaded from another server and then uploaded to a new one was not deleted on cancelling the wizard [CA-156788]

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-01-09 12:54:12 +00:00
Mihaela Stoica
a109726218 CA-153178: Add context menu for Docker containers in the XC treeview and start, stop, pause and resume commands 2014-12-05 10:28:55 +00:00
Gabor Apati-Nagy
afbbf25325 CA-153179: Add options for customizing the config drive to the XC VM creation wizard
Todo: tidy up code & code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-12-04 18:04:43 +00:00
Mihaela Stoica
65b4ef1f37 CA-152052: Fix the issue where the License Manager showed the wrong state when assigning/releasing license from pool
The problem was that the License Manager was listening to PropertyChanged events on the master only, not on slaves.
When the master's properties change (e.g. edition) we update the row in the license manager; but in some cases a slave (or more) hasn't been updated yet (as it may be updated in another event.from) and we think that the pool is partially updated.
Our solution is to listen to Host BatchCollectionChanged event, which is triggered once per cache update for the host collection (it any property changed for any of the hosts).
The sleep in the ApplyLicenseEditionAction is not needed anymore, nor is the extra call to update the cell after the action is completed, because the cell is getting updated correctly on the BatchCollectionChanged event.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-11-24 16:57:42 +00:00
Mihaela Stoica
b5d14120de CA-149811: End the connection to each slave after that host has joined the pool to prevent XenCenter showing connection lost alerts
This fixes the following issue: event.from fails with "The underlying connection was closed: A connection that was expected to be kept alive was closed by the server.".
It happens because we end the connections to the slave hosts only after all hosts have joined the pool and in the meantime event.from on a slave fails.

We fix this by ending the connection to each host immediately after the host has joined the pool.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-10-28 09:36:05 +00:00
Gabor Apati-Nagy
f48f7c8f11 CP-9784: Recognise LICENSE_SERVER_VERSION_OBSOLETE alert in XenCenter 2014-10-02 16:04:05 +01:00
Stephen Turner
107e00e5fb CA-145254 Incorrect error message when try to create CIFS SR with invalid credentials 2014-09-05 16:23:22 +01:00
Mihaela Stoica
64970a7d13 CA-107598: Fixed the issue where XenCenter hides the "Licensing Error" popup when running in RDC
The reason for the error dialog appearing behind License Manager dialog was that we used MainWindow as parent of the Licensing Error dialog (in ShowLicensingFailureDialog method in ApplyLicenseEditionCommand)
and there were already 3 other modal dialogs displayed one on top of each other: License Manager, Apply License and Action Progress.
 Fixed by calling the ShowLicensingFailureDialog from the command, on action.Completed event (instead of action.Run) and passing the Parent as a parameter, so that we can use the correct parent when displaying the error dialog.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-08-14 14:40:24 +01:00
Mihaela Stoica
07e946b1f6 CA-142249: Prevent an ArgumentOutOfRangeException in ActionProgressDialog by ignoring negative values in the action's PercentComplete property.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-08-12 09:46:45 +01:00
Stephen Turner
577363a3a1 CA-141389 Log all GET and POST calls 2014-08-07 16:23:06 +01:00
Stephen Turner
399d00991b CA-139913 Convert tests of AugustaOrGreater to CreedenceOrGreater where the feature is in Creedence 2014-08-05 17:16:50 +01:00
Mihaela Stoica
cb7dcc81f4 CA-136173: Getting several notifications for one user-level action (e.g. Updating network operation creates 4 entries in the Notifications/Events view)
- Set the pool details in the action to allow proper filtering by location on the Events page
- Also, when possible, set the Host property: when setting the SR in the action, we also set the Host to SR.Home

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-21 11:40:26 +01:00
Mihaela Stoica
b544924559 CA-136173: Getting several notifications for one user-level action (e.g. Updating network operation creates 4 entries in the Notifications/Events view)
- Multiple action: propagate error messages back up the action tree to the parent action.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-21 11:24:33 +01:00
Mihaela Stoica
3c051654d6 CA-136173: Getting several notifications for one user-level action (e.g. Updating network operation creates 4 entries in the Notifications/Events view)
-  Suppress reporting of success and failure for sub-actions:
The suppress history flag is set when the action is created and if is false (by default) the action is added to the history (the Events list).
In order to suppress history for the subactions, we need change all actions used in Edit pages so their constructor can set the SuppressHistory flag and then use these constructors with suppressHistory = true on all the implementations of IEditPage.SaveSettings() where an action is created
(then we need to remember to do the same everytime we introduce a new page and / or "save" action).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-21 11:19:04 +01:00
Mihaela Stoica
d69df44cf1 CA-137305: When creating a VM, ensure that the vGPUs are unset if not needed.
If a VM is created from snapshot which has a vGPU and "No" vGPU is selected  then the newly created VM shouldn't have a vGPU.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-30 09:44:19 +01:00
Mihaela Stoica
1ff55016c8 CP-8547: Add button in XenCenter to initiate space reclamation on an SR: Changes following code review.
- Added check for null for sm.features in SR.SupportsTrim;
- Better error messages;
- Moved error messages from Messages to FriendlyNames;
- Removed the check for actions in progress from TrimSRCommand.CanExecute().

-

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-24 14:48:31 +01:00
Mihaela Stoica
1f217b9983 CP-8547: Add button in XenCenter to initiate space reclamation on an SR.
The operation applies to an SR. The button is on the Storage tab of the host/pool, and is entitled "Reclaim freed space".
It comes between the New SR and Properties buttons.
If the SR does not support TRIM , the button is invisible and the Properties button moves left to close up the gap.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-24 11:32:36 +01:00
Mihaela Stoica
8f1eb99e76 CP-8120 Set cores per socket through XenCenter: Added 'Topology' field to the New VM Wizard.
- Text on CPU page - changed to include topology.
- Summary page on the New VM Wizard – changed to include topology

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-05 13:03:06 +01:00
Gabor Apati-Nagy
728efca6e2 Merge pull request #71 from cheng--zhang/CA-135563
CA-135563:WLB tab show error message after disconnect WLB by Read-Only user
2014-05-16 14:41:19 +01:00
Cheng Zhang
bfdac9c295 CA-135563:WLB tab show error message after disable WLB using Read Only user
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2014-05-16 14:14:27 +08:00
Stephen Turner
f64d021059 CA-135078 Rename "Delete Pool"
Renamed "Delete Pool" to "Make into standlone server"
Made sure it can never work with a multi-server pool
Removed confirmation dialog, as it is not destructive
Removed from context menu, as it is not important/common enough
2014-05-15 18:47:13 +01:00
Gabor Apati-Nagy
73fccdab61 CA-115429: New fix as per code review: Deletion of snapshot is successful but XenCenter logs show error. 2014-05-15 14:18:28 +01:00
Gabor Apati-Nagy
f511403e87 CA-115429: Removed code, because it does not needed for supported XS versions
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-05-14 16:04:56 +01:00
Gabor Apati-Nagy
4ee0642a54 CA-115429: Fixed: Deletion of snapshot is successful but XenCenter logs show error.
XAPI (from 1.7) destroy destroys suspend VDIs as well (code is here: xapi: ocaml/xapi/cli_operations.ml). Depending on actual race conditions, this can lead to a situation when we try to destroy a Suspend VDI that has just been deleted.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-05-14 14:41:07 +01:00
Mihaela Stoica
6a6be458fd CA-110209: Install Update Wizard: If the patch is already uploaded, then we use it and ignore the "already exists" error. 2014-04-30 13:31:39 +01:00
Konstantina Chremmou
f1ebc3b5eb CA-130615: Do not show an event notification when the connection fails due to being
existing or due to the host being a slave. Use the action description instead of
the action title to construct the error for failed connection results. Indentation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-04-28 15:01:11 +01:00
Konstantina Chremmou
f0cf20ec43 CA-127510: Reworked the logic of differentiating between tasks started by this instance
of XenCenter and tasks started from outside and cancelling the former when exiting
or disconnecting from the pool.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-03-11 14:30:01 +00:00
Mihaela Stoica
5e5a8d7cb2 CP-7686: Make check-for-updates work in the presence of service packs by using the new fields from updates.xml, requiredpatches and conflictingpatches.
Changed the way the dependency patches are fetched, to avoid getting an exception if
requiredpatches/conflictingpatches node has at least one child that has no uuid attribute,
also checking the child name

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-03-05 10:29:59 +00:00
Mihaela Stoica
2ca98a7638 CP-7686: Make check-for-updates work in the presence of service packs by using the new fields from updates.xml, requiredpatches and conflictingpatches.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-02-17 09:31:57 +00:00
Konstantina Chremmou
f8117cd4f5 CA-114482: Changed workflow of retrieving updates: the list of published updates
is downloaded and stored every time an update is performed (if manual all updates
are downloaded, if automatic only as per the user's choices). If there are available
updates, update alerts are generated if there are connected hosts and disappear
when the hosts are disconnected.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-08 13:17:02 +00:00
Konstantina Chremmou
22ec1d9ac5 CP-6093: Redesign of the CloseXenCenterWarningDialog to use the same controls as
the events page. This renders the old custom history controls obsolete, hence
removed them. Moved ActionBase extension methods to XenAdmin.Core namespace.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-23 11:59:49 +00:00
Konstantina Chremmou
361b49066c CP-6093: Anyone outside the Alert class should not know anything about the lock
used to access the alerts list. The list itself should be private as there is a
risk to access it and forgetting to use the lock.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-21 12:32:27 +00:00
Konstantina Chremmou
da5408bf21 Missing license headers.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-14 12:59:08 +00:00
Konstantina Chremmou
c843f5b867 CP-6511: Ovf import/export for vGPU enabled VMs.
# HG changeset patch
# User Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
# Date 1384181202 0
#      Mon Nov 11 14:46:42 2013 +0000
# Node ID 6810ba763a896bcf7dd4295f30c6d5f42b02e9de
# Parent  37666849a54470e0da04b8d14c17940f8b580636

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-14 12:29:30 +00:00
Konstantina Chremmou
f7d59a8c24 [CP-6383]: Configuration of vGPU types for pGPUs
# HG changeset patch
# User Gabor Apati-Nagy <Gabor.Apati-Nagy@citrix.com>
# Date 1382623622 -3600
#      Thu Oct 24 15:07:02 2013 +0100
# Node ID 9b2305266f104c3ae9ec32804a92b3596d0aa399
# Parent  66330c7be272cd62a342e20ff109eea6b4d846f8

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-14 11:11:24 +00:00
Konstantina Chremmou
402e2458ce CP-6382: Added GPU page to the Pool properties dialog (PR-1675)
# HG changeset patch
# User Mihaela Stoica <Mihaela.Stoica@citrix.com>
# Date 1381486465 -3600
#      Fri Oct 11 11:14:25 2013 +0100
# Node ID ae162fb56bac4f1c2f7cc4c47b640a6933ea6deb
# Parent  48644db7dcf80d93efb9d6e86e982b95894cbd9d

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-14 10:35:48 +00:00
Gabor Apati-Nagy
19409f8e20 [CA-112327] Fixed Bug in BatchingMigrateVirtualDiskManager class 2013-11-04 12:35:12 +00:00
Mihaela Stoica
29a8ba30f4 CA-113396: Destoy password secrets used in SR creation after the creation is complete.
When creating an SR, if XenCenter creates new secrets, then they should be destroyed
after the SR creation is complete. This is safe since any secrets in the device-config
are duplicated and unique ones are used for each PBD creation.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-10-17 12:36:10 +01:00
Konstantina Chremmou
a879e50df1 CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User Stephen Turner <stephen.turner@citrix.com>
# Date 1378992269 -3600
# Node ID 5b5548029247d300baddfac9f2aac881ed6cc086
# Parent  28eb1719f7f648773bd707c3cb81bb537d8f78d8
CA-114912: Unlocalised strings

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 15:01:14 +01:00
Konstantina Chremmou
548944486f CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User Stephen Turner <stephen.turner@citrix.com>
# Date 1377867999 -3600
# Node ID 931d568b9b0f00809b9acbe31462423dfaf8a8d4
# Parent  5de50259a5796a999290798fb61086338db1e847
Fix [CA-114381]: Hard-coded strings

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 14:45:26 +01:00
Konstantina Chremmou
b3d2cecf89 CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
# Date 1376915592 -3600
# Node ID 4ccecd98746c40c5b1850f28c3e557e803102939
# Parent  cc14bc84973e1dd7e07ee6d90a2bac2cdd7baf79
[CA-112396], [CA-112304], [CA-112241]: Increased the width of the middle column
of the ActionProgressDialog TableLayoutPanel by 40px to reduce occurrance of text
wrapping. Ellipsized pool name in the GetHeartbeatSRsAction.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 14:23:49 +01:00
Konstantina Chremmou
ed88db2df0 Fixed two potential null reference exceptions in the XenOvfTransport project and
removed uninitialised streams which we were taking care to close. Solution-wide
style: use string.IsNullOrEmpty method instead of checking separately for null
and zero length.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 08:30:34 +01:00
Konstantina Chremmou
89fa1950a4 CP-6083: Updated test. Prevent potential NullReferenceException.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-20 14:33:23 +01:00
Konstantina Chremmou
8ae4eaa060 CP-6084: Added vGPUs to New VM Wizard.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-20 11:24:46 +01:00
Konstantina Chremmou
cab8dca36b CP-6083: Added vGPUs to the VM's property page.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-18 13:06:47 +01:00
Konstantina Chremmou
67d15dcca5 CP-5750: Moved capping of event numbers to a more relevant place and corrected logic
to remove the oldest items first and fire an event when doing so.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-13 10:52:15 +01:00
Konstantina Chremmou
62586ef89c CP-5750: Removed ActionType; the actions should be categorised by status (in progress,
succeeded, failed; cancelled at the moment counts as failed, we may need to distinguish
in future). As a consequence the filter checkboxes from the top of the Log tab
were removed and some temporary changes were made to the drawing of action rows
(the controls will change completely in a subsequent commit).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:38 +01:00
Konstantina Chremmou
38ab6b8ffa CP-5750: When a License warning is generated, create an alert rather than an Action.
Removed ActionType.Alert. Removed Alerts checkbox from the Log tab.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:36 +01:00
Konstantina Chremmou
077cb17deb CP-5750: Changed the declaration for the ActionBase events Completed, Changed and
NewAction to use the Action<ActionBase> delegate instead of EventHandler. Thus
there is no need to fire them with Empty or null EventArgs and on several occasions
we avoid casting objects in the event handlers.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:33 +01:00
Konstantina Chremmou
eb1dd68a28 CP-5750: Code tidy. Comment improvement.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:31 +01:00
Konstantina Chremmou
db1aacaa85 The parameter 'force' was added to Host.apply_edition in Clearwater, not Augusta.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-05 17:45:12 +01:00
Adrian Jachacy
da00b13bb9 Merge branch 'master' of git://hg.uk.xensource.com/carbon/trunk/xenadmin 2013-07-23 16:29:16 +01:00
Adrian Jachacy
d89d04a33d CA-76329: SR destroy option is missing from XenCenter (even SR doesn't contains any VDI and SR is detached)
1. Changed definition of IsDetached property in SR.cs: SR is detached when it has no PBDs or when all its PBDs are unplugged.
2. Added bool HasPBDs property in SR.cs (replaced previous IsDetached property definition).
3. Reviewed all usages of sr.IsDetached property.

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-23 13:42:27 +01:00
Mihaela Stoica
6399087bd5 Updated ApplyLicenseEdition action to use the correct version of Host.apply_edition depending on host's version.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-07-19 16:32:42 +01:00
Mihaela Stoica
b7d6b03577 CA-111310: Call VDI.copy asynchronously to avoid timeout [SCTX-1366]
- Changed the synchronous call to VDI.copy to an async one in VMMoveAction and MoveVirtualAction;
- Corrected the calculation of action step in VMMoveAction.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-07-16 10:25:02 +01:00
Adrian Jachacy
54b66a08d8 CP-5352: PR-1634: Request and consume list of SRs required to recover a VM / vApp, and add Resolve All button.
1. Updated XenModel.csproj following update to XenAPI.
2. Host.apply_edition requires three parameters now: pass false in the last parameter (_force parameter).

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-03 11:46:26 +01:00
Mihaela Stoica
bd36a85bff CP-4816: Initial commit to git repo
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-06-24 12:41:48 +01:00