Commit Graph

5165 Commits

Author SHA1 Message Date
Tim Liu
685a53bc22 CP-28679: XC: Allow choosing boot options during disk import (#2203)
* CP-28679: XC: Allow choosing boot options during disk import

Signed-off-by: Tim Liu <tim.liu@citrix.com>

* CP-28679: XC: Allow choosing boot options during disk import

1. Keep spaces instead of tabs
2. Update page header text to reflect the new control
3. Refine UI

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-31 02:02:33 +01:00
Konstantina Chremmou
a1033de3a4
Merge pull request #2206 from xenserver/master
Merging from master into feature/REQ-396 to fix broken tests
2018-08-29 15:17:44 +01:00
Tim Liu
0b9c2f4f96 CP-28678: XC: Import UEFI OVFs correctly
Add comment for the unusual function usage

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-29 10:54:37 +01:00
Konstantina Chremmou
ad773d8f75 Fixed null reference exception in tests.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-29 10:25:47 +01:00
Tim Liu
2cc5b1f0b6 CP-28676: XC: Allow choosing boot options during new VM wizard
1. Make controls auto sizable
2. Change hotkey
3. Rename variable

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-28 12:46:36 +01:00
Tim Liu
f0b1e6b3af CP-28676: XC: Allow choosing boot options during new VM wizard
1. Update the duplicated shortcuts on CPU&Mem Page
2. Default radio boxes invisible
3. Move hardcoded logic to VM.cs
4. BIOS boot should be always enabled
5. Move radio boxes to Installation Media page
6. Extract radio boxes as a user control
7. Update summary

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-28 12:46:36 +01:00
Tim Liu
98207906d7 CP-28676: XC: Allow choosing boot options during new VM wizard
Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-28 12:46:36 +01:00
Tim Liu
25c0787238 CP-28677: XC: Exported OVFs contain UEFI metadata
1. Add count check
2. Refine the code by linq (both export & import)
3. Create new desc rather than using the generic one
4. Add backward compatibility when importing

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-28 10:42:48 +01:00
Tim Liu
92d786d051 CP-28677: XC: Exported OVFs contain UEFI metadata
Extended xenBootOrder to xenBootParams

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-28 10:42:48 +01:00
Konstantina Chremmou
12678f0afa CA-286882: Updated unit tests.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-24 16:18:44 +01:00
Weiwei You
1ed70d2233 CP-28915: Add HavanaOrGreater method
Signed-off-by: Weiwei You <weiwei.you@citrix.com>
2018-08-24 12:12:28 +01:00
Darren Matthews
f7859a1596 L10N: Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-23 08:41:13 +01:00
Darren Matthews
0e7057d067 L10N: Translation updates and Re-Sync JA & CN resx files to match the new English resx
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-22 09:02:08 +01:00
Darren Matthews
fc7ec88fd4 L10N: CA-294333 fixed overlap issue in JA resource file
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-22 09:02:08 +01:00
Tim Liu
d432cf5477 CA-293776: The order in which a single update is applied on the slave… (#2180)
* CA-293776: The order in which a single update is applied on the slaves is not the same as the order in which they are displayed

Apply the same Hosts sorting rules for all the PatchingWizard Pages .

Signed-off-by: Tim Liu <tim.liu@citrix.com>

* CA-293776: The order in which a single update is applied on the slaves is not the same as the order in which they are displayed

Place orderby clause after where clause

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-20 15:46:58 +01:00
Konstantina Chremmou
b36534c157 CA-293813: Patch pools in parallel when installing a single update/patch or supplemental package. (#2183)
* CA-293813: Patch pools in parallel when installing a single update/patch or supplemental package.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Corrections as per code review.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 12:05:16 +01:00
Konstantina Chremmou
542da6487c Removed call to empty base method. Added erroneously removed comma.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 08:23:04 +01:00
Konstantina Chremmou
1c2845697c Fixed tab order; renamed the radio buttons because it was difficult to tell what each one referred to.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 08:23:04 +01:00
Konstantina Chremmou
6885c21b5e Removed unnecessary control VMMemoryControlsBase and moved the logic of the VMs
property to the derived classes (they don't share much of it anyway) and the method
CalcMemoryUsed to the VMShinyBar class where it is needed. Also made the latter's
property Increment non-browsable.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 08:23:04 +01:00
Konstantina Chremmou
c67f85ebaa CA-210190: Fixed various layout and truncation issues on the VM/template memory
setting controls. Also removed the various types of ballooning dialogs since
the only thing changing was the contained memory settings control.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 08:23:04 +01:00
Konstantina Chremmou
9b61298113 Added hotkeys; fixed tab order; fixed flickering of warning message on first load.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-16 14:09:36 +01:00
Mihaela Stoica
e21c26be67 CA-271864: Add the missing setter
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-16 11:38:34 +01:00
Mihaela Stoica
20dfd74375 CA-271864: Add the host name to the precheck problem description for more Problem classes.
Also changed two classes to inherit from the VMProblem class.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-16 11:38:34 +01:00
Mihaela Stoica
8b2ab5f79d Removed some unused classes and messages
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-16 11:38:34 +01:00
Mihaela Stoica
5879b5ae60 CA-271864: Add the host name to the precheck failure when the VM cannot be evacuated.
The other part of this ticket (add OTHER_OPERATION_IN_PROGRESS to the known errors) has already been done in commit 97a60c91.
Minor refactoring to the VMProblem class.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-16 11:38:34 +01:00
Konstantina Chremmou
c8c2ea448a CA-156828: Do not uncompress imported appliance on a modal dialog, but rather
asynchronously on the SelectImportSourcePage, so that the rest of XenCenter
is usable while the unzip is taking place; for this purpose a progress bar
was added on the page and the DecompressApplianceDialog was removed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-16 10:59:35 +01:00
Konstantina Chremmou
a918a0b0c8 The method UpdateToolbarsCore should be private. Do not call it explicitly; it is
called by the PluginsChanged event handler.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
c270882737 Improved previous commit to avoid setting the TabPageFeature Urls when switching
from this an object with selected TabPageFeature to a different object with a
deselected TabPageFeature.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
abec5c4aba CA-284090: Added a dedicated status bar on the TabPageFeature to resemble real
life browsers and allow the user to see the status even if other actions are taking
place. Removed webClient use from the browser; instead try sequentially to navigate
to all Uris until one succeeds; this avoids sending duplicate requests and allows
the user to see all endpoints tried out. Reworked the WebBrowser event handlers
to ensure the UI reflects correctly the browser state.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
07f298096f CA-284090: Refactored the code setting the object in the TabePageFeatures to avoid
multiple iterations as well as updating the feature when it's not needed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
d67dd1c815 Do not create a Uri if there are no IPs as it throws exception unnecessarily; Return
about:blank instead. Removed parameter null check as it is done by PlaceholderRegex.Replace.
Minor tidy up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
3de03f32d3 Simplified retrieval of credentials from authentication prompt.
Placed TabPageCredentialsDialog controls on a TableLayout panel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
518951d868 Deregister events and dispose of web clients when removing them from the list.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
23975c5ee6 Updated event signature to use Action<T1,T2> instead of custom delegates.
Moved NavigateError- and AuthenticatinPromptEventArgs classes inside WebBrowser2
as they are only relevant to the latter class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Konstantina Chremmou
7494a712fb Re-arranged the class members to make the file easier to navigate and minimise scrolling up/down when developing.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-15 09:59:58 +01:00
Mihaela Stoica
034f472163 CA-286882: Check for page visibilty before calling HidePage
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-13 17:18:53 +01:00
Mihaela Stoica
56a3725b36 Corrected the title and description of VM lifecycle operations when run as Mulltiple/Parallel actions
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-13 17:18:53 +01:00
Mihaela Stoica
8230315f76 CA-286882: Shutting down large number of VMs causes XenCenter to hang
Created a new base class for the Notifications pages (Alerts, Updates, Events). This can be used in the future to host more of the common code between these pages. For now, it implements a common mechanism for showing/hiding the page and ensures that the event handlers are deregistered when the page is hidden (i.e. when the user switches to a different view) and registered again when the page becomes visible

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-13 17:18:53 +01:00
Konstantina Chremmou
f4d92da5ee CA-202377: Removed last instance of the QueuedBackgroundWorker and deleted the class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-13 17:04:27 +01:00
Konstantina Chremmou
78ecef617d Fixed issue where the agility calculation was run even for VMs that were not
actually added (because they can't be protected, e.g. the control domains).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-13 17:04:27 +01:00
Konstantina Chremmou
649e5a3483 Do not start updating the agility before reaching the corresponding page on the HAWizard.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-13 17:04:27 +01:00
Konstantina Chremmou
a68ca3beb2 Added tooltip on the Agility cell so the user can see the reason why the VM
is not agile simply by hovering over the cell. Previously the user could see
this only if they selected the VM, expanded the restart priority dropdown
and hovered over the Restart item.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-13 17:04:27 +01:00
Kat Shann
72562ba059 Lima Help Files (#2178)
* L10n: Inverness: build_chm #24
* Revert "L10n: Inverness": This reverts commit 8b41bb8c79cd4d73ed6021a5533cf7624a5421c4.
* L10n: Inverness: CHMs from build_chm master-l10n #24 Second attempt at checkin with a merge conflict resolve. (I hope)
* L10n: Localized files with fix: Remove artifacts introduced by XTM
* Update Kolkata Help files
* Update fro broken links fix
* CP-28648: Check -in the Lima versions of the CHM files

Signed-off-by: Katherine Shann <katherine.shann@citrix.com>
2018-08-13 11:42:06 +01:00
Konstantina Chremmou
b19d2fdeec CA-104539: Don't allow the user to make a pool into a standalone server if HA is enabled
or being enabled. Although the CLI allows it, it makes sense to disallow deleting the pool
when HA is on because XenCenter does not offer enabling HA if there is no pool there.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-10 09:50:31 +01:00
Konstantina Chremmou
0827d686ba Added hotkeys to ToolStriMenuItems and ellipsis (in reality only the iscsiToolStripMenuItem
launches a dialog requiring user input, but added it to fcToolStripMenuItem
too because it looks symmetric and in any case the user does have to close
an error pop-up if the scan fails). Also, do not show "no SRs found pop-up"
if the user cancels the IscsiDeviceConfigDialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-10 09:50:31 +01:00
Ji Jiang
d0fc3be56e CA-294091: Fix two Update wizards co-exist bug
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-08-07 12:02:57 +01:00
Mihaela Stoica
61ee71dac1 CA-290536: Fix XenCenter uncaught exception in VM console when losing host connection
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-06 15:14:24 +01:00
Mihaela Stoica
b8168eed28 CA-292626: Consider the contains-livepatch flag of all the applicable… (#2165)
* CA-292626: Consider the contains-livepatch flag of all the applicable updates when doing the prechecks in the automated updates mode.

Instead of looking at the minimal patches, we look at all applicable patches for that host (i.e. all the updates on the host's version that are not already installed) and we say that the host won't need a reboot only if all these are marked as contains-livepatch.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-03 16:11:06 +01:00
timliu55
51ba3a82ce CA-293854: Patching wizard updates list loses selection and resizes c… (#2164)
* CA-293854: Patching wizard updates list loses selection and resizes columns when resorted
Remove the redundant code
Change the AutoSize mode from DisplayedCells to AllCells.
Fix the date column sorting
Disable column header AutoSizing

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-03 11:32:51 +01:00
liulinC
7be8bd0530 CA-204242: save the server status report blocks xencenter (#2158)
* CA-204242: save the server status report blocks xencenter

Signed-off-by: Lin Liu <lin.liu@citrix.com>
2018-08-03 09:08:47 +01:00