Commit Graph

3552 Commits

Author SHA1 Message Date
Konstantina Chremmou
6caa4199cd CA-328267: Only remove connection dialogs when they close, not when the AddServerDialog closes.
Otherwise the connection dialog remains open even after a connection that required
entering a new password succeeded.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-29 10:07:36 +00:00
Konstantina Chremmou
576d2d5a83 CA-271455 regression: clean temporary OVF packages extracted from OVAs, but not original OVF packages.
Also, remove obsolete lines that delete touch files (they are not created any more).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-29 10:07:36 +00:00
Konstantina Chremmou
70ec38b5d5 CA-333226: Reload the SR selection page when the selected affinity changes.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-24 11:45:54 +00:00
Konstantina Chremmou
bfc8141391 CA-318468, CA-271455: Reworked OVF validation and OVA package extraction during import.
- Handle validation for OVF files with a name different from the containing
  OVA package. Other corrections to wrong validation logic.
- Show validation warnings on a dialog that can be turned off.
- Clean up extracted files after an OVA package has been imported.
- Plus code refactoring and simplification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-16 16:26:30 +00:00
Konstantina Chremmou
45fe63ecde Corrections as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-08 16:09:36 +00:00
Konstantina Chremmou
efa0fc2fdc CA-187943: Show a warning when a new VM's disks cannot be accommodated on the template or default SR due to lack of space.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-08 16:09:36 +00:00
Konstantina Chremmou
9e33f4c90c Do not re-select a best SR if the user has already selected one via the New Disk dialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-08 16:09:36 +00:00
Konstantina Chremmou
99a3a30fc7 Removed methods that add unnecessary complexity.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-08 16:09:36 +00:00
Konstantina Chremmou
ef7c90a9e9 Layout modifications.
- Renamed button to make it more discoverable.
- Placed the controls on a table layout panel for better response to wizard resizing.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-08 16:09:36 +00:00
Konstantina Chremmou
9e1ec4cf41 CA-333236: Calculate local time for HotfixEligibilityAlert properties on the UI thread.
The Title and Description of HotfixEligibilityAlert  involve calculation of local
time which should be done on the UI thread, otherwise the time is not localised
correctly, and additionally the application crashes when dismissing or sorting
these alerts.
Also, stop spamming the logs with each alert removal; code efficiency correction.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-02 13:15:18 +00:00
Darren Matthews
ce217adc60 L10N : Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-12-13 12:49:56 +00:00
Konstantina Chremmou
198baf4beb CA-332711: Do not count checked pools as selected if they are disabled.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-11 10:25:43 +00:00
Konstantina Chremmou
f459ef5956 CA-331420: Do not refresh the license status on the general tab if the selected object is not a pool/host.
- Removed AsyncServerTime class as it adds complexity and the risk of
  getting an outdated time.
- Simplified event signatures and compacted nested method calls.
- Fixed typo and removed unused code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-09 14:39:09 +00:00
Xueqing Zhang
224acb6706 CA-330890: update storage select wazard in XCM
Signed-off-by: Xueqing Zhang <xueqing.zhang@citrix.com>
2019-12-09 11:06:25 +00:00
Konstantina Chremmou
fc1cbf636e Simplified signature of connection events.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-06 11:17:46 +00:00
Konstantina Chremmou
1bf5add051 Typo in property name.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-06 11:17:46 +00:00
Konstantina Chremmou
b9522c8cb2 CA-328267: Do not show the connection dialog if it's already disposed. Various other code improvements:
- Use the base class connection property instead of an own field.
- Do not fix fonts an window location; it's done in the parent class.
- Corrected event registration and duplicate handling.
- Launch modal forms in using blocks.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-06 11:17:46 +00:00
Konstantina Chremmou
a18d6d3ccb The application would not exit if closed with a connection dialog open. Performance improvement.
- Set owner form for some connection commands to ensure that the application
will exit if the user attempts to close the main window while a connection
dialog is visible.
- Do not iterate through all the VMs of the connection in order to close
potentially open VM dialogs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-06 11:17:46 +00:00
Konstantina Chremmou
11cd01900b Made the XenDialogBase's connection a readonly field so it's set in a uniform way throughout the application.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-06 11:17:46 +00:00
Konstantina Chremmou
e34cf30168 Renamed dialog to match containing file name. Minor refactoring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-06 11:17:46 +00:00
Konstantina Chremmou
9cfb714322 CA-330814: Code clean-up in the XenOvfTransport project.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-19 09:20:14 +00:00
Konstantina Chremmou
6bc54fc1e8 CA-330686: use the SM capabilities instead of the allowed operations for deducing if the SR supports mirroring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-18 13:01:33 +00:00
Mihaela Stoica
cb1531ae0d CA-330689: Fix failure in the cross pool migrate filter
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-11-15 17:11:09 +00:00
Konstantina Chremmou
1050b14edc Prevent from crashing if cancelling the Import wizard while on the Select host page.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-14 12:14:26 +00:00
Mihaela Stoica
aca8be2939 CP-32431: Add version check to the drag and drop commands
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-11-13 13:39:27 +00:00
Konstantina Chremmou
5614dafbe6 CA-329742, CA-330301: Logging simplification.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
99572da0fb Corrections to the logging of Win32 exceptions. Minor refactoring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
667e9e8caf Log the stack trace when an exception is encountered and don't use the *Format() counterpart of the logging method for it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fad80c778b Avoid duplicate logging; compact multiple logging calls.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
f4265732ca Do not localise log entries or ellipsise names. Log exception stack traces where applicable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fb2edf99b8 Do not initialise a logger if a class does not use it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
61fccecac6 Corrected the supported runtime's sku in xenadmin's application config.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:19 +00:00
Konstantina Chremmou
0eb2f09fa2 Ensure we update the controls on the UI thread.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:19 +00:00
Mihaela Stoica
b73f5c9beb CP-32431: Remove the CPU feature compatibility check from XenCenter
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-11-12 09:47:04 +00:00
Darren Matthews
e56a6e5d66 L10N : Translation Update and Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-11-11 15:23:40 +00:00
Mihaela Stoica
93a6171108 CP-32361: Update the RPU hotfixes
- Replaced RPU003 and RPU004 with new versions
- Added RPU005 for Naples

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-11-11 15:23:29 +00:00
Mihaela Stoica
01b011c982 CA-329399: Improve the error message displayed if the update wizard if a host cannot be evacuated.
If a host cannot be evacuated because other hosts in the pool are maintenance mode and pending a reboot following an update installation, then include instructions to reboot those hosts and then press Retry.
Also updated the text for the Manual mode, removing the reference to installing other updates and doing a reboot manually at the end, because that won't be always possible, due to the fact that now we put the hosts in maintenance mode before installing the update.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-11-08 10:27:49 +00:00
Konstantina Chremmou
4a8507fd86 CA-330394: Fixed issue whereby queued conversions had a start time in future.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-08 09:24:06 +00:00
Mihaela Stoica
326e4d8fe8 CA-329695: Restrict switching the boot mode in the New VM wizard (when created from template or snapshot)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-11-01 15:14:24 +00:00
Konstantina Chremmou
56b3990875 CA-329838: Do not reload the last wizard page when hitting the finish button.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-01 11:00:46 +00:00
Konstantina Chremmou
5d8b0f685f Corrected spelling to match the docs. Use en-us spelling.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-30 11:41:44 +00:00
Konstantina Chremmou
dcaf527757 CA-293784: Path and message updates.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-30 11:41:44 +00:00
Konstantina Chremmou
7cc42fe2ee CA-329317: When migrating a VDI do not enable target SRs that do not allow mirroring.
- Compacted code deciding whether to show an SR on the picker.
- Removed code sorting the disabled SRs because it repeats partially the
SR checks without reflecting exactly the disabled reason and probably
causes confusion when compared with the main treeview.
- Renamed property.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-25 10:07:06 +01:00
Darren Matthews
01764e8972 L10N: Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-10-21 13:53:59 +01:00
Mihaela Stoica
32981d24f1 CP-32254: Add DMC deprecation banner
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-10-18 10:04:51 +01:00
Xueqing Zhang
4dacede64b CP-32033 Add PV guests precheck in Xencenter
Signed-off-by: Xueqing Zhang <Xueqing.Zhang@citrix.com>
2019-10-18 09:56:21 +01:00
Konstantina Chremmou
ce958e5999 Corrected message and tab indices.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
d013c21f27 Further corrections to the DiskSpinner's rounding behaviour.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
f39a715816 CP-29522, CA-302477: Added TB option to the NumericUpdown of the NewDiskDialog and fixed validation on the VDISizeLocationPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
73eaed6af8 Fixed some issues around the validation of SrPicker selections.
- Fixed button enablement on the IntraPoolCopy page.
- Regression on the NewDiskDialog were selection was considered valid
even if the SR was disabled.The SrSelectionChanged and SelectedIndexChanged
were fired in the wrong order. To fix this the event SrSelectionChanged
is removed (in reality after the refactoring in 5b79b1dc94
it became obsolete).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00