Commit Graph

700 Commits

Author SHA1 Message Date
Konstantina Chremmou
563b2cc359 CA-338276: Corrected virtualisation state link text for post stockholm linux guests.
Also, merged the methods calculating the virtualisation status and its friendly
string so as to simplify the logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-26 00:03:45 +01:00
Konstantina Chremmou
9bf7e80fe9 Merged branch master into feature/REQ-716 and resolved conflicts.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/BallooningDialog.cs
#	XenAdmin/Dialogs/WarningDialogs/InstallToolsWarningDialog.cs
2020-04-24 15:37:01 +01:00
Konstantina Chremmou
40e395f2bd CA-338273: Accept more ISO 8086 formats.
Also, move time utility methods to one place (the Util class which contains unit conversions).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-24 14:30:32 +01:00
Konstantina Chremmou
60da6080f9
Refactored three button dialog (#2627)
* ThreeButtonDialog simplification step1: Help name.
* ThreeButtonDialog simplification step2: Window title.
* ThreeButtonDialog simplification step3: Removed class Details.
* ThreeButtonDialog simplification step4: Removed unnecessary (and wrong) class.
* ThreeButtonDialog simplification step5: Compacted TDButton constructors.
* ThreeButtonDialog simplification step6: Removed purposeless methods.
* ThreeButtonDialog simplification step7: Refactored constructor logic.
* ThreeButtonDialog simplification step8: Icon normalisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-22 14:47:03 +01:00
Konstantina Chremmou
f31a8f2085 Some refactoring to memory editing controls.
Override the polymorphic methods of XenTabPage on the ballooning wizard;
No need to exposed the memory values outside the VMMemoryControlsEdit class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-17 16:23:06 +01:00
Konstantina Chremmou
d198b693d1 Replaced InstallToolsWarningDialog with a ThreeButtonDialog. Removed methods duplicating command execution logic.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-17 16:23:06 +01:00
Konstantina Chremmou
dfb49c97a1 CP-32687, CP-32689: Remove "Install PV Tools" options from stockholm onwards.
Replace with help links where necessary or convenient. Also:
- Registered unused event.
- Minor refactoring to: make the InstallToolsCommand.CanExecute clearer; use
  local methods.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-17 16:23:06 +01:00
Konstantina Chremmou
456978e572 CP-32688: Remove guest tools from DVD ISO dropdown for Stockholm onwards
Also, removed properties that were never set to true.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-17 16:23:06 +01:00
Konstantina Chremmou
03dbf38f6f Merge branch 'master' into feature/REQ-814
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenModel/Messages.Designer.cs
2020-04-02 10:58:58 +01:00
Konstantina Chremmou
3ecd6a4d8b Fixed missing ExpandedChanged event registrations. Tidied up methods toggling the section expanded state.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-01 16:27:13 +01:00
Konstantina Chremmou
2b3884fa72 Spinner Icon enhancements
Added failure result; added default values for success and failure images;
renamed method and property; removed duplicate code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-01 16:27:13 +01:00
Konstantina Chremmou
4ff42f51f3 Modifications on the NewNetwork wizard (includes CA-192746).
- NetworkDetails page: reworked it to fix NumericUpdown validation and messages (CA-192746).
- SelectNetworkType page: moved warnings closer to the corresponding network types,
  fixed wrong label enabled state and made enablement logic more explicit.
- All pages: property modernisation and control layout tweaks (mostly margins).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-02 17:46:29 +00:00
Konstantina Chremmou
cf633c3d9d Removed duplicate method.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-02-28 13:33:57 +00:00
Konstantina Chremmou
f459ef5956 CA-331420: Do not refresh the license status on the general tab if the selected object is not a pool/host.
- Removed AsyncServerTime class as it adds complexity and the risk of
  getting an outdated time.
- Simplified event signatures and compacted nested method calls.
- Fixed typo and removed unused code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-09 14:39:09 +00:00
Xueqing Zhang
224acb6706 CA-330890: update storage select wazard in XCM
Signed-off-by: Xueqing Zhang <xueqing.zhang@citrix.com>
2019-12-09 11:06:25 +00:00
Konstantina Chremmou
fc1cbf636e Simplified signature of connection events.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-06 11:17:46 +00:00
Konstantina Chremmou
11cd01900b Made the XenDialogBase's connection a readonly field so it's set in a uniform way throughout the application.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-06 11:17:46 +00:00
Konstantina Chremmou
6bc54fc1e8 CA-330686: use the SM capabilities instead of the allowed operations for deducing if the SR supports mirroring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-18 13:01:33 +00:00
Konstantina Chremmou
5614dafbe6 CA-329742, CA-330301: Logging simplification.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fad80c778b Avoid duplicate logging; compact multiple logging calls.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fb2edf99b8 Do not initialise a logger if a class does not use it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Darren Matthews
e56a6e5d66 L10N : Translation Update and Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-11-11 15:23:40 +00:00
Konstantina Chremmou
7cc42fe2ee CA-329317: When migrating a VDI do not enable target SRs that do not allow mirroring.
- Compacted code deciding whether to show an SR on the picker.
- Removed code sorting the disabled SRs because it repeats partially the
SR checks without reflecting exactly the disabled reason and probably
causes confusion when compared with the main treeview.
- Renamed property.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-25 10:07:06 +01:00
Konstantina Chremmou
ce958e5999 Corrected message and tab indices.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
d013c21f27 Further corrections to the DiskSpinner's rounding behaviour.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
f39a715816 CP-29522, CA-302477: Added TB option to the NumericUpdown of the NewDiskDialog and fixed validation on the VDISizeLocationPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
73eaed6af8 Fixed some issues around the validation of SrPicker selections.
- Fixed button enablement on the IntraPoolCopy page.
- Regression on the NewDiskDialog were selection was considered valid
even if the SR was disabled.The SrSelectionChanged and SelectedIndexChanged
were fired in the wrong order. To fix this the event SrSelectionChanged
is removed (in reality after the refactoring in 5b79b1dc94
it became obsolete).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
ec79720057 Do not pass the delegates showing messages as parameters to the actions, but rather have them handle action events.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Mihaela Stoica
8b41a214b2
Merge pull request #2521 from xenserver/feature/REQ-756
Merge feature/REQ-756 into master
2019-09-27 13:18:21 +01:00
Darren Matthews
4a3fd35b51 L10N: Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-09-25 15:17:19 +01:00
Konstantina Chremmou
5244c91658 Help refactoring.
- Removed DebugHelp. The user settings are normally not meant for debugging code.
- Moved HelpId logic from the main window to the tab pages.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 15:02:05 +01:00
Konstantina Chremmou
3d92246607 The GpuConfiguration list should not be editable. Resize GpuShinyBar Edit button when the text changes.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-23 13:39:54 +01:00
Konstantina Chremmou
6066de3ae2 Corrections and enhancements. (#2496)
* Corrections and enhancements.

Fixed version compatibility check. Added context menu to the conversion list.

* Exclude templates and snapshots when looking for the conversion VM.

* Further corrections.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-28 14:57:36 +01:00
Konstantina Chremmou
d22b212afa Renamed property as there are clashes with a child class (will have to be refactored in future). Treat warnings as errors in all projects.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-22 14:03:30 +01:00
Konstantina Chremmou
9157735803 CP-30958: Initial implementation of the Conversion Manager in XenCenter. (#2481)
* CP-30958: Initial implementation of the Conversion Manager in XenCenter.
* Corrections following review and improvements.
* Further corrections and improvements.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-22 10:47:43 +01:00
Konstantina Chremmou
c0d6b409e2 CA-324782: Select the right memory SR otherwise the PVS cache appears as not configured.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-06 10:43:01 +01:00
Konstantina Chremmou
30226c590d CA-116060: Stop saving the expanded state of the New Search panel with the other Search metadata.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-23 14:00:38 +01:00
Darren Matthews
8c59390de0 L10N : CA-207272 truncation issue fix
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-07-23 11:27:21 +01:00
Konstantina Chremmou
0e57e871b9 Removed unnecessary instance class SrPickerItemFactory.
Removed comments that did not provide further info than the class name
they were documenting. Removed unused code. Launch progress dialog within
a using block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 16:19:25 +01:00
Konstantina Chremmou
6e9ac153ca CA-323248: Allow VDI move to a local SR if the latter can be seen from the home hosts of the VMs the VDI is attached to.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 16:19:25 +01:00
Konstantina Chremmou
4844bac1e8 CP-30451: Unit test restructuring and modifications for better use of the Nunit3 framework.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-11 16:34:59 +01:00
Michael
99af56ac94 REQ-720: Initial implementation of GPUEditPage and AddVgpuDialog. (#2422)
* CP-31063: Add support for multiple vGPU
(incomplete)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CP-31063: Add support for multiple vGPU
(part 2)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* AddVGPUDialog

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Update bindings.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* REQ-720: Initial implementation of AddVgpuDialog.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Improve the handling of buttons and combobox. Fix comments.

Signed-off-by: Michael Z <michael.zhao@citrix.com>

* Fix comments.

Signed-off-by: Michael Z <michael.zhao@citrix.com>
2019-06-10 14:49:31 +08:00
Darren Matthews
1f2a729573 L10N : Translation Updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-06-09 17:04:28 +01:00
Darren Matthews
0a6d66ce6d L10N : translation update and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-05-28 21:53:56 +01:00
Konstantina Chremmou
8b1e799c7b General TabPage layout modifications (includes CA-164372). (#2439)
- CA-164372: Added line breaks in the pool updates list for readability and to match the corresponding host list.
- Moved the updates, version and licence sections closer together.
- Removed unnecessary panels and placed top buttons on a TableLayoutPanel.
- Moved size hardcoded values from the code to the resource files.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-05-21 11:58:26 +01:00
Konstantina Chremmou
4ce9878b45 Refactored the VIFDialog to fix various problems: (#2398)
* Refactored the VIFDialog to fix various problems:
- Launch the dialog in using blocks.
- Event GotFocus is not meant to be handled directly in the code.
- Populate the dialog in the OnLoad override instead of the constructor
  as this causes problems at design time.
- Popping up an error message for duplicate MAC on combobox item
  selection or textbox text change is not optimal UX. Perform this
  check once when closing the form. Additionally the parent form of the
  pop up should be the dialog, not the main window.
- The validation messages are not obvious to the user because they are
  hidden in the tooltip of a disabled button. Show them inline instead.
- There is no need to create commands for VIF creation/change; use
  the relevant actions instead.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Corrections as per code review plus some more code tidy and refactoring.

- Added option to suppress Create/DeleteVIFActions
- Use property RebootRequired to indicate hot-plugging is unavailable
  (assigning various objects of different types to the Result of the action
  during its run may cause confusion).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-25 08:23:09 +01:00
Konstantina Chremmou
6273856761 Prevent VisualStudio's designer from crashing when opening the MainWindow.
Made command parameterless constructors public; made browsable events public;
replaced manually written with auto-generated code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-24 15:03:20 +01:00
Aaron Robson
cdc8de930f CA-301907: Improvements to the VMSS dialog, the VMSS frequency properties/wizard page and the VMSS finish wizard page (#2358)
- On the dialog show the next run time in both the client's and the server's local time zone.
- On the VMSS frequency page allow the user to pick the schedule in the client's
  local time zone and show then next run time in both the client's and the server's local time zone.
- Refactoring to fix workflow and class design, reduce amount of code and simplify logic.
- Various layout improvements.

Signed-off-by: Aaron Robson aaron.robson@citrix.com
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-15 14:10:42 +00:00
Konstantina Chremmou
2c884ea47f CA-311146: Copy the results of a linq query to a list to prevent
enumeration on modified collection (it also improves efficiency).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-02-26 11:18:53 +00:00
Konstantina Chremmou
eef3320eca Removed code applicable to servers earlier than dundee since connection to them is now blocked.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-02-06 09:25:38 +00:00
Konstantina Chremmou
749518e94c CA-303195: Provide the user the option to reconsider wizard cancellation
(either when cancelling the wizard itself or exiting the application).
Implemented in the first instance for compiling the server status report.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-15 17:12:09 +00:00
Konstantina Chremmou
7a0658c908 Reduced accessibility of controls to private. Moved some of the wizard cancelling
logic to the last wizard page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Konstantina Chremmou
1789abb901 Reduced accessibility of controls to private. Minor refactoring. Typo. Removed
unnecessary event handler. Removed event that was fired but never subscribed to.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Konstantina Chremmou
033b7579ef Reduced accessibility of controls to private.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Konstantina Chremmou
e762dd04c7 Added readonly restrictions to DataGridViewRow cells.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 11:30:15 +00:00
Konstantina Chremmou
83732625ac The event handler meant to toggle the section's expanded state on mouse double
click was hooked to the wrong event.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-18 09:28:47 +00:00
Tim Liu
530257c1bb Fix the wrong layout
Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-12-11 14:52:20 +00:00
Darren Matthews
e6d2861b9b L10N : Translation updates and resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-12-03 14:48:42 +00:00
Konstantina Chremmou
16c88cc7b7 CA-302791: Rewrote the ChangeFolder dialog to fix usability issues.
- Corrected folder selection; reduced clicks required to select folders;
  improved text; added delete button.
- Moved FolderChangeDialogTreeView to the same folder as the other TreeViews;
- Added missing null checks to the MutliSelectTreeView and hid properties
  HScrollPos and VScrollPos from VS's designer (the former was initialised
  to zero every time the designer was updated, causing the treeview images
  to disappear).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-26 10:29:39 +00:00
Aaron Robson
4af1f68fd6 CA-270440: Copy VM full copy SR list isn't sorted naturally. Resolving not just for SrPickerItem but for the CustomTreeNode as used for other related classes.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-16 15:11:34 +00:00
Aaron Robson
7122615836 CA-271967: Dismiss button is flat after dismissing first of a list of events.
Handling OnMouseMove which fires more repeatedly than OnMouseEnter and OnMouseLeave with an early return to preserve CPU efficiency.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-11-16 11:14:21 +00:00
Konstantina Chremmou
2a575b01a5 Fixed issue whereby VS kept toggling between SubType Component and User Control
for some custom controls.

In the case of DoubleBufferedPanel I removed the Designer attributes from
the class definition.
In the case of the EnableableComboBoxEditingControl I moved it to a new
file because the other classes it was sharing the old file with did not
derive from Component.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-09 16:23:29 +00:00
Konstantina Chremmou
c1256c7734 Removed redundant code from GradientPanel and made it more object oriented;
also moved it out of the containing folder as it was its only resident.
Corrected the TitleBar fore colour as it was hard to read due to small contrast
with the bar's backround colour; normalised the code setting the other colours
so it's more unambiguous.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-09 16:20:52 +00:00
Darren Matthews
1a74fd440f L10N: Translation and resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-29 12:01:08 +00:00
Konstantina Chremmou
e9b598e3ba CA-209495: Layout correction on exit VM full screen tip.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-26 13:39:13 +03:00
Konstantina Chremmou
fdb9cb4743 CA-235084, CA-235085: Layout corrections on the host and VM memory panels.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-26 13:39:13 +03:00
Konstantina Chremmou
5b79b1dc94 Removed the label from the SrPicker because in half of the occasions it was
hidden and in all other cases it was set by the implementing control, i.e.
the label was not reusable, hence no reason to have it in the control and risk
layout issues. This means that the SrPicker does not need to be a control
encapsulating a CustomTreeVIew, but simply derive from the latter.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
f1d5abb7a5 Replaced duplicate events ItemSelectionNull and ItemSelectionNotNull with SrSelectionChanged.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
0fe584cdba Removed unnecessary method and replaced it with the field it returns.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
0eef02fc3b Removed redundant code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-24 12:49:31 +01:00
Konstantina Chremmou
90589a30c9 Modified treeview and toolbar updates (#2264)
This PR is aimimg to (1) fix a regression introduced by #2223 whereby the toolbar items did not have the correct state on first launch; (2) improve performance by removing some updates which I believe are not needed.

* Removed some duplicate calls to RefershTreeView and UpdateToolbars because
they are called within the action's Complete event handler.
Also, normalise the way the treeview refresh is requested by the various actions the
commands are launching.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Removed some explicit calls to refresh the treeview since this is done by
the connection result handlers.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* The toolbars and tabs should be updated every time the treeview is refreshed.

This should happen when the refresh event is handled rather than calling
UpdateToolbars explicitly after a treeview refresh is requested; also, it is
the treeview refreshes that should be throttled and not the toolbar and
tab updates (the throttling mechanism may need correction).
Also, removed unnecessary Invoke as we are already on the UI thread.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Simplified UpdateManager.Update event declaration.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-16 16:24:54 +01:00
Aaron Robson
c1c368070a CA-299063: Prevent the Network Interfaces from disappearing when the VM is Locked due to a Storage Deveice being deleted.
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-08 12:59:55 +01:00
Konstantina Chremmou
edea57ebf3 Simplified the logic updating the TabPages.
- The new logic of adding/removing tabs in the ChangeToNewTabs method also fixes
  tab-title flickering when we move from the Home node to a disconnected host.
- Renamed enum members Tab.Overview to Tab.Search and Tab.Settings to Tab.General
  since the pages mapped to them are TabPageSearch and TabPageGeneral respectively.
- Do not call directly UpdateToolbarsCore but rather UpdateToolbars since the
  latter takes account of the queued requested updates.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
b267007bdc Unused code removal; designer tidy up.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
194cd18ea3 Do not construct certain members if we are in Visual Studio's designer mode
because they crash the designer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
fb40cb7a5a Hide properties which should not be serialised by the Visual Studio designer.
Minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
fa1cf41d5b No need to add nodes to the treeview in the constructor (which also means at design time);
PersistExpandNodes should not take for granted that the treeview always has nodes.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Mihaela Stoica
02075486ba
Merge pull request #2237 from xenserver/feature/REQ-488
Merge branch feature/REQ-488 into master
2018-10-05 09:41:21 +01:00
Aaron Robson
ca1113fbcc CA-287643: Replaced list view with data grid view to resolve column sizing issue and for consistency with the rest of the product. (#2226)
CA-287643: Replaced list view with data grid view to resolve column sizing issue and for consistency with the rest of the product.

Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-02 10:18:34 +01:00
Darren Matthews
2ce509efb3 L10N: Translation updates along with Interface resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-28 14:00:14 +01:00
Darren Matthews
47be1b0ecf L10N: CA-294292 resync Japanese and Chinese files. Truncation issues fixed.
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-27 12:43:04 +01:00
Konstantina Chremmou
2b83de433d CA-294292: Layout modifications to fix error message truncation issues.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-27 12:43:04 +01:00
Konstantina Chremmou
95cd300e61 CA-210190 Memory spinner: removed the label so it's easier to align
the spinner with the surrounding controls on a parent control/form.
Also, removed the icon from the spinner because in the
majority of implementations it was invisible and the extra space was just
complicating the alignment of the surrounding controls.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-26 11:06:24 +01:00
Konstantina Chremmou
1d7008beab
Merge pull request #2227 from xenserver/feature/REQ-680
REQ-680: Rebranding XenServer to Citrix Hypervisor
2018-09-21 00:28:44 +01:00
Michael Z
40197ae2d0 REQ-680: Fix auto-merge errors.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-20 22:41:11 +08:00
Mihaela Stoica
592b110f06 CA-297216: Remove the upsell message from the memory tab and disable the DMC settings for VMs in the "Memory Setting" dialog if the server is not licensed.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-09-18 15:33:53 +01:00
Michael Z
9034c5a57a REQ-680: Merge master to feature branch.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-17 20:00:30 +10:00
Michael Z
5e37264185 CA-297617: Change Citrix Hypervisor Tools to Citrix VM Tools.
Signed-off-by: Michael Z <michael.zhao@citrix.com>
2018-09-14 15:54:04 +01:00
Darren Matthews
f7859a1596 L10N: Translation updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-23 08:41:13 +01:00
Darren Matthews
0e7057d067 L10N: Translation updates and Re-Sync JA & CN resx files to match the new English resx
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-22 09:02:08 +01:00
Konstantina Chremmou
1c2845697c Fixed tab order; renamed the radio buttons because it was difficult to tell what each one referred to.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 08:23:04 +01:00
Konstantina Chremmou
6885c21b5e Removed unnecessary control VMMemoryControlsBase and moved the logic of the VMs
property to the derived classes (they don't share much of it anyway) and the method
CalcMemoryUsed to the VMShinyBar class where it is needed. Also made the latter's
property Increment non-browsable.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 08:23:04 +01:00
Konstantina Chremmou
c67f85ebaa CA-210190: Fixed various layout and truncation issues on the VM/template memory
setting controls. Also removed the various types of ballooning dialogs since
the only thing changing was the contained memory settings control.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-17 08:23:04 +01:00
serenc
1b0338d36b CP-28926: Add additional error message for >2TB VDIs
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-08-15 10:02:15 +01:00
serencorbett1
bf088cb944 CP-27825: Remove restriction on creating >2TB disk (#2160)
* Remove restriction on creating >2TB disk
* Changed restrictions for resizing VDI
* Removed old method and replaced it with direct calls to new method

Signed-off-by: serenc <seren.corbett@citrix.com>
2018-08-06 15:28:32 +01:00
Mihaela Stoica
61ee71dac1 CA-290536: Fix XenCenter uncaught exception in VM console when losing host connection
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-06 15:14:24 +01:00
Darren Matthews
a6991596a5 L10N Bug Fixes (CA-294292 & CA-294333) (#2163)
* L10N: CA-294292 Fixed truncation issue in language files.
* L10N: CA-294333 Fixed overlapping issue in Japanese file.
* L10N: CA-294333 Fixed overlapping issue in Japanese file.

Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-02 10:13:54 +01:00
Konstantina Chremmou
85b326497d CA-293664: Corrected text colour for selected item.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-25 09:39:04 +01:00
Mihaela Stoica
9accb3c69f Merge branch 'master' into REQ-672
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenAdmin.csproj
2018-07-13 13:14:36 +01:00
Konstantina Chremmou
c11b692958 CA-293158: Reworked the logic enabling/disabling and selecting servers depending
on the update mode, so that the right set of hosts is passed on to the prechecks
page for partially upgraded pools that are to be updated to a new version with
hotfixes. Also, corrected code that was mixing the logic of changing the enabled
 state of a row with the checked state.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-08 22:43:21 +01:00
Jisheng Xing
b6e1ad6b83 fix typos and rename a function 2018-06-21 14:54:47 +01:00
Konstantina Chremmou
14aa3f3f5d CA-289335: Do not check the NetworkComboBoxItem can be selected unless it has been added to the ComboBox.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-06 16:06:41 +01:00
Mihaela Stoica
c2b42fa107 CA-289335: Refactoring to avoid setting the SelectedItem twice
- also avoids iterating through the combobox items again to determine which item to select

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-24 16:23:04 +01:00
Ji Jiang
9ddb253ec0 CP-26866: Add a specific warning when creating a bond on cluster network
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-05-23 16:47:59 +01:00
Konstantina Chremmou
6a36bf37ff The designed class should be the first one in the file, otherwise VisualStudio's designer breaks.
In this case, the CheckableDataGridViewRowEventArgs are very specialised and can be nested in the CheckableDataGridView.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-15 13:17:04 +01:00
Mihaela Stoica
4096803ee1 CA-288560: Convert CPU average frequency to GHz, when needed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-02 12:57:10 +01:00
Mihaela Stoica
906af62422 CA-288560: Add friendly name and units for CPU average frequency
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-02 12:57:10 +01:00
Konstantina Chremmou
e6b62809c1 CA-287714: Fixed regression introduced with b4956da8f1:
The DataArchive.Sets are supposed to be updated on the UI thread.
Added an extra safeguard when updating the DataKey items, namely copy the archives
to a local variable. Also, some minor refactoring to make looking up sets into
the archives more efficient.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-12 15:48:47 +01:00
Konstantina Chremmou
7655011158 Compliance with C# conventions: normally interface names start with an I.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 13:00:27 +01:00
vetrivelc
c910f7d41b L10N: Translation Updates 2018-03-27 13:47:39 +01:00
Jisheng Xing
8e64c917e2 fix review comments
modify the judgement of SR-IOV network

fix review comments

fix review comments

judge the resolve result and modify the link status of VLAN on SR-IOV
2018-03-26 16:33:11 +08:00
Jisheng Xing
f41a61ac73 CA-286278: VLAN network on top of SRIOV also belongs to SR-IOV
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-26 16:32:38 +08:00
Jisheng Xing
6cf968a209 CA-286129: allow VIF to be updated to a SRIOV VF 2018-03-23 14:44:58 +08:00
Jisheng Xing
73eefe33b5 CA-286136: modify SR-IOV related info display
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-23 14:44:57 +08:00
jishengx
a22cb38835 CP-26363: Display the remaining VF numbers in NIC TabPage (#1982)
* CP-26363: Display the remaining VF numbers in NIC TabPage

* correct the link status of Networking TabPage

* show the warning when creating SR-IOV network

* fix some comments

* modify the action

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-23 14:44:56 +08:00
jishengx
e7bfb78c00 CP-26884 + CP-27199: Add network-sriov info in OVF file when exporting vm + Block VF assignment to VM according to recommendations: a (#1980)
* CP-26884: add network-sriov info in OVF file when exporting vm

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* CP-27199: Block VF assignment to VM according to recommendations

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix some comments

* revert the Messages.resx
2018-03-23 14:44:51 +08:00
Jisheng Xing
7dd99857cd CP-26391: Display the SR-IOV network status on Networking Tab Page
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-23 14:41:55 +08:00
jishengx
c966e25cc1 CP-26000: Add SR-IOV column in Networking and NIC TabPage (#1903) 2018-03-23 14:24:51 +08:00
Konstantina Chremmou
29cdf221bc Cleared some level 4 warnings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-22 15:07:32 +00:00
Michael Zhao
7c8b2f6d40 CA-271850: Increase the timeout of session for querying MaximumTolerableHostFailures. 2018-03-20 07:09:34 +00:00
Michael
ebb918296b CA-284226: Optimize performance of menu Start-on-Server and Migrate-to-Server (#1985)
* CA-284226: Reduce unnecessary CanExecute() calls.

* CA-284226: Optimize the performance of menu Migrate to Server and Start on Server.

* Fix an error in updating Migrate menu with WLB, which lead to crash.

* Clear the worker queue when menu is closed.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>

* Fix comments.
2018-03-20 07:07:19 +00:00
Mihaela Stoica
f7b27ec222
Merge pull request #1994 from xenserver/REQ-477
Merge REQ-477 into master
2018-03-19 13:23:19 +00:00
Konstantina Chremmou
ee648135f6 Since it is easy to forget calling the base class method at the beginning of the
PageLoaded override in derived classes, enforce it by wrapping the page specific
code in a new virtual method, which the derived classes can override and PageLoaded
can call after its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
7a1b1a6dcc Since it is easy to forget calling the base class method at the end of the PageLeave
override in derived classes, enforce it by wrapping the page specific code in
a new virtual method, which the derived classes can override and PageLeave can
call before its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Mihaela Stoica
ff05fb698c Merge remote-tracking branch 'upstream/master' into REQ-477
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/XenAPI/Auth.cs
#	XenModel/XenAPI/Blob.cs
#	XenModel/XenAPI/Bond.cs
#	XenModel/XenAPI/Console.cs
#	XenModel/XenAPI/Converters.cs
#	XenModel/XenAPI/Crashdump.cs
#	XenModel/XenAPI/DR_task.cs
#	XenModel/XenAPI/Event.cs
#	XenModel/XenAPI/Feature.cs
#	XenModel/XenAPI/GPU_group.cs
#	XenModel/XenAPI/Host.cs
#	XenModel/XenAPI/Host_cpu.cs
#	XenModel/XenAPI/Host_crashdump.cs
#	XenModel/XenAPI/Host_metrics.cs
#	XenModel/XenAPI/Host_patch.cs
#	XenModel/XenAPI/JsonRpcClient.cs
#	XenModel/XenAPI/LVHD.cs
#	XenModel/XenAPI/Maps.cs
#	XenModel/XenAPI/Message.cs
#	XenModel/XenAPI/Network.cs
#	XenModel/XenAPI/PBD.cs
#	XenModel/XenAPI/PCI.cs
#	XenModel/XenAPI/PGPU.cs
#	XenModel/XenAPI/PIF.cs
#	XenModel/XenAPI/PIF_metrics.cs
#	XenModel/XenAPI/PUSB.cs
#	XenModel/XenAPI/PVS_cache_storage.cs
#	XenModel/XenAPI/PVS_proxy.cs
#	XenModel/XenAPI/PVS_server.cs
#	XenModel/XenAPI/PVS_site.cs
#	XenModel/XenAPI/Pool.cs
#	XenModel/XenAPI/Pool_patch.cs
#	XenModel/XenAPI/Pool_update.cs
#	XenModel/XenAPI/Role.cs
#	XenModel/XenAPI/SDN_controller.cs
#	XenModel/XenAPI/SM.cs
#	XenModel/XenAPI/SR.cs
#	XenModel/XenAPI/Secret.cs
#	XenModel/XenAPI/Session.cs
#	XenModel/XenAPI/Subject.cs
#	XenModel/XenAPI/Task.cs
#	XenModel/XenAPI/Tunnel.cs
#	XenModel/XenAPI/USB_group.cs
#	XenModel/XenAPI/User.cs
#	XenModel/XenAPI/VBD.cs
#	XenModel/XenAPI/VBD_metrics.cs
#	XenModel/XenAPI/VDI.cs
#	XenModel/XenAPI/VGPU.cs
#	XenModel/XenAPI/VGPU_type.cs
#	XenModel/XenAPI/VIF.cs
#	XenModel/XenAPI/VIF_metrics.cs
#	XenModel/XenAPI/VLAN.cs
#	XenModel/XenAPI/VM.cs
#	XenModel/XenAPI/VMPP.cs
#	XenModel/XenAPI/VMSS.cs
#	XenModel/XenAPI/VM_appliance.cs
#	XenModel/XenAPI/VM_guest_metrics.cs
#	XenModel/XenAPI/VM_metrics.cs
#	XenModel/XenAPI/VTPM.cs
#	XenModel/XenAPI/VUSB.cs
#	XenModel/XenModel.csproj
2018-02-27 17:42:18 +00:00
Konstantina Chremmou
b4956da8f1 Performance and workflow improvement:
- no need to register the XenObjects events with the ArchiveMaintainer since
what the handler does is not specific to this class; this can be done on the
Performance page where the events are also registered.
- set directly the ArchiveMaintainer's XenObject to the new value without
setting it intermediately to null as this causes a full data download event
if the object has not changed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-22 10:18:18 +00:00
Konstantina Chremmou
267035c2c6 Use Action instead of EventHandler since the event is fired without arguments.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-22 10:18:18 +00:00
Konstantina Chremmou
63c6b817d5 CA-40854: The Session's uuid is in reality its opaque_ref. Use the opaque_ref so
it's obvious what it is. The Session's uuid will be deprecated from the API bindings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-21 14:08:01 +00:00
serenc
c99c4a0f2e CA-280299: Rescan SRs when choosing SR for copying VM 2018-02-05 10:53:46 +00:00
Konstantina Chremmou
123db499f5 Merge branch 'master' into REQ-420 2018-01-25 13:38:58 +00:00
Konstantina Chremmou
fb8434819d Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-11-30 13:56:32 +00:00
Konstantina Chremmou
566c6f0219 Namespace tidy 1/several: replaced Citrix.XenCenter with XenCenterLib.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-11-30 13:56:32 +00:00
Konstantina Chremmou
a170ec33e2 Merge remote-tracking branch 'upstream/master' into REQ-420
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	autogenerated XenModel/XenAPI/* files
2017-11-17 11:53:41 +00:00
Gabor Apati-Nagy
4630994198 Merge pull request #1797 from mcintyre94/CP-24974
[CP-24974] Avoid calculatingVM agility/failure tolerance twice
2017-10-18 15:58:27 +01:00
Callum McIntyre
e77b8f9445 [CP-24974] Avoid calculatingVM agility/failure tolerance twice
This is caused by the `waitingNtolUpdate.waitOne()` call being at the end of the loop, not the beginning. The reason is that the `waitingNtolUpdate` is set during the first iteration (before the thread even gets loaded) - because the setter for Settings in this file sets it (and that's set by the setter for AssignPriorites.Connection, which is set in the HAWizard constructor). So when the thread first spawns we do the calculations, then get to the `waitOne` lock, which is set so we go back around the loop and calculate everything again before returning to the lock and waiting to be triggered. The correct behaviour is to trigger only once on the page load, and then only when re-triggered. To achieve that I've moved the `waitOne` call to the beginning of the loop, so that (assuming the `waitingNtolUpdate` lock is set before the thread is first started) we immediately run the calculations and then stop at the beginning of the loop waiting to be triggered again. This means that on page load (and after each re-trigger) we only calculate once.

The assumption that the lock is set before the thread is triggered is currently valid, because as mentioned above it's currently set by the setter for Settings which is indirectly called by the wizard constructor. I don't want to rely on that behaviour though because it's very indirect, so just to be safe I've added an explicit set just before the thread is triggered so that it's guaranteed to run the calculations the first time. This isn't strictly necessary but seems better than relying on the existing implicit setting. Since we use the same mechanism just in a different place, all the existing code that sets `waitingNtolUpdate` continues to trigger this thread as expected.
2017-10-06 14:07:31 +01:00
Mihaela Stoica
0e5f1335d4 CP-24498: RPU wizard to block the selection of unlicensed hosts
Also includes some improvements to the Select Pools page of the RPU wizard
- do not show the checkbox if the item is disabled
- show the icon for the pool items, not only for hosts (making this consistent with the similar page in the Update Wizard)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-25 13:27:06 +01:00
Ji Jiang
7fd18e99cf CP-24032: Updates page collapsing enhancement
Store the pool collapsing state and rebuild it after refresh.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
41cec6e42b CP-23967: change two superclass to abstract class
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
17f76870b3 CP-23967: Fix and unify sorting in different views
The commit fixes bug and unify sorting rules in ManageUpdatesPage,
PatchingWizard_SelectServers and RollingUpgradeWizardSelectPool data
grid views.

The rules are:
1) Name column sorted purely by name.
2) Other columns sorted by string value, if the same, sorted by default,
which is still in order even in reverse direction.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
8b2bc83a12 CP-23453: Populate "By Host" view in Updates page
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:47 +01:00
Ji Jiang
66b1b52ad1 CP-23450: Add "View" btn in Updates page toolbar
1) View button has "By Update" and "By Host" options.
2) "By Host" view hides "Filter by Date", "Dismiss All" and "Restore
Dismissed Updates" buttons.
3) "By Host" view turns date filter OFF.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 14:58:04 +01:00
Konstantina Chremmou
915059d099 The Proxy_xxx classes should not be used outside the API bindings (in reality
these classes should have been internal).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-14 11:52:15 +01:00
Konstantina Chremmou
514c33140b Converted remaining extension get and set properties of the API classes to methods
in order to prevent them from being serialised alongside the API properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-05 02:15:38 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Stephen Turner
89f51e90a1 CA-258782 Remove thin provisioning code (#1728)
* CA-258782 Remove thin provisioning code

* Revert file that shouldn't have been touched

* Remove line that was only present for debugging
2017-08-22 16:40:08 +01:00
Konstantina Chremmou
ad7e2fa6a6 CA-257927: Changed ChangeableList.RemoveAll method to fire the CollectionChangedEvent
once for all the items to be removed, passing in their list as argument. This method,
and the method Clear calling it, are used for alerts, updates, events and connections,
hence changed the handling of the CollectionChanged event in these cases to expect
either a single item or a collection. In the case of alerts, updates and events
this means that we can rebuild the whole list instead of removing single rows which
causes the application to hang for big numbers of items.
2017-07-24 14:48:02 +01:00
Letsibogo Ramadi
2fb35c8faa CA-235459 - G11n:SC: The numeric tag for “Disks” and “Network” is ove… (#1693)
* CA-235459 - G11n:SC: The numeric tag for “Disks” and “Network” is overlap on the search window.

* CA-235459 - G11n:SC: The numeric tag for “Disks” and “Network” is overlap on the search window.

- use col widths from resource file instead of hardcoded values

* CA-235459 - G11n:SC: The numeric tag for “Disks” and “Network” is overlap on the search window.

- safer implementation

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-07-21 16:15:29 +01:00
vetrivelc
a9e5198c7e L10N : Translation updates and bug fixes 2017-07-19 15:09:10 +05:30
Gabor Apati-Nagy
597762b884 CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
Removed code that is no longer needed. Also removed an obsolete unit test.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-12 16:49:37 +01:00
Mihaela Stoica
71600b20de CA-242134: Rename some of the classes and files, following the removal of the VMPP support
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-25 16:29:27 +01:00
Gabor Apati-Nagy
3a83bba457 Merge pull request #1503 from letsboogey/gpu
CP-21558 - On the vGPU types dialog, hide the column headers where al…
2017-03-28 10:54:54 +01:00
Letsibogo Ramadi
808063c125 CP-21558 - On the vGPU types dialog, hide the column headers where all the values are 0 2017-03-27 14:22:16 +01:00
Stephen Turner
6d8c7b76df CA-95798: Limit size of LongStringComboBox 2017-03-10 17:29:58 +00:00
Letsibogo Ramadi
34780b1e0a CP-21120 - XenCenter shows MxGPU as 'passthrough' rather than model 2017-03-07 16:13:53 +00:00
Letsibogo Ramadi
27918a1c02 CP-20881 - Implement RDP console resize when toggling the full screen mode
In addition to ticket requirements, the console size is updated when the console is:
- resized in undocked mode
- resized manually by dragging window edges
- resized by dragging the panel splitter

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-03-01 17:48:42 +00:00
Mihaela Stoica
430b9e87ed CP-19607: More event handlers that needed to be deregistered 2017-01-31 14:35:59 +00:00
Mihaela Stoica
c35eae23be CP-19607: Unregister event handlers when the tab pages are hidden
Implemented a generic mechanism to allow tab pages to unregister their event handlers when they are hidden (when a tab page gets deselected)
Also changed VMStoragePage to derive from BaseTabPage, so it could use the same mechanism.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-25 12:38:33 +00:00
Mihaela Stoica
80e60abf7c CP-19607: Make sure that event handlers are unregistered when the SrPicker control is disposed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-25 12:15:59 +00:00
Gabor Apati-Nagy
978f85233c CA-176169: Added copyright statement to files which it was missing from
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-16 20:14:56 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
sri harsha tagore k
cb0a0e2267 L10N:Translations check-ins 2017-01-12 13:22:48 +00:00
sri harsha tagore k
08edd54ac1 L10N:Translations check-ins 2017-01-06 12:46:19 +00:00
Mihaela Stoica
3f89610f75 CP-20245: Wording changes for change of feature name to PVS-Accelerator
- changes following the renaming of the RRDs

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-04 14:41:56 +00:00
Konstantina Chremmou
cbdf7d3742 Merge pull request #1334 from MihaelaStoica/CA-216752
CA-216752: Not all wizards progress through to the next page by press…
2016-12-22 09:14:29 +00:00
sri harsha tagore k
fcda47d3a0 L10N:Translations check-ins
Cherry-picked: ff6a3984d5a97313903a4d230bca15e54674976e [ff6a398]
Author: sri harsha tagore k <sriharshatagore.karpurapu@citrix.com>
2016-12-21 16:20:30 +00:00
Gabor Apati-Nagy
751ba4956d Merge pull request #1303 from kc284/CA-104329
CA-104329: Removed calculation which might cause lag from the page lo…
2016-12-16 11:13:05 +00:00
sri harsha tagore k
7e13917939 L10N:TRanslations check-ins
CA-235084/CA-235085/CA-235080/CA-235081 fixes
2016-12-16 11:01:53 +00:00
Mihaela Stoica
30c30e85bb CA-235381: XenCenter should not allow users to edit the PVS cache storage if it is in use
- Replaced the information tooltip with a warning icon and label at the bottom of the page.
- Added some null checks

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-13 11:09:23 +00:00
Konstantina Chremmou
f165cef307 CA-104329: Do not re-iterate through the datagridview rows to retrieve the VMs'
restart settings when leaving the page. Get the already calculated value from the
tolerance indicator instead.
2016-12-13 09:10:26 +00:00
Mihaela Stoica
508f638b3a CA-216752: Not all wizards progress through to the next page by pressing the Enter key
- Added a new method in XenTabPage which the derived classes can implement to select a default control after the page is loaded.
- Added a new wizard test that runs through the wizard by pressing the Enter key and checks if it has landed on the right page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-08 14:52:21 +00:00
Mihaela Stoica
1156d57787 CA-235381: XenCenter should not allow users to edit the PVS cache storage if it is in use
- On the PVS Cache Configuration dialog, disable the cache storage fields with an information tooltip stating that this PVS cache storage cannot be changed because it is in use.
- Also set the minimum width for the splitter panels, to avoid display issues when the splitter is moved and either of the panels becomes unusable.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-07 17:45:50 +00:00
Mihaela Stoica
6f28a7bfb1 CP-17276: Out of Memory exception when XenCenter exceeds the maximum number of GDI handles
Changed the tree builder so that the tree nodes rely on the TreeView's font. If the nodes have their NodeFont != null, then a tree update causes new fonts to be generated for each node and when fonts are being created faster than they could be cleaned up, we reach the GLI handles limit of 10000 (which causes the Out of Memory exception).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-24 16:35:51 +00:00
Callum McIntyre
8e542c199f [CA-229350] Correct the minimum dom0 memory required to enable Memory Only 2016-11-15 12:19:43 +00:00
Callum McIntyre
b3e334654f [CA-229350] PVS allows Memory Only even when no control domain memory available
We now disable the Memory Only option if the available dom0 memory is less than the minimum the spinner supports (1Gb)
2016-11-14 14:59:57 +00:00
Mihaela Stoica
19b0a86fa7 CA-192747: Default name for the performance graphs
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-10 14:42:45 +00:00
Callum McIntyre
a1e254e7a4 [CA-225715] Performance Graph reporting for CPU for a VM based on max VCPUs(not current vcpu)
Instead of using VCPUs_max, use VCPUs_at_startup, which is the value set when we change the VCPUs count on the VM. Note that despite its name we don't need to restart to see this value change.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-02 17:24:51 +00:00
Callum McIntyre
fd46c9b24e [CA-220457] Move the match Regex objects to be static class objects
Moved from BuildList method to the GraphHelpers class. Since they're only used in this class for this search, and there's similar but broader Regex objects in the Helpers class that are used for parsing, I think it's better to keep them in this class to avoid confusion.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-27 10:41:44 +01:00
Callum McIntyre
173149b749 [CA-220457] Add friendly names for new graphs, and filter duplicates
We have some new RRDs - read, write, read_latency and write_latency. This adds support for them by adding a friendly name and using it to display them. It also adds some filtering (see GraphHelpers.cs) because for backward compatibility io_throughput_read and io_throughput_write (which differ from read and write only in scale) are still available, but shouldn't be displayed in XC. If the new read or write are available, we filter these old datasources out.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-26 16:03:12 +01:00
sri harsha tagore k
1e8791fb38 L10N:TRanslations check-ins 2016-10-19 16:37:43 +05:30
Mihaela Stoica
9de2dae4a1 Merge pull request #1219 from sriharshak/master
L10N:TRanslations check-ins
2016-10-18 17:57:42 +01:00
sri harsha tagore k
529cddb035 L10N:TRanslations check-ins 2016-10-18 22:16:57 +05:30
mcintyre94
284afe255e Merge pull request #1210 from kc284/CA-150412
CA-150412: OtherConfigAndTagsWatcher deliberately throws exceptions
2016-10-18 17:11:28 +01:00
sri harsha tagore k
63387232b9 L10N:TRanslations check-ins 2016-10-18 20:45:24 +05:30
Mihaela Stoica
329f084a7e Merge branch 'CAR-2184' to master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/XenAPI-Extensions/SR.cs
2016-10-18 10:18:47 +01:00
Konstantina Chremmou
38bf5b86d3 Merge pull request #1208 from MihaelaStoica/CA-224567
CA-224567: PVS Site renaming plus some other improvements
2016-10-17 22:06:48 +01:00
Konstantina Chremmou
bf08f9d875 Refactored old events which did not need to pass parameters when fired, but were
defined a long time ago, before C# obtained the Action delegates.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-13 22:59:06 +01:00
Mihaela Stoica
9ec9cf1aee CA-225057: Add a helper method for setting the Clipboard text and use in all places where Clipboard.SetText was used.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 16:16:16 +01:00
Mihaela Stoica
387c28dadc CA-225057: XenCenter throws an Exception when trying to copy something to the clipboard on the Network page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 13:14:37 +01:00
Mihaela Stoica
abde6e9641 CA-224567: PVS Site renaming plus some other improvements
- Renamed Add/Remove PVS Site buttons
- Added a note on the PVS Cache configuration page, regarding the recommended cache size and the allowed size for "memory only"
- Added a warning about the Site configuration not being complete until the PVS part is done as well (only visible if PVS_uuid is not set for a PVS_site)
-  Added PVS Read Caching status on the VM's general tab
- The absolute maximum allowed for a cache size is 2TB
- Changed the rubric on the Enable PVS read caching dialog

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 12:47:32 +01:00
Konstantina Chremmou
dc5318010c Merge pull request #1196 from mcintyre94/CA-114492
[CA-114492] Stop GroupBy buttons remaining overlapped…
2016-10-12 20:24:36 +01:00
Mihaela Stoica
be668850a4 CP-19086: In the PVS Cache configuration dialog, we shouldn't try to save a "not configured" site if it was "not configured" before
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-12 17:10:39 +01:00
Mihaela Stoica
a8c7aba673 CP-17932: Ensure that the correct units are displayed for the PVS cache stats
- For the PVS cache space utilization the multiplying factor should be 1 (the default value) because its values range from 0 to 100

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-12 14:19:32 +01:00
Mihaela Stoica
80df4a2681 CP-17932: Ensure that the correct units are displayed for the PVS cache stats
- plus resorting Messages.resx

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-11 13:13:50 +01:00
Callum McIntyre
baccb87d00 [CA-114492] Only do SetUp if the user was actually dragging a button (not for every click on the button)
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-10 10:11:30 +01:00
Callum McIntyre
9f39bdfb23 [CA-114492] Stop GroupBy buttons remaining overlapped after a drag operation by ensuring they snap back to a correct setup on mouseup
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-07 14:16:06 +01:00
Mihaela Stoica
be66919627 CP-19086: Improvements to the PVS cache UI
- If the PVS site cannot be removed (it has running proxies) then popup a dialog stating the reason, instead of starting the action and failing there. We still have the same check in the action, just in case the situation changed in the meantime.
- Removed unused controls

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-03 10:51:56 +01:00
Mihaela Stoica
aebffe9b13 CP-19086: Improvements to the PVS cache UI
PVS Tab:
- Move the "View PVS sites" button inside the "Configure PVS Cache" dialog (next to Remove button) and make it per-site (showing only the PVS servers from that site)
- Remove "Currently attached" column from the VMs section
- Rename "Status" column to "Read caching status"

Configure PVS Cache" dialog:
- Make sure there is a scrollbar to accommodate all hosts in a pool
- Add a confirmation dialog when a site is removed. The action is executed when the Remove button is pressed.
- When Memory SR is selected, set the maximum value to the dom0-extra-memory..
- Allow empty configuration (but see next point): The OK button should only be disabled if the PVS site name is empty
- Add an extra option in the "Cache storage" combobox, with text "Not configured", selected by default on a new site. When this is selected, we will remove the existing entry in pvs_cache_storage and will not create a new one.
- When a PVS site is deleted (forgotten), we first delete all the associated PVS_servers, otherwise the site cannot be deleted.
2016-10-01 00:23:28 +01:00
Konstantina Chremmou
775ee87bab CA-220511: Fixed issue where it was not possible to migrate the VDI of a VM without
home host from a shared to a local storage (while it was possible from the CLI).
Minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-28 23:14:25 +01:00
Konstantina Chremmou
eb3fbe2ac8 Corrections and refactoring on VDI move/migrate:
- Allow move of multiple VDIs
- CA-187659: show better messages when batching move/migration of multiple VDIs.
- Show different tooltips for single vs. multiple VDI move/migration/deletion.
- Refactored the MoveDiskDdialog. Removed the inherited class VDIMigrateDialog and
the batching manager as it was not very different from its parent, it was registering
the events twice, and was batching migration of even single VDIs.
- Tidied up the Move- and MigrateVirtualDisk commands so they're easier to compare.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-28 09:50:43 +01:00
Mihaela Stoica
82dea74899 CP-17920: Add dialog for PVS cache configuration
- new image for PVS_site
- added cache size restrictions based on the SR selected
- added button to remove the PVS site on the page
- fixed the error where the subtext for a new PVS sites showed as "Not configured" even after it has been configured

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-27 16:34:26 +01:00