Commit Graph

653 Commits

Author SHA1 Message Date
Mihaela Stoica
ceaa7460e4 Merge pull request #1281 from GaborApatiNagy/CA-229009&CA-229019
CA-229019 and CA-229009
2016-11-10 17:52:24 +00:00
Gabor Apati-Nagy
7790c8e51d CA-229019: XenCenter behavior on installing already uploaded update
Code review follow up commit

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:46:07 +00:00
Mihaela Stoica
bef415cc98 Merge pull request #1277 from GaborApatiNagy/CA-227719
CA-229185: XenCenter: Dundee and Creedence hosts should be disabled for Ely updates in 'Select Servers'
2016-11-10 17:20:03 +00:00
Gabor Apati-Nagy
b0588d980a CA-229009: VDI is not deleted for the updates
XenCenter will now remove VDIs that couldn't been introduced.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:18:51 +00:00
Gabor Apati-Nagy
4fad0d309a CA-229019: XenCenter behavior on installing already uploaded update
The Pool_update does not always covers all the VDIs XenCenter creates. These orphaned ones have to be deleted as well.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:15:40 +00:00
Gabor Apati-Nagy
7b6a296a68 CA-229185: XenCenter: Dundee and Creedence hosts should be disabled for Ely updates in 'Select Servers'
For ISO updates, when disabling hosts, use the filename matching logic for pre-Ely hosts as well.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 14:57:10 +00:00
Mihaela Stoica
a609e440f6 Merge pull request #1272 from mcintyre94/CA-228729
[CA-228729] Improve the message shown on finishing the update installation
2016-11-10 14:47:29 +00:00
Mihaela Stoica
30a5f36515 Merge pull request #1271 from mcintyre94/CA-228723
[CA-228723]  Cancelling update installation leaves the update in xapi db
2016-11-10 14:45:51 +00:00
mcintyre94
e7f4f3b8a0 Merge pull request #1267 from kc284/CA-227601
CA-227601: check SR supports db replication on a background thread.
2016-11-09 17:42:41 +00:00
Callum McIntyre
638d8fe9e6 [CA-228723] Use sync destroy method in the cleanup action 2016-11-09 16:32:16 +00:00
Callum McIntyre
4a2b27e8ab [CA-228729] Improve the message shown on finishing the update installation
Changed the message to Delete/Deleting/Deleted update installation files, as used in other messages.
2016-11-09 15:52:52 +00:00
Mihaela Stoica
4df0c65d26 Merge pull request #1264 from mcintyre94/CA-226897
[CA-226897] Resume on Server option won't automatically resume the VM
2016-11-09 14:44:03 +00:00
mcintyre94
c595a1a624 Merge pull request #1262 from MihaelaStoica/CA-226103
CA-226103: Hotkey conflict in the “Choose the type of new storage” UI…
2016-11-09 11:00:44 +00:00
Callum McIntyre
d71d9d10d8 [CA-228729] Improve the message shown on finishing the update installation
Previous message was Remove/Removing/Removed Updates, which is confusing. Changed to Clean/Cleaning/Cleaned Update Files.
2016-11-08 16:53:50 +00:00
Callum McIntyre
6a096ebf07 [CA-226897] Move the VMCrossPoolMigrateAction to be a variable outside the block, and added SuppressHistory to the MultipleAction. 2016-11-08 16:05:51 +00:00
Callum McIntyre
d7060cbdb1 [CA-228723] Cancelling update installation leaves the update in xapi db
Modify the cleanup pool update action to also call update destroy (removing the update from xapi db) when the update has not been applied to any hosts (ie we cancelled the wizard before completion).
2016-11-08 15:31:35 +00:00
Gabor Apati-Nagy
bb298cc213 Merge pull request #1270 from MihaelaStoica/CA-227034
CA-227034: Slipstream packaged Live patching hotfix is rebooting host
2016-11-08 14:44:07 +00:00
Mihaela Stoica
b0c4521340 Merge pull request #1266 from mcintyre94/CA-227845
[CA-227845] Fixing problems caused by tooltip container on hotfix wizard mode page
2016-11-08 14:31:20 +00:00
Mihaela Stoica
6b374cb400 CA-227034: Slipstream packaged Live patching hotfix is rebooting host
This happened because the LivePatchCodesByHost was null when the prechecks were generated for an update, so the live patch codes returned by the precheck were ignored.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-08 11:43:54 +00:00
Konstantina Chremmou
f17617b2ec CA-227601: check whether the storage repositories support database replication
on a background thread and show a spinner while this is going on. Also: run this
check only the first time the page is loaded; some refactoring, namely simplified
the code scanning for SRs by reducing the number of things each method does;
fixed column widths; removed unused property.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-07 13:54:03 +00:00
Callum McIntyre
15e04d1a6d [CA-227845] Fixing problems caused by tooltip container on hotfix wizard mode page
Due to the tooltip container introduced for the automatic radio button, winforms didn't treat these radio buttons properly - we needed code to make them mutually exclusive, tab didn't behave properly and keyboard arrow navigation between them didn't work. Therefore I have removed the tooltip container (so our radio buttons behave properly without any extra work) and we instead use a winforms tooltip shown when the mouse is over the automatic radio button. Note that since the control is disabled when we want a tooltip, neither hover events nor attaching a winforms tooltip in the usual way will work. Therefore I use a mousemove event on the table, which displays the tooltip if and only if we are over the disabled control. Also adjusted the tab indexes to make sure tab works correctly across the whole page.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-04 17:09:52 +00:00
Callum McIntyre
9b1a3315f0 [CA-226897] Resume on Server option won't automatically resume the VM
The resume on server uses the CrossPoolMigrateCommand to implement the migration of the VM to the desired host. Before this change that command had no support for resuming a VM after migrating it, so the VM was not resumed. With this change, the CrossPoolMigrateWizard can take an optional (default false) parameter to restart the VM after migration. When this is true, the migrate action becomes a MultipleAction, first migrating and then restarting the VM.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-03 15:35:25 +00:00
Mihaela Stoica
af8c178712 CA-147722: Truncation issue occurred on CPU & Memory window when VM memory more than physical memory.
Also aligning the warning icon with the label.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-03 15:30:56 +00:00
Mihaela Stoica
aca6c41aef CA-226103: Hotkey conflict in the “Choose the type of new storage” UI while creating new storage
Also changed the page to use different resource strings for the Storage type in the right hand panel (no hotkeys should be shown there)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-03 13:55:46 +00:00
Cheng Zhang
0b27b36d9b CA-227274: Fix CN and JP version process lable size
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-11-02 18:05:36 +08:00
Callum McIntyre
8e88d9d36d [CA-227608] Change HA intro page wording
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-01 17:42:00 +00:00
Callum McIntyre
07f866e3a0 [CA-227602] Remove the unused bottom row from the table
This fixes the extra padding, we don't need that bottom row at all

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-01 16:32:45 +00:00
Callum McIntyre
722527f84e [CA-227602] Truncation on the Install Mode page in the Install Upgrade wizard
I've looked at how this was implemented in Dundee, and there we used an absolute height on the row containing the manual checkbox. I've done the same here, changing row 3 from autosize to absoliute 47px. I've also removed the empty row that was between the two radio buttons. This is a Winforms problem, without workarounds an autosize radio button in an autosize container (say the table row) will report its height as one row of text, no matter whether it needs more. This seems to be the only place we use a long radio label (as opposed to a separate label underneath the radio), so I doubt it's worth doing anything more complex than this. I've tested it with the CN string used in the ticket, and it uses less space than the English translation. The string also hasn't changed from Dundee.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-01 15:17:43 +00:00
mcintyre94
5518efaa69 Merge pull request #1245 from kc284/master
CA-226817: Do not allow OVF/OVA import on a host incompatible with th…
2016-10-28 15:46:15 +01:00
Konstantina Chremmou
3a2444ea49 CA-226817: Do not allow OVF/OVA import on a host incompatible with the VM's hardware
platform version. Also, preserve between export and import the VM's has_vendor_device settings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-27 16:03:16 +01:00
Callum McIntyre
c1e3346bd4 [CA-223486] Only add the licensing check if any hosts need to be checked
This will avoid having an empty group if no host needs checking.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-27 14:01:17 +01:00
Callum McIntyre
318faeedad [CA-223486] Refactoring and expanding fltering to all pre-Clearwater only checks
We now enumerate pre-Creedence and pre-Clearwater servers once, and check hosts only in those lists for the checks that only apply to those servers.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-27 11:39:01 +01:00
Callum McIntyre
299ed430cc [CA-223486] Only add the check for hosts that it applies to, instead of all selected ones.
This avoids unnecessary checks where we are upgrading multiple pools from different versions. Also made the same change for the unrelated pre-Clearwater only checks which had the same issue.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-27 10:18:26 +01:00
Callum McIntyre
0ba1e5c6df [CA-223486] Storage Link Status validation is included in Precheck During RPU
We now only include the StorageLink check if we have any hosts earlier than Creedence in the RPU.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-26 17:28:11 +01:00
Gabor Apati-Nagy
325f2c2c6e Merge pull request #1238 from xenserver/CAR-2245
CAR-2245: XenCenter changes for CAR-2245 Standarize packaging formats
2016-10-24 17:56:16 +01:00
Mihaela Stoica
6eb2c80895 CP-19257: Icon for Kylin Linux
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-21 18:46:38 +01:00
Gabor Apati-Nagy
55a4957056 Removed unused field (Release build failed on this)
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-21 11:29:32 +01:00
Gabor Apati-Nagy
92b59a9e44 CA-226261: Install HFX Wizard: Mode page: both radio buttons selected
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-21 10:20:25 +01:00
Gabor Apati-Nagy
668979c29f Merge remote-tracking branch 'github_xenadmin/master' into CAR-2245_temp
Conflicts:
	XenAdmin/TabPages/GeneralTabPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizardModeGuidanceBuilder.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_ModePage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenAdminTests/WizardTests/PatchingWizard/PatchingWizardModeGuidanceBuilderTests.cs
	XenModel/Network/Cache.cs
	XenModel/XenModel.csproj
2016-10-20 19:12:57 +01:00
Gabor Apati-Nagy
1c7f6ac643 Merge remote-tracking branch 'github_xenadmin/CAR-2245' into CAR-2245_temp 2016-10-20 17:58:20 +01:00
Gabor Apati-Nagy
6c26359dd6 Merge pull request #1222 from MihaelaStoica/CAR-2245
CP-19218: Add restart warnings to the Precheck Page when installing h…
2016-10-20 17:41:32 +01:00
Gabor Apati-Nagy
f4a0f3ae40 CP-19303: XenCenter: Use new livepatching codes
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-20 17:19:42 +01:00
Mihaela Stoica
2a66b68c7b Merge pull request #1220 from GaborApatiNagy/CAR-2245_temp
CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
2016-10-20 16:02:05 +01:00
Mihaela Stoica
8c93206ce5 CP-19218: Add restart warnings to the Precheck Page when installing hotfixes
-  If reboot is needed, display this as an info, not a warning

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-20 13:09:48 +01:00
Mihaela Stoica
2546731edc CA-226102: HFX wizard host selection not grayed out when hotfix not applicable for current version
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-20 11:33:55 +01:00
Gabor Apati-Nagy
da0ebc467c CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Fixed refactoring mistake

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 14:02:29 +01:00
Gabor Apati-Nagy
64d7938f55 CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Removed dead code

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 13:42:34 +01:00
Gabor Apati-Nagy
27581fa7a1 CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Moved ISO to InvisibleMessages and Branding

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 13:42:16 +01:00
Gabor Apati-Nagy
225885ac45 CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Always define the extension to search for

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 13:39:14 +01:00
Mihaela Stoica
07faabe1f0 CP-19218: Add restart warnings to the Precheck Page when installing hotfixes
- added a new precheck, called "Live patching status" which checks is a reboot is needed for each host. If reboot is needed, the check will display a warning, otherwise it will show a green tickbox, saying that the server does not need to be rebooted, and if live patching is used, this information will be included as well.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-19 13:10:24 +01:00