Commit Graph

653 Commits

Author SHA1 Message Date
Mihaela Stoica
1bb49758ff Merge pull request #1151 from huazhihao/CA-218956
CA-218956: Expose HIMN when showing hidden objects
2016-09-08 13:10:38 +01:00
Mihaela Stoica
8bf507e634 CA-220613: Truncation on the Migration Network page of the Cross Pool Migration wizard
Fixing regression introduced in commit 3a5444ceb2

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-08 12:01:56 +01:00
John Hua
b0638bb4f5 CA-218956: Expose HIMN when showing hidden objects
Expose both the HIMN network and any VIFs associated with the HIMN
network using XenCenter when the "View->Show Hidden Objects" option
is displayed. However the shown HIMN should not be able to autoplug,
edit or delete.
2016-09-08 17:48:25 +08:00
Gabor Apati-Nagy
b12f488ffd Merge pull request #1147 from MihaelaStoica/CA-220040
CA-220040: Patching wizard shows reboot required where it is not expected
2016-09-05 12:05:12 +01:00
Mihaela Stoica
12a025a253 CA-220040: Patching wizard shows reboot required where it is not expected
- When building the list of servers that require post-install actions, ignore the ones where the patch has already been installed.
- Also fixing the infinite recursion in Build() method (causing StackOverflowException when installing a supplemental pack).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 17:36:11 +01:00
Mihaela Stoica
b1728ee125 CA-220049: Non-livepatch hotfix installation is failing
This fixes the NullReferenceException that occurs when trying to evacuate a host after a non-livepatch update (that requires reboot) has been installed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 17:14:21 +01:00
Callum McIntyre
49a586430e CP-17848: Rename UpdateType enum NewSuppPack to ISO, since for this ticket we will handle all updates as ISOs 2016-08-31 10:42:09 +01:00
Gabor Apati-Nagy
d5bb5d96bc Merge pull request #1139 from mcintyre94/CA-107341
CA-107341:  Truncation issue occurred on rolling pool upgrade window.
2016-08-30 16:01:01 +01:00
Gabor Apati-Nagy
d7a94c1684 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
Fixed flickering

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 16:41:12 +01:00
Gabor Apati-Nagy
15f69ef584 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
Improving AvoidRestartHost usage/interface

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 16:04:28 +01:00
Gabor Apati-Nagy
f55cf77c00 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
XenCenter will check host.patches_requiring_reboot when a host restart is due while a batch update is in progress. If the restart is not required, XenCenter will skip relevant PlanActions.
The intention here is to check this whenever a restart is due according to the original schedule - this way a completely livepatchable update can prevent the restart while the key batch hotfixing logic is not changed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 15:37:57 +01:00
Gabor Apati-Nagy
0174974c93 Merge branch 'master' of https://github.com/xenserver/xenadmin into CP-18014
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.ja.resx
	XenModel/Messages.resx
	XenModel/Messages.zh-CN.resx
2016-08-26 15:22:03 +01:00
Callum McIntyre
b7de03cd98 CP-18417:Move the pool forbidden message into the Messages class (though text isn't finalised yet) 2016-08-26 14:51:05 +01:00
Callum McIntyre
a548c21120 CP-18417: Simplifying the automatic enabled/disabled logic.
Automatic is disabled if any pool forbids auto restart (per Neptune), and reboot is required. It's also disabled if the update type isn't one of the three in the switch statement. If it's enabled it is checked by default.
2016-08-26 14:45:24 +01:00
Callum McIntyre
8639660562 Move the check to stop Neptune servers being selected into the IsInAutomaticMode checks 2016-08-26 14:24:24 +01:00
Callum McIntyre
c41602085d CA-107341: Truncation issue occurred on rolling pool upgrade window.
Truncated pool and host names on the Ready to Upgrade page to 64 characters, which resolves the layout problem from extremely long names.
2016-08-25 16:48:39 +01:00
Callum McIntyre
7f5390e9c4 CP-18618: If live patching fails, warn the user
If we are expecting to live patch, but at the end
hosts.patches_requring_reboot contains the patch, then warn the user that
live patching has failed for the host - and it needs to be rebooted.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-24 11:13:58 +01:00
Gabor Apati-Nagy
7ee2e605ee CP-18012: Use extended precheck information in Update Wizard
This commit implements the check for LiveUpdate capability of a patch. If
the patch is completely live-updatable, XenCenter will not restart the
host (but will do further checks once it has finished installing the
update - separate ticket)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-23 18:31:23 +01:00
Callum McIntyre
af9327d30a CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard.
Redone the commit without any size changes.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-23 10:52:00 +01:00
Callum McIntyre
493b86a5c3 Revert "CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard."
This reverts commit d928a406bc.
2016-08-23 10:37:29 +01:00
Callum McIntyre
d928a406bc CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard.
Moved the hotkey for "Find Storage Repositories" from S to R.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-22 17:44:56 +01:00
Konstantina Chremmou
e99f86c29c Merge branch 'master' into REQ-156 2016-08-19 17:54:37 +01:00
Callum McIntyre
615b55321d Intermediate checkin, branched from REQ156 and applied my changes, needs checking. 2016-08-19 17:27:24 +01:00
Konstantina Chremmou
d07a34ad19 Set checkbox state in the designer and not in the constructor to avoid starting
the checks before the page is loaded. Corrected the conditions for enabling the
Previous and Next buttons on this page. This commit fixes broken RPU wizard test.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-19 15:45:16 +01:00
Konstantina Chremmou
73b0c36fb6 CA-217232: Added some null ref checks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-19 10:55:18 +01:00
Konstantina Chremmou
0cd8391feb Merge pull request #1128 from GaborApatiNagy/REQ-156_github
CA-217232: Fixed regression caused by the fix for CA-216935
2016-08-19 10:42:41 +01:00
Gabor Apati-Nagy
54f67be47c CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 17:55:44 +01:00
Gabor Apati-Nagy
d054c80f62 CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review
2016-08-18 16:02:24 +01:00
Gabor Apati-Nagy
1c5ba794b4 CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review
2016-08-18 16:00:50 +01:00
Gabor Apati-Nagy
53619c775d Merge remote-tracking branch 'github_xenadmin/master' into REQ-156_github_master
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenModel/Actions/ParallelAction.cs
	XenModel/FriendlyNames.resx
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-08-18 12:22:40 +01:00
Gabor Apati-Nagy
37c120ee57 CA-217232: Fixed regression caused by the fix for CA-216935
Creation of PoolPatchMapping objects made safer.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 11:30:50 +01:00
Gabor Apati-Nagy
feafb7ac62 CA-217232: Fixed regression caused by the fix for CA-216935
Comparing uuids instead of references that likely will be changed after the Cache has been repopulated.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 11:25:39 +01:00
Gabor Apati-Nagy
3fc9c3edb6 Merge pull request #1111 from MihaelaStoica/CA-210549
CA-210551: Non-modal action progress bar on the Pre-Checks page of th…
2016-08-16 16:08:54 +01:00
Callum McIntyre
3a5444ceb2 CA-217821: Specified home server in cross pool migration should behave as home server
Mostly just terminology changes from home server to target server in the CPM wizard. Changes in shared component SelectMultipleVMDestinationPage (shared with ImportWizard) to allow CPM wizard to rename the Home Server column (as it can the VM/template one - using the same pattern).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 14:22:18 +01:00
Mihaela Stoica
549bcd8480 CA-210551: Non-modal action progress bar on the Pre-Checks page of the Hotfix and RPU wizards
- Moved progress bar at the bottom of the page and made it the same height as on Upload page; This progress bar is now used when the prechecks are performed (existing functionality) and also for the "resolve" actions (new functionality).
- Added a label for displaying action progress.
- The icon and label saying that you need to resolve problems is hidden when there are no issues found and when an action is in progress (when the progress label is shown instead).
- When a resolve action is in progress, all controls on the page are disabled, apart from Cancel; pressing Cancel will cancel the "resolve" action and the wizard.
- Also put everything in a TableLayoutPanel (hence all the designer changes)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-12 13:27:47 +01:00
Gabor Apati-Nagy
50e9504da7 CA-217862: Batch Updates: Fixed order of checks when setting the tooltip for disabled hosts
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-11 11:14:32 +01:00
Konstantina Chremmou
68ac5a50e4 CA-33357: FIxed tab order.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-10 15:24:47 +01:00
Gabor Apati-Nagy
9f7a635da1 Merge remote-tracking branch 'github_xenadmin/REQ-156' into REQ-156
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Core/Updates.cs
2016-08-10 12:50:45 +01:00
Gabor Apati-Nagy
f9d8b4dea9 CA-217862: Batch updates: Install dundee released hotfixes in Batch fails when pool slave is not reachable and pool partially upgraded
Partially upgraded pools are not supported. If the versions of servers mismatch in a pool, Automatic updating will be disabled with the appropriate info message.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-10 10:48:22 +01:00
Konstantina Chremmou
12b44cfece Merge pull request #1093 from MihaelaStoica/CA-217388
CA-217388: Hotfix Install wizard shows update as already uploaded whe…
2016-08-10 09:11:37 +01:00
Konstantina Chremmou
5f75c0dd74 CA-217847: Fixed issue where servers were marked as unable to be updated automatically
even when automatic mode was supported for them. The problem was that the xenserver
versions were not retrieved from the DownloadUpdatesXmlAction once the latter had run.
Also, minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-09 16:53:02 +01:00
Mihaela Stoica
4046ce0f95 Merge pull request #1096 from GaborApatiNagy/master_batch_new2
CA-217382: Batch updates: Install batch updates is not showing low di…
2016-08-09 14:17:48 +01:00
Konstantina Chremmou
208d4aa1f9 Merge pull request #1099 from GaborApatiNagy/CA-217844
CA-217844: Handling Automatic update not supported
2016-08-09 14:05:12 +01:00
Konstantina Chremmou
016c39bdaa CA-217843: AS requested per code review, hide originally the controls related to
automatic mode to avoid flickering during page load.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-09 12:45:35 +01:00
Gabor Apati-Nagy
e28ca1ded1 CA-217844: Handling Automatic update not supported
If there is no <minimalpatches /> tag, the version is not supported. This check has priority over licensed state when displaying the reason why a server is not supported.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-08 18:30:54 +01:00
Gabor Apati-Nagy
16afbd3bed CA-217382: Batch updates: Install batch updates is not showing low disk space error in pre-checks when host dom0 is full
Fixes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-08 18:05:42 +01:00
Konstantina Chremmou
e9ca8b529a CA-217843 best effort: Run RestoreDismissedUpdates action asynchronously to prevent UI hiccups.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-08 14:37:47 +01:00
Konstantina Chremmou
c30938ff12 CA-217843: Fixed various issues on the select patch page: control tab order; some
hotkeys; button enabled state; some memory leaks; added spinner while check for
updates is in progress; added alternative text for when automatic mode is not available.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-08 11:41:42 +01:00
Gabor Apati-Nagy
f93a977ddf CA-217382: Batch updates: Install batch updates is not showing low disk space error in pre-checks when host dom0 is full
Implemented pre-check to check whether there is enough free disk space
before starting updating a pool.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-05 18:05:09 +01:00
Konstantina Chremmou
9d05bcdce5 CA-33357: Improvements: show the disk name on the New VM storage page so it is
more obvious to the user that they can edit it. To this purpose change the button
Properties to Edit (and do the same on the Networking page for consistence). Also
show the name of the disk (ellipsized if too long) on the wizard's finish page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-05 16:02:03 +01:00
Mihaela Stoica
7186860cc2 CA-217390: Hotfix wizard: Add null reference check in the function that builds the list of post-update tasks.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-04 15:31:34 +01:00
Mihaela Stoica
dc24aa7fcc CA-217388: Hotfix Install wizard shows update as already uploaded when it is not actually uploaded because there wasn't enough space
- Add a new update to the list of uploaded updates only when the upload action has completed successfully.
- Do not perform the disk space check if there is nothing to upload (update has already been uploaded).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-04 15:10:36 +01:00
Gabor Apati-Nagy
0ae6568a60 CA-216854: Fixed error messages shown
Now the wizard shows localized and friendly error messages instead of error codes

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-03 17:15:57 +01:00
Gabor Apati-Nagy
48ef276c06 CA-216935: Fixed a bug that can occur when multiple pools are being updated with the same update and one of the prechecks happen before the other pool is finished applying the update
The PatchPrechecksOnMultipleHostsInAPoolPlanAction did not filter the patchmappings by masterhost, so with some probability, it could choose the wrong mapping (pool_patch object for the same update, but in different pool). This bug is being fixed in this commit, other changes only renamed (for more consistent naming) a class and removed an unused field.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-02 14:30:20 +01:00
Konstantina Chremmou
e8a009678f Fixed issue on the New SR wizard where the SR type details panel was not populated
when the default checked button was invisible.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-28 13:16:49 +01:00
Gabor Apati-Nagy
3ca0db4b98 Merge pull request #1072 from Frezzle/CA-209198
CA-209198: Allowed to attempt to install hotfix when it is already applied
2016-07-25 15:04:21 +01:00
Mihaela Stoica
9b9e9f87a8 Merge pull request #1076 from kc284/bugfix
Fixed bugs CA-207901 and CA-149814
2016-07-25 09:14:39 +01:00
Konstantina Chremmou
13e6a73fa5 Merge pull request #1074 from MihaelaStoica/CA-216697
CA-216697: MTU message present on the Network Settings page when crea…
2016-07-22 20:38:44 +01:00
Konstantina Chremmou
b9b00ca4cd CA-149814: Added short description to fill in the redundant space on the top of the
FolderBrowser dialogs. Fixed text which caused label to look unaligned. Prevent
crash when attempting to launch the DownloadAppliance dialog with "http://" as URI.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-22 08:31:58 +01:00
Mihaela Stoica
2e62dc8476 CA-216697: MTU message present on the Network Settings page when creating an internal network
In the New Network wizard, when the "Single-Server Private Network" type is selected, the Network settings page should not display the MTU hint message, because it is not relevant to any controls on the page

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-07-20 10:26:12 +01:00
Frezzle
5555709337 [CA-209198] Allowed to attempt to install hotfix when it is already applied
XenCenter no longer ignores checking if the master host already has the specified patch applied; it now checks before trying to apply it, which means we get no error in the Patching Wizard's Patching Page.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-19 17:49:40 +01:00
Gabor Apati-Nagy
893275fb2f CA-215573: Batch updates: Install update wizard "Finish" button activated even when batch install still in progress
Trivial changeset

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-19 09:25:17 +01:00
Gabor Apati-Nagy
a007eec882 CA-216162: Batch updates: Wrong hover message on install update wizard when installing batch updates
Better messages on Select Server Page

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-19 09:12:30 +01:00
Konstantina Chremmou
ea60eaa24e Merge pull request #1065 from xenserver/CAR-2217
Request to merge CAR-2217 into master
2016-07-11 14:11:00 +01:00
Frezzle
54a2ba7ac4 [CA-107357] Migrate VM Wizard allows selection of broken SRs
Detached SRs are no longer selectable.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-07 14:57:20 +01:00
Gabor Apati-Nagy
bd26c7ac0e CA-215093: Batch updates: Update progress failed in a pool of mixed state hosts
Utilising default comparer on Host (This will makemaster first.)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 15:37:52 +01:00
Gabor Apati-Nagy
f8a7d97890 CA-215093: Batch updates: Update progress failed in a pool of mixed state hosts
Where (in code removed by this commit) we iterated through the planActionsByHost dictionary, the hosts were iterated through in the order how the dictionary was initialized. Despite the actions were added in the right order, they then were screwed up, because the Cache.Hosts can have the hosts randomly while we want the master to be first.

To fix the bug, I changed the data structure from a dictionary to a list that has the actions exactly in the (good) order, the order they were added, eliminating the risk of the actions being retrieved in the wrong order.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 14:35:31 +01:00
Gabor Apati-Nagy
1fe300c16d CA-214063: Batch Updates: Name of the master is shown
Removed unused field

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 11:00:40 +01:00
Gabor Apati-Nagy
504f73778f CA-214063: Batch Updates: Name of the master is shown instead of the pool's name on Select Servers Page
Code review changes: Showing server icon for standalone hosts instead the pool icon

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 10:42:49 +01:00
Gabor Apati-Nagy
55ff3794cf CA-214063: Batch Updates: Name of the master is shown instead of the pool's name on Select Servers Page
Fixed display issue, now showing pools (and standalone hosts at the same level), not masters.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-01 17:41:49 +01:00
Mihaela Stoica
60c298d9e3 CA-116547: During Installation of Hotfix requiring restart of PV guests displays Dom0 in the list of VMs to be rebooted in XenCenter.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-30 12:32:41 +01:00
Gabor Apati-Nagy
66be637878 Merging (upstream) master into REQ-156 branch caused a build error:
Fixed build error that was caused by changed visibility of a method.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-29 17:56:51 +01:00
Gabor Apati-Nagy
994f5b4811 Merge remote-tracking branch 'github_xenadmin/master' into master_batch_new2 2016-06-29 16:52:13 +01:00
Gabor Apati-Nagy
ee08e06f52 CA-214566: Upload succeeded, but Pool_patch hasn't been found
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-27 19:43:41 +01:00
Konstantina Chremmou
fd3393049c Code simplification: use Action delegate instead of EventHandler since the event is not sending any objects when triggered. 2016-06-27 10:20:23 +01:00
Mihaela Stoica
e87505e13d CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix a dialog return check changed by accident

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-23 15:47:15 +01:00
Gabor Apati-Nagy
a8445d5ed8 Fixed warning as an error in build
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-23 10:27:16 +01:00
Konstantina Chremmou
3fc701ecb8 CP-17502: Hide SR types from the NewSrWizard if the corresponding sm plugin is not available.
Further, disable the Reattach SR if there is no sm plugin for its type.
2016-06-22 18:34:21 +01:00
Gabor Apati-Nagy
587c2b5f5d CA-214077: Typo in Messages.resx
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-22 14:43:22 +01:00
Gabor Apati-Nagy
39109d30a4 CA-214062: REQ-156 Batch Updates: In progress actions shown as done
Fixed trivial bug where in progress actions had done shown as their statuses

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-22 11:07:12 +01:00
Konstantina Chremmou
bdbd9e1f55 CP-17502: No directly related to this ticket, but I found myself in the ISO SR neighbourhood and did some minor refactoring. 2016-06-21 10:29:37 +01:00
Konstantina Chremmou
0f908a674e CP-17750: Block the patching wizard for clusters with the hci-forbid-update flag (disable the relevant pools/hosts on the select servers page; do not launch the patching wizard at all if there are no clusters that can be patched). 2016-06-20 14:10:00 +01:00
Mihaela Stoica
da9e99b1cb CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix ActionProgressDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:17:42 +01:00
Konstantina Chremmou
b575fd3d44 CP-17690: Block RPU for clusters with the hci-forbid-rpu flag (disable the relevant pools/hosts on the select pool page; do not launch the RPU wizard at all if there are no upgradable clusters). 2016-06-20 13:11:21 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Gabor Apati-Nagy
7a84b305ef CP-17699: Developer testing and improvements
for Batch Updating

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-17 14:15:59 +01:00
Mihaela Stoica
fcee4d8876 CA-77990: Report required actions for all VMs at once in the hotfix wizard / RPUW (#951)
* CA-77990: Report required actions for all VMs at once in the hotfix wizard / RPUW

* CA-77990: Resolve precheck problems in parallel in the Patching wizard

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-77990: Resolve precheck problems in parallel in the Patching wizard

Changes following code review: Made the ParallelAction work across connections and removed CrossConnectionParallelAction

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-77990: Modified ParallelAction to create queue on RunSubActions only, with the correct queue size

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-07 17:40:59 +01:00
Gabor Apati-Nagy
9ec512921b CP-15790: Prepare XenCenter for unit testing of Automatic Updates
Added support for defining custom update.xml location in Registry. This
can be either a local file or an URL. This will be beneficial when testing XenCenter.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-07 16:02:57 +01:00
Gabor Apati-Nagy
bd69aab6d2 CP-15719: UI: Implement error handling/reporting on Upload & Install page
Changes following code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-03 15:08:30 +01:00
Gabor Apati-Nagy
d449b153b3 Merge remote-tracking branch 'github_xenadmin/REQ-156' into master_batch_new2 2016-06-03 13:31:00 +01:00
Gabor Apati-Nagy
3561155d03 CP-15719: UI: Implement error handling/reporting on Upload & Install page
Some more on error handling, better displaying of errors

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-01 13:45:21 +01:00
Gabor Apati-Nagy
81a0bf20f9 CP-15714: UI: Change Select Servers Page
DownloadUpdatesXmlAction is called on PageLeave and not when the user selects Automatic Mode. This way we get the error message at the right time, also showing a progress dialog what makes the UX much better.
New tooltips for servers on the Select Server Page to to cover two more cases

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-31 19:00:35 +01:00
Gabor Apati-Nagy
73d67f407d CP-15719: UI: Implement error handling/reporting on Upload & Install page
Implemented error handling.
If there has been an error in a pool, we stop executing actions in that pool immediately, and report the error once every other actions have finished. Error in one pool will not affect the upgrade process of other pools.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-18 13:43:34 +01:00
Gabor Apati-Nagy
a05e92d001 UI: Implement parallel execution of the sequences
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-11 14:13:14 +01:00
Gabor Apati-Nagy
235ebe9b33 Merge branch 'master' of https://github.com/xenserver/xenadmin into master_batchupdate_new 2016-05-05 13:59:28 +01:00
Gabor Apati-Nagy
834c012fb8 Merge pull request #953 from MihaelaStoica/CA-206464
CA-206464: Add certificate validation to the VM export
2016-05-04 13:58:04 +01:00
Gabor Apati-Nagy
deb4d5724c CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
Fixes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 13:47:41 +01:00
Gabor Apati-Nagy
ae02594683 CP-15713: UI: Change Before You Start page
Removed the first item instead of changing it - it is more logical to not to have it displayed here.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 12:25:38 +01:00
Gabor Apati-Nagy
62d332bc45 CP-15713: UI: Change Before You Start page
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:37:39 +01:00
Gabor Apati-Nagy
fdb930bb19 CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
cleaned up code

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:21:23 +01:00
Gabor Apati-Nagy
72147734b5 CP-16513: UI: Apply licensing requirements 2016-05-04 11:08:08 +01:00
Gabor Apati-Nagy
fca591cd6f CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
intermediate commit

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:07:37 +01:00
Gabor Apati-Nagy
466f01b926 CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:06:39 +01:00
Gabor Apati-Nagy
d3914a2318 CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
intermediate commit

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:02:16 +01:00
CITRITE\sriharshak
809bf9161e L10N:Dundee translation changes 2016-04-26 16:39:21 +05:30
Mihaela Stoica
f9c52cd637 Merge pull request #962 from sriharshak/master
L10N:CA-205536 fix
2016-04-22 11:18:32 +01:00
CITRITE\sriharshak
f600cb53a5 L10N:CA-205536 fix 2016-04-21 23:14:03 +05:30
Gabor Apati-Nagy
e7d7661d51 CA-208720: Fix for: Can type text into the label in Bugtool wizard, Destination page
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-04-21 17:55:56 +01:00
CITRITE\sriharshak
7d5f20cf4e L10N:CA-206595 fix 2016-04-21 17:17:22 +05:30
CITRITE\sriharshak
9b6ecde8ab L10N:CA-169593 fix 2016-04-21 12:34:33 +05:30
Mihaela Stoica
ed7548e02a CA-206464: Add certificate validation to the VM export
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-20 15:17:48 +01:00
CITRITE\sriharshak
8c0623b8f2 L10N:Dundee:Translation check-ins 2016-04-20 19:16:33 +05:30
Mihaela Stoica
549e26ad94 CA-208495: XenCenter does not specify the NFS version when reattaching an existing SR
- Re-position the version radio-buttons, so that is clear that the selected version applies to both Create and Reattach
- Pass the selected version to the attach command in the device_config parameter

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-20 09:44:58 +01:00
Mihaela Stoica
64d9bece24 CA-207915: XenCenter does not display the correct supported NFS versions in the New SR wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-15 15:01:09 +01:00
Mihaela Stoica
6dcc00d017 CA-205204: Uncaught exception during RPU
When an exception is reported during the RPU, XenCenter tries to re-enable the host. But when this fails, we should just ignore it and report the original exception.

Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-03-24 17:18:53 +00:00
CITRITE\sriharshak
cf2fbe88e3 L10N:Dundee:Xencenter:ITR002 transltion check-ins 2016-03-23 23:58:30 +05:30
Gabor Apati-Nagy
6934e7fa3f Merge pull request #905 from MihaelaStoica/CA-204191
CA-204191: Trying to avoid Uncaught exception System.InvalidOperation…
2016-03-23 09:53:07 +00:00
CITRITE\sriharshak
ef8628ff92 L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
Gabor Apati-Nagy
1b877a5db9 CP-15715: UI: Modify Prechecks page
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-17 16:35:00 +00:00
Mihaela Stoica
6d40a6db2b CA-204191: Trying to avoid Uncaught exception System.InvalidOperationException: Object is currently in use elsewhere.
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-03-17 16:12:43 +00:00
Mihaela Stoica
5d19694fb0 Merge pull request #903 from stephen-turner/CA-203766
CA-203766: Replace more uses of 'via'
2016-03-16 13:51:45 +00:00
Gabor Apati-Nagy
2a474b01d9 CP-15712: Add Automatic mode (internal parameter)
Hard coded strings --> Messages

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-16 13:22:23 +00:00
Stephen Turner
feea3f2ad0 CA-203766: Replace more uses of 'via' 2016-03-16 13:17:47 +00:00
Gabor Apati-Nagy
c48bc2ac44 CP-15712: Add Automatic mode (internal parameter)
Changes after the very first code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-16 12:59:20 +00:00
Gabor Apati-Nagy
312cd931ca CP-15712: Add Automatic mode (internal parameter)
Disableded non-required pages in the wizard
Added placeholder for new pages
Changed sequence of pages
Removed unnecessary code

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-16 11:38:16 +00:00
Gabor Apati-Nagy
549fda0480 Revert "CA-201032: Made automatic option not visible in the Install Patches Wizard"
This reverts commit 88a3291630.
2016-03-11 14:46:19 +00:00
Mihaela Stoica
ee0b20e626 Merge pull request #893 from GaborApatiNagy/master_CA-202417
CA-202417: New VM Wizard Memory Modify button is not working reliably…
2016-03-11 13:49:49 +00:00
Gabor Apati-Nagy
8091a9bc63 CA-202417: New VM Wizard Memory Modify button is not working reliably when specified in MB
Now we set Increment exactly as on other pages
when the unit is MB: the increment it will be calculated dynamically (1, 2, 4,...)
when GB, increment will be 1 GB for values >=10GB, 0.1GB otherwise

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-10 11:52:04 +00:00
Gabor Apati-Nagy
88e0a1c1fa Merge pull request #876 from MihaelaStoica/CA-201645
CA-201645: The Install Update wizard should delete patch installation…
2016-03-09 11:29:34 +00:00
Gabor Apati-Nagy
4ca88573f0 Merge pull request #879 from MihaelaStoica/CA-202371
CA-202371: Change wording on VM Advanced options page
2016-03-09 11:23:49 +00:00
Mihaela Stoica
1eac78ac00 CA-203178: Unable to create HBA SR using new storage repository wizard in XC
- Removed the Storage provisioning page from the New SR Wizard
2016-03-08 14:47:55 +00:00
Mihaela Stoica
b30e80b054 CA-202371: Change wording on VM Advanced options page
- Changes to the the layout: order of radio buttons, removed group box around the manual setting of shadow multiplier;
- Shadow multiplier edit box no longer disabled when "Optimize manually" not checked

- Also changed the wording on the Name page of the new VM wizard
2016-03-04 10:44:01 +00:00
Mihaela Stoica
72ec9df41a CA-201645: The Install Update wizard should delete patch installation file if manual mode is selected
- Added PoolPatchCleanAction which is called for each pool after the patch has been applied on all selected hosts

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-03-03 11:34:00 +00:00
Gabor Apati-Nagy
9571322b7b CA-202295: Hotkeys should not be part of the branding tag
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-02 14:00:18 +00:00
Mihaela Stoica
b14a1dd72c Merge pull request #871 from GaborApatiNagy/master_CA-175498
CA-175498: Better error message when patching fails
2016-03-02 10:33:12 +00:00
Gabor Apati-Nagy
ed43975454 CA-201083: Incorrect help link in Copy VM wizard
Changed keys of help ids related to copy mode

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-01 18:12:16 +00:00
Gabor Apati-Nagy
9bf37f7d25 CA-201083: Incorrect help link in Copy VM wizard
Removed redundant criterias from some ifs

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-01 18:07:53 +00:00
Gabor Apati-Nagy
e011ade0da CA-175498: Even more logging
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-01 16:51:01 +00:00
Gabor Apati-Nagy
b0c8004230 CA-175498: [HFP Tardy] Error "Remove the patch backup files" when patch-apply fails and user tries to re-apply the patch is not shown on XC.
log the error message that is actually displayed on UI

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-01 16:10:24 +00:00
Gabor Apati-Nagy
6ec9257667 CA-175498: [HFP Tardy] Error "Remove the patch backup files" when patch-apply fails and user tries to re-apply the patch is not shown on XC.
Show a more detailed error message

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-01 16:06:42 +00:00
Gabor Apati-Nagy
bb592fc769 CA-201083: Incorrect help link in Copy VM wizard
Copy VM or Copy Templates wizard will point to the same help: "Copying VMs and Templates"
Migrate and Move VM will show: "Migrate Virtual Machines"

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-26 18:21:51 +00:00
Stephen Turner
7867901e0d Merge pull request #858 from xenserver/revert-746-CA-178985
CA-190986: Revert "CA-178985: Removed ova.xml import from XenCenter"
2016-02-25 09:30:58 +00:00
Gabor Apati-Nagy
1ca313c1e0 Revert "CA-178985: Removed ova.xml import from XenCenter" 2016-02-24 15:33:18 +00:00
Gabor Apati-Nagy
88a3291630 CA-201032: Made automatic option not visible in the Install Patches Wizard
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-24 15:31:58 +00:00
Gabor Apati-Nagy
ebec8b1d7e CA-197423: Incorrect UI text and help link in Copy Template wizard
One missing helpid fixed

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-24 13:52:10 +00:00
Gabor Apati-Nagy
0c56385921 CA-197423: Incorrect UI text and help link in Copy Template wizard
Fixed helpids

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-24 11:10:09 +00:00
Gabor Apati-Nagy
4bdc5ffa79 CA-197423: Incorrect UI text and help link in Copy Template wizard
Fixing UI text (template instead of VM where needed)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-24 10:44:37 +00:00
Gabor Apati-Nagy
6cde7d9c3f CP-15830: Add Help IDs for new dialogs in Dundee 2016-02-18 13:09:53 +00:00
Gabor Apati-Nagy
0f20df0f4b CP-16097: Hide Thin Provosioning in XenCenter
Added the same comment to all the changes

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-17 13:14:42 +00:00
Gabor Apati-Nagy
6cf7776795 CP-16097: Hide Thin Provosioning in XenCenter
Commented code out only for easier reverting.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-17 11:42:19 +00:00