Commit Graph

2960 Commits

Author SHA1 Message Date
Gabor Apati-Nagy
71cdd69f90 Merge pull request #1127 from kc284/master
Improvements made while investigating CA-218953:
2016-08-18 11:11:11 +01:00
Konstantina Chremmou
73a549a4d0 Improvements made while investigating CA-218953:
- when the cd drive or the tools iso cannot be found, the action should fail.
- if the tools SR is broken, do not show the error on a pop-up because the UX is
bad when installation is attempted on multiple VMS.
- added one more entry to the list of possible tools iso names.
- small performance improvement.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-17 22:35:01 +01:00
Gabor Apati-Nagy
684b03317d Merge pull request #1120 from MihaelaStoica/CA-180127
CA-180127: Unable to unset VM home server if all shared SRs are full
2016-08-16 16:22:16 +01:00
Gabor Apati-Nagy
a069e177c3 Merge pull request #1118 from MihaelaStoica/CA-147142
CA-147142: ReadOnly user should not be allowed to delete crash dump f…
2016-08-16 16:16:56 +01:00
Gabor Apati-Nagy
3fc9c3edb6 Merge pull request #1111 from MihaelaStoica/CA-210549
CA-210551: Non-modal action progress bar on the Pre-Checks page of th…
2016-08-16 16:08:54 +01:00
Mihaela Stoica
a3ad025bc6 Merge pull request #1117 from mcintyre94/CA-218304
CA-218304: Text cut off in Properties dialog, Alerts tab
2016-08-16 11:03:48 +01:00
Callum McIntyre
e2215c71f5 CA-218304: Modify tab stops in alert properties tab
Now behaves as expected - alert interval (top control) has lowest tab stop, all other groups incremented by 1.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-16 10:44:37 +01:00
Mihaela Stoica
4bc3cca91c Merge pull request #1122 from GaborApatiNagy/master_CA-150198
CA-150198: EN: Missing hotkey for “Properties” after right clicking virtual disk
2016-08-16 10:40:55 +01:00
Mihaela Stoica
7c4a4fa219 Merge pull request #1121 from mcintyre94/CA-218241
CA-218241: Cancel connect right click menu item does not seem to be doing anything
2016-08-16 09:44:51 +01:00
Callum McIntyre
4559e162b7 CA-218304: Text cut off in Properties dialog, Alerts tab
Instead of adding a second table layout panel for the rubric label, I have extended the original table to include two new rows at the top - one for the label rubric, and one for the repeat interval controls (previously not in the table).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-16 08:49:56 +01:00
Mihaela Stoica
8bdcbc5208 Merge pull request #1119 from mcintyre94/CA-217821
CA-217821: Specified home server in cross pool migration should behave as home server
2016-08-15 19:38:00 +01:00
Gabor Apati-Nagy
0cb878d577 CA-150198: EN: Missing hotkey for “Properties” after right clicking virtual disk.
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-15 17:32:53 +01:00
Callum McIntyre
a41c76a0ba CA-217821: Remove unused TARGET_SERVER_MENU_ITEM key from Japanese+Chinese resources
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 16:38:48 +01:00
Callum McIntyre
05efba8b9f CA-217821: Rename command back to CrossPoolMigrateToHomeCommand 2016-08-15 16:13:35 +01:00
Callum McIntyre
8b035b3af5 CA-218241: Cancel connect right click menu item does not seem to be doing anything
The CancelHostConnectionCommand executes by using a DisconnectCommand, so the fix here is to allow that command to execute on connections in progress as well as those that are connected.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 15:25:14 +01:00
Mihaela Stoica
67be366858 CA-180127: Unable to unset VM home server if all shared SRs are full
By passing null as the srHost parameter to the affinity picker, the "no home server" radio button remains enabled, even when no shared SRs are available, allowing users to unset the home server of a VM

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-15 15:15:00 +01:00
Mihaela Stoica
b35564cb85 CA-147142: ReadOnly user should not be allowed to delete crash dump files
- Made the action PureAsyncAction, so that it automatically checks if the current user can perform all the necessary api calls

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-15 14:27:43 +01:00
Callum McIntyre
3a5444ceb2 CA-217821: Specified home server in cross pool migration should behave as home server
Mostly just terminology changes from home server to target server in the CPM wizard. Changes in shared component SelectMultipleVMDestinationPage (shared with ImportWizard) to allow CPM wizard to rename the Home Server column (as it can the VM/template one - using the same pattern).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 14:22:18 +01:00
Callum McIntyre
0cb567128b CA-218304: Text cut off in Properties dialog, Alerts tab
This is resolved by moving the label into a TableLayoutPanel, docked to the top and with auto-grow on.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 10:45:53 +01:00
Gabor Apati-Nagy
c90582a72e Merge pull request #1116 from GaborApatiNagy/master_livepatch
CP-18012: Fixed the Jenkins build, regenerated resources
2016-08-12 18:31:27 +01:00
Gabor Apati-Nagy
b835090338 CP-18012: Fixed the Jenkins build, regenerated resources
Fixed test:
1) Test Failure : XenAdminTests.UnitTests.MiscTests.NamesAndMessagesTests.XapiFriendlyNameStaticMethodsReturnStrings
     Null value returned for get_SR_BACKEND_FAILURE_457
  Expected: not null
  But was:  null

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-12 18:26:30 +01:00
Gabor Apati-Nagy
8a10351c5d Merge pull request #1113 from xenserver/revert-1110-CP-18011
Revert "Cp 18011: [XenCenter] Add live patching checkbox"
2016-08-12 17:20:38 +01:00
Gabor Apati-Nagy
9dd3a41857 Revert "Cp 18011: [XenCenter] Add live patching checkbox" 2016-08-12 17:19:34 +01:00
Mihaela Stoica
aeeb1260e7 Merge pull request #1110 from mcintyre94/CP-18011
Cp 18011: [XenCenter] Add live patching checkbox
2016-08-12 17:17:37 +01:00
Gabor Apati-Nagy
62dabcccf7 Merge pull request #1112 from MihaelaStoica/master
Add ElyOrGreater function
2016-08-12 17:06:31 +01:00
Mihaela Stoica
e5ab6fe06d Add ElyOrGreater function
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-12 17:03:49 +01:00
Callum McIntyre
1cfa2f6df0 CP-18011: Change the restrict_live_patching check to use BoolKeyPrefer true
This means that if license_params doesn't contain this key we consider it restricted.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 16:05:50 +01:00
Callum McIntyre
cc25e3ec45 CP-18011: [XenCenter] Add live patching checkbox
UI changes to add rubric label and radio buttons instead of a checkbox.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 15:58:49 +01:00
Mihaela Stoica
549bcd8480 CA-210551: Non-modal action progress bar on the Pre-Checks page of the Hotfix and RPU wizards
- Moved progress bar at the bottom of the page and made it the same height as on Upload page; This progress bar is now used when the prechecks are performed (existing functionality) and also for the "resolve" actions (new functionality).
- Added a label for displaying action progress.
- The icon and label saying that you need to resolve problems is hidden when there are no issues found and when an action is in progress (when the progress label is shown instead).
- When a resolve action is in progress, all controls on the page are disabled, apart from Cancel; pressing Cancel will cancel the "resolve" action and the wizard.
- Also put everything in a TableLayoutPanel (hence all the designer changes)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-12 13:27:47 +01:00
Callum McIntyre
82092adee4 CP-18011: Add licensing check for live patching before showing the new page
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 11:55:12 +01:00
Callum McIntyre
d3f4a4aa99 CP-18011: [XenCenter] Add live patching checkbox
Add the Live Patching tab as a new part of PropertiesDialog, shown for pools and standalone hosts. Tab contains one checkbox which toggles the live_patching_disabled XenServer API property. Not yet implemented: license check ("The option should only be shown if the pool is licensed")

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 09:51:20 +01:00
Gabor Apati-Nagy
9de5e7ef9f Merge pull request #1107 from mcintyre94/CP-18011
CP-18011: Add live patching checkbox
2016-08-11 13:21:30 +01:00
Callum McIntyre
f67c0e0a6b CP-18011: Add live patching checkbox
Bringing in XenAPI changes for live patching

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-11 13:17:36 +01:00
Mihaela Stoica
285ee143f0 Merge pull request #1106 from kc284/master
CA-33357: Fixed tab order.
2016-08-11 09:45:56 +01:00
Konstantina Chremmou
68ac5a50e4 CA-33357: FIxed tab order.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-10 15:24:47 +01:00
Konstantina Chremmou
12b44cfece Merge pull request #1093 from MihaelaStoica/CA-217388
CA-217388: Hotfix Install wizard shows update as already uploaded whe…
2016-08-10 09:11:37 +01:00
Konstantina Chremmou
62543bcf26 Merge pull request #1094 from MihaelaStoica/CA-210549
CA-210549: Make MultipleAction and ParallelAction cancellable
2016-08-09 15:13:58 +01:00
Mihaela Stoica
ea52f34d65 Merge pull request #1100 from mcintyre94/CA-150200
CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter
2016-08-09 10:37:41 +01:00
Callum McIntyre
93518392a8 CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter.
Remove the old value, leaving only the new one

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-09 10:31:55 +01:00
Mihaela Stoica
f914f03c21 CA-210549: Make MultipleAction and ParallelAction cancellable
- Fixed the way we calculate PercentComplete for ParallelAction: use the sum of actions in actionsByConnection and actionsWithNoConnection instead of subActions.Count, to avoid waiting for the completion of actions that we never start, because we exclude actions with disconnected connections from actionsByConnections
2016-08-09 10:03:11 +01:00
Mihaela Stoica
77336bdd44 Merge pull request #1095 from kc284/CA-33357
CA-33357: Improvements: show the disk name on the New VM storage page…
2016-08-08 17:04:01 +01:00
Gabor Apati-Nagy
21bcf546d2 Merge pull request #1098 from mcintyre94/CA-150200
CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter.
2016-08-08 15:26:20 +01:00
Callum McIntyre
0b67303f77 CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter.
New hotkey for "Show columns" is alt+C

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-08 15:10:51 +01:00
Mihaela Stoica
529e921e24 Merge pull request #1078 from kc284/CA-147657
CA-147657 plus some refactoring
2016-08-08 13:47:59 +01:00
Konstantina Chremmou
9d05bcdce5 CA-33357: Improvements: show the disk name on the New VM storage page so it is
more obvious to the user that they can edit it. To this purpose change the button
Properties to Edit (and do the same on the Networking page for consistence). Also
show the name of the disk (ellipsized if too long) on the wizard's finish page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-05 16:02:03 +01:00
Mihaela Stoica
56038e3eba CA-210549: Make MultipleAction and ParallelAction cancellable
- The multiple action is cancellable if is at least one sub action is not completed
- When a multiple action is cancelled, we try to cancel all sub actions that are not completed
- Also changed the way we calculate the percent complete for the parent action, to report partial progress of the sub actions

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-05 15:46:07 +01:00
Konstantina Chremmou
1065ca14eb Merge pull request #1088 from MihaelaStoica/CA-217449
CA-217449 &  CA-173661 - Control domain memory alert fixes
2016-08-05 12:27:31 +01:00
Mihaela Stoica
7186860cc2 CA-217390: Hotfix wizard: Add null reference check in the function that builds the list of post-update tasks.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-04 15:31:34 +01:00
Mihaela Stoica
dc24aa7fcc CA-217388: Hotfix Install wizard shows update as already uploaded when it is not actually uploaded because there wasn't enough space
- Add a new update to the list of uploaded updates only when the upload action has completed successfully.
- Do not perform the disk space check if there is nothing to upload (update has already been uploaded).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-04 15:10:36 +01:00
Mihaela Stoica
5a7e4185a9 Merge pull request #1092 from kc284/bugfix
CA-104472: Refactoring and removal of duplicate code. This also fixes…
2016-08-04 09:59:25 +01:00