Commit Graph

1824 Commits

Author SHA1 Message Date
Konstantina Chremmou
73a549a4d0 Improvements made while investigating CA-218953:
- when the cd drive or the tools iso cannot be found, the action should fail.
- if the tools SR is broken, do not show the error on a pop-up because the UX is
bad when installation is attempted on multiple VMS.
- added one more entry to the list of possible tools iso names.
- small performance improvement.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-17 22:35:01 +01:00
Gabor Apati-Nagy
684b03317d Merge pull request #1120 from MihaelaStoica/CA-180127
CA-180127: Unable to unset VM home server if all shared SRs are full
2016-08-16 16:22:16 +01:00
Gabor Apati-Nagy
3fc9c3edb6 Merge pull request #1111 from MihaelaStoica/CA-210549
CA-210551: Non-modal action progress bar on the Pre-Checks page of th…
2016-08-16 16:08:54 +01:00
Mihaela Stoica
a3ad025bc6 Merge pull request #1117 from mcintyre94/CA-218304
CA-218304: Text cut off in Properties dialog, Alerts tab
2016-08-16 11:03:48 +01:00
Callum McIntyre
e2215c71f5 CA-218304: Modify tab stops in alert properties tab
Now behaves as expected - alert interval (top control) has lowest tab stop, all other groups incremented by 1.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-16 10:44:37 +01:00
Mihaela Stoica
4bc3cca91c Merge pull request #1122 from GaborApatiNagy/master_CA-150198
CA-150198: EN: Missing hotkey for “Properties” after right clicking virtual disk
2016-08-16 10:40:55 +01:00
Mihaela Stoica
7c4a4fa219 Merge pull request #1121 from mcintyre94/CA-218241
CA-218241: Cancel connect right click menu item does not seem to be doing anything
2016-08-16 09:44:51 +01:00
Callum McIntyre
4559e162b7 CA-218304: Text cut off in Properties dialog, Alerts tab
Instead of adding a second table layout panel for the rubric label, I have extended the original table to include two new rows at the top - one for the label rubric, and one for the repeat interval controls (previously not in the table).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-16 08:49:56 +01:00
Gabor Apati-Nagy
0cb878d577 CA-150198: EN: Missing hotkey for “Properties” after right clicking virtual disk.
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-15 17:32:53 +01:00
Callum McIntyre
05efba8b9f CA-217821: Rename command back to CrossPoolMigrateToHomeCommand 2016-08-15 16:13:35 +01:00
Callum McIntyre
8b035b3af5 CA-218241: Cancel connect right click menu item does not seem to be doing anything
The CancelHostConnectionCommand executes by using a DisconnectCommand, so the fix here is to allow that command to execute on connections in progress as well as those that are connected.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 15:25:14 +01:00
Mihaela Stoica
67be366858 CA-180127: Unable to unset VM home server if all shared SRs are full
By passing null as the srHost parameter to the affinity picker, the "no home server" radio button remains enabled, even when no shared SRs are available, allowing users to unset the home server of a VM

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-15 15:15:00 +01:00
Callum McIntyre
3a5444ceb2 CA-217821: Specified home server in cross pool migration should behave as home server
Mostly just terminology changes from home server to target server in the CPM wizard. Changes in shared component SelectMultipleVMDestinationPage (shared with ImportWizard) to allow CPM wizard to rename the Home Server column (as it can the VM/template one - using the same pattern).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 14:22:18 +01:00
Callum McIntyre
0cb567128b CA-218304: Text cut off in Properties dialog, Alerts tab
This is resolved by moving the label into a TableLayoutPanel, docked to the top and with auto-grow on.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 10:45:53 +01:00
Gabor Apati-Nagy
9dd3a41857 Revert "Cp 18011: [XenCenter] Add live patching checkbox" 2016-08-12 17:19:34 +01:00
Mihaela Stoica
aeeb1260e7 Merge pull request #1110 from mcintyre94/CP-18011
Cp 18011: [XenCenter] Add live patching checkbox
2016-08-12 17:17:37 +01:00
Callum McIntyre
cc25e3ec45 CP-18011: [XenCenter] Add live patching checkbox
UI changes to add rubric label and radio buttons instead of a checkbox.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 15:58:49 +01:00
Mihaela Stoica
549bcd8480 CA-210551: Non-modal action progress bar on the Pre-Checks page of the Hotfix and RPU wizards
- Moved progress bar at the bottom of the page and made it the same height as on Upload page; This progress bar is now used when the prechecks are performed (existing functionality) and also for the "resolve" actions (new functionality).
- Added a label for displaying action progress.
- The icon and label saying that you need to resolve problems is hidden when there are no issues found and when an action is in progress (when the progress label is shown instead).
- When a resolve action is in progress, all controls on the page are disabled, apart from Cancel; pressing Cancel will cancel the "resolve" action and the wizard.
- Also put everything in a TableLayoutPanel (hence all the designer changes)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-12 13:27:47 +01:00
Callum McIntyre
82092adee4 CP-18011: Add licensing check for live patching before showing the new page
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 11:55:12 +01:00
Callum McIntyre
d3f4a4aa99 CP-18011: [XenCenter] Add live patching checkbox
Add the Live Patching tab as a new part of PropertiesDialog, shown for pools and standalone hosts. Tab contains one checkbox which toggles the live_patching_disabled XenServer API property. Not yet implemented: license check ("The option should only be shown if the pool is licensed")

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-12 09:51:20 +01:00
Konstantina Chremmou
68ac5a50e4 CA-33357: FIxed tab order.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-10 15:24:47 +01:00
Konstantina Chremmou
12b44cfece Merge pull request #1093 from MihaelaStoica/CA-217388
CA-217388: Hotfix Install wizard shows update as already uploaded whe…
2016-08-10 09:11:37 +01:00
Mihaela Stoica
ea52f34d65 Merge pull request #1100 from mcintyre94/CA-150200
CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter
2016-08-09 10:37:41 +01:00
Callum McIntyre
93518392a8 CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter.
Remove the old value, leaving only the new one

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-09 10:31:55 +01:00
Mihaela Stoica
77336bdd44 Merge pull request #1095 from kc284/CA-33357
CA-33357: Improvements: show the disk name on the New VM storage page…
2016-08-08 17:04:01 +01:00
Callum McIntyre
0b67303f77 CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter.
New hotkey for "Show columns" is alt+C

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-08 15:10:51 +01:00
Mihaela Stoica
529e921e24 Merge pull request #1078 from kc284/CA-147657
CA-147657 plus some refactoring
2016-08-08 13:47:59 +01:00
Konstantina Chremmou
9d05bcdce5 CA-33357: Improvements: show the disk name on the New VM storage page so it is
more obvious to the user that they can edit it. To this purpose change the button
Properties to Edit (and do the same on the Networking page for consistence). Also
show the name of the disk (ellipsized if too long) on the wizard's finish page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-05 16:02:03 +01:00
Konstantina Chremmou
1065ca14eb Merge pull request #1088 from MihaelaStoica/CA-217449
CA-217449 &  CA-173661 - Control domain memory alert fixes
2016-08-05 12:27:31 +01:00
Mihaela Stoica
7186860cc2 CA-217390: Hotfix wizard: Add null reference check in the function that builds the list of post-update tasks.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-04 15:31:34 +01:00
Mihaela Stoica
dc24aa7fcc CA-217388: Hotfix Install wizard shows update as already uploaded when it is not actually uploaded because there wasn't enough space
- Add a new update to the list of uploaded updates only when the upload action has completed successfully.
- Do not perform the disk space check if there is nothing to upload (update has already been uploaded).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-04 15:10:36 +01:00
Konstantina Chremmou
dbef554ac0 CA-104472: Refactoring and removal of duplicate code. This also fixes descrepancies
in the calculation of the never-expiring licence ("greater than 3653 days" in
LicenceAlert and LicenceStatus vs "greater than or equal to 3653 days" elsewhere).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-03 21:07:04 +01:00
Mihaela Stoica
35fb115358 CA-173661: Control domain memory alert setting not showing up in the tab subtitle on Host Properties dialog
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-01 12:24:25 +01:00
Mihaela Stoica
bd497356f6 CA-217449: Dom0 VM properties should not be visible in XenCenter
- The "Alarm Settings" action on Alerts page should open host's properties dialog for Dom0 alerts
- Also added help id for the Control Domain Memory Usage alert
2016-08-01 12:21:19 +01:00
Konstantina Chremmou
e8a009678f Fixed issue on the New SR wizard where the SR type details panel was not populated
when the default checked button was invisible.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-28 13:16:49 +01:00
Mihaela Stoica
aa78621897 Merge pull request #1069 from kc284/master
CA-136768: Fixed bad layout of buttons at the top of the snapshots ta…
2016-07-26 14:43:33 +01:00
Mihaela Stoica
54849d4f5e Merge pull request #1084 from GaborApatiNagy/master_CA-213728
CA-213728: Going to Home Server tab can change home server
2016-07-25 16:45:45 +01:00
Gabor Apati-Nagy
3ca0db4b98 Merge pull request #1072 from Frezzle/CA-209198
CA-209198: Allowed to attempt to install hotfix when it is already applied
2016-07-25 15:04:21 +01:00
Gabor Apati-Nagy
f6139c713a CA-213728: Going to Home Server tab can change home server
Even though the correct row have been selected by the time the grid becomes visible, it is not displayed properly. This change set fixes the problem by selecting the row again.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-25 14:31:55 +01:00
Gabor Apati-Nagy
a1bb0846e8 CA-213281, CA-213278: OK fixed
Bugs fixed:
* OK button not re-enabling when switching back to using existing credentials in Health Check Enrollment dialog
* Using empty credentials to authenticate with Citrix Insight Services does not disable OK button in Health Check Enrollment dialog

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-25 13:54:47 +01:00
Mihaela Stoica
9b9e9f87a8 Merge pull request #1076 from kc284/bugfix
Fixed bugs CA-207901 and CA-149814
2016-07-25 09:14:39 +01:00
Konstantina Chremmou
cce9d5b1ce Refactoring: (1) Simplified the logic for gathering the can't-execute-reasons for
a selected item collection - there was no need to make temporarily each one of them
the command selection just to call CanExecute on them. (2) Do not mix the methods
returning the can't-execute-reasons (which can be unknown) with the tooltip property
(which can be null).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-25 01:01:05 +01:00
Konstantina Chremmou
1bbec00d57 CA-147657: Allow setting the ToolTipText for the command ToolStripButtons and ToolStripMenuSubitems
to null, otherwise the wrond text is shown for items with null can't-execute-reason
that are selected after items with non-null can't execute reason.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-25 01:00:53 +01:00
Konstantina Chremmou
d32b7a967b Added overload for the SelectedItemCollection constructor taking one item - it seems to be needed as often as the other constructors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-25 01:00:44 +01:00
Konstantina Chremmou
13e6a73fa5 Merge pull request #1074 from MihaelaStoica/CA-216697
CA-216697: MTU message present on the Network Settings page when crea…
2016-07-22 20:38:44 +01:00
Konstantina Chremmou
b9b00ca4cd CA-149814: Added short description to fill in the redundant space on the top of the
FolderBrowser dialogs. Fixed text which caused label to look unaligned. Prevent
crash when attempting to launch the DownloadAppliance dialog with "http://" as URI.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-22 08:31:58 +01:00
Mihaela Stoica
2e62dc8476 CA-216697: MTU message present on the Network Settings page when creating an internal network
In the New Network wizard, when the "Single-Server Private Network" type is selected, the Network settings page should not display the MTU hint message, because it is not relevant to any controls on the page

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-07-20 10:26:12 +01:00
Konstantina Chremmou
2fd3a91ee6 CA-136768: Fixed bad layout of buttons at the top of the snapshots tab page. Also fixed text alignment on the chevron button.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-20 00:04:06 +01:00
Konstantina Chremmou
917754c937 CA-192541: Added detail to the Import/Export OVF/OVA and Import Disk Image actions
title so we can tell the one from the other. For consistency I used a format similar
to Import/export XVA. I also removed the gerund from the latter as it cannot be
used when the action is completed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-19 23:53:17 +01:00
Frezzle
5555709337 [CA-209198] Allowed to attempt to install hotfix when it is already applied
XenCenter no longer ignores checking if the master host already has the specified patch applied; it now checks before trying to apply it, which means we get no error in the Patching Wizard's Patching Page.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-19 17:49:40 +01:00