Commit Graph

161 Commits

Author SHA1 Message Date
Konstantina Chremmou
73a549a4d0 Improvements made while investigating CA-218953:
- when the cd drive or the tools iso cannot be found, the action should fail.
- if the tools SR is broken, do not show the error on a pop-up because the UX is
bad when installation is attempted on multiple VMS.
- added one more entry to the list of possible tools iso names.
- small performance improvement.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-17 22:35:01 +01:00
Mihaela Stoica
7c4a4fa219 Merge pull request #1121 from mcintyre94/CA-218241
CA-218241: Cancel connect right click menu item does not seem to be doing anything
2016-08-16 09:44:51 +01:00
Callum McIntyre
05efba8b9f CA-217821: Rename command back to CrossPoolMigrateToHomeCommand 2016-08-15 16:13:35 +01:00
Callum McIntyre
8b035b3af5 CA-218241: Cancel connect right click menu item does not seem to be doing anything
The CancelHostConnectionCommand executes by using a DisconnectCommand, so the fix here is to allow that command to execute on connections in progress as well as those that are connected.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 15:25:14 +01:00
Callum McIntyre
3a5444ceb2 CA-217821: Specified home server in cross pool migration should behave as home server
Mostly just terminology changes from home server to target server in the CPM wizard. Changes in shared component SelectMultipleVMDestinationPage (shared with ImportWizard) to allow CPM wizard to rename the Home Server column (as it can the VM/template one - using the same pattern).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 14:22:18 +01:00
Konstantina Chremmou
cce9d5b1ce Refactoring: (1) Simplified the logic for gathering the can't-execute-reasons for
a selected item collection - there was no need to make temporarily each one of them
the command selection just to call CanExecute on them. (2) Do not mix the methods
returning the can't-execute-reasons (which can be unknown) with the tooltip property
(which can be null).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-25 01:01:05 +01:00
Konstantina Chremmou
1bbec00d57 CA-147657: Allow setting the ToolTipText for the command ToolStripButtons and ToolStripMenuSubitems
to null, otherwise the wrond text is shown for items with null can't-execute-reason
that are selected after items with non-null can't execute reason.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-25 01:00:53 +01:00
Konstantina Chremmou
d32b7a967b Added overload for the SelectedItemCollection constructor taking one item - it seems to be needed as often as the other constructors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-25 01:00:44 +01:00
Konstantina Chremmou
ea60eaa24e Merge pull request #1065 from xenserver/CAR-2217
Request to merge CAR-2217 into master
2016-07-11 14:11:00 +01:00
Mihaela Stoica
21fe02922f Merge pull request #1048 from cheng-z/CA-213045
CA-213045: Make server backup file name rebrandable
2016-07-08 16:16:46 +01:00
Cheng Zhang
a682811ed5 CA-213045: Rework on comments to change string format
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-07-04 09:11:10 +08:00
Konstantina Chremmou
051afb48c2 Merge pull request #1012 from MihaelaStoica/CA-209502
CA-209502: Exception while deleting multiple folders
2016-07-01 09:04:48 +01:00
Mihaela Stoica
bcc120f0b2 CA-209502: FolderAction refactoring
- created subclasses for each folder action type (create, rename, delete, move)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-30 15:41:46 +01:00
Cheng Zhang
76f7946ec4 CA-213045: Make server backup file name rebrandable
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-06-30 10:31:10 +08:00
Mihaela Stoica
97feb30fbf Merge pull request #1041 from kc284/CAR-2217-other
CP-17866: Grey out the "Move" button on the VM storage tab if the storage does not allow mirroring.
2016-06-28 13:22:30 +01:00
Konstantina Chremmou
3d8ae9daf8 CP-17470: Added missing hotkey. Performance improvement by using Exists instead of FindAll in check. 2016-06-27 10:43:29 +01:00
Konstantina Chremmou
5dd2873b72 CP-17866: Grey out the "Move" button on the VM storage tab if the storage does not allow mirroring. 2016-06-24 18:10:22 +01:00
Konstantina Chremmou
8e2c381f85 CP-17470: Warn users if they attempt rebooting or shutting down a host running a
VM with the hci-warn-before-shutdown flag. Minor changes to make the warnings for
rebooting and shutting down more consistent (preselect the No button for rebooting;
extended the Yes button text; modified warning text)
2016-06-23 15:26:32 +01:00
Konstantina Chremmou
3fc701ecb8 CP-17502: Hide SR types from the NewSrWizard if the corresponding sm plugin is not available.
Further, disable the Reattach SR if there is no sm plugin for its type.
2016-06-22 18:34:21 +01:00
Konstantina Chremmou
0f908a674e CP-17750: Block the patching wizard for clusters with the hci-forbid-update flag (disable the relevant pools/hosts on the select servers page; do not launch the patching wizard at all if there are no clusters that can be patched). 2016-06-20 14:10:00 +01:00
Mihaela Stoica
62870544c6 CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix UpsellDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:26:52 +01:00
Mihaela Stoica
da9e99b1cb CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix ActionProgressDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:17:42 +01:00
Konstantina Chremmou
b575fd3d44 CP-17690: Block RPU for clusters with the hci-forbid-rpu flag (disable the relevant pools/hosts on the select pool page; do not launch the RPU wizard at all if there are no upgradable clusters). 2016-06-20 13:11:21 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Konstantina Chremmou
42f76bfa23 CA-212078: Correction as per code review to guard against the case when the VM is not resident on any host. 2016-06-07 12:27:54 +01:00
Konstantina Chremmou
5b19081d61 CA-212078: Do not check for CPU compatibility feature when the VM's resident host is not dundee or greater. 2016-06-07 09:30:37 +01:00
Mihaela Stoica
5d58222248 CA-209502: Exception while deleting multiple folders
- Changed the FolderAction class so that it can be used to delete or move multiple folders across connections, instead of having multiple actions (one for each holder) which can not run in parallel.
- The api calls that update the EMPTY_FOLDERS entry in pool's other_config are preformed last for all connections, avoiding cross-thread exceptions when two threads try to add/remove the same key.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-03 15:38:52 +01:00
Mihaela Stoica
c5ba4b49e9 CA-205554: XenCenter says "Activating virtual disks" when deactivating multiple virtual disk
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-06 08:15:16 +01:00
Mihaela Stoica
3eeba34778 CA-205693: Add a check to prevent Index out of range error
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-04 14:23:38 +01:00
CITRITE\sriharshak
ef8628ff92 L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
Mihaela Stoica
379de1f414 CA-203428: Check the CPU feature compatibility on migration only if the VM is on a Dundee or higher host
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-03-10 14:07:12 +00:00
Mihaela Stoica
0504b5b295 CA-196643: Check the CPU feature compatibility in StartDiagnosisForm
- The StartDiagnosisForm dialog shows the reasons why a VM cannot be started or resumed. XenCenter tries to get these reasons from a call to VM.assert_can_boot_here, but his function does not perform a CPU feature compatibility check.
- This commit adds the CPU feature compatibility check for resume operations.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-02-26 10:54:07 +00:00
Gabor Apati-Nagy
0f20df0f4b CP-16097: Hide Thin Provosioning in XenCenter
Added the same comment to all the changes

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-17 13:14:42 +00:00
Gabor Apati-Nagy
6cf7776795 CP-16097: Hide Thin Provosioning in XenCenter
Commented code out only for easier reverting.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-17 11:42:19 +00:00
Mihaela Stoica
cd8ed2d686 CP-15576: Hide containers options that aren't available for Windows Server
- Container pause is not available if the the container is on a Windows VM.
- Processes is not available if the the container is on a Windows VM.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-02-12 16:48:52 +00:00
Mihaela Stoica
86ec959e26 CP-15399: Improvements to the way we handle rebranding of saved searches
- InvisibleMessages.resx contains the default value for the saved search (xensearch), which can be overwritten in Branding.cs

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-02-04 12:04:33 +00:00
Rob Hoes
4d7693a503 CA-196231: Don't confuse start-on with migration
The "Start on Server" VM context menu incorrectly enabled hosts that a VM can
only be started on after a storage migration.  This was due to the fact that
the VMOperationToolStripMenuItem class is used for both "Start on Server" as
well as "Migrate to Server".

This change ensures that start checks are done when a start is requested, and
migration checks otherwise.

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
2016-02-01 17:34:24 +00:00
Mihaela Stoica
fc5ebd2d40 CP-15401: Move HiddenFeatures to a new class
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-01-28 21:43:15 +00:00
Mihaela Stoica
3416707fd2 Merge pull request #785 from cheng--zhang/CP-15401
CP-15401: Show/Hide rdpPolling, upsell and optimize for XenApp depend…
2016-01-26 09:31:24 +00:00
Cheng Zhang
b33e579f28 CP-15401: Hide HealthCheck by reg key
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-25 13:40:45 +08:00
Mihaela Stoica
3ccfcc7e3a Merge pull request #782 from cheng--zhang/CP-15398
CP-15398: Make version, xsupdate and xensearch rebrandable
2016-01-22 13:16:03 +00:00
Cheng Zhang
88d881b126 CP-15401: Show/Hide rdpPolling, upsell and optimize for XenApp depending on XenCenter registry keys
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-22 13:31:22 +08:00
Gabor Apati-Nagy
e5545b3011 Merge pull request #781 from MihaelaStoica/CP-15408
CP-15408: Add license restrictions
2016-01-20 14:04:08 +00:00
Mihaela Stoica
c423fff1dc CP-15408: Renamed RestrictInterPoolMigrate function
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-01-20 13:48:36 +00:00
Cheng Zhang
992ee9e62f CP-15400: Make xensearch rebrandable
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-20 11:33:54 +08:00
Cheng Zhang
4a1a9914d6 CP-15408: Add license restriction for VM migration
Cherry picked from cream-indigo:
CP-14848: License restriction for migration for DragDropMigrateVMCommand
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-18 15:48:06 +00:00
Cheng Zhang
ea690581d0 CP-15408: Add license restriction for VM migration
Cherry picked from cream-indigo:
CP-14848: XenCenter: Implement license restriction for migration
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-18 15:44:50 +00:00
Mihaela Stoica
0d08b143d1 CP-15390: Bring back "restrict_pooling"
(partially revert commit 8ea7e73b55)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-01-15 14:42:36 +00:00
Gabor Apati-Nagy
bbfc6b06a1 Merge pull request #757 from MihaelaStoica/CA-190928
CA-190928: Disable "Disconnect Workload Balancing Server" menu option…
2015-12-18 11:38:53 +00:00
Mihaela Stoica
c8620e978f CA-191315: Storage motion from XenCenter should no longer be blocked on WLB-enabled pools
The restriction that Storage Motion was not possible in the presence of WLB has been removed in Dundee. This commit removes the check in XenCenter.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-12-16 12:58:24 +00:00