Commit Graph

6494 Commits

Author SHA1 Message Date
Danilo Del Busso
77bd034e8d
CA-359965: Consider physical_utilisation value when checking for free space in thinly provisioned SRs (#3028)
* CA-359965: Consider `physical_utilisation` value when checking for free space in thinly provisioned SRs

* CA-359965: Fix miscellaneous formatting issues

* Made SrPickerItem show the SR by default. Removed virtual method that was never overriden.

* Use slightly more intuitive name for property; also inverted its logic.

* Renamed VdiCreationCanProceed to the more specific CanFitDisks since it only deals with sizes.

* Re-arranged classes in file.

* Refactored SrPickerItem:

- Merged CanBeEnabled and DisabledReason properties to method CanBeEnabled(out disabledREason)
  to avoid running the same checks twice.
- Pass the disk instead of the size into extension method SR.CanFitDisks
  so that the correct size can be used for each storage (thin vs. non-thin provision).

* Correction as per code review and some tweaks to make the checks clearer and more efficient.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-10-11 09:26:54 +01:00
Konstantina Chremmou
a4e7462948 Fixed issue where the version on the update dropdown was not refreshed if a new update was found.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-10-07 13:20:56 +01:00
Konstantina Chremmou
94d4360218 Removed NewDiskDialog constructor as it was not particularly useful. 2022-10-07 09:19:10 +01:00
Konstantina Chremmou
83a1a74e02 Disable the Rescan button on the SR storage page when the SR is detached because the operation fails anyway.
Also, some tidy up so the checks are clearer.
2022-10-07 09:19:10 +01:00
Konstantina Chremmou
940b1580b9 Fixes issue where the Finish page of the NewVM wizard was not showing the selected home server correctly. 2022-10-07 09:19:10 +01:00
Konstantina Chremmou
0d70266173 CP-40748: Upgrade log4net to 2.0.15
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-10-04 11:00:12 +01:00
Konstantina Chremmou
e5d1a1bf03 Bumped pipeline version to 4.5.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-10-04 11:00:12 +01:00
Konstantina Chremmou
4d6fd38809 Bumped branding to v4.7. 2022-09-16 10:03:08 +01:00
Konstantina Chremmou
7144528f6b CP-39938: Flag a partially applied hotfix with red only if homogeneous application is required.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-08-22 12:45:37 +00:00
Danilo Del Busso
4f91b8a7e0
Merge pull request #3036 from danilo-delbusso/improvement/RPU_CP-39929
CP-39929: Improvements on the RPU/Updates wizard
2022-08-22 11:58:30 +00:00
Konstantina Chremmou
76a9295bee CP-40641: Bumped branding to v4.6.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-08-19 09:45:51 +01:00
Konstantina Chremmou
21a15104e7 Corrected the registry key name to use when running from source code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-08-19 09:45:51 +01:00
Danilo Del Busso
85e0ffec12
CP-39929: Use 24hrs format for RPU/Update logs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-17 11:40:38 +01:00
Danilo Del Busso
2438996c69
CP-39929: Use pipe | as delimiter for RPU/Update logs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-16 13:47:07 +01:00
Danilo Del Busso
8a3a24d92c
Normalise whitespace in Xenadmin/Diagnostics/Problems/*
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-15 16:13:44 +01:00
Danilo Del Busso
c6b50a5669
Use expression-bodied format for properties in Xenadmin/Diagnostics/Problems/*
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-15 16:13:39 +01:00
Danilo Del Busso
4ef260111b
CP-39929: Fix checkbox text in DisplayOptionsPage
Also add missing ALT shortcuts

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-15 15:58:39 +01:00
Danilo Del Busso
60cd8b9f88
CP-39929: Fix incorrect timestamp shown in RPU/Update wizards
Also:
- Use new date format for logs
- Specify option parameter names
- Do not show timestamp for host name log
- Do not show timestamp for null/whitespace only lines

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-15 15:57:55 +01:00
Danilo Del Busso
c2dc35359f
CP-39929: Enable MaximizeBox for PatchingWizard
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-15 15:47:59 +01:00
Konstantina Chremmou
6c2634074b Guard against registry keys returning empty strings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-08-15 13:39:57 +01:00
Danilo Del Busso
487eba2edf CA-368321: Update Json.NET from 10.0.2 to 13.0.1
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-15 13:39:48 +01:00
Danilo Del Busso
158be06d8d
CP-39929: Remove useless new line after appending error string
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-15 13:11:40 +01:00
Danilo Del Busso
4340892b59
CP-39929: Prevent whitespace strings from being prepended with timestamp
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-15 13:10:22 +01:00
kishore Mengani
1f0452bf8f L10n: Translations updated & Resx sync
Signed-off-by: kishore Mengani <kishore.mengani@citrix.com>
2022-08-12 10:31:53 +01:00
Danilo Del Busso
54a9f22c87
CP-39929: Add timestamps to update logs
- Add option to the display options page
- Add related setting
- Refactor `ExtensionMethods` to be more compact and flexible
- Add docs to `ExtensionMethods`
- Whitespace fixes

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-10 15:44:07 +01:00
Danilo Del Busso
1fd39713f1
CP-39929: Tidy up settings files
sort settings by name

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-10 15:26:19 +01:00
Danilo Del Busso
cf44274a14
CP-39929: Enable use of maximize box for RPU Wizard
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-03 15:05:49 +01:00
Danilo Del Busso
824a46d541
CP-39929: Remove ellipsing from VMProblem descriptions
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-08-03 14:58:39 +01:00
Konstantina Chremmou
20a28c6c33 CP-40177: Remove mentions of Internet Explorer
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-07-25 11:34:09 +01:00
Danilo Del Busso
c34a398cce CA-368958: Reset clip region once performance lines are drawn
Resetting the clip so that on the next render we don't hide labels and title.
Also moved logic outside `LineRenderer.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-07-21 14:28:43 +00:00
Konstantina Chremmou
00c3196440
Merge pull request #3027 from kc284/import-issues
CA-368811, CA-368812: Issues on the import wizard.
2022-07-20 13:50:15 +01:00
Danilo Del Busso
652845bc8f CA-368528: Fix performance data not being updated after a few seconds on VMs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-07-19 13:42:22 +00:00
Konstantina Chremmou
d6f83bac9c Increased width of memory NumericalUpDown because at the maximum value the text was truncated.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-07-19 12:26:10 +01:00
Danilo Del Busso
c2604a69bd CA-368811: Fix memory values showing in bytes in Import Wizard
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-07-19 12:10:15 +01:00
Konstantina Chremmou
030e07390c CA-368812: The SR selection page was not refreshed if the user selected a different target host in the same pool.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-07-14 22:23:52 +01:00
Konstantina Chremmou
c1e5825e24 CA-368811: FIxed issue whereby a minimum memory of 512MB was enforced silently on disk image imports.
Also, increased the maximum allowed memory for imported disk images.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-07-14 16:00:58 +01:00
Konstantina Chremmou
7c87333439 CA-368577: Prevent crashing when the OVF envelope has been created for a disk image import. Some code tidy.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-07-11 14:58:09 +01:00
Danilo Del Busso
ae9d7120e9
Merge pull request #3024 from kc284/master
CP-38582: Corrected version check - last_software_update was added in xapi 22.20.0
2022-06-21 15:23:10 +01:00
Konstantina Chremmou
46cd8308be CP-38582: Corrected version check - last_software_update was added in xapi 22.20.0
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-21 13:08:59 +01:00
Konstantina Chremmou
3d313f2d31 Updated C# SDK (xapi 22.20.0-1.xs8).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-21 10:49:06 +01:00
Konstantina Chremmou
15b05ae572 Fixed issue on the Import XVA wizard where the SR selection was not taking account of...
all scenarios of changed affinity if the user moved from the SR selection
page back to the server selection page and forwards again.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-21 10:49:06 +01:00
Konstantina Chremmou
7e11806790 CP-38582: Use more detailed format for the build and the last updated datetime.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-21 10:49:06 +01:00
Konstantina Chremmou
294519ef29 Bumped branding to v4.5.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-21 10:49:06 +01:00
Konstantina Chremmou
6898148466
Merge pull request #3021 from kc284/remove-updates-tab
CP-39817: Removed updates tab page.
2022-06-21 10:48:46 +01:00
Konstantina Chremmou
eb73a9f106 Show the DownloadUpdatesXmlAction only when it is run by the user or it has failed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-20 15:27:22 +01:00
Konstantina Chremmou
9c61f64ec5 Show the status of the DownloadUpdatesXmlAction on the Events tab (previously it was shown on the Updates tab).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-16 11:47:54 +01:00
Konstantina Chremmou
b79eda2d4b Removed unused code around restoring dismissed updates.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-16 11:21:43 +01:00
Konstantina Chremmou
fc925ba047 Removed unused CfuAvailabilityCheck class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-16 11:21:43 +01:00
Konstantina Chremmou
414eff9c2f CP-39817: Removed the option to check for server new versions since it is not relevant any longer.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-16 11:21:42 +01:00
Konstantina Chremmou
7deb50ee79 CP-39817: Added CFU button to replace the functionality of the Refresh button Remove updates tab page.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-16 11:21:42 +01:00