Commit Graph

3909 Commits

Author SHA1 Message Date
Danilo Del Busso
0ffee712b7 CP-36392: Add null check to connection call in ExternalPluginAction.cs
Also remove `null` check that always resolves to true
Also tidy up code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-10-01 11:56:34 +01:00
Konstantina Chremmou
a2d829b93c CA-359092: Clarify SMB storage option in NewSR wizard
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-09-24 11:20:13 +01:00
Danilo Del Busso
2f176caf46 CP-38219: Update RPU005 to version 3.0
Also exclude Yangtze or greater from hotfix check

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-09-24 11:19:36 +01:00
Konstantina Chremmou
de8acfff24 Use the DEPRECATION_URL as the default value for the Details link of the DeprecationBanner
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/TabPages/BallooningPage.cs
2021-09-23 10:44:43 +01:00
Konstantina Chremmou
cfbfea2830 Minor ProblemWithMoreInfo refactoring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-09-23 10:44:43 +01:00
Konstantina Chremmou
d59a61991e CP-36908: Remove support for xscontainer supp-pack from stockholm.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Commands/PauseDockerContainerCommand.cs
#	XenAdmin/Commands/RestartDockerContainerCommand.cs
#	XenAdmin/Commands/ResumeDockerContainerCommand.cs
#	XenAdmin/Commands/StartDockerContainerCommand.cs
#	XenAdmin/Commands/StopDockerContainerCommand.cs
#	XenAdmin/Controls/DeprecationBanner.cs
#	XenAdmin/TabPages/GeneralTabPage.cs
#	XenModel/Utils/Helpers.cs
2021-09-23 10:44:43 +01:00
Konstantina Chremmou
d740e83620 CP-38018: Report mismatch between pool and host certificate verification in an undismissable way
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-09-23 10:44:30 +01:00
Konstantina Chremmou
55fd07f8ba Minor refactoring.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-09-23 10:44:30 +01:00
Danilo Del Busso
f3d0b1f302
CP-36392: Rename _selectedNodes to _internalSelectedNodes
To avoid getter naming confusion
Also rename `_seletedNodesWrapper` to `_selectedNodes`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-09-20 09:35:24 +01:00
Danilo Del Busso
bb765e2b0f
CP-36392: Dispose '_webClient' when it is no longer needed
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-09-20 09:35:23 +01:00
Danilo Del Busso
12faf4413b
CP-36392: Refactor getter so that it doesn't clash with private field 'selectedCD'
- Remove private field
- Modify `SelectCD` call to take in parameter

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-09-20 09:35:22 +01:00
Danilo Del Busso
24e1b146ae
CP-36392: Refactor property names so they have unique names in SummaryPanel.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-09-20 09:35:21 +01:00
Danilo Del Busso
a61f61d66f
CP-36392: Remove duplicate field in MultipleDvdIsoList.cs
Also remove `VM` from designer

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-09-20 09:35:19 +01:00
Danilo Del Busso
157fe77f8f
CP-36392: Add comment to ignored catch blocks
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CP-36392: Add missing comments to ignored catch blocks

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-09-20 09:35:17 +01:00
Danilo Del Busso
32571300bb Add variable to null check when importing OVF files from web server
Also modify `int` into `var`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-09-17 14:55:09 +01:00
Danilo Del Busso
46b83bf3a4 Prevent null reference when importing OVF files from web server
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-09-17 14:55:09 +01:00
Konstantina Chremmou
7d9bbbc68b XSI-1107/CA-237939: Do not offer full disk copy when creating a VM from a snapshot.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-09-17 14:54:56 +01:00
Konstantina Chremmou
1936b74030 CA-294901: Reworked rubric for home server assignment because previous work on it broke the template case.
Also, no need to use a different message for single and multiple VMs or templates.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-09-17 14:54:56 +01:00
Danilo Del Busso
6aedaa7742
CP-36392: Refactor setter so that it actually refers to the field 'sendScanCodes'
Removed private method is only referenced within the public setter

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-09-17 11:22:47 +01:00
Konstantina Chremmou
cacdb2ef34 Typos.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-09-07 11:12:56 +01:00
Konstantina Chremmou
5ee8230834 Merge remote-tracking branch 'upstream/master' into feature/REQ-403
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Alerts/Types/CertificateAlert.cs
#	XenAdmin/Commands/DisconnectWlbServerCommand.cs
#	XenAdmin/Commands/ViewWorkloadReportsCommand.cs
#	XenAdmin/TabPages/GeneralTabPage.cs
#	XenModel/PoolJoinRules.cs
2021-09-01 14:43:23 +01:00
Konstantina Chremmou
6f7a82017f CP-38073: Corrected resx file for the Chinese language.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-08-31 14:09:08 +01:00
Danilo Del Busso
4b0b83245f
CP-34231: Remove language with negative connotations (#2860)
* CA-34231: Replace negative language with `block list` in code and references

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `stop` in code and references

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `freezing` in code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run/ran` in code comments

Some paramater mentions have been renamed, as they will be renamed in future commits.
Excluded mentions in XenAPI/Host.cs and XenAPI/VM.cs since code is autogenerated.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	CFUValidator/CommandLineOptions/CFUCommandLineOptionManager.cs
#	XenAdmin/Controls/Wlb/WlbOptModeScheduler.cs
#	XenAdmin/Dialogs/Wlb/WorkloadReports.cs

* CA-34231: Replace negative language with `run` in Command.cs Run method

Used Resharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/TabPages/GeneralTabPage.cs

* CA-34231: Replace negative language with `run` in Command.cs CanRun method

Used Resharper rename utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in Command.cs CanRunCore method

Used ReSharper rename utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/DRConfigureCommand.cs
#	XenAdmin/Commands/DRDryrunCommand.cs
#	XenAdmin/Commands/DRFailbackCommand.cs
#	XenAdmin/Commands/DRFailoverCommand.cs
#	XenAdmin/Commands/DisasterRecoveryCommand.cs
#	XenAdmin/Commands/VMGroupCommand.cs

* CA-34231: Replace negative language with `run` in Command.cs RunCore method

Used ReSharper rename utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in Command.cs GetCantExecuteReasonCore method

Used ReSharper rename utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in Command.cs GetCantRunReasons method

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative language with `run` in Command.cs

Also applied to related symbols. Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in methods named CanRun

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in methods in CrossPoolMigrateCommand.cs

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/CrossPoolMigrateCommand.cs

* CA-34231: Replace negative language with `run` in remaining Run methods

Also updated negative language in `DeleteVMCommand`
Also updated in comment in `CrossPoolMigrateCommand`
Also renamed missed instances of `CanRun`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in `CanRunCore` and `RunCore`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative language with `run` in Commands folder

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative language with `run` in XenAdmin/Controls folder

Used ReSharper renaming utility. Had to rename `WlbReportView.xs:RunReport()` to `WlbReportView.xs:StartRunReport()` to resolve conflict with change from `WlbReportView:ExecuteReport()` to `WlbReportView:RunReport()`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Controls/Wlb/WlbOptModeScheduler.cs
#	XenAdmin/Dialogs/Wlb/WorkloadReports.cs
#	XenAdminTests/UnitTests/WlbTests/WlbScheduledTaskTests.cs

* CA-34231: Replace all remaining negative language with `run` in code

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/Controls/WlbRecommendations.cs
#	XenAdminTests/UnitTests/WlbTests/WlbScheduledTaskTests.cs
#	XenModel/WLB/WlbScheduledTask.cs

* CA-34231: Replace negative language with `supporter` or `bond member` in code strings

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `supporter` or `bond member` in Messages string

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx

* CA-34231: Replace remaining negative language with `supporter` in .resx files

Used ReSharper renaming utility. FriendlyErrorNames.resx has been excluded.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `supporter` or `bond member` in XenAdmin code

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/NewPoolDialog.cs

* CA-34231: Replace negative language with `supporter` or `bond member` in XenModel code

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in CFUValidator code

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	CFUValidator/CFUValidator.cs

* CA-34231: Replace negative language with `coordinator` in solution's comments and hardcoded strings

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `Helpers:GetCoordinator` method

Used ReSharper renaming utility.
also renamed similarly named method in `ObjectChange.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Alerts/Types/HotfixEligibilityAlert.cs
#	XenAdmin/Controls/CustomDataGraph/ArchiveMaintainer.cs

* CA-34231: Replace negative language with `coordinator` in `EvacuateHostDialog.resx`

Used ReSharper renaming utility. Excluded jp and zh resources

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/EvacuateHostDialog.resx

* CA-34231: Replace negative language with `coordinator` in `EvacuateHostDialog.resx`

Used ReSharper renaming utility. Excluded jp and zh resource files.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/NewPoolDialog.resx

* CA-34231: Rename missing language references for change to `coordinator`

Misc files were not saved before last commits.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `Messages.resx`'s code

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/HACommand.cs
#	XenAdmin/TabPages/AdPage.cs
#	XenModel/Actions/Network/CreateBondAction.cs
#	XenModel/Actions/Network/NetworkAction.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx

* CA-34231: Replace negative language with `coordinator` in `ExternalPluginAction.cs`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Commands`

Used ReSharper renaming utility. Also replace negative language in missed comment in `ExternalPluginAction.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/AddHostToPoolCommand.cs
#	XenAdmin/Commands/HACommand.cs

* CA-34231: Replace negative language with `coordinator` in `Helpers.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `NetworkingHelper.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `PoolJoinRules.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/NewPoolDialog.cs

* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Commands`, `Controls`, and `Core`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/AddHostToPoolCommand.cs

* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Diagnostics`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Dialogs`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/NewPoolDialog.cs

* CA-34231: Replace remaining negative language with `coordinator` in `XenAdmin`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
#	XenAdmin/TabPages/GeneralTabPage.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeExtrasPage.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizard.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenSearch/Columns.cs

* CA-34231: Replace remaining negative language with `coordinator` in `XenModel\Actions`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenModel/Actions/Network/CreateBondAction.cs

* CA-34231: Replace remaining negative language with `coordinator` in `XenModel`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative strings with `main` in `Messages.resx`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx

* CA-34231: Replace remaining negative string names with `main` in `Messages.resx`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/OptionsPages/SaveAndRestoreOptionsPage.cs
#	XenModel/Messages.resx

* CA-34231: Rename dialogs to replace negative connotations with `main`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `main` in `SaveAndResoreOptionsPage.cs`

Also updated its resx file. Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/OptionsPages/SaveAndRestoreOptionsPage.cs

* CA-34231: Fix invalid reference in `SaveAndRestoreOptionsPage.Designer.cs` after renaming

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `main` in `EnterMainPasswordDialog.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `main` in `ChangeMainPasswordDialog.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Fix invalid reference not changed after renaming `EnterMainPasswordDialog.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative language with `main` in `XenAdmin/Dialogs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Update class names in HelpManager.resx

Following renaming of main password dialog. Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `main` in `Metadata.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Remove remaning negative language with `coordinator` from `Messages.resx`

Used ReSharper renaming

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Remove remaning negative language with `other pool member` from `Messages.resx`

Used ReSharper

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative language in solution

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Remove commented out code in VNCGraphicsClient.cs

Code has only been improved partially as it's not strictly relevant to the PR

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Amend negative word replacement in XSVNCScreen.cs

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Simplify debug call formatting in NewPoolDialog.cs

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Add code mistakenly removed in MainWindow.cs

Removed as part of `f155f9c8`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Revert renaming of constant related to Windows' API

Considered external to CH Center

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Amend hotkey for Coordinator field in `NewPoolDialog`

Previous ALT+<key> hotkey was conflicting with CreatePool

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Remove unecessary whitespace in EvacuateHostDialog.cs

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Update if block to exclude unecessary else in DRFailoverWizard.cs

Not relevant to the PR, but the change is small enought to no need extra testing

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Amend typo in PoolJoinRules.cs

supporer -> supporter

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Replace missing negative language with `coordinator` in `XenAPI-Extensions/Pool.cs`

Variables and methods XenAPI-Extensions were mistakenly skipped

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Replace negative language in `XenApi-Extensions` with `coordinator/interface`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Replace negative language in `XenApi-Extensions` with `supporter/member`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Replace remaining negative language in `XenServerHealthCheckBugTool.cs`

This is only used to format the string

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Change line-endings to CRLF in `Page_CloudConfigParamters.cs`

Done in order to fix merge conflict into master

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Amend misc negative language renaming typos

`XenServerHealthCheckBugTool` and `XenServerHealthCheckService`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-08-31 11:31:16 +01:00
Xihuan Yang
9864595313 CP-38073: Add Rocky Linux icon 2021-08-26 10:50:06 +01:00
Konstantina Chremmou
856a883b8b CA-357326: Do not attempt to start the VM that was quickly created from template if the action has not succeeded.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-08-23 10:59:26 +01:00
Danilo Del Busso
bcc5cf8166
CA-310974: Hide GPU page if the host has no GPU capability (#2847)
* CA-310974: Hide GPU page if the host has no GPU capability

* Hid GPU page in PropertiesDialog
* Hid GPU page in NewVMWizard

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-310974: Move GPU availability check to Helpers class

* Switch from field to method based check
* Update affected logic
* Remove rubric toggle in PopulatePage when GpuEditPage is shown
* Hide AddVGPUDialog when GpusAvailable returns false

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-310974: Remove missing GPUs strings in Messages.resx

* GPU_RUBRIC_NO_GPUS_POOL
* GPU_RUBRIC_NO_GPUS_SERVER

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-310974: Disable combobox in AddVGPUDialog when there are no GPUs

Avoids exception being thrown if user tries to select empty first item

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-310974: Amend position of GPU availability check

Moved since gpuCapability is used in the Finish method of the wizard

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-310974: Remove unecessary null checks in Helpers method

The Cache and its properties (e.g. GPU_groups) are readonly and initialised as empty.
The API object properties that are ref lists (g.PGPUs, g.supported_VGPU_types) are also initialised as empty and are demarshalled by the SDK as empty if they have no values.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-08-23 10:58:41 +01:00
CitrixChris
dbd5f0c344
CA-349435 - Fixed tooltip display on Options and Properties dialogs (#2841)
* CA-34935 ConnectionOptions invalid tooltip now dissappears when page changes or when the dialog moves

Signed-off-by: Christopher Lancaster <christopher.lancaste1@citrix.com>

* CA-349435 modified IOptionsPage & IEditPage to include a Hide Tooltip method, implemented it in all relevant classes. Hooked up events in the options dialog & properties dialog to hide tooltips on tab change or dialog move

Signed-off-by: Christopher Lancaster <christopher.lancaste1@citrix.com>

* CA-349435 removed duplicate pages that were added accidently/automatically

Signed-off-by: Christopher Lancaster <christopher.lancaste1@citrix.com>
2021-08-23 10:34:46 +01:00
Danilo Del Busso
5a0094341b
CA-339590: Add conditional page control refresh in HA Wizard (#2846)
* CA-339590: Add conditional page control refresh in HA Wizard
* CA-339590: Remove remaining HA Wizard page control reloads
Removed PopulatePageControls method and used PopulatePage override instead.
Removed IsDirty implementation from AssignPriorities.
* CA-339590: Remove useless calls to IsDirty in AssignPriorities
Call did not serve any purposes after previous switch to PopulatePage method
* CA-339590: Remove `IsFirstLoad` check for SR scan in HAWizard
Check was not necessary for CA-339590

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-08-16 11:01:35 +01:00
Konstantina Chremmou
af832f23cf
Merge pull request #2848 from kc284/datasources
* DataSet field Uuid is not really a uuid. Renamed to Id to avoid misunderstandings.
* Renamed properties DataSet.Type and DataSourceItem.DataType to Category. The old name was not reflecting what they were.
* Renamed property DataSet.TypeString to DataSet.DataSourceName so it reflects better what it is.
* Renamed property DataSet.Name to DataSet.FriendlyName for clarity. Removed duplicate string.Format() call.
* The DataSourceItem.Uuid is not really a uuid. Renamed it to Id to avoid misunderstandings. Also, compacted DataSourceItem constructors.

* Removed unused and duplicate properties.
- DataKey.Hide was unused. Once removed, DataSet.Deselected was unused, hence was also removed.
- Dataset.Draw was duplicating DataSet.Show, hence was removed.
- DataSet.NeverShow is not necessary, DataSet.Hide can be used both for datasources
  that should not be shown at all as well as datasources that are wrong for this object.

* Made DataSet.FriendlyName a get-only property and compacted repetitive code.

* Use the Helpers regular expressions for assigning the datasource category.

* Removed id from the DataSet constructor parameters. It can be constructed from the XenObject and the datasource name.

* Compacted the code for readability (it was difficult to follow the build of the URIs).

Also, removed use of Helper.GetUuid to avoid the use of reflection. Minimised casts.

* CP-36567: Use the datasource units as specified in the API instead of deducing them from the datasource name.

- Also, merged static method DataSet.Create into the DataSet constructor.
- Minor restructuring of the ArchiveMaintainer file (moved all private fields
  and properties closer together).
- Added new resource file so the units can be separated from Messages.
2021-08-10 14:43:05 +01:00
Konstantina Chremmou
2d356bef47
Merge pull request #2824 from kc284/wlb
Some code removal and workflow fixes around WLB reports (includes CA-339666).
2021-08-10 14:34:17 +01:00
Konstantina Chremmou
bdbdb0feb0
Merge pull request #2821 from kc284/master
CA-340735: Re-wrote Page_InstallationMedia of the NewVM wizard to fix various issues
2021-08-10 14:32:18 +01:00
Konstantina Chremmou
019b8219c4 Updated hall of fame.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-08-10 14:15:00 +01:00
Danilo Del Busso
c5bb3dc49d
CA-279581: Prevent panel headers from overlapping scrollbar (#2844)
* CA-279581: Prevent panel headers from overlapping scrollbar
* CA-279581: Include sections' parent height in scrollbar check
* CA-279581: Move null check to parent property when refreshing GeneralTabPage scrollbar

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-08-10 14:13:11 +01:00
Konstantina Chremmou
76d1e5c8f5 CP-36567: Use the datasource units as specified in the API instead of deducing them from the datasource name.
- Also, merged static method DataSet.Create into the DataSet constructor.
- Minor restructuring of the ArchiveMaintainer file (moved all private fields
  and properties closer together).
- Added new resource file so the units can be separated from Messages.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-08-05 15:36:46 +01:00
Konstantina Chremmou
581a9c41ee Compacted the code for readability (it was difficult to follow the build of the URIs).
Also, removed use of Helper.GetUuid to avoid the use of reflection. Minimised casts.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-08-05 15:36:46 +01:00
Konstantina Chremmou
a95aeceed4 Removed id from the DataSet constructor parameters. It can be constructed from the XenObject and the datasource name.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-08-05 15:36:46 +01:00
Konstantina Chremmou
a0bd8a7d46 Use the Helpers regular expressions for assigning the datasource category.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-08-05 15:36:45 +01:00
Konstantina Chremmou
5619b65fe2 Made DataSet.FriendlyName a get-only property and compacted repetitive code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-08-03 23:16:16 +01:00
Konstantina Chremmou
ded4bcd807 Removed unused and duplicate properties.
- DataKey.Hide was unused. Once removed, DataSet.Deselected was unused, hence was also removed.
- Dataset.Draw was duplicating DataSet.Show, hence was removed.
- DataSet.NeverShow is not necessary, DataSet.Hide can be used both for datasources
  that should not be shown at all as well as datasources that are wrong for this object.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-08-03 23:16:15 +01:00
Konstantina Chremmou
abecb4994e The DataSourceItem.Uuid is not really a uuid. Renamed it to Id to avoid misunderstandings.
Also, compacted DataSourceItem constructors.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-08-03 23:16:15 +01:00
Konstantina Chremmou
3b30b12a42 Renamed property DataSet.Name to DataSet.FriendlyName for clarity. Removed duplicate string.Format() call.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-08-03 23:16:14 +01:00
Konstantina Chremmou
090667fd85 Renamed property DataSet.TypeString to DataSet.DataSourceName so it reflects better what it is.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-08-03 23:16:13 +01:00
Konstantina Chremmou
9eac324ed9 Renamed properties DataSet.Type and DataSourceItem.DataType to Category.
The old name was not reflecting what they were.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-08-03 23:16:13 +01:00
Konstantina Chremmou
c2ea499057 DataSet field Uuid is not really a uuid. Renamed to Id to avoid misunderstandings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-08-03 23:16:12 +01:00
Konstantina Chremmou
5e7f18dcab
Merge pull request #2845 from xenserver/feature/hyperman
Merge feature/hyperman branch into master
2021-08-03 12:04:18 +01:00
Danilo Del Busso
f7d808ee8a CA-350819: Add support for passwordless certificates in VM export signing
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-07-30 17:22:23 +01:00
Konstantina Chremmou
d0307c183b Corrected log files path and removed obsolete log file settings from XenOvfApi.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-07-30 17:17:54 +01:00
Konstantina Chremmou
e0bedb88a9 Tests fixes and minor refactoring:
- Fixed broken test due to missing static images.
- Fixed NUnitEngineExeption thrown due to StackOverflowException when searching
  for non-existing assembly (due to wrong branding).
- Commented out ignored tests causing the overall NUnit result to be reported as
  Warning instead of Passed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-07-30 17:17:54 +01:00
Konstantina Chremmou
461f180aaa Merge remote-tracking branch 'upstream/master' into feature/hyperman
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/BugToolWizardFiles/BugToolPageRetrieveData.cs
#	XenModel/Actions/VM/ImportVmAction.cs
2021-07-25 15:25:32 +01:00
Konstantina Chremmou
e368d74330 DelegatedAsyncAction should only be used for simple API calls, hence created new class for retrieving WLB host evacuation recommendations.
This allows removal of DelegatedAsyncAction.ResultObject, which might lead to complicated implementations.
Also: some refactoring of the other WLB retrieve recommendations actions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-07-23 09:40:12 +01:00
Konstantina Chremmou
63f4fb4be5 CP-36122: Warn the user about inhomogeneous certificate verification when creating/joining a pool.
Also, removed methods that were obscuring unnecessarily the contained logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-07-06 10:01:06 +01:00
Konstantina Chremmou
d3e8bc0d7a Order the host certificates by type and the trusted CA certificates by name.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-23 15:29:53 +01:00
Konstantina Chremmou
3ff714da65 CP-35467: Implemented ability to reset the host certificate.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-23 15:29:53 +01:00
Konstantina Chremmou
b896da04d7 Simplified the signature of the methods adding entries to the GeneralTabPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-23 15:29:53 +01:00
Konstantina Chremmou
3f4b0883df Tidied up WLB menu items. Corrected CanExecute logic for the associated commands. Unregister event upon action completion.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-23 15:29:53 +01:00
Konstantina Chremmou
7018c866c5 CP-36125: Extended interface for inspection of certificates.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-23 15:29:53 +01:00
Konstantina Chremmou
f2eb3fa973 CP-35632: Support for new alerts.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-23 15:29:53 +01:00
Konstantina Chremmou
f4e17109c8 CP-36124: Check and enable TLS verification on first connection. Also, PascalCased some methods.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-23 15:29:53 +01:00
Konstantina Chremmou
92cf9572bc CA-355655: Throttle the number of parallel downloads of server status report data in a pool.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-23 15:25:24 +01:00
Konstantina Chremmou
1df1083a2d Use more generic names for client version updates, checks, alerts etc.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-09 15:52:10 +01:00
Konstantina Chremmou
dce5a0d1c1 CA-355163: Check the client branding matches the new client version alert.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-09 15:52:10 +01:00
Konstantina Chremmou
3251ddf495 CA-355018: Ensure disabled health check status is reflected in the cache before re-rerunning prechecks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-08 15:57:08 +01:00
Konstantina Chremmou
36beaa5180 CA-355166: Updated help links.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-08 15:56:29 +01:00
Konstantina Chremmou
70af65e446 CA-355182: Removed obsolete RPU hotfixes.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-08 15:55:52 +01:00
Konstantina Chremmou
2defc1dbff Fixed workflow when loading the WorkloadReports dialog (includes CA-339666).
- Fixed exception handling in RetrieveWlbConfiguration action (exceptions of type
  other than Failure were silenced).
- CA-339666: Fixed control flickering when showing the WorkloadReports dialog.
- Retrieve the WlbConfiguration before attempting populating the controls.
- If the dialog was launched requesting a certian report to be run, the report
  was not selected on the list.
- Some refactoring to simplify the code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-27 15:39:52 +01:00
Konstantina Chremmou
393e041c4f Removed commented out and dead code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-27 11:30:58 +01:00
Konstantina Chremmou
3082745c85 Tidied up WLB report files:
- Moved the business logic classes to XenModel close to their base class.
- Moved WorkloadReports dialog close to the other WLB dialogs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-26 17:54:53 +01:00
Konstantina Chremmou
fcb5a1e445 Removed obsolete files. Moved test utility class to the right project.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-26 17:06:03 +01:00
Konstantina Chremmou
33295bfc1b CA-354879, CA-354877: Branding and version corrections.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-26 00:37:25 +01:00
Konstantina Chremmou
67d1ddd1d1 Merge remote-tracking branch 'upstream/master' into feature/hyperman
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	Jenkinsfile
#	XenAdmin/Alerts/Types/GuiOldAlert.cs
#	XenAdmin/Alerts/Types/LicenseAlert.cs
#	XenAdmin/Commands/RestartToolstackCommand.cs
#	XenAdmin/Diagnostics/Problems/HostProblem/HostNotSafeToUpgradeWarning.cs
#	XenAdmin/Dialogs/AllowUpdatesDialog.cs
#	XenAdmin/Dialogs/OptionsPages/ConfirmationOptionsPage.cs
#	XenAdmin/Dialogs/RepairSRDialog.cs
#	XenAdmin/Dialogs/UpsellDialog.cs
#	XenAdmin/Plugins/UI/TabPageCredentialsDialog.cs
#	XenAdmin/Program.cs
#	XenAdmin/Wizards/ConversionWizard/ConversionNetworkPage.cs
#	XenAdmin/Wizards/CrossPoolMigrateWizard/CrossPoolMigrateDestinationPage.cs
#	XenAdmin/Wizards/NewSRWizard_Pages/SrWizardType.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_FirstPage.cs
#	XenCenterLib/XSVersionAttribute.cs
#	XenModel/BrandManager.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
2021-05-25 15:51:42 +01:00
Konstantina Chremmou
5676334c8d CP-36917: Updated server version.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-24 09:56:20 +01:00
Joey
a56a383ec0
CP-35687: Detach update mechanism from update wizard (#2812)
* CP-35687: Detach update mechanism from update wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>

* CP-35687 part 2: Removed updates mechanism.
* Corrections as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-21 15:13:45 +01:00
Konstantina Chremmou
d21f6dda5a CA-340735: Re-write to fix workflow issues and simplify the code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-21 00:39:03 +01:00
Konstantina Chremmou
bff0fcfc85 CA-340735: Prevent multiple registration of combobox events during page repopulation after a template change.
Also renamed the event handlers to match VS conventions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-21 00:39:03 +01:00
Konstantina Chremmou
2f399c6737 Fixes to the OO design of ISODropDownBox and CHChanger classes. Register template events on the Page_InstalaltionMedia.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-21 00:39:03 +01:00
Konstantina Chremmou
26abbcd615 Removed overrides that were doing the same as the base class methods.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-21 00:39:03 +01:00
Konstantina Chremmou
04c42158f8 Set default value of property Empty and hide it from the designer.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-21 00:39:02 +01:00
Konstantina Chremmou
88c923b11c Removed colour settings for unsupported windows versions.
Note that OS.Version.Major=6 covers up to and including the supported Win8.1 and
WS2012, but there is not point in using earlier windows colour schemes for them.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-18 11:12:11 +01:00
Konstantina Chremmou
13cd1998b8 Consolidation of ballooning colours.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-18 11:12:11 +01:00
Konstantina Chremmou
0fc835a194 Removed BlueBorderPanel.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-18 11:12:11 +01:00
Konstantina Chremmou
75b05f81a2 CP-35350: Moved WLB server icon to the branding folder. Use different arrow files on the WLB credentials dialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-18 11:12:11 +01:00
Konstantina Chremmou
003d65087b Ensure there are servers whose CPU will be downlevelled before showing the warning.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-17 14:52:57 +01:00
Konstantina Chremmou
e3e73c8a0a
Merge pull request #2807 from xenserver/feature/legacy-partition
Merge feature/legacy-partition to master
2021-05-04 13:06:16 +01:00
Konstantina Chremmou
2dff51f4cc CA-353426: Button text was truncated in Japanese.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-04 13:05:44 +01:00
Konstantina Chremmou
b116c4713d CA-353524: Full copy of VM on the same SR is allowed.
Moving and copying a VM should be treated differently, hence we need a different
SrPickerItem subclass for each operation. Minor logic simplifications.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-04 13:05:27 +01:00
Konstantina Chremmou
cfddc5d318 CA-353217: Fixed handling of filenames with spaces.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-28 11:28:41 +01:00
Konstantina Chremmou
ca8e53e0ba CA-294901: Improved message on the CrossPoolMigrateWizard.
Also, NoTargetServerPoolItem class should be private to the SelectMultipleVMDestinationPage
because it is not used anywhere else.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-28 11:28:28 +01:00
Konstantina Chremmou
735896fdca CA-340976: Corrected disabled reason for IP address configuration button.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-27 00:18:47 +01:00
Mihaela Stoica
a75e8fca4f
Merge branch 'master' into feature/legacy-partition 2021-04-23 14:37:05 +01:00
Konstantina Chremmou
19052e912d CA-353092: Added labels detailing what the compression option does.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-20 12:34:31 +01:00
Konstantina Chremmou
a104175cb6 Corrected the branding of the session's user agent.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-14 15:50:50 +01:00
Konstantina Chremmou
3f4737c57a Upgraded log4net to 2.0.12.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-09 09:16:01 +01:00
Konstantina Chremmou
6d8ad062f8 CA-353070: Corrected wizard title. Fixed navigation with the Tab key.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-08 17:28:48 +01:00
Konstantina Chremmou
abf4ae3f35 CP-36392 pt.1: Removed unused using directives.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-07 10:04:47 +01:00
Konstantina Chremmou
e5bee7be6a Added Events in progress to the outlook-style status labels of the main window.
- Reordered the labels to reduce flickering for short actions.
- No need to fire action events in a try-catch block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-07 10:04:30 +01:00
Konstantina Chremmou
75cda928ec CA-352896: Corrected latency units.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-01 11:30:54 +01:00
Konstantina Chremmou
35e1d68afa CA-352901: Fixed window title and translations for window title and menu item.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-01 11:30:54 +01:00
Konstantina Chremmou
a0e2967792 CP-31105: Replaced the hardcoded name patterns in the resource files with format placeholders.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-31 11:50:32 +01:00
Konstantina Chremmou
c4b076bd97 Removed unused code alongside strings in need of branding.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-31 11:50:32 +01:00
Ji Jiang
c1ec145cf7 Fix some messages
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2021-03-22 23:32:09 +00:00