Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-12-05 01:21:07 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,766 Commits 12 Branches 48 Tags 186 MiB
85414de2c2
Commit Graph

6766 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Danilo Del Busso
85414de2c2
Tidy up XSVNCScreen: Fix naming in file 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:11 +01:00
Danilo Del Busso
133cd456c6
Tidy up XSVNCScreen: use null propagation and conditional access 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:10 +01:00
Danilo Del Busso
4cfb129f6d
Tidy up XSVNCScreen: fix typo 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:10 +01:00
Danilo Del Busso
d28ec66a2b
Tidy up XSVNCScreen: remove cast with pattern variable 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:10 +01:00
Danilo Del Busso
56274d7298
Tidy up XSVNCScreen: merge conditional expression 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:09 +01:00
Danilo Del Busso
a55cc8ea7a
Tidy up XSVNCScreen: remove redundant type arguments 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:09 +01:00
Danilo Del Busso
d0e63e7bd7
Tidy up XSVNCScreen: remove redundant explicit delegate creation 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:08 +01:00
Danilo Del Busso
a79eaa0bcc
Tidy up XSVNCScreen: use var when possible 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:08 +01:00
Danilo Del Busso
67dd31fc44
Tidy up XSVNCScreen: remove redundant base() call 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:07 +01:00
Danilo Del Busso
2287672e44
Tidy up XSVNCScreen: use expression-bodied properties 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:07 +01:00
Danilo Del Busso
bcb3fdc00a
Tidy up XSVNCScreen: use built-in type references 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:06 +01:00
Danilo Del Busso
5ba0a42bd5
Tidy up XSVNCScreen: remove redundant initializers 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:06 +01:00
Danilo Del Busso
53fba195a7
Tidy up XSVNCScreen: remove this when unnecessary 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:06 +01:00
Danilo Del Busso
b8eb2b5549
CA-379640: Do not reset remote consoles if they're still attempting connection to a VM 
This prevents `AccessViolationException`s being called, as they're hit when two instances of `AxMSTSCLib.AxMsRdpClient9` call `Connect` on the same IP + Port combination, which results in the same memory being accessed in unmanaged code.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:54:05 +01:00
Danilo Del Busso
9ea0a53447
Catch HRESULT E_FAIL exceptions for IRDPClient.Connect calls 
The `Connect` method returns `E_FAIL` if it is called while the control is already connected or in the connecting state. This can be hit when a lot of connections are being opened at the same time, and it's there as a failsafe.

Also adds `IsAttemptingConnection` as a new field

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:47:02 +01:00
Danilo Del Busso
7067629b29
Add IRdpClient to abstract some common functionality of RDP clients 
The reason this wasn't added to the `AxMsRdpClientX` classes is that I thought it best to not touch `AxMSTSCLib` classes as they are likely generated.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-11 10:47:01 +01:00
Konstantina Chremmou
33d0b725ff
Merge pull request #3160 from danilo-delbusso/dev/vcpus-warnings 
Miscellaneous fixes to vCPUs warnings
 2023-07-10 15:11:56 +01:00
Konstantina Chremmou
d3004bfac3
Merge pull request #3136 from danilo-delbusso/dev/start-twice-CA-376480 
CA-376480, CA-374325, & CA-378489: Prevent two instances from starting after running installer; Add desktop shortcut option; Remove existing shortcuts
 2023-07-10 15:07:34 +01:00
Danilo Del Busso
1d8391c9f9
CA-378489: Remove all remnants of previous installation when upgrading with Wix installer 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-10 13:48:09 +01:00
Danilo Del Busso
715f873329
CA-374325: Move shortcut to last page 
Also update spacing of controls within the `CustomizeDlg` to take more advantage of the available space

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-10 13:48:09 +01:00
Danilo Del Busso
a08ed18770
Improve wording for IMPORT_WIZARD_CPUS_COUNT_MISMATCH_POOL warning 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-10 13:44:09 +01:00
Konstantina Chremmou
b7eff2d790
Merge pull request #3167 from danilo-delbusso/bug/CA-379402_eua 
CA-379402: Fix EUA check & add hotfix check to `HostMemoryPostUpgradeCheck`
 2023-07-04 15:47:29 +01:00
Danilo Del Busso
d2424eacf3
Ensure PrepareToUpgradeCheck is run first in the manual upgrade block 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-04 08:58:31 +01:00
Danilo Del Busso
4e59f26cad
Ensure CanRun is called before adding EUA check to precheks list 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-04 08:57:45 +01:00
Danilo Del Busso
eba3305587
Prevent HostMemoryPostUpgradeCheck from running if required hotfixes are missing 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-03 16:03:17 +01:00
Danilo Del Busso
6eb09cbac4
CA-379402: Do not return Problems if the EUA check is run for upgrades to 8.2 CU1 or below 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-03 16:03:16 +01:00
Danilo Del Busso
dc747fec05
Update wording of vCPUs count warnings in ImportWizard 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-03 15:46:02 +01:00
Danilo Del Busso
b43387774e
Remove backing field for AllSelectedTargets 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-07-03 15:43:49 +01:00
Konstantina Chremmou
d4374285a9 CA-377017: Improved message shown when attempting to export VMs with vTPMs as OVF/OVA packages. 
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
 2023-07-03 11:38:58 +01:00
Danilo Del Busso
1e78d6964b CP-41573: Do not attempt problem reversion if SolutionAction.Connection is null 
Applies to newly added EUA presence problem

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 16:26:22 +01:00
Danilo Del Busso
594db56b6a CP-41573: Refresh pre-checks once EuaNotAcceptedProblem is fixed 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00
Danilo Del Busso
06ab09eabb CP-41573: Apply code review suggestions 
- Ensure `UpgradeRequiresEUA` runs for Yangtze or greater hosts
- Group non-manual checks in same if block
- Remove unused field in `EuaNotFoundProblem`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00
Danilo Del Busso
6ce22f759a CP-41923: Update RPU005 to version 5.0 
Also:
- Add `HostDoesNotHaveHotfixWarning` warning to EUA `Check` when necessary
- Filter our `null` EUAs before passing them to the `Problem`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00
Danilo Del Busso
58be7ff5f9 CP-41573: Make AcceptEuaDialog resizable 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00
Danilo Del Busso
c0f849e4fa CP-41573: Use existing generic message for EuaNotFoundProblem 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00
Danilo Del Busso
ffbf8e3cd0 CP-41573: Use wizard page as a parent of AcceptEuaDialog 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00
Danilo Del Busso
927c5b138f CP-41573: Set AcceptButton and CancelButton for AcceptEuaDialog 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00
Danilo Del Busso
b7a20d5c04 CP-41573: Add 10 padding to AcceptEuaDialog content 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00
Danilo Del Busso
c463601e52 CP-41573: Add blocking problem if POST82X hosts cannot fetch the EUA 
Also:
- Remove unused `button_click` event handler in `AcceptEuaDialog`
- Load EUAs within the `UpgradeRequiresEua` `Check` and removed the spinner from `AcceptEuaDialog`
- Remove `_errors` from `AcceptEuaDialog`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00
Danilo Del Busso
de6372f680 CP-41573: Check for presence of valid URI within UpgradeRequiresEUA Check 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00
Danilo Del Busso
f03c1cc17b CP-41573: Move EUA precheck after hotfixes 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00
Danilo Del Busso
5f5695057d CP-41573: Improve comparison logic for problems 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00
Danilo Del Busso
f707b0daca CP-41573: Add UpgradeRequiresEua as a permanent check to the RollingUpgradeWizardPrecheckPage 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00
Danilo Del Busso
49b8f8e16f CP-41573: Add UpgradeRequiresEua and EuaNotAcceptedProblem 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00
Danilo Del Busso
e265a1f23e CP-41573: Add helper function to fetch host EUA 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00
Danilo Del Busso
34eb5ff9b0 Enable multiple IXenObjects to be associated with a Check instance 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-26 10:11:19 +01:00
Danilo Del Busso
eb0636fe9c
Update warning messages for host selection when importing VM appliance 
Adds a new field in `SelectMultipleVMDestinationPage`: `AllSelectedTargets`.

This new field contains a list of all hosts that have been selected. This way `ImportSelectHostPage` can check for each `Host` that has been selected individually and add more relevant messages

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-19 13:46:33 +01:00
Danilo Del Busso
084215feaf
Reset ovfMaxVCpusCount when a new OVF is selected 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-16 11:37:32 +01:00
Danilo Del Busso
a2a5ae0cf4
Move _ovfVCpusCount.Clear outside content check loop 
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
 2023-06-16 11:19:40 +01:00
Konstantina Chremmou
17b3406639
Merge pull request #3155 from kc284/two_bugs 
Fixed two issues when saving pool properties
 2023-06-13 13:39:37 +01:00