Commit Graph

5094 Commits

Author SHA1 Message Date
Konstantina Chremmou
85b326497d CA-293664: Corrected text colour for selected item.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-25 09:39:04 +01:00
Konstantina Chremmou
664bd9dd0c CA-293723: Reworked SR selection logic so that hotfix application works for
for both fully and partially attached SR. For ely and above the SR needs to
be visible from master, while for earlier versions we pick a list of a SRs
to cover all hosts.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-24 10:14:57 +01:00
Konstantina Chremmou
d0c011d00c Improved error message and simplified error handling and logging to avoid multiple catch-rethrow of exceptions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-24 10:14:57 +01:00
Konstantina Chremmou
58c6754ff2 No need to access the setting ServerHistory in a try-catch block that resets
all settings in case of failure. Null check and minor optimisation of setting
KnownServers.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-24 10:14:57 +01:00
Mihaela Stoica
ee6925beae CA-293923: Changed the sleep time between retries.
Also, there shouldn't be a sleep after the last try.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-19 16:12:50 +01:00
Joey
e5f4329f5d
Merge pull request #2146 from MihaelaStoica/CA-293923
CA-293923: Use a NetworkAvailabilityChanged event to detect changes i…
2018-07-19 14:12:28 +01:00
vetrivelc
8ef1764c84 L10N: Translation Updates & CA-293780 2018-07-19 11:05:16 +01:00
Konstantina Chremmou
a86edc6cfd Copy some more properties of the XmlRpcProxy to the JsonRpcClient and ensure all
JsonRpcCient properties are replicated when the session is duplicated.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-18 14:49:37 +01:00
Konstantina Chremmou
ac7eb1a8e2 CA-293478: Always set the WebRequest properties to the values specified by the JsonRpcClient.
This fixes issue where the WebRequest.Proxy had a non-null default value, which
prevented connection to a server with the management interface on a vlan.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-18 14:49:37 +01:00
Mihaela Stoica
42c3a369a3 CA-293923: Use a NetworkAvailabilityChanged event to detect changes in the network connectivity and mark the download as failed when the network becomes unavailable
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-18 14:23:37 +01:00
Mihaela Stoica
9fb6b85887
Merge pull request #2144 from xenserver/REQ-672
Merge REQ-672 to master
2018-07-16 12:36:15 +01:00
Konstantina Chremmou
d639708781 CA-293863: Do not update the done and in-progress actions on the worker thread.
Also, do not log error every time the output panel is updated.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-16 11:50:42 +01:00
Konstantina Chremmou
c67abdb9b8
Merge pull request #2141 from MihaelaStoica/REQ-672
Merge master into REQ-672 branch + fix the PoolHasGFS2SR class
2018-07-13 13:40:48 +01:00
Mihaela Stoica
a2aa002aae Update the PoolHasGFS2SR class to inherit from HostPostLivenessCheck
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-13 13:23:01 +01:00
Mihaela Stoica
9accb3c69f Merge branch 'master' into REQ-672
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenAdmin.csproj
2018-07-13 13:14:36 +01:00
Konstantina Chremmou
b0f9d41381 Changed the description of the actions saving properties of XenObjects to express
explicitly what the actions do. The previous description "updating" could be
confusing when seen out of context amidst other actions on the events page,
because updating also refers to server patching.
2018-07-13 12:39:33 +01:00
Konstantina Chremmou
a55d9d3edd CA-293764: Do not suppress history for the actions applying hotfixes because
if they fail the user has no indication an error occurred.
Also, simplified the logging and error handling within the action body: failures
are logged anyway by the base class, so no special handling is necessary.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-13 12:39:33 +01:00
Konstantina Chremmou
9157db94ac CA-293764: Added new property XenObject to the Checks, which returns the Pool
or Host accordingly. Extended comparison of Problems to also take account of
the XenObject the Check was performed on, otherwise the Problems get mixed
up when there are homonymous members across pools.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-13 12:39:33 +01:00
Mihaela Stoica
192f38671b Add RBAC checks to PoolDisableClusteringAction
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-12 15:15:21 +01:00
serenc
e1cb27a80d CA-292991: Remove unused modules and check clusterHostPif not null
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-07-12 14:57:59 +01:00
serenc
dc833d2cc8 CA-292991: Store resolved values in a variable
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-07-12 14:57:59 +01:00
serenc
118eca3d61 CA-292991: Block host joining cluster with cluster network (bonded/unbonded) unless the interface is defined
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-07-12 14:57:59 +01:00
serenc
0bec35629a CA-293337: Pass device-config from probe to PBD.create
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-07-12 14:57:14 +01:00
Mihaela Stoica
15aee105f0 CA-293669:Code optimisation
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-12 14:45:23 +01:00
Mihaela Stoica
f09683be7c CA-293669: Block the installation of an old-format patch if the pool is partially upgraded and the master is Ely or greater
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-12 14:45:23 +01:00
Mihaela Stoica
6e468da70a CA-293669: In the Updates tab, show the required updates for the slaves in a partiallly upgraded pool, even when the master's version cannot be found in the c-f-u
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-12 14:45:23 +01:00
Ji Jiang
6e2720cbc4 CA-292377: Show warning if no cluster network found
1) When create/delete bond, inconsistent cluster network may occur. Show
warning in this case.
2) Refactor UI on cluster network edit page.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-07-12 14:40:46 +01:00
Konstantina Chremmou
542cf63428 Improved the RBAC message on the Patching wizard to provide more info on the
minimum required role. Do not deselect a pool on the RPU wizard if it fails
the RBAC check; let the user decide either to reconnect with more privileges
or deselect it.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-12 13:36:27 +01:00
Mihaela Stoica
5e9f6d84f9 CP-28712: Add new message and friendly names (#2132)
CP-28712: Add new message and friendly names

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-12 10:39:16 +01:00
Ji Jiang
ce3a1a6f02 CA-293686: Fix the spelling mistake
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-07-11 16:35:00 +01:00
Ji Jiang
9e8e8237e2 CA-293721: Improve host HostMaintenanceMode problem description
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-07-11 14:28:49 +01:00
Mihaela Stoica
12dc85f830 CA-293687: Remove redundant check
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-11 12:59:52 +01:00
Mihaela Stoica
eeb671d960 CA-293687: After a host has been upgraded, perform a check for updates before calculating the minimal patches
(to ensure that XC has the latest c-f-u data, as it's possible that the user hasn't configured XenCenter to automatically check for updates)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-11 12:59:52 +01:00
Mihaela Stoica
f59c6a4815 In the RPU wizard, run the HA and automated updates license checks on SelectedMasters, to ensure that they are run even if the master does not need to be upgraded or updated
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-11 12:59:52 +01:00
Mihaela Stoica
046c4e1c7b CA-293682: In the RPU wizard, only check the batch hotfix license restriction for Dundee or greater hosts
... because pre-Dundee hosts dont't have this license flag, but they might have it after the upgrade.

Also added a bit more logging in the function that generates the update plan actions

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-11 12:59:52 +01:00
serencorbett1
63d09dd117 CP-28431: Block updates/upgrades from Kolkata if clustering enabled (#2124)
* CP-28431: Block updates and upgrades from Kolkata onwards if clustering enabled
* CP-28431: Rename files and change from Pool Check to [Host] Check
* CP-28431: Change description message

Signed-off-by: Seren Corbett <seren.corbett@citrix.com>
2018-07-09 10:59:09 +01:00
Konstantina Chremmou
624a228715 Corrected the logic deciding whether a supplemental pack is applicable on a host.
(This looks like a better fix for CA-236547 too).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-08 22:43:21 +01:00
Konstantina Chremmou
c11b692958 CA-293158: Reworked the logic enabling/disabling and selecting servers depending
on the update mode, so that the right set of hosts is passed on to the prechecks
page for partially upgraded pools that are to be updated to a new version with
hotfixes. Also, corrected code that was mixing the logic of changing the enabled
 state of a row with the checked state.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-08 22:43:21 +01:00
Konstantina Chremmou
91563ebd54 No need to catch and rethrow exception as it's logged anyway; a couple of more optimisations.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-08 22:43:21 +01:00
Konstantina Chremmou
0aa43018a4 Removed ManualModeSelected property in favour of the existing ManualUpgrade; moved the latter in the class using it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-08 22:43:21 +01:00
Konstantina Chremmou
8851139a11 Reverted the AutomatedUpdatedLicenseCheck to derive from HostPostLivenessCheck or
the liveness warning is not issued if the pool is disconnected. HAOffCheck tidy up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-08 22:43:21 +01:00
Ji Jiang
3c2463040a CA-293322: Fix blocked unclustered network setting change
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-07-08 22:15:42 +01:00
Alexander Schulz
66e4382d3b Snapshot view: Treeview as default (like in the past)
https://github.com/xcp-ng/xenadmin/issues/62
2018-07-08 01:37:15 +01:00
Mihaela Stoica
a511124b82 CA-293311: RPU wizard: Only check the maintenance mode on hosts that need to be upgraded (and check host liveness on the hosts where we will only apply updates)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-06 16:03:28 +01:00
Mihaela Stoica
1ac88b7cec CA-293311: RPU wizard: In a partially upgraded pool, apply the hotfixes on the upgraded hosts before upgrading the remaining slaves
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-06 16:03:28 +01:00
Mihaela Stoica
7c1484d6c7 CA-293099: If the update that we are trying to apply is already applied, then show that in the wizard.
Also sort Messages.resx and call ReplaceProgressStep instead of AddProgressStep in the DownloadPatchPlanAction class (when the download is skipped)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-04 16:08:22 +01:00
Konstantina Chremmou
b08e91a470 Do not create a new background worker every time the checks are refreshed; queue
a new check on the existing one instead. Moved the background worker to the designer
of the class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-04 12:09:37 +01:00
Konstantina Chremmou
c2ae0a6069 Placed the CFU availability and the automated updates licence checks under the same group as requested per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-04 12:09:37 +01:00
Konstantina Chremmou
69c9d942ff CA-293328: SafeToUpgradeCheck was not checking for liveness first; now this
is enforced on all host post-liveness checks.
Added missing description to SafeToUpgradeCheck.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-04 12:09:37 +01:00
Konstantina Chremmou
63e4ced7fe Run the CFU availability check together with the check for the automated updates licence.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-04 12:09:37 +01:00