Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2025-01-21 07:49:32 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,617 Commits 12 Branches 48 Tags 186 MiB
88a60312df
Commit Graph

4201 Commits

Author SHA1 Message Date
Konstantina Chremmou
a77f3c3994 Corrections per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-11-16 17:36:17 +00:00
Konstantina Chremmou
a3569aa875 CP-41048: Add each SR to the SrPicker as soon as its scan finishes, without waiting for the other scans to finish. 
The scans run in parallel in batches of three to avoid flooding the session.
Also, prevent firing the SelectedIndexChanged event multiple times when populating the NewDisk dialog.
Renamed the SrPicker control on the latter (because SrListBox is a different type of control).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-11-15 16:48:53 +00:00
Konstantina Chremmou
5252272853 Changed the order of some of the initial and final operations. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-11-14 09:45:34 +00:00
Konstantina Chremmou
d1132f5823 Removed undocumented and buggy command line functionality. Moved command line arguments handling to the main window. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-11-14 09:45:34 +00:00
Konstantina Chremmou
6644ef920a CP-41108: Replaced the separate splash screen executable with a form within the application executable. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-11-14 09:45:33 +00:00
Konstantina Chremmou
1102ac80e2 Moved settings loading, and proxy and authentication module configuration to the Settings class as it's more relevant there. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-11-11 14:24:22 +00:00
Konstantina Chremmou
cc808dff1d Moved methods showing/hiding objects to the config provider as they are more relevant there. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-11-11 14:11:48 +00:00
Konstantina Chremmou
167ccf4904 Moved colour definition close to where it is used. Fixed leak where new underline fonts where created but not disposed. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-11-11 14:10:31 +00:00
Danilo Del Busso
ebcef64a24
Merge pull request #3062 from danilo-delbusso/bug/credentials_CA-371356 
CA-371356 [XSI-1327]: Add option to prevent resetting pwd prompt function on disconnection
 2022-10-28 09:44:13 +01:00
Konstantina Chremmou
de6a4f89c1
Merge pull request #3033 from danilo-delbusso/bug/prevent-host-reset 
Prevent host reset when moving between wizard pages using `SelectMultipleVMDestinationPage`
 2022-10-27 10:58:54 +01:00
Danilo Del Busso
0b5d259745
CA-371356: Add option to prevent resetting pwd prompt function on connection disconnection 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-10-20 14:26:32 +01:00
Danilo Del Busso
77bd034e8d
CA-359965: Consider physical_utilisation value when checking for free space in thinly provisioned SRs (#3028) 
* CA-359965: Consider `physical_utilisation` value when checking for free space in thinly provisioned SRs

* CA-359965: Fix miscellaneous formatting issues

* Made SrPickerItem show the SR by default. Removed virtual method that was never overriden.

* Use slightly more intuitive name for property; also inverted its logic.

* Renamed VdiCreationCanProceed to the more specific CanFitDisks since it only deals with sizes.

* Re-arranged classes in file.

* Refactored SrPickerItem:

- Merged CanBeEnabled and DisabledReason properties to method CanBeEnabled(out disabledREason)
  to avoid running the same checks twice.
- Pass the disk instead of the size into extension method SR.CanFitDisks
  so that the correct size can be used for each storage (thin vs. non-thin provision).

* Correction as per code review and some tweaks to make the checks clearer and more efficient.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-10-11 09:26:54 +01:00
Konstantina Chremmou
a4e7462948 Fixed issue where the version on the update dropdown was not refreshed if a new update was found. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-10-07 13:20:56 +01:00
Konstantina Chremmou
94d4360218 Removed NewDiskDialog constructor as it was not particularly useful. 2022-10-07 09:19:10 +01:00
Konstantina Chremmou
83a1a74e02 Disable the Rescan button on the SR storage page when the SR is detached because the operation fails anyway. 
Also, some tidy up so the checks are clearer.
 2022-10-07 09:19:10 +01:00
Konstantina Chremmou
940b1580b9 Fixes issue where the Finish page of the NewVM wizard was not showing the selected home server correctly. 2022-10-07 09:19:10 +01:00
Konstantina Chremmou
0d70266173 CP-40748: Upgrade log4net to 2.0.15 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-10-04 11:00:12 +01:00
Konstantina Chremmou
9f781a5876 CA-370847: Unable to collect status report for multiple servers 
Linq.Intersect was failing to combine server capabilities because the helper
class did not implement GetHashCode.
 2022-09-26 10:05:01 +01:00
Konstantina Chremmou
74487155fa
Merge pull request #3053 from xenserver/master 
Merge master into feature/vtpm
 2022-09-16 14:27:56 +01:00
Konstantina Chremmou
71a8fde3c6 Wording and layout modifications for clarity. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-15 16:26:47 +01:00
Konstantina Chremmou
126bf9131c Use the correct xapi tag for vTPM support. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-13 16:35:32 +01:00
Konstantina Chremmou
d7124c9dcc Indentation/whitespace normalization. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-09 11:58:15 +01:00
Konstantina Chremmou
eedcfbe59d CP-40350: Hide vtpm capability if the feature flag is off. 
Also, some refactoring and addition of null checks.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-09 11:58:15 +01:00
Konstantina Chremmou
9e00a633f3 Create vTPMs as non-unique by default. Added title and description to create/destroy vTPM actions. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-09 11:58:15 +01:00
Konstantina Chremmou
fc5ccf77be Warn the user when exporting VMs with vTPMs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-09 11:58:15 +01:00
Konstantina Chremmou
bbc4ccdd52 Allow vTPM assignment when creating a VM. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-09 11:58:15 +01:00
Konstantina Chremmou
f7d96e21fd UEFI and UEFI secure boot modes are now fully supported, hence remove experimental warning. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-09 11:58:15 +01:00
Konstantina Chremmou
709a12f15a Allow vTPM management only on real VMs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-09 11:58:15 +01:00
Konstantina Chremmou
d94c55533c Renamed VM method is_a_real_vm to IsRealVm. 
The new name complies with C# conventions and allows distinguishing it from xapi field names.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-09-09 11:58:15 +01:00
Konstantina Chremmou
7768b71b2a Address review comments. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-31 11:06:40 +01:00
Konstantina Chremmou
fa955466ee Removed duplicate registration of events. Restored missing event registration. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-31 11:06:40 +01:00
Konstantina Chremmou
7144528f6b CP-39938: Flag a partially applied hotfix with red only if homogeneous application is required. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-22 12:45:37 +00:00
Danilo Del Busso
4f91b8a7e0
Merge pull request #3036 from danilo-delbusso/improvement/RPU_CP-39929 
CP-39929: Improvements on the RPU/Updates wizard
 2022-08-22 11:58:30 +00:00
Konstantina Chremmou
476648636b CP-40642: Hide templates with platform["vtpm"]=true 
Also, some corrections to the template comparer on the NewVM wizard's Template page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-19 17:11:50 +01:00
Konstantina Chremmou
1a786b38bf CP-39688: Added vTPM manager for creating and removing vTPMs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-19 17:11:50 +01:00
Konstantina Chremmou
5d75200735 CP-39533: Added indication on the general tab that a vTPM is attached to a VM. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-19 15:12:46 +01:00
Konstantina Chremmou
21a15104e7 Corrected the registry key name to use when running from source code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-19 09:45:51 +01:00
Danilo Del Busso
85e0ffec12
CP-39929: Use 24hrs format for RPU/Update logs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-17 11:40:38 +01:00
Danilo Del Busso
2438996c69
CP-39929: Use pipe | as delimiter for RPU/Update logs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-16 13:47:07 +01:00
Danilo Del Busso
8a3a24d92c
Normalise whitespace in Xenadmin/Diagnostics/Problems/* 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-15 16:13:44 +01:00
Danilo Del Busso
c6b50a5669
Use expression-bodied format for properties in Xenadmin/Diagnostics/Problems/* 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-15 16:13:39 +01:00
Danilo Del Busso
4ef260111b
CP-39929: Fix checkbox text in DisplayOptionsPage 
Also add missing ALT shortcuts

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-15 15:58:39 +01:00
Danilo Del Busso
60cd8b9f88
CP-39929: Fix incorrect timestamp shown in RPU/Update wizards 
Also:
- Use new date format for logs
- Specify option parameter names
- Do not show timestamp for host name log
- Do not show timestamp for null/whitespace only lines

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-15 15:57:55 +01:00
Danilo Del Busso
c2dc35359f
CP-39929: Enable MaximizeBox for PatchingWizard 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-15 15:47:59 +01:00
Konstantina Chremmou
6c2634074b Guard against registry keys returning empty strings. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-15 13:39:57 +01:00
Danilo Del Busso
158be06d8d
CP-39929: Remove useless new line after appending error string 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-15 13:11:40 +01:00
Danilo Del Busso
4340892b59
CP-39929: Prevent whitespace strings from being prepended with timestamp 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-15 13:10:22 +01:00
kishore Mengani
1f0452bf8f L10n: Translations updated & Resx sync 
Signed-off-by: kishore Mengani <kishore.mengani@citrix.com>
 2022-08-12 10:31:53 +01:00
Danilo Del Busso
54a9f22c87
CP-39929: Add timestamps to update logs 
- Add option to the display options page
- Add related setting
- Refactor `ExtensionMethods` to be more compact and flexible
- Add docs to `ExtensionMethods`
- Whitespace fixes

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-10 15:44:07 +01:00
Danilo Del Busso
1fd39713f1
CP-39929: Tidy up settings files 
sort settings by name

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-10 15:26:19 +01:00
Danilo Del Busso
cf44274a14
CP-39929: Enable use of maximize box for RPU Wizard 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-03 15:05:49 +01:00
Danilo Del Busso
824a46d541
CP-39929: Remove ellipsing from VMProblem descriptions 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-03 14:58:39 +01:00
Danilo Del Busso
a6eb7255d9
Fix whitespace in SelectMultipleVMDestinationPage.cs and ImageVMConfigPage.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-03 13:39:54 +01:00
Danilo Del Busso
8bc10f22a7
CA-368812: Improve field naming in SelectMultipleVMDestinationPage 
Also make selected target a publicly accessible field

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-03 13:39:52 +01:00
Danilo Del Busso
a69843352f
CA-368812: Prevent host reset when moving between wizard pages using SelectMultipleVMDestinationPage 
Multiple changes:

1. Remove `SetDefaultTarget(ChosenItem);` from `PageLeaveCore`. This was clearing the value every time the page was left.
2. Add event `m_dataGridView_CellValueChanged`. Inside the event, we keep track of which target host/pool was selected
3. Add a check that resets the value set in `m_dataGridView_CellValueChanged` in case the chosen pool is changed.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-03 13:39:50 +01:00
Konstantina Chremmou
69c007eabb
CA-368812: Refresh the gridview when the cell value is set so as to show the correct string. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-03 13:39:47 +01:00
Konstantina Chremmou
5a5f292959
CA-368812: The host selection was reset when moving back from the SR selection page. 
Also, minor code tidy.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-03 13:39:42 +01:00
Konstantina Chremmou
20a28c6c33 CP-40177: Remove mentions of Internet Explorer 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-07-25 11:34:09 +01:00
Danilo Del Busso
c34a398cce CA-368958: Reset clip region once performance lines are drawn 
Resetting the clip so that on the next render we don't hide labels and title.
Also moved logic outside `LineRenderer.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-07-21 14:28:43 +00:00
Konstantina Chremmou
00c3196440
Merge pull request #3027 from kc284/import-issues 
CA-368811, CA-368812: Issues on the import wizard.
 2022-07-20 13:50:15 +01:00
Danilo Del Busso
652845bc8f CA-368528: Fix performance data not being updated after a few seconds on VMs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-07-19 13:42:22 +00:00
Konstantina Chremmou
d6f83bac9c Increased width of memory NumericalUpDown because at the maximum value the text was truncated. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-07-19 12:26:10 +01:00
Danilo Del Busso
c2604a69bd CA-368811: Fix memory values showing in bytes in Import Wizard 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-07-19 12:10:15 +01:00
Konstantina Chremmou
030e07390c CA-368812: The SR selection page was not refreshed if the user selected a different target host in the same pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-07-14 22:23:52 +01:00
Konstantina Chremmou
c1e5825e24 CA-368811: FIxed issue whereby a minimum memory of 512MB was enforced silently on disk image imports. 
Also, increased the maximum allowed memory for imported disk images.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-07-14 16:00:58 +01:00
Konstantina Chremmou
7c87333439 CA-368577: Prevent crashing when the OVF envelope has been created for a disk image import. Some code tidy. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-07-11 14:58:09 +01:00
Konstantina Chremmou
46cd8308be CP-38582: Corrected version check - last_software_update was added in xapi 22.20.0 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-21 13:08:59 +01:00
Konstantina Chremmou
15b05ae572 Fixed issue on the Import XVA wizard where the SR selection was not taking account of... 
all scenarios of changed affinity if the user moved from the SR selection
page back to the server selection page and forwards again.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-21 10:49:06 +01:00
Konstantina Chremmou
7e11806790 CP-38582: Use more detailed format for the build and the last updated datetime. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-21 10:49:06 +01:00
Konstantina Chremmou
6898148466
Merge pull request #3021 from kc284/remove-updates-tab 
CP-39817: Removed updates tab page.
 2022-06-21 10:48:46 +01:00
Konstantina Chremmou
eb73a9f106 Show the DownloadUpdatesXmlAction only when it is run by the user or it has failed. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-20 15:27:22 +01:00
Konstantina Chremmou
9c61f64ec5 Show the status of the DownloadUpdatesXmlAction on the Events tab (previously it was shown on the Updates tab). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:47:54 +01:00
Konstantina Chremmou
b79eda2d4b Removed unused code around restoring dismissed updates. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:21:43 +01:00
Konstantina Chremmou
fc925ba047 Removed unused CfuAvailabilityCheck class. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:21:43 +01:00
Konstantina Chremmou
414eff9c2f CP-39817: Removed the option to check for server new versions since it is not relevant any longer. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:21:42 +01:00
Konstantina Chremmou
7deb50ee79 CP-39817: Added CFU button to replace the functionality of the Refresh button Remove updates tab page. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:21:42 +01:00
Konstantina Chremmou
bde23b23bf Fixed some code smells. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:21:42 +01:00
Konstantina Chremmou
e5d090d614 CP-39817: Removed the updates tab page. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:21:42 +01:00
Danilo Del Busso
2798315b46
Merge pull request #3017 from danilo-delbusso/task/last-updated_CP-38583 
CP-38582: Show `Last updated` field in General `TabPage`
 2022-06-15 13:32:36 +01:00
Konstantina Chremmou
8beae03d35 CP-38583: suggested modifications. (And a couple of code smells). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-15 13:05:11 +01:00
CitrixChris
ffa7f28c12
Merge pull request #3019 from xenserver/feature/REQ-622 
REQ-622: Citrix Hypervisor Center quick-update mechanism
 2022-06-13 14:57:15 +01:00
Konstantina Chremmou
fd627e687f CP-39933: Show the names of the PV guests preventing upgrade if any are detected. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-08 14:01:04 +01:00
Danilo Del Busso
6d6b0ce5fc
CP-38582: Show Last updated field in General TabPage 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-05-30 09:36:39 +01:00
Konstantina Chremmou
2889b1678d Corrections as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-25 11:36:08 +01:00
Konstantina Chremmou
df35684586 Moved version checking methods to a separate file. Use C# naming conventions. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Commands/DragDropCrossPoolMoveHaltedVMCommand.cs
#	XenAdmin/Commands/DragDropMigrateVMCommand.cs
#	XenAdmin/Wizards/CrossPoolMigrateWizard/Filters/CrossPoolMigrateCanMigrateFilter.cs
 2022-05-25 11:35:47 +01:00
Konstantina Chremmou
2f30ef1e19 CP-38687: Improved the speed of deleting multiple alerts. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-25 11:29:25 +01:00
Konstantina Chremmou
afa21f16a9
Merge pull request #3011 from kc284/CA-366140 
CA-366140: Reverted original solution. Handled error thrown when retrieving datasources.
 2022-05-25 11:04:51 +01:00
Konstantina Chremmou
76738ad91f
Merge pull request #3003 from kc284/drag-drop-3 
CA-294370: Rewrote logic calculating if migration is allowed + some other fixes.
 2022-05-25 11:04:26 +01:00
Konstantina Chremmou
755cec2bc1
Merge pull request #2998 from danilo-delbusso/bug/scrollbar_CA-293683 
CA-293683: Prevent automatic scrolling in RPU wizard if user has scrolled manually
 2022-05-25 11:04:03 +01:00
Konstantina Chremmou
dcbbbe84e9 CA-366140: Handle and log exceptions thrown when retrieving data sources. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-19 12:12:46 +01:00
Konstantina Chremmou
20cf55c19f Revert "CA-366140: Run data source operations on VMs only if they are allowed." 
This reverts commit dd56f744e8.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Actions/GUIActions/SaveDataSourceStateAction.cs
 2022-05-19 11:18:52 +01:00
Konstantina Chremmou
74bf6f3ba5 CP-36392: Fixes to sonarqube score. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-19 11:09:46 +01:00
Konstantina Chremmou
4f7ad4f0f0 Fixed broken build and made some additional L10n corrections to the layout. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-19 11:09:39 +01:00
Konstantina Chremmou
0cfe9c0a07 Corrections as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-18 10:54:44 +01:00
kishore Mengani
6b69496a39 L10n: Resx resync and trnslations updates 
Signed-off-by: kishore Mengani <kishore.mengani@citrix.com>
 2022-05-17 10:51:10 +01:00
Danilo Del Busso
4f09efe475
CA-293683: Prevent automatic scrolling when setting text in SmartScrollTextBox 
Also fix issue whereby `IsVerticalScrollBarAtBottom` would also return `True`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-05-16 15:33:52 +01:00
Konstantina Chremmou
8af0184030 Replaced dismiss button with release notes button. Show the application name in the update button. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-16 14:08:02 +01:00
Danilo Del Busso
6b200bef8b
Reorder fields in AutomatedUpdatesBasePage.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-05-12 13:36:13 +01:00
Danilo Del Busso
f2a67243a7
Apply code cleanup to AutomatedUpdatesBasePage.cs 
Use `var` where possible
Rename fields and methods following conventions
Use pattern matching when casting
Rename variables using more meaningful names

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-05-12 13:34:58 +01:00
Danilo Del Busso
27382f308b
CA-293683: Prevent automatic scrolling in RPU wizard if user has scrolled manually 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-05-12 13:06:04 +01:00