Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2025-01-21 07:49:32 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,617 Commits 12 Branches 48 Tags 186 MiB
88a60312df
Commit Graph

4201 Commits

Author SHA1 Message Date
Danilo Del Busso
cf44274a14
CP-39929: Enable use of maximize box for RPU Wizard 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-03 15:05:49 +01:00
Danilo Del Busso
824a46d541
CP-39929: Remove ellipsing from VMProblem descriptions 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-03 14:58:39 +01:00
Danilo Del Busso
a6eb7255d9
Fix whitespace in SelectMultipleVMDestinationPage.cs and ImageVMConfigPage.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-03 13:39:54 +01:00
Danilo Del Busso
8bc10f22a7
CA-368812: Improve field naming in SelectMultipleVMDestinationPage 
Also make selected target a publicly accessible field

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-03 13:39:52 +01:00
Danilo Del Busso
a69843352f
CA-368812: Prevent host reset when moving between wizard pages using SelectMultipleVMDestinationPage 
Multiple changes:

1. Remove `SetDefaultTarget(ChosenItem);` from `PageLeaveCore`. This was clearing the value every time the page was left.
2. Add event `m_dataGridView_CellValueChanged`. Inside the event, we keep track of which target host/pool was selected
3. Add a check that resets the value set in `m_dataGridView_CellValueChanged` in case the chosen pool is changed.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-08-03 13:39:50 +01:00
Konstantina Chremmou
69c007eabb
CA-368812: Refresh the gridview when the cell value is set so as to show the correct string. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-03 13:39:47 +01:00
Konstantina Chremmou
5a5f292959
CA-368812: The host selection was reset when moving back from the SR selection page. 
Also, minor code tidy.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-08-03 13:39:42 +01:00
Konstantina Chremmou
20a28c6c33 CP-40177: Remove mentions of Internet Explorer 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-07-25 11:34:09 +01:00
Danilo Del Busso
c34a398cce CA-368958: Reset clip region once performance lines are drawn 
Resetting the clip so that on the next render we don't hide labels and title.
Also moved logic outside `LineRenderer.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-07-21 14:28:43 +00:00
Konstantina Chremmou
00c3196440
Merge pull request #3027 from kc284/import-issues 
CA-368811, CA-368812: Issues on the import wizard.
 2022-07-20 13:50:15 +01:00
Danilo Del Busso
652845bc8f CA-368528: Fix performance data not being updated after a few seconds on VMs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-07-19 13:42:22 +00:00
Konstantina Chremmou
d6f83bac9c Increased width of memory NumericalUpDown because at the maximum value the text was truncated. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-07-19 12:26:10 +01:00
Danilo Del Busso
c2604a69bd CA-368811: Fix memory values showing in bytes in Import Wizard 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-07-19 12:10:15 +01:00
Konstantina Chremmou
030e07390c CA-368812: The SR selection page was not refreshed if the user selected a different target host in the same pool. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-07-14 22:23:52 +01:00
Konstantina Chremmou
c1e5825e24 CA-368811: FIxed issue whereby a minimum memory of 512MB was enforced silently on disk image imports. 
Also, increased the maximum allowed memory for imported disk images.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-07-14 16:00:58 +01:00
Konstantina Chremmou
7c87333439 CA-368577: Prevent crashing when the OVF envelope has been created for a disk image import. Some code tidy. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-07-11 14:58:09 +01:00
Konstantina Chremmou
46cd8308be CP-38582: Corrected version check - last_software_update was added in xapi 22.20.0 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-21 13:08:59 +01:00
Konstantina Chremmou
15b05ae572 Fixed issue on the Import XVA wizard where the SR selection was not taking account of... 
all scenarios of changed affinity if the user moved from the SR selection
page back to the server selection page and forwards again.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-21 10:49:06 +01:00
Konstantina Chremmou
7e11806790 CP-38582: Use more detailed format for the build and the last updated datetime. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-21 10:49:06 +01:00
Konstantina Chremmou
6898148466
Merge pull request #3021 from kc284/remove-updates-tab 
CP-39817: Removed updates tab page.
 2022-06-21 10:48:46 +01:00
Konstantina Chremmou
eb73a9f106 Show the DownloadUpdatesXmlAction only when it is run by the user or it has failed. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-20 15:27:22 +01:00
Konstantina Chremmou
9c61f64ec5 Show the status of the DownloadUpdatesXmlAction on the Events tab (previously it was shown on the Updates tab). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:47:54 +01:00
Konstantina Chremmou
b79eda2d4b Removed unused code around restoring dismissed updates. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:21:43 +01:00
Konstantina Chremmou
fc925ba047 Removed unused CfuAvailabilityCheck class. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:21:43 +01:00
Konstantina Chremmou
414eff9c2f CP-39817: Removed the option to check for server new versions since it is not relevant any longer. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:21:42 +01:00
Konstantina Chremmou
7deb50ee79 CP-39817: Added CFU button to replace the functionality of the Refresh button Remove updates tab page. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:21:42 +01:00
Konstantina Chremmou
bde23b23bf Fixed some code smells. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:21:42 +01:00
Konstantina Chremmou
e5d090d614 CP-39817: Removed the updates tab page. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-16 11:21:42 +01:00
Danilo Del Busso
2798315b46
Merge pull request #3017 from danilo-delbusso/task/last-updated_CP-38583 
CP-38582: Show `Last updated` field in General `TabPage`
 2022-06-15 13:32:36 +01:00
Konstantina Chremmou
8beae03d35 CP-38583: suggested modifications. (And a couple of code smells). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-15 13:05:11 +01:00
CitrixChris
ffa7f28c12
Merge pull request #3019 from xenserver/feature/REQ-622 
REQ-622: Citrix Hypervisor Center quick-update mechanism
 2022-06-13 14:57:15 +01:00
Konstantina Chremmou
fd627e687f CP-39933: Show the names of the PV guests preventing upgrade if any are detected. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-06-08 14:01:04 +01:00
Danilo Del Busso
6d6b0ce5fc
CP-38582: Show Last updated field in General TabPage 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-05-30 09:36:39 +01:00
Konstantina Chremmou
2889b1678d Corrections as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-25 11:36:08 +01:00
Konstantina Chremmou
df35684586 Moved version checking methods to a separate file. Use C# naming conventions. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Commands/DragDropCrossPoolMoveHaltedVMCommand.cs
#	XenAdmin/Commands/DragDropMigrateVMCommand.cs
#	XenAdmin/Wizards/CrossPoolMigrateWizard/Filters/CrossPoolMigrateCanMigrateFilter.cs
 2022-05-25 11:35:47 +01:00
Konstantina Chremmou
2f30ef1e19 CP-38687: Improved the speed of deleting multiple alerts. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-25 11:29:25 +01:00
Konstantina Chremmou
afa21f16a9
Merge pull request #3011 from kc284/CA-366140 
CA-366140: Reverted original solution. Handled error thrown when retrieving datasources.
 2022-05-25 11:04:51 +01:00
Konstantina Chremmou
76738ad91f
Merge pull request #3003 from kc284/drag-drop-3 
CA-294370: Rewrote logic calculating if migration is allowed + some other fixes.
 2022-05-25 11:04:26 +01:00
Konstantina Chremmou
755cec2bc1
Merge pull request #2998 from danilo-delbusso/bug/scrollbar_CA-293683 
CA-293683: Prevent automatic scrolling in RPU wizard if user has scrolled manually
 2022-05-25 11:04:03 +01:00
Konstantina Chremmou
dcbbbe84e9 CA-366140: Handle and log exceptions thrown when retrieving data sources. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-19 12:12:46 +01:00
Konstantina Chremmou
20cf55c19f Revert "CA-366140: Run data source operations on VMs only if they are allowed." 
This reverts commit dd56f744e8.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Actions/GUIActions/SaveDataSourceStateAction.cs
 2022-05-19 11:18:52 +01:00
Konstantina Chremmou
74bf6f3ba5 CP-36392: Fixes to sonarqube score. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-19 11:09:46 +01:00
Konstantina Chremmou
4f7ad4f0f0 Fixed broken build and made some additional L10n corrections to the layout. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-19 11:09:39 +01:00
Konstantina Chremmou
0cfe9c0a07 Corrections as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-18 10:54:44 +01:00
kishore Mengani
6b69496a39 L10n: Resx resync and trnslations updates 
Signed-off-by: kishore Mengani <kishore.mengani@citrix.com>
 2022-05-17 10:51:10 +01:00
Danilo Del Busso
4f09efe475
CA-293683: Prevent automatic scrolling when setting text in SmartScrollTextBox 
Also fix issue whereby `IsVerticalScrollBarAtBottom` would also return `True`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-05-16 15:33:52 +01:00
Konstantina Chremmou
8af0184030 Replaced dismiss button with release notes button. Show the application name in the update button. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-16 14:08:02 +01:00
Danilo Del Busso
6b200bef8b
Reorder fields in AutomatedUpdatesBasePage.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-05-12 13:36:13 +01:00
Danilo Del Busso
f2a67243a7
Apply code cleanup to AutomatedUpdatesBasePage.cs 
Use `var` where possible
Rename fields and methods following conventions
Use pattern matching when casting
Rename variables using more meaningful names

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-05-12 13:34:58 +01:00
Danilo Del Busso
27382f308b
CA-293683: Prevent automatic scrolling in RPU wizard if user has scrolled manually 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-05-12 13:06:04 +01:00
CitrixChris
1d003da4c7
CP-39720: Enable auth tokens (#3002) 
* CP-39720 adds a auth token to updates.xml download and chc.msi download if it exists in the registry keys

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 adds definition of GetInternalStageAuthToken() to XenServerHealthCheckConfigProvider.cs

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 updates token name to be more consistent

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 updates token name in missed request

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CP-39720 reads token name from registry

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-05-10 12:22:28 +01:00
Konstantina Chremmou
eca6f1d2a4 CA-294370: Rewrote logic calculating if migration is allowed: 
Objective was to increase efficiency and better report the reason why migration
is not allowed. For this, WlbEnabledFilter and ResidentHostIsSameAsSelection
filters were merged into the CrossPoolMigrateFilter, and properties
FailureFound and Reason of the ReasoningFilter class were merged into method
FailureFound(out failureReason).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:37 +01:00
Konstantina Chremmou
b7ce6e7fb2 Removed unused code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:36 +01:00
Konstantina Chremmou
a8bb8a7baa The Reasoning filters should look for failures on the item passed in their constructor: 
This is ensured when abstract class FailureFoundFor(IXenObject) is protected.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:36 +01:00
Konstantina Chremmou
8699f8803f Prevent multiple evaluations of CanRun(). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:36 +01:00
Konstantina Chremmou
c5d96a77cf Do not allow drag-and-drop of a VM onto a host that is not live. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 15:21:36 +01:00
Konstantina Chremmou
d0fdc5360b
Merge pull request #2980 from danilo-delbusso/bug/rdp-gray_CA-322672 
CA-322672: Do not stop polling for RDP capabilities on VMs
 2022-05-09 15:15:39 +01:00
Konstantina Chremmou
938de8dcb7 CA-311156: Select the home node prior to starting restoring sessions. 
Because if these are protected by a master password, the application shows
all tabs it constructed with while the password dialog is open.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:38:25 +01:00
Konstantina Chremmou
b172cd0785 Removed private field ToolbarsEnabled: 
It's not worth increasing the complexity of the already complex main form
in order to avoid repeating the setting's name.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:38:25 +01:00
Konstantina Chremmou
404ee1680a Tidy up. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:37:54 +01:00
Konstantina Chremmou
ae7df535c2 Some layout and logic changes so the page looks and behaves more like the other wizard pages with progress bars. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:37:54 +01:00
Konstantina Chremmou
9b7d502e74 CA-329538: Tell the user to ensure tools are installed if a VM cannot be migrated via drag-and-drop. 
Also, show the name of the VM in the various failure messages as drag-and-drop
may operate on multiple VMs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:37:16 +01:00
Konstantina Chremmou
6f3895ff10 Minor refactoring: 
Use C# naming conventions; merged nested if blocks; use pattern matching.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:36:49 +01:00
Konstantina Chremmou
dd56f744e8 CA-366140: Run data source operations on VMs only if they are allowed. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-05-09 13:36:49 +01:00
Konstantina Chremmou
429341cdca
Merge pull request #2992 from kc284/console 
Port PR#2941 to master
 2022-04-25 17:06:35 +01:00
Konstantina Chremmou
1928cf3db7 CA-366139: Specify which VM lacking the feature could not be migrated during RPU. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-25 17:06:01 +01:00
Konstantina Chremmou
188cfdda22 CP-39571: Removed spaces from the name of the log files. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-22 14:32:14 +01:00
Konstantina Chremmou
efb855a6e9 Modifications around VncView disposal: 
- Do not dispose of the activeView when pausing the console (which happens
  when we move away from the console tab.
- When setting a new source, remove and re-add the activeView only when
  it has changed.
- Dispose an unneeded view immediately instead of starting a timer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:18 +01:00
Konstantina Chremmou
5453c0c2ca Corrected toggling console paused state when selecting/deselecting the console tabs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:18 +01:00
Konstantina Chremmou
456cd93db8 A VncView is created for both VNC and RDP, so I don't see why it should be disposed of for VNC only. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:18 +01:00
Konstantina Chremmou
0c1541985c Check for docking should happen outside the VncView's Pause() method. 
Also, use Pascal case for property name to match C# conventions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:18 +01:00
Konstantina Chremmou
3601ada1f6 Reduced the public interface of the console panel. 
Methods exposing internal functionality like the timers should not be public.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:17 +01:00
Konstantina Chremmou
4d7457c331 The console panel is not meant to come in focus when the user navigates on the treeview. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:17 +01:00
Konstantina Chremmou
63c170310d Use Pascal case for method names to match C# conventions. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-21 11:28:17 +01:00
Danilo Del Busso
d17b99e6b0
CA-322672: Improve comments around RDP status checks 
`data/ts` indicates the VM has RDP enabled

`feature-ts2` is the feature flag indicating that `data/ts` is valid.

`feature-ts` is the feature flag indicating the toolstack can enable RDP remotely (by writing to `control/ts`)

the `network` object contains the IP info written by the `xenvif` driver (which needs a 1st reboot to swap out the emulated network adapter)

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-04-20 12:39:47 +01:00
Konstantina Chremmou
59486541a5
Merge pull request #2985 from kc284/sonarqube 
CP-36392: Improvement of sonarqube score
 2022-04-20 10:25:23 +01:00
Konstantina Chremmou
889ef5adce Renamed fields. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-14 11:45:21 +01:00
Danilo Del Busso
d90abfd1b6
[CHC] CA-366069 & XSI-1222: Fix incorrect capitalisation of value in Japanese version + add some case insensitive checks (#2986) 
* CA-366069: Fix incorrect capitalization of value in Japanese invisible messages `resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add case insensitive checks on code around usage of `ISO_UPDATE`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove changes in string capitalisation

Move capitalisation invariance to checks only

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove `ISO_UPDATE` from `InvisibleMessages.resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add remaining `ToLowerInvariant()` calls

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-04-14 11:36:55 +01:00
Konstantina Chremmou
3858320cc4
CA-366115 & CA-366116: Quick Update Feature - FQP Bug fixes (#2988) 
* CA-366115: Release the installer when cancelling the installation because of pending tasks.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* CA-366116: Use always the same filename for the temporary downloaded installer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Allow to cancel while retrying to download the installer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-12 12:09:44 +01:00
Konstantina Chremmou
07f2de6786 Use C# naming conventions. Removed some code redundancies. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-12 10:32:57 +01:00
Konstantina Chremmou
9e8a8a77a5 Code style fixes. Removal of unused code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-11 22:57:08 +01:00
Konstantina Chremmou
558897740d Reworked instantiation of dummy actions that complete immediately. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-11 21:59:29 +01:00
Konstantina Chremmou
038de3ca62 Use consistent variable names. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-11 19:43:09 +01:00
CitrixChris
5b0b27eca1
CP-39382: Lock msi file while verifying and launching install process (#2973) 
* CP-39382 adds lock around msi file while being verified and launched. Improves naming of variables in line with conventions.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-39382 removes unnessessary usings, fixes background tasks running check. Tidies up structure.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* Further modifications.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* CP-39382 adds back in messages lost in merge conflict resolution

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-11 10:11:33 +01:00
Konstantina Chremmou
a35efa06aa CP-36392: Removed unnecessary statement: 
The body of the setter never proceeds before the first line because value==_state
and the child's level has just been increased and is zero or greater.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:35 +01:00
Konstantina Chremmou
04ac8249a6 CP-36392: Refactored to avoid having unused object instantiations of the ActionBase class. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:35 +01:00
Konstantina Chremmou
d2548ae4c0 CP-36392: Do not create an action for changing the master password. 
Generally we don't show events for saving applications options. Also,
renamed field and deleted comments that were not particularly enlightening.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:34 +01:00
Konstantina Chremmou
dce02a2562 Renamed AsyncAction.RunExternal to AsyncAction.RunSync so it is more descriptive. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:34 +01:00
Konstantina Chremmou
758a60f3f8 Converted interface HistoryItem to an abstract class. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:33 +01:00
Konstantina Chremmou
ec33caf4b5 CP-36392: Refactored so that GetHashCode() does not call the homonymous base class method. 
This required refactoring the OVF.AddVirtualSystem() method to accept the
system ID as a parameter. Also, removed some unused methods that were
calling OVF.AddVirtualSystem().

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:33 +01:00
Konstantina Chremmou
177c47f79f CP-36392: Refactored so that GetHashCode() does not reference mutable fields. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:33 +01:00
Konstantina Chremmou
b3bc93f1f6 CP-36392: Refactored so that GetHashCode() does not reference mutable fields. 
Also, removed some unused GridRow class members.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:33 +01:00
Konstantina Chremmou
c28bb4b34c CP-36392: Removed block that is never hit: 
The situation described in the comment is not applicable as scaling does
not change outside the UI thread, and OnResize() does call SetupScaling().

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:32 +01:00
Konstantina Chremmou
3c4808a689 Remove redundant code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-05 10:19:13 +01:00
Konstantina Chremmou
acc5ed0210 CP-38542: Remove option to disable live patching. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-01 16:17:22 +01:00
Konstantina Chremmou
aaee939453 Some corrections on the DRWizard prechecks page: 
- Re-arranged and re-worded controls so that this page looks more like
  the precheck page of the patching and RPU wizards.
- Do not show the failure message unless issues are found.
- Do no enable the Resolve All button unless all issues are fixable.
- Fixed crash when the required SR is present in the pool but detached.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-01 16:07:43 +01:00
Konstantina Chremmou
ef86be5347
Merge pull request #2978 from kc284/actions 
Compacted ParallelAction and MultipleAction constructors.
 2022-04-01 16:07:30 +01:00
Danilo Del Busso
7a3fe5ddee CA-334613: Clip region within which performance graph lines are drawn 
Sharp turns in the graph can result in the line being drawn outside of the box.
This change makes sure the line is only rendered within the input rectangle.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-04-01 15:41:04 +01:00
Konstantina Chremmou
5920691ea4 Merge branch 'master' into feature/REQ-622 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	Jenkinsfile
#	XenAdmin/Commands/DisconnectCommand.cs
#	XenAdmin/MainWindow.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
 2022-03-30 15:17:13 +01:00
Danilo Del Busso
05ba1ce8a0
CA-322672: Partly tidy up VNCTabView.cs 
Apply some naming and styling conventions. Specifically, remove useless usages of `this.`, use arrow syntax for RDP fields, and remove redundant bool field initialisation

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-03-29 15:46:31 +01:00
Danilo Del Busso
1d98a298f5
CA-322672: Partly tidy up XSVNCScreen.cs 
Apply some naming and styling conventions.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-03-29 15:41:06 +01:00
Danilo Del Busso
c5d2e36564
CA-322672: Do not stop polling for RDP capabilities on VMs 
These changes keep polling open console connections to check the status of RDP capabilities.
This is necessary when installing/uninstalling VM tools on VMs. Without this, changes in the `guest_metrics` aren't spotted. Consequently, the user is not shown the option to connect with RDP until they disconnect (or the console session is disconnected), even if the VM is capable.
That is because before this, the polling for RDP changes (as performed by `connectionPoller`) was only started if the VM had RDP capabilities when first connecting to it with the console.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-03-29 15:34:09 +01:00
CitrixChris
e951aa5268
Changes the confimation dialog to one that actually shows background … (#2959) 
* Changes the confimation dialog to one that actually shows background tasks

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Removes unused messages

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Seperates Download and Install Logic so background task checker only happens after msi is downloaded

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Allows download to be canceled

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Some corrections.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-28 15:25:32 +01:00
Konstantina Chremmou
81d5c508a1 Refactoring suggested by code review (largely naming conventions). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-28 13:43:24 +01:00
Konstantina Chremmou
a91dd6398d Compacted ParallelAction and MultipleAction constructors. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-21 13:50:27 +00:00
Konstantina Chremmou
f5672a8645 CP-39323: Check for DMC in use prior to cross-pool migration to pools where DMC is unavailable. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-21 13:10:51 +00:00
Konstantina Chremmou
dd978914cf CA-365297: Fixed error shown when attempting live migration of DMC VM to non-DMC host. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-21 13:10:51 +00:00
Konstantina Chremmou
220ab25302 CA-365317: Updated warnings after disallowing connection to pre-yangtze servers. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-21 13:10:25 +00:00
Konstantina Chremmou
ab676786b1 CP-39366: Disallow connection to servers earlier than yangtze. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-14 17:32:48 +00:00
Konstantina Chremmou
713bec52ce CA-365082: Do not run the PrepareToUpgradeCheck before the necessary RPU hotfix has been applied. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-14 17:32:29 +00:00
Konstantina Chremmou
545d85d433 CA-364273: Do not log out the current user if they cancel the operation from the elevated session dialog. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-14 17:31:31 +00:00
Konstantina Chremmou
00c5285411 CP-39142: Add RPU pre-check in CHCenter to warn of DMC removal. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-03 14:36:06 +00:00
Konstantina Chremmou
dec2eead15 Renamed methods so they describe better what they do. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-03 14:36:06 +00:00
Konstantina Chremmou
b2dc968ab1 CP-38895: Check version annotations when using API fields or methods. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-03 14:35:45 +00:00
Darren Matthews
151841ce5e L10N : Translation Updates & Resx sync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2022-03-03 14:35:30 +00:00
Danilo Del Busso
101d6f0a00 CP-36392: Use value in empty setters 
Mostly to remove warning from SonarQube, so exception is only thrown in DEBUG mode

Address code surrounding previously emptied setters
Avoids throwing exceptions when not needed
Move default `VerticalTabs` fields outside of constructor

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-02-24 11:53:44 +00:00
Danilo Del Busso
2c5373323c CP-36392: Inherit IDisposable to avoid confusion 
Classes didn't extend IDisposable
Also used null propagation to tidy up method body

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-02-24 11:53:44 +00:00
Danilo Del Busso
a310fa60cf CP-36392: Remove all unnecessary using s 
Ignores XenAPI

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-02-24 11:53:44 +00:00
Darren Matthews
c7c60849b3 L10N : Resx Sync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2022-02-24 11:53:31 +00:00
Konstantina Chremmou
d0944cf19c A new row should be added only when it is not found. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-23 12:38:02 +00:00
Konstantina Chremmou
ff76729940 Hide the client update button by default. Added null check. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-21 15:56:06 +00:00
Konstantina Chremmou
99452959c3 Further tweaks as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-17 12:52:30 +00:00
Konstantina Chremmou
b050adaeaa Some corrections and tidy up. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
0d9a204661 CP-31587 moves validate msi exception messages to messages.resx. Sets update client button to hidden on launch. 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
5845bab13f CP-31587 Implements reviewer's comments. 
Moves dialog strings to messages.resx. Corrects button colours, hides update client option to avoid highlighting when disabled. Revmoves unessessary comments.

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
d8b1d5737d CP-31587 added comfirmation dialog to manageupdates page 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
755411a970 CP-31587 implements confirmation check before updating client 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
75f9b402ec CP-31587 added a checksum check to download and install client action 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
c1c8c3d1c3 Adds updates check started/completed event handlers 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
0a0533a59f CP-31587 improved DownloadAnUpdateClientAction 
Made variables more accurate, removed unnessessary code

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
aa59e8f475 CP-31587 Created new download and install action that downloads the file from updates.xml url and stores in in temp folder with progress dialog 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Konstantina Chremmou
ca37331c8d CA-362709, CA-362711: Reworked the logic for allowing full disk copy when creating a VM from a snapshot or custom template. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-14 14:35:51 +00:00
Konstantina Chremmou
321389455e Refactoring: compacted Role.ValidRoleList() and Role.CanPerform() overloads. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-03 11:59:17 +00:00
Konstantina Chremmou
6aec4ea281 CP-38893: Make internal roles unavailable for selection. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-03 11:59:17 +00:00
Konstantina Chremmou
50dd22f4da CA-362868: POOL_CA_CERTIFICATE_* alerts are issued on the certificate and not on the pool. 
Also, moved the function retrieving the XenObject from the alert to the Message class extensions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-31 14:56:12 +00:00
Konstantina Chremmou
d6f91526d2 Restored friendly name and description for CVSM. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-31 14:56:12 +00:00
Konstantina Chremmou
1580a89594
Merge pull request #2931 from kc284/settings 
Minor refactoring; null check; tidy up
 2022-01-27 13:34:20 +00:00
Konstantina Chremmou
bae03aff8b Fixed issue where the settings from previous installations were not imported. Added more documentation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-24 19:55:38 +00:00
Konstantina Chremmou
b4afd3ce4c CA-261979: Use utf-8 encoding for logging (or on localised systems the log files may contain illegible characters). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-24 15:22:28 +00:00
Danilo Del Busso
f07b3d4e05 CP-37850: Update RPU005 to version 4.0 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-24 15:22:07 +00:00
Konstantina Chremmou
ba8cf7f782
Merge pull request #2934 from xenserver/feature/CP-38483 
CP-38483: Unbundle putty from  Citrix Hypervisor Center
 2022-01-24 15:21:32 +00:00
Konstantina Chremmou
f29e267670 Some corrections and refactoring on the external console feature. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
c9bb9c1f0c CA-362353: Add file existence check when launching SSH console 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
66d1c6624b CA-362355: Remove SSH console location check if paths haven't changed 
Avoids users not being able to save other options if the selected SSH console location isn't valid

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
322edd3536 CA-362352: Save SSH Console settings changes on startup 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
34876461fc CA-362354: Account for non-exe files when saving SSH client path 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Konstantina Chremmou
2c18b7c7ed Tidy up: moved method to Settings and renamed it. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-13 11:04:13 +00:00
Konstantina Chremmou
8086359d2d Minor refactoring. Show more logging. Null check. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-13 11:01:59 +00:00
Danilo Del Busso
9ebcdaabd7 CP-38530: Remove reference to PuTTY in LegalNoticesDialog 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-07 10:04:43 +00:00
Danilo Del Busso
6a52322035 CP-38530: Remove PuTTY from build scripts and wix installer 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-07 10:04:43 +00:00