Commit Graph

5903 Commits

Author SHA1 Message Date
Konstantina Chremmou
94024f99a9 CA-347481: Clean up the disks of the destroyed VM if import is interrupted due to cancellation or failure.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-03 14:55:38 +00:00
Konstantina Chremmou
9c26617ad7 CP-35343: Fixed broken build.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-01 12:08:12 +00:00
Konstantina Chremmou
2469c947c9 Increased precision in displaying progress of transferred disk data.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-01 12:07:13 +00:00
Konstantina Chremmou
719d6b5e45 CA-347487: Fixed error formatting.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-01 12:07:13 +00:00
Konstantina Chremmou
07ae413e15 CA-349194: Prevent crash when initialising a disk image import.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-01 11:03:49 +00:00
Konstantina Chremmou
d7512d14c7 CA-347479: Added more cancellation points.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-01 11:03:49 +00:00
Konstantina Chremmou
4f564979e1 CA-345349: Verify the exported disk using DiscUtils and fail the whole export if one disk export failure occurs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-13 14:34:15 +01:00
Konstantina Chremmou
d23c40c543 CA-324350: When the OVF files are compressed, create manifest and signature on the final package after the compression.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-13 14:34:15 +01:00
Konstantina Chremmou
f24a81bd28 CA-89896: Enabled cancellation during OVA packaging/extraction and file compression/decompression.
Also removed some more unused methods.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-13 14:34:15 +01:00
Konstantina Chremmou
38c88b5692 CA-64500: Offer the option to start the vApp or VM automatically after an OVF/OVA import.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-13 14:34:15 +01:00
Konstantina Chremmou
88d3e66505 Hide the error at construction to prevent flickering when the page is loaded. Property modernisation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-13 14:34:15 +01:00
Konstantina Chremmou
54e8347a5c CP-34826: Upgraded DiscUtils to version 0.11.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-13 14:34:15 +01:00
Konstantina Chremmou
6f44821e40 Import refactoring 4: Simplifications and corrections, including:
- Improvements to progress reporting (CA-65894).
- Added some logging.
- Use the connection cache instead of making server calls.
- Moved some methods to the string utilities and added unit tests.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
42b06251bc Export refactoring 4: Some improvements to progress reporting (CA-65894). Added some logging.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
23892df15d Moved the OVF actions to XenModel and removed what was left from XenOvfTransport.
Previously this was not possible due to XenModel-XenOvfTransport cyclical references.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
317f66758d Removed Settings file. It is not meant for storing constants and most entries were obsolete anyway.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
4e95b25572 Removed XenOvfTransportEvent.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
74aa727f15 Import refactoring 3: Made class Import static.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
1e5877eff7 Import refactoring 2: We don't download files while importing them, but earlier while setting up the import.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
0cd2d253f3 Import refactoring 1: Simplified confusing calculations. Also:
Speed up operation by setting the appliance, start-up properties and vendor device
in the record from which the VM is created instead of making server calls after
its creation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
d22af4cd83 Export refactoring 3: Use the connection cache instead of making server calls. Also:
- Avoid multiple exception catching and rethrowing.
- Corrected VirtualSystemType identification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
31c4b86395 Export refactoring 2: Made XenOvfTransport.Export static.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
7e709f9dbb Export refactoring 1: Merged methods _copydisk and _export for efficiency in adding a disk section to the OVF.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
18c407d992 Removed controls for Transfer VM configuration.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
6e2c45bcd5 CP-34221: Basic implementation of export/import using the API's http actions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
bf9f5b1308 Ensure all the CommandLib classes are defined in this namespace so as to avoid conflicts with homonymous classes from other namespaces.
- Automatic indentation fix as a consequence.
- Use proper xml doc for the various methods and classes.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
cd0135c7ff Removed unused code for .wim (not supported) and .xva (we use a different mechanism).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
e3d6db3a80 Removed support for long retired XVA v1 packages.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
c4754c0251 Removed exception that was never thrown (referring to obsolete licensing restriction).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-09-08 10:34:08 +01:00
Konstantina Chremmou
2bb1cd5c5c CA-343781: Fixed error visibility when the check for updates fails. Corrected error image size.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-09-08 10:34:08 +01:00
Konstantina Chremmou
cdd650d40e Fixed 3rd party library references in the solution project files.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-09-08 10:34:08 +01:00
Darren Matthews
c75ab40ef8 L10N : Translation Updates and Resx Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-09-01 14:26:40 +01:00
Konstantina Chremmou
822394597f Corrected button text. Fixed duplicate hotkey in the host right click menu.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-08-24 16:49:23 +01:00
Konstantina Chremmou
e3896239df CA-339305: XenCenter was hanging when update alerts were removed very fast, and other issues:
- Use a plain list to store update alerts and, where possible, fire a collection
  change event only after a bulk change and not every time a single object is added
  or removed.
- Fixed issue where dismissed updates were stored in the config of all connected
  pools, even of those where the update did not apply.
- Corrected RBAC checks for update dismissal.
- Fixed enabled state of dismiss buttons.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-08-21 16:08:20 +01:00
Konstantina Chremmou
f05b512ca4 Tidy up event registration and deregistration on the MainWindow.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-08-21 16:08:20 +01:00
Konstantina Chremmou
56fdf0402e CA-342572, CA-342031: Bumped version of 3rd party libraries.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-08-21 09:11:35 +01:00
Konstantina Chremmou
ea146cd242 CP-34160: Bumped branding.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-08-21 09:11:35 +01:00
Konstantina Chremmou
f0c20ae86b CA-343459: Update automatically the upgrade method depending on the specified url prefix.
Also, remove the upgrade methods from the resource files since they are not meant
to be translated.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-08-21 09:11:10 +01:00
Konstantina Chremmou
6a412d4a10
Merge pull request #2719 from kc284/feature/REQ-819
Resolve conflicts and merge feature/REQ-819 into master
2020-08-19 09:02:14 +01:00
Konstantina Chremmou
2e66ec9133 Merge remote-tracking branch 'upstream/master' into feature/REQ-819
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/OptionsPages/SecurityOptionsPage.cs
2020-08-11 13:35:39 +01:00
Konstantina Chremmou
c244d8d4db CA-339584: Include CD VDI in the storage mapping for intra-pool migration
Also: removed unused method; some property modernisation; removed class
LiveMigrateOptionsVmMapping which was rather complicating things.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-08-11 08:46:42 +01:00
Konstantina Chremmou
e0864cd99c CA-342526: Ensure the update list has been populated and the specified update has been selected before stepping into the next page.
Also, reduced visibility of the methods moving between wizard pages to avoid
creating complex situations.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-31 10:54:49 +01:00
Konstantina Chremmou
a076cc59a2
Dialog deletion (#2701)
* Replaced LicenseWarningDialog with a simple WarningDialog.
* Replaced VcpuWarningDialog with a simple WarningDialog.
* Replaced RemoveCrashdumpsWarningDialog with a simple WarningDialog.
* Replaced UsbUsageDialog with a simple WarningDialog.
* Replaced WlbDeleteReportSubscriptionDialog with a simple WarningDialog. Added null checks to event invocation.
* Replaced DisableWlbDialog with a simple Warning dialog.
* Replaced ConnectionRefusedDialog with a simple Error dialog.
* Replaced UserDeviceDialog with a simple Warning dialog.
* Replaced RevertDialog with a simple Warning dialog.
* Removed unused dialogs.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 11:29:01 +01:00
Konstantina Chremmou
a66a82878e The ConnectionOptionsPage should not access private controls of its parent but rather communicate its valid state via an event.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 11:27:29 +01:00
Konstantina Chremmou
ca3e9c0219 Removed unused SaveSessionCommand and consequently refactored SaveAndRestoreDialog constructor.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 11:27:29 +01:00
Konstantina Chremmou
65ea154b9d Moved the code that logs settings to the Settings static class.
Although it may look tidy to log the settings in the OptionsDialogPages that
expose them to the user, in reality it makes for unnecessarily complicated code
design as it places business logic in UI code and mixes the class dependencies.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 11:27:29 +01:00
Konstantina Chremmou
82bb06dba3 Unit tests for filtering VMs by virtualisation state.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 10:42:20 +01:00
Konstantina Chremmou
8fb44a55cb Added flag VM.VirtualisationStatus.NOT_INSTALLED to replace value 0 for clarity.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 10:42:20 +01:00
Konstantina Chremmou
2755f71dcf CA-341423: Added a new filter value for VMs with only the management agent installed so they can be easier to find.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 10:42:20 +01:00
Konstantina Chremmou
e30ea433c7 Refactoring to simplify the code and make calculations more efficient:
Removed unnecessary abstractions. Replaced named delegates with anonymous ones.
Use pattern matching and avoid multiple casts. Be consistent in the properties
we check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 10:42:20 +01:00