Commit Graph

108 Commits

Author SHA1 Message Date
Gabor Apati-Nagy
d50f8a7d94 Merge branch 'master' into master_github
Conflicts:
	XenModel/Messages.resx
	XenModel/XenAPI-Extensions/Host.cs
	mk/xenadmin-build.sh
2015-01-19 15:22:59 +00:00
Mihaela Stoica
13c6d323c3 CA-147163: Non-modal hotfix upload progress dialog
- Added new page to the patching wizard, called "Upload" which displays the upload actions for each server and the progress of these actions
- MultipleAction: added the functionality to optionally stop the action on first failure
- Fixed the error where an existing patch downloaded from another server and then uploaded to a new one was not deleted on cancelling the wizard [CA-156788]

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-01-09 12:54:12 +00:00
Mihaela Stoica
a109726218 CA-153178: Add context menu for Docker containers in the XC treeview and start, stop, pause and resume commands 2014-12-05 10:28:55 +00:00
Gabor Apati-Nagy
afbbf25325 CA-153179: Add options for customizing the config drive to the XC VM creation wizard
Todo: tidy up code & code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-12-04 18:04:43 +00:00
Mihaela Stoica
65b4ef1f37 CA-152052: Fix the issue where the License Manager showed the wrong state when assigning/releasing license from pool
The problem was that the License Manager was listening to PropertyChanged events on the master only, not on slaves.
When the master's properties change (e.g. edition) we update the row in the license manager; but in some cases a slave (or more) hasn't been updated yet (as it may be updated in another event.from) and we think that the pool is partially updated.
Our solution is to listen to Host BatchCollectionChanged event, which is triggered once per cache update for the host collection (it any property changed for any of the hosts).
The sleep in the ApplyLicenseEditionAction is not needed anymore, nor is the extra call to update the cell after the action is completed, because the cell is getting updated correctly on the BatchCollectionChanged event.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-11-24 16:57:42 +00:00
Mihaela Stoica
b5d14120de CA-149811: End the connection to each slave after that host has joined the pool to prevent XenCenter showing connection lost alerts
This fixes the following issue: event.from fails with "The underlying connection was closed: A connection that was expected to be kept alive was closed by the server.".
It happens because we end the connections to the slave hosts only after all hosts have joined the pool and in the meantime event.from on a slave fails.

We fix this by ending the connection to each host immediately after the host has joined the pool.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-10-28 09:36:05 +00:00
Gabor Apati-Nagy
f48f7c8f11 CP-9784: Recognise LICENSE_SERVER_VERSION_OBSOLETE alert in XenCenter 2014-10-02 16:04:05 +01:00
Stephen Turner
107e00e5fb CA-145254 Incorrect error message when try to create CIFS SR with invalid credentials 2014-09-05 16:23:22 +01:00
Mihaela Stoica
64970a7d13 CA-107598: Fixed the issue where XenCenter hides the "Licensing Error" popup when running in RDC
The reason for the error dialog appearing behind License Manager dialog was that we used MainWindow as parent of the Licensing Error dialog (in ShowLicensingFailureDialog method in ApplyLicenseEditionCommand)
and there were already 3 other modal dialogs displayed one on top of each other: License Manager, Apply License and Action Progress.
 Fixed by calling the ShowLicensingFailureDialog from the command, on action.Completed event (instead of action.Run) and passing the Parent as a parameter, so that we can use the correct parent when displaying the error dialog.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-08-14 14:40:24 +01:00
Mihaela Stoica
07e946b1f6 CA-142249: Prevent an ArgumentOutOfRangeException in ActionProgressDialog by ignoring negative values in the action's PercentComplete property.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-08-12 09:46:45 +01:00
Stephen Turner
577363a3a1 CA-141389 Log all GET and POST calls 2014-08-07 16:23:06 +01:00
Stephen Turner
399d00991b CA-139913 Convert tests of AugustaOrGreater to CreedenceOrGreater where the feature is in Creedence 2014-08-05 17:16:50 +01:00
Mihaela Stoica
cb7dcc81f4 CA-136173: Getting several notifications for one user-level action (e.g. Updating network operation creates 4 entries in the Notifications/Events view)
- Set the pool details in the action to allow proper filtering by location on the Events page
- Also, when possible, set the Host property: when setting the SR in the action, we also set the Host to SR.Home

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-21 11:40:26 +01:00
Mihaela Stoica
b544924559 CA-136173: Getting several notifications for one user-level action (e.g. Updating network operation creates 4 entries in the Notifications/Events view)
- Multiple action: propagate error messages back up the action tree to the parent action.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-21 11:24:33 +01:00
Mihaela Stoica
3c051654d6 CA-136173: Getting several notifications for one user-level action (e.g. Updating network operation creates 4 entries in the Notifications/Events view)
-  Suppress reporting of success and failure for sub-actions:
The suppress history flag is set when the action is created and if is false (by default) the action is added to the history (the Events list).
In order to suppress history for the subactions, we need change all actions used in Edit pages so their constructor can set the SuppressHistory flag and then use these constructors with suppressHistory = true on all the implementations of IEditPage.SaveSettings() where an action is created
(then we need to remember to do the same everytime we introduce a new page and / or "save" action).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-21 11:19:04 +01:00
Mihaela Stoica
d69df44cf1 CA-137305: When creating a VM, ensure that the vGPUs are unset if not needed.
If a VM is created from snapshot which has a vGPU and "No" vGPU is selected  then the newly created VM shouldn't have a vGPU.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-30 09:44:19 +01:00
Mihaela Stoica
1ff55016c8 CP-8547: Add button in XenCenter to initiate space reclamation on an SR: Changes following code review.
- Added check for null for sm.features in SR.SupportsTrim;
- Better error messages;
- Moved error messages from Messages to FriendlyNames;
- Removed the check for actions in progress from TrimSRCommand.CanExecute().

-

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-24 14:48:31 +01:00
Mihaela Stoica
1f217b9983 CP-8547: Add button in XenCenter to initiate space reclamation on an SR.
The operation applies to an SR. The button is on the Storage tab of the host/pool, and is entitled "Reclaim freed space".
It comes between the New SR and Properties buttons.
If the SR does not support TRIM , the button is invisible and the Properties button moves left to close up the gap.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-24 11:32:36 +01:00
Mihaela Stoica
8f1eb99e76 CP-8120 Set cores per socket through XenCenter: Added 'Topology' field to the New VM Wizard.
- Text on CPU page - changed to include topology.
- Summary page on the New VM Wizard – changed to include topology

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-05 13:03:06 +01:00
Gabor Apati-Nagy
728efca6e2 Merge pull request #71 from cheng--zhang/CA-135563
CA-135563:WLB tab show error message after disconnect WLB by Read-Only user
2014-05-16 14:41:19 +01:00
Cheng Zhang
bfdac9c295 CA-135563:WLB tab show error message after disable WLB using Read Only user
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2014-05-16 14:14:27 +08:00
Stephen Turner
f64d021059 CA-135078 Rename "Delete Pool"
Renamed "Delete Pool" to "Make into standlone server"
Made sure it can never work with a multi-server pool
Removed confirmation dialog, as it is not destructive
Removed from context menu, as it is not important/common enough
2014-05-15 18:47:13 +01:00
Gabor Apati-Nagy
73fccdab61 CA-115429: New fix as per code review: Deletion of snapshot is successful but XenCenter logs show error. 2014-05-15 14:18:28 +01:00
Gabor Apati-Nagy
f511403e87 CA-115429: Removed code, because it does not needed for supported XS versions
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-05-14 16:04:56 +01:00
Gabor Apati-Nagy
4ee0642a54 CA-115429: Fixed: Deletion of snapshot is successful but XenCenter logs show error.
XAPI (from 1.7) destroy destroys suspend VDIs as well (code is here: xapi: ocaml/xapi/cli_operations.ml). Depending on actual race conditions, this can lead to a situation when we try to destroy a Suspend VDI that has just been deleted.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-05-14 14:41:07 +01:00
Mihaela Stoica
6a6be458fd CA-110209: Install Update Wizard: If the patch is already uploaded, then we use it and ignore the "already exists" error. 2014-04-30 13:31:39 +01:00
Konstantina Chremmou
f1ebc3b5eb CA-130615: Do not show an event notification when the connection fails due to being
existing or due to the host being a slave. Use the action description instead of
the action title to construct the error for failed connection results. Indentation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-04-28 15:01:11 +01:00
Konstantina Chremmou
f0cf20ec43 CA-127510: Reworked the logic of differentiating between tasks started by this instance
of XenCenter and tasks started from outside and cancelling the former when exiting
or disconnecting from the pool.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-03-11 14:30:01 +00:00
Mihaela Stoica
5e5a8d7cb2 CP-7686: Make check-for-updates work in the presence of service packs by using the new fields from updates.xml, requiredpatches and conflictingpatches.
Changed the way the dependency patches are fetched, to avoid getting an exception if
requiredpatches/conflictingpatches node has at least one child that has no uuid attribute,
also checking the child name

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-03-05 10:29:59 +00:00
Mihaela Stoica
2ca98a7638 CP-7686: Make check-for-updates work in the presence of service packs by using the new fields from updates.xml, requiredpatches and conflictingpatches.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-02-17 09:31:57 +00:00
Konstantina Chremmou
f8117cd4f5 CA-114482: Changed workflow of retrieving updates: the list of published updates
is downloaded and stored every time an update is performed (if manual all updates
are downloaded, if automatic only as per the user's choices). If there are available
updates, update alerts are generated if there are connected hosts and disappear
when the hosts are disconnected.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-08 13:17:02 +00:00
Konstantina Chremmou
22ec1d9ac5 CP-6093: Redesign of the CloseXenCenterWarningDialog to use the same controls as
the events page. This renders the old custom history controls obsolete, hence
removed them. Moved ActionBase extension methods to XenAdmin.Core namespace.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-23 11:59:49 +00:00
Konstantina Chremmou
361b49066c CP-6093: Anyone outside the Alert class should not know anything about the lock
used to access the alerts list. The list itself should be private as there is a
risk to access it and forgetting to use the lock.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-21 12:32:27 +00:00
Konstantina Chremmou
da5408bf21 Missing license headers.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-14 12:59:08 +00:00
Konstantina Chremmou
c843f5b867 CP-6511: Ovf import/export for vGPU enabled VMs.
# HG changeset patch
# User Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
# Date 1384181202 0
#      Mon Nov 11 14:46:42 2013 +0000
# Node ID 6810ba763a896bcf7dd4295f30c6d5f42b02e9de
# Parent  37666849a54470e0da04b8d14c17940f8b580636

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-14 12:29:30 +00:00
Konstantina Chremmou
f7d59a8c24 [CP-6383]: Configuration of vGPU types for pGPUs
# HG changeset patch
# User Gabor Apati-Nagy <Gabor.Apati-Nagy@citrix.com>
# Date 1382623622 -3600
#      Thu Oct 24 15:07:02 2013 +0100
# Node ID 9b2305266f104c3ae9ec32804a92b3596d0aa399
# Parent  66330c7be272cd62a342e20ff109eea6b4d846f8

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-14 11:11:24 +00:00
Konstantina Chremmou
402e2458ce CP-6382: Added GPU page to the Pool properties dialog (PR-1675)
# HG changeset patch
# User Mihaela Stoica <Mihaela.Stoica@citrix.com>
# Date 1381486465 -3600
#      Fri Oct 11 11:14:25 2013 +0100
# Node ID ae162fb56bac4f1c2f7cc4c47b640a6933ea6deb
# Parent  48644db7dcf80d93efb9d6e86e982b95894cbd9d

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-14 10:35:48 +00:00
Gabor Apati-Nagy
19409f8e20 [CA-112327] Fixed Bug in BatchingMigrateVirtualDiskManager class 2013-11-04 12:35:12 +00:00
Mihaela Stoica
29a8ba30f4 CA-113396: Destoy password secrets used in SR creation after the creation is complete.
When creating an SR, if XenCenter creates new secrets, then they should be destroyed
after the SR creation is complete. This is safe since any secrets in the device-config
are duplicated and unique ones are used for each PBD creation.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-10-17 12:36:10 +01:00
Konstantina Chremmou
a879e50df1 CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User Stephen Turner <stephen.turner@citrix.com>
# Date 1378992269 -3600
# Node ID 5b5548029247d300baddfac9f2aac881ed6cc086
# Parent  28eb1719f7f648773bd707c3cb81bb537d8f78d8
CA-114912: Unlocalised strings

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 15:01:14 +01:00
Konstantina Chremmou
548944486f CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User Stephen Turner <stephen.turner@citrix.com>
# Date 1377867999 -3600
# Node ID 931d568b9b0f00809b9acbe31462423dfaf8a8d4
# Parent  5de50259a5796a999290798fb61086338db1e847
Fix [CA-114381]: Hard-coded strings

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 14:45:26 +01:00
Konstantina Chremmou
b3d2cecf89 CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
# Date 1376915592 -3600
# Node ID 4ccecd98746c40c5b1850f28c3e557e803102939
# Parent  cc14bc84973e1dd7e07ee6d90a2bac2cdd7baf79
[CA-112396], [CA-112304], [CA-112241]: Increased the width of the middle column
of the ActionProgressDialog TableLayoutPanel by 40px to reduce occurrance of text
wrapping. Ellipsized pool name in the GetHeartbeatSRsAction.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 14:23:49 +01:00
Konstantina Chremmou
ed88db2df0 Fixed two potential null reference exceptions in the XenOvfTransport project and
removed uninitialised streams which we were taking care to close. Solution-wide
style: use string.IsNullOrEmpty method instead of checking separately for null
and zero length.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 08:30:34 +01:00
Konstantina Chremmou
89fa1950a4 CP-6083: Updated test. Prevent potential NullReferenceException.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-20 14:33:23 +01:00
Konstantina Chremmou
8ae4eaa060 CP-6084: Added vGPUs to New VM Wizard.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-20 11:24:46 +01:00
Konstantina Chremmou
cab8dca36b CP-6083: Added vGPUs to the VM's property page.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-18 13:06:47 +01:00
Konstantina Chremmou
67d15dcca5 CP-5750: Moved capping of event numbers to a more relevant place and corrected logic
to remove the oldest items first and fire an event when doing so.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-13 10:52:15 +01:00
Konstantina Chremmou
62586ef89c CP-5750: Removed ActionType; the actions should be categorised by status (in progress,
succeeded, failed; cancelled at the moment counts as failed, we may need to distinguish
in future). As a consequence the filter checkboxes from the top of the Log tab
were removed and some temporary changes were made to the drawing of action rows
(the controls will change completely in a subsequent commit).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:38 +01:00
Konstantina Chremmou
38ab6b8ffa CP-5750: When a License warning is generated, create an alert rather than an Action.
Removed ActionType.Alert. Removed Alerts checkbox from the Log tab.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:36 +01:00
Konstantina Chremmou
077cb17deb CP-5750: Changed the declaration for the ActionBase events Completed, Changed and
NewAction to use the Action<ActionBase> delegate instead of EventHandler. Thus
there is no need to fire them with Empty or null EventArgs and on several occasions
we avoid casting objects in the event handlers.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:33 +01:00
Konstantina Chremmou
eb1dd68a28 CP-5750: Code tidy. Comment improvement.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:31 +01:00
Konstantina Chremmou
db1aacaa85 The parameter 'force' was added to Host.apply_edition in Clearwater, not Augusta.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-05 17:45:12 +01:00
Adrian Jachacy
da00b13bb9 Merge branch 'master' of git://hg.uk.xensource.com/carbon/trunk/xenadmin 2013-07-23 16:29:16 +01:00
Adrian Jachacy
d89d04a33d CA-76329: SR destroy option is missing from XenCenter (even SR doesn't contains any VDI and SR is detached)
1. Changed definition of IsDetached property in SR.cs: SR is detached when it has no PBDs or when all its PBDs are unplugged.
2. Added bool HasPBDs property in SR.cs (replaced previous IsDetached property definition).
3. Reviewed all usages of sr.IsDetached property.

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-23 13:42:27 +01:00
Mihaela Stoica
6399087bd5 Updated ApplyLicenseEdition action to use the correct version of Host.apply_edition depending on host's version.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-07-19 16:32:42 +01:00
Mihaela Stoica
b7d6b03577 CA-111310: Call VDI.copy asynchronously to avoid timeout [SCTX-1366]
- Changed the synchronous call to VDI.copy to an async one in VMMoveAction and MoveVirtualAction;
- Corrected the calculation of action step in VMMoveAction.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-07-16 10:25:02 +01:00
Adrian Jachacy
54b66a08d8 CP-5352: PR-1634: Request and consume list of SRs required to recover a VM / vApp, and add Resolve All button.
1. Updated XenModel.csproj following update to XenAPI.
2. Host.apply_edition requires three parameters now: pass false in the last parameter (_force parameter).

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-03 11:46:26 +01:00
Mihaela Stoica
bd36a85bff CP-4816: Initial commit to git repo
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-06-24 12:41:48 +01:00