Commit Graph

563 Commits

Author SHA1 Message Date
Konstantina Chremmou
b33e08b73e CP-30918: Show warnings if GFS2 SRs are not used with multipath.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-25 06:48:41 +00:00
Konstantina Chremmou
8bdc8816c3 CA-309152: Remote logging is offered in addition to local and not instead of it (#2405)
* The radiobuttons local-remote gave the impression the two types of logging
were mutually exclusive. Use a checkbox instead to make it obvious that
the logs are directed to a remote server in addition to being stored locally.

* Updated log destination display on the General TabPage.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-03-21 13:35:26 +00:00
Darren Matthews
597813723d L10N : Translation Updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2019-02-26 11:54:11 +00:00
Ji Jiang
ba649634e5 CP-30602: Add boot mode info to Naples XC
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2019-02-15 12:02:11 +00:00
Konstantina Chremmou
eef3320eca Removed code applicable to servers earlier than dundee since connection to them is now blocked.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-02-06 09:25:38 +00:00
Konstantina Chremmou
7a4d5719c7 Renamed class and file PropertyManager to FriendlyNameManager to avoid confusion,
because it only manages friendly names; moved it closer to the relevant resource files.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-28 14:49:48 +00:00
Konstantina Chremmou
033b7579ef Reduced accessibility of controls to private.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-01-08 12:01:46 +00:00
Darren Matthews
6733649868 L10N : Translation and Resx resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-12-20 11:06:41 +00:00
Konstantina Chremmou
44d70e6867 Suggested UX enhancement: store the user's preferred updates view; note that
option to change this on the Options dialog has not been provided as deemed
unnecessary.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 11:30:15 +00:00
Konstantina Chremmou
5f800f9816 CA-304787: Fixed issue where the Updates-by-server view did not show the required
updates until Refresh was clicked. Also, some UX improvements:

- The Install Updates button should always be enabled in case the user wants
to install supp packs.
- If a type of update is disabled, show always the message at the top of the
grid view, for both views, and even if the list is not completely empty,
otherwise the user may easily forget the update is disabled and be misled.
In this case, the centred warning does not need to show the reason why no
updates were found.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 11:30:15 +00:00
Konstantina Chremmou
981bc3094c Fixed controls spacing, top toolstrip borders and made the top toolstrip on the History page click through.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 11:30:15 +00:00
Konstantina Chremmou
e762dd04c7 Added readonly restrictions to DataGridViewRow cells.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-19 11:30:15 +00:00
Konstantina Chremmou
d08efd4a86 Expand the general section on the GeneralTabPage by default only the first
time a new object type is selected. If the user has chosen to collapse it,
respect their choice.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-18 09:28:47 +00:00
Konstantina Chremmou
7a3ba9c980 CA-287648: Do not show the user the licence status before its value has been retrieved.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-18 09:28:47 +00:00
Konstantina Chremmou
7918bc9480 Removed unused method and fixed some code inefficiencies.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-18 09:28:47 +00:00
Konstantina Chremmou
5a4ff2c8a9 Renamed event handler to be more relevant to the event handled.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-12-18 09:28:47 +00:00
Konstantina Chremmou
c1256c7734 Removed redundant code from GradientPanel and made it more object oriented;
also moved it out of the containing folder as it was its only resident.
Corrected the TitleBar fore colour as it was hard to read due to small contrast
with the bar's backround colour; normalised the code setting the other colours
so it's more unambiguous.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-09 16:20:52 +00:00
Konstantina Chremmou
fc98eed16b CA-237915: When one attempts logging oneself out, warn them if there are outstanding actions.
For this purpose, call the DisconnectCommand instead of session.logout_subject_identifier.
Also:
- Add the new actions to the History synchronously on the main thread,
otherwise the warning dialog may not detect in time the new actions.
- Although the local root account is currently first in the list, checking whether
the first item is selected is a fragile way of establishing whether the local
root account is selected. Check the row's IsLocalRootRow property as in the
rest of the file.
- Added username detail to the logout action; fixed typo in message key.
- Some minor refactoring to make the code more efficient.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-01 12:52:07 +02:00
Darren Matthews
176624e029 L10N: Translation updates and resx sync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-21 13:53:09 +01:00
Konstantina Chremmou
90589a30c9 Modified treeview and toolbar updates (#2264)
This PR is aimimg to (1) fix a regression introduced by #2223 whereby the toolbar items did not have the correct state on first launch; (2) improve performance by removing some updates which I believe are not needed.

* Removed some duplicate calls to RefershTreeView and UpdateToolbars because
they are called within the action's Complete event handler.
Also, normalise the way the treeview refresh is requested by the various actions the
commands are launching.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Removed some explicit calls to refresh the treeview since this is done by
the connection result handlers.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* The toolbars and tabs should be updated every time the treeview is refreshed.

This should happen when the refresh event is handled rather than calling
UpdateToolbars explicitly after a treeview refresh is requested; also, it is
the treeview refreshes that should be throttled and not the toolbar and
tab updates (the throttling mechanism may need correction).
Also, removed unnecessary Invoke as we are already on the UI thread.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Simplified UpdateManager.Update event declaration.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-16 16:24:54 +01:00
Mihaela Stoica
01e8e3feed
Merge pull request #2251 from kc284/disk
CA-289948: allow VDI of a stopped VM to be moved on unlicensed pools
2018-10-16 13:27:36 +01:00
Darren Matthews
5645cb9596 L10N: resx sync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-16 12:38:36 +01:00
Darren Matthews
a8e03537a5 L10N : Translation updates and ReSync resx files
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-10-09 12:26:51 +01:00
Konstantina Chremmou
ca0f4ce1d4 CA-238884: Some layout corrections to ease localisation for the PvsPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 13:06:40 +01:00
Konstantina Chremmou
9bd27f8915 Minor layout corrections and button reordering on the storage tab for VMs,
Hosts, and SRs, so that all three tab pages look the same.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 12:33:05 +01:00
Konstantina Chremmou
b6420b6c12 CA-289948: If migration of individual VDIs is not allowed due to licensing restrictions,
do not show the upsell dialog; the user should be able to move the VDIs without
having to detach them first.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 12:33:04 +01:00
Konstantina Chremmou
9236bbc0e3 CA-298592: Check the licenseStatus is not null when accessing its properties.
There can be cases when we have logged in a session, events are fired
causing the tab pages to be refreshed, however we may abort the connection,
for example, due to brand mismatch. In this case the licenseStatus has not
been initialized, however the refreshing general tab tries to access its
properties resulting to a crash.
Also some method tidy up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
a7c628b9ae Fixed issues with showing the correct licence for a host/pool on the main window and general tab.
- When the host/pool was disconnected or when changing selection from connected to disconnected pool
the header was not updated with the new licence status.
- If the pool hosts' edition is none of the known editions, show unknown, not free.
- Tidy up: moved the Pool.LicenseString method to Helpers.GetFriendlyLicenseName.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-05 15:16:12 +01:00
Darren Matthews
2ce509efb3 L10N: Translation updates along with Interface resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-09-28 14:00:14 +01:00
Konstantina Chremmou
3f2ddb854a Since the ConfigureHA button is used both enablement and editing HA, we don't
need an EnableHA button which additionally appears greyed out while HA is being
enabled. While an HA action is in progress we should only change the enabled
status of the already visible buttons.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-27 12:43:04 +01:00
Mihaela Stoica
8998e88255 CA-297216: Remove the unused class and control
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-09-18 15:33:53 +01:00
Darren Matthews
0e7057d067 L10N: Translation updates and Re-Sync JA & CN resx files to match the new English resx
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2018-08-22 09:02:08 +01:00
Mihaela Stoica
8230315f76 CA-286882: Shutting down large number of VMs causes XenCenter to hang
Created a new base class for the Notifications pages (Alerts, Updates, Events). This can be used in the future to host more of the common code between these pages. For now, it implements a common mechanism for showing/hiding the page and ensures that the event handlers are deregistered when the page is hidden (i.e. when the user switches to a different view) and registered again when the page becomes visible

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-13 17:18:53 +01:00
Ji Jiang
d0fc3be56e CA-294091: Fix two Update wizards co-exist bug
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-08-07 12:02:57 +01:00
Konstantina Chremmou
fc88e5c5be Removed null value image from datagridview columns as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
65f67f2455 Ensure AdEnableAction is always shown in History. FindActiveAdAction can be private.
Show ellipsis on the join/leave button since it launches a dialog requirng user input.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
12fe9e9620 Store the domain and username rather than the whole AdPasswordPrompt.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
02eaac832a CA-294365: Replaced all references to pool or master except the necessary
with references to the connection; pool or master can be resolved from the
latter. This among others prevents the AD page from crashing when the master
and the pool change after master's entering maintenance mode.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
d604fc16ab Ensure subject events are deregistered every time the rows are cleared.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
d65dbeaf2e Launch action dialogs in a using block. Prevent button flickering when the gridview is repopulated.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
1d5d06c15d No need to repopulate the whole list if a subject's property has changed, refresh just this subject's row.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
21072e13fc Removed redundant code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
3bd8a03699 CA-272127: Aesthetic and usability improvements in the AD users list: fixed
cell alignment; removed grid; expand/collapse on row double click and on expander
cell single click. Refactored class AdSubjectRow.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
18be622889 Made the Events page rows to expand/collapse on double click like the Alerts and Updates pages.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
vetrivelc
8ef1764c84 L10N: Translation Updates & CA-293780 2018-07-19 11:05:16 +01:00
Mihaela Stoica
9accb3c69f Merge branch 'master' into REQ-672
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenAdmin.csproj
2018-07-13 13:14:36 +01:00
Mihaela Stoica
6e468da70a CA-293669: In the Updates tab, show the required updates for the slaves in a partiallly upgraded pool, even when the master's version cannot be found in the c-f-u
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-12 14:45:23 +01:00
Alexander Schulz
66e4382d3b Snapshot view: Treeview as default (like in the past)
https://github.com/xcp-ng/xenadmin/issues/62
2018-07-08 01:37:15 +01:00
Mihaela Stoica
ad1dabd257 CA-293026: Fix the updates shown on a partially upgraded pool
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-28 15:37:02 +01:00
Jisheng Xing
b6e1ad6b83 fix typos and rename a function 2018-06-21 14:54:47 +01:00