* CA-294333: NewPolicySnapshotPage corrections.
- Fixed layout and accessibility of controls.
- Changed clickable info icons to normal icon+text info panels because they
are used more widely across XenCenter and the user does not need extra clicks
to access the information.
- Fixed bug where two clicks were required to check the quiescing checkbox
if the Disk and Memory radio was selected.
* Minor layout correction.
* Removed some obsolete code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
having preselected a connection on the treeview. Also added a null check to
prevent crash if the connection is suddenly interrupted while moving away
from the select destination host page.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CP-28679: XC: Allow choosing boot options during disk import
Signed-off-by: Tim Liu <tim.liu@citrix.com>
* CP-28679: XC: Allow choosing boot options during disk import
1. Keep spaces instead of tabs
2. Update page header text to reflect the new control
3. Refine UI
Signed-off-by: Tim Liu <tim.liu@citrix.com>
1. Update the duplicated shortcuts on CPU&Mem Page
2. Default radio boxes invisible
3. Move hardcoded logic to VM.cs
4. BIOS boot should be always enabled
5. Move radio boxes to Installation Media page
6. Extract radio boxes as a user control
7. Update summary
Signed-off-by: Tim Liu <tim.liu@citrix.com>
* CA-293776: The order in which a single update is applied on the slaves is not the same as the order in which they are displayed
Apply the same Hosts sorting rules for all the PatchingWizard Pages .
Signed-off-by: Tim Liu <tim.liu@citrix.com>
* CA-293776: The order in which a single update is applied on the slaves is not the same as the order in which they are displayed
Place orderby clause after where clause
Signed-off-by: Tim Liu <tim.liu@citrix.com>
* CA-293813: Patch pools in parallel when installing a single update/patch or supplemental package.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Corrections as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
property to the derived classes (they don't share much of it anyway) and the method
CalcMemoryUsed to the VMShinyBar class where it is needed. Also made the latter's
property Increment non-browsable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
setting controls. Also removed the various types of ballooning dialogs since
the only thing changing was the contained memory settings control.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The other part of this ticket (add OTHER_OPERATION_IN_PROGRESS to the known errors) has already been done in commit 97a60c91.
Minor refactoring to the VMProblem class.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
asynchronously on the SelectImportSourcePage, so that the rest of XenCenter
is usable while the unzip is taking place; for this purpose a progress bar
was added on the page and the DecompressApplianceDialog was removed.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
from this an object with selected TabPageFeature to a different object with a
deselected TabPageFeature.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
life browsers and allow the user to see the status even if other actions are taking
place. Removed webClient use from the browser; instead try sequentially to navigate
to all Uris until one succeeds; this avoids sending duplicate requests and allows
the user to see all endpoints tried out. Reworked the WebBrowser event handlers
to ensure the UI reflects correctly the browser state.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
about:blank instead. Removed parameter null check as it is done by PlaceholderRegex.Replace.
Minor tidy up.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Moved NavigateError- and AuthenticatinPromptEventArgs classes inside WebBrowser2
as they are only relevant to the latter class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Created a new base class for the Notifications pages (Alerts, Updates, Events). This can be used in the future to host more of the common code between these pages. For now, it implements a common mechanism for showing/hiding the page and ensures that the event handlers are deregistered when the page is hidden (i.e. when the user switches to a different view) and registered again when the page becomes visible
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
is not agile simply by hovering over the cell. Previously the user could see
this only if they selected the VM, expanded the restart priority dropdown
and hovered over the Restart item.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* L10n: Inverness: build_chm #24
* Revert "L10n: Inverness": This reverts commit 8b41bb8c79cd4d73ed6021a5533cf7624a5421c4.
* L10n: Inverness: CHMs from build_chm master-l10n #24 Second attempt at checkin with a merge conflict resolve. (I hope)
* L10n: Localized files with fix: Remove artifacts introduced by XTM
* Update Kolkata Help files
* Update fro broken links fix
* CP-28648: Check -in the Lima versions of the CHM files
Signed-off-by: Katherine Shann <katherine.shann@citrix.com>
or being enabled. Although the CLI allows it, it makes sense to disallow deleting the pool
when HA is on because XenCenter does not offer enabling HA if there is no pool there.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
launches a dialog requiring user input, but added it to fcToolStripMenuItem
too because it looks symmetric and in any case the user does have to close
an error pop-up if the scan fails). Also, do not show "no SRs found pop-up"
if the user cancels the IscsiDeviceConfigDialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Remove restriction on creating >2TB disk
* Changed restrictions for resizing VDI
* Removed old method and replaced it with direct calls to new method
Signed-off-by: serenc <seren.corbett@citrix.com>
* CA-292626: Consider the contains-livepatch flag of all the applicable updates when doing the prechecks in the automated updates mode.
Instead of looking at the minimal patches, we look at all applicable patches for that host (i.e. all the updates on the host's version that are not already installed) and we say that the host won't need a reboot only if all these are marked as contains-livepatch.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
* CA-293854: Patching wizard updates list loses selection and resizes columns when resorted
Remove the redundant code
Change the AutoSize mode from DisplayedCells to AllCells.
Fix the date column sorting
Disable column header AutoSizing
Signed-off-by: Tim Liu <tim.liu@citrix.com>
* L10N: CA-294292 Fixed truncation issue in language files.
* L10N: CA-294333 Fixed overlapping issue in Japanese file.
* L10N: CA-294333 Fixed overlapping issue in Japanese file.
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
Show ellipsis on the join/leave button since it launches a dialog requirng user input.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
with references to the connection; pool or master can be resolved from the
latter. This among others prevents the AD page from crashing when the master
and the pool change after master's entering maintenance mode.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
cell alignment; removed grid; expand/collapse on row double click and on expander
cell single click. Refactored class AdSubjectRow.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-293628: Some RPU prechecks do not mention the host the precheck has run on
Signed-off-by: Tim Liu <tim.liu@citrix.com>
* CA-293628: Some RPU prechecks do not mention the host the precheck has run on
Signed-off-by: Tim Liu <tim.liu@citrix.com>
* CA-284914: Prechecks are re-run every time the 'Hide successful prechecks' is ticked/unticked
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
* fix some comments
all settings in case of failure. Null check and minor optimisation of setting
KnownServers.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
explicitly what the actions do. The previous description "updating" could be
confusing when seen out of context amidst other actions on the events page,
because updating also refers to server patching.
if they fail the user has no indication an error occurred.
Also, simplified the logging and error handling within the action body: failures
are logged anyway by the base class, so no special handling is necessary.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
or Host accordingly. Extended comparison of Problems to also take account of
the XenObject the Check was performed on, otherwise the Problems get mixed
up when there are homonymous members across pools.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
1) When create/delete bond, inconsistent cluster network may occur. Show
warning in this case.
2) Refactor UI on cluster network edit page.
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
minimum required role. Do not deselect a pool on the RPU wizard if it fails
the RBAC check; let the user decide either to reconnect with more privileges
or deselect it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
(to ensure that XC has the latest c-f-u data, as it's possible that the user hasn't configured XenCenter to automatically check for updates)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
... because pre-Dundee hosts dont't have this license flag, but they might have it after the upgrade.
Also added a bit more logging in the function that generates the update plan actions
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
* CP-28431: Block updates and upgrades from Kolkata onwards if clustering enabled
* CP-28431: Rename files and change from Pool Check to [Host] Check
* CP-28431: Change description message
Signed-off-by: Seren Corbett <seren.corbett@citrix.com>
on the update mode, so that the right set of hosts is passed on to the prechecks
page for partially upgraded pools that are to be updated to a new version with
hotfixes. Also, corrected code that was mixing the logic of changing the enabled
state of a row with the checked state.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
the liveness warning is not issued if the pool is disconnected. HAOffCheck tidy up.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also sort Messages.resx and call ReplaceProgressStep instead of AddProgressStep in the DownloadPatchPlanAction class (when the download is skipped)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
a new check on the existing one instead. Moved the background worker to the designer
of the class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
is enforced on all host post-liveness checks.
Added missing description to SafeToUpgradeCheck.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
reverted to the new class UpdateUpgradeWizard which serves as base for the
Patching and the RPU wizards. Pass the list of resolved problems to the
automated updates page and not the actions, so as to prevent premature (i.e.
on creation as opposed to on start) addition to the global list shown on
the Events page.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
is now in one place, namely the PatchingWizard_PrecheckPage.UnwindChangesActions.
The pages following this page use now this list instead of the problems
encountered, so we ensure that the update/upgrade plans do not include the
unwind action if no resolution of problems took place on the prechecks page.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
are set unless the new value is actually different. Small efficiency improvements
to the DownloadPatch action and plan action.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
a message in this case as the SRs are reconnected after reboot and this may lead
to duplicate messages. Also, simplified check-and-plug methods for PBDs to avoid
repetition of iterations.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Deprecate set but unused Status property in favour of ProgressDescription.
* Deprecate set but unused TitlePlan property.
* Deprecated property Title in favour of ProgressDescription.
* Removed unused plan RebootHostPlanAction.
* Updated event declaration.
* Removed property Visible. The plan is to have the actions log their history as soon as some is available.
* Reworked the logging for the plan actions. The main change is the replacement of
the ProgressDescription with a stack where all the steps of an action are stored,
i.e. the action is responsible for its history, not the worker running it.
* Lock the progress history before accessing it.
* Better handling of error logging and user cancellation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
1) Always pool level selection of hosts, except uploading sup pack file
from disk.
2) Revert homogeneity precheck change recently. It won't happen in new version
update any more.
3) User can never update slaves to a higher version than master, so delete
master_version_not_compatible_problem.
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
- In the RPU case, re-enable the host after the upgrade is done, as the host will be put back into maintenance mode when needed during the update process.
- The VMs should not be repatriated during the RPU
- When a host is rebooted, it needs to be disabled first (even if an evacuation is not needed), otherwise the reboot won't happen
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
Renamed HostPlanActions class to HostPlan to avoid confusion with the HostPlanAction class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Also corrected the function that creates the update plan action in RPU: when running a retry, these actions shouldn't be regenerated.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
- Some methods have been moved/added to the base class to facilitate the calculation of the plan actions in the RPU case.
- Also fixed the calculation of the progress bar value.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
The base class contains all the code for creating and starting the background workers, displaying the progress of the actions, handling failures and retries.
The derived classes override the property for label at the top of the page and the method that generates the plan actions.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
- ensure that an action is only added once to the DoneActions and InProgressActions
- reset the wizard buttons (Cancel, Finish) when a retry is started
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
* CP-28286: Support resume from a partially upgraded pool via Update wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
* CP-28286: Fix comments of the previous commit
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
Because we couldn't control user's selected combination from
a mixed pool, and the version compatibility precheck exists already,
here just simply skip the precheck and issue a warning.
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
and unregister item event in a try-finally block (may cure CA-289721); suspend-resume
layout when updating the datagridview.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
the code will break if the column on the LicenceManager is renamed. Also, do
not create the new cell before the index checks pass.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
In this case, the CheckableDataGridViewRowEventArgs are very specialised and can be nested in the CheckableDataGridView.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
This change improves the performance of the drop-down menu considerably, as it avoids the server calls from the Command.ToolTipText
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
- added an action for the API call that retrieves the WLB VM recommendations
- removed the thread used for updating the menu items, so that we always access the menu items on the UI thread and do only the server calls on separate threads (for WLB, getting the recommendations now is done on the new action, for non-WLB we have the `workerQueueWithoutWlb`)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
Also, no need to trigger an event when the host is null or when get_servertime
fails only to double-log it in the handling class.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-286291: Fix the crash when quickly and repeatedly popping up Migrate-to-Server menu.
* Update the thread model.
Signed-off-by: Michael Zhao <michael.zhao@citrix.com>
* Fix an error in using _stopped flag.
